Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | remove lasgn since AST is mutated | Aaron Patterson | 2010-12-16 | 1 | -1/+1 | |
| | | ||||||
| * | just mutate the ast, fewer lasgns | Aaron Patterson | 2010-12-16 | 1 | -3/+2 | |
| | | ||||||
* | | remove lasgn since AST is mutated | Aaron Patterson | 2010-12-10 | 1 | -1/+1 | |
| | | ||||||
* | | just mutate the ast, fewer lasgns | Aaron Patterson | 2010-12-10 | 1 | -3/+2 | |
|/ | ||||||
* | no more manager manipulation if there is no custom join ast | Aaron Patterson | 2010-12-10 | 1 | -6/+5 | |
| | ||||||
* | froms should never equal 0 | Aaron Patterson | 2010-12-10 | 1 | -2/+0 | |
| | ||||||
* | manager will always be a manager | Aaron Patterson | 2010-12-10 | 1 | -10/+6 | |
| | ||||||
* | eliminate lasgns | Aaron Patterson | 2010-12-10 | 1 | -10/+10 | |
| | ||||||
* | dealing with an AST manager, not a relation, so fix the variable names | Aaron Patterson | 2010-12-10 | 1 | -12/+12 | |
| | ||||||
* | adding a fixme comment | Aaron Patterson | 2010-12-08 | 1 | -0/+1 | |
| | ||||||
* | renaming variables, making the join_ast method private | Aaron Patterson | 2010-12-08 | 1 | -51/+27 | |
| | ||||||
* | further reducing dependence on custom_joins | Aaron Patterson | 2010-12-08 | 1 | -0/+2 | |
| | ||||||
* | reducing use of custom joins | Aaron Patterson | 2010-12-08 | 1 | -1/+6 | |
| | ||||||
* | passing the ast to a table when the relation is a table | Aaron Patterson | 2010-12-07 | 1 | -3/+20 | |
| | ||||||
* | JoinDependency is always created with an AST now | Aaron Patterson | 2010-12-07 | 1 | -1/+15 | |
| | ||||||
* | cleaning up custom_join_sql method | Aaron Patterson | 2010-12-07 | 1 | -4/+6 | |
| | ||||||
* | fix warnings, stop using global variables | Aaron Patterson | 2010-11-30 | 1 | -4/+2 | |
| | ||||||
* | stop using splat args when we do not need them | Aaron Patterson | 2010-11-30 | 1 | -2/+2 | |
| | ||||||
* | reduce method calls on arel | Aaron Patterson | 2010-11-30 | 1 | -1/+1 | |
| | ||||||
* | skip cloning if arguments are blank | Aaron Patterson | 2010-11-22 | 1 | -8/+22 | |
| | ||||||
* | group can be done by left side only | Aaron Patterson | 2010-11-17 | 1 | -6/+3 | |
| | ||||||
* | collapsing same table / column WHERE clauses to be OR [#4598 state:resolved] | Aaron Patterson | 2010-11-17 | 1 | -4/+25 | |
| | ||||||
* | use shorter form for sql literals | Aaron Patterson | 2010-11-17 | 1 | -1/+1 | |
| | ||||||
* | adding bind_values to relations | Aaron Patterson | 2010-10-26 | 1 | -1/+8 | |
| | ||||||
* | use shortened version to generate a sql literal | Aaron Patterson | 2010-10-19 | 1 | -1/+1 | |
| | ||||||
* | avoid cloning if we do not need to clone | Aaron Patterson | 2010-10-19 | 1 | -0/+2 | |
| | ||||||
* | avoid creating a proc object when possible | Aaron Patterson | 2010-10-19 | 1 | -2/+2 | |
| | ||||||
* | Refactor JoinDependency and friends so that a JoinAssociation can produce an ↵ | Jon Leighton | 2010-10-13 | 1 | -12/+1 | |
| | | | | arbitrary number of joins, which will be needed in order to support nested through associations. | |||||
* | reorder removed in favor of except(:order).order | Santiago Pastorino | 2010-10-11 | 1 | -10/+1 | |
| | ||||||
* | avoid creating objects when we can | Aaron Patterson | 2010-10-03 | 1 | -1/+1 | |
| | ||||||
* | build_where should be private | Aaron Patterson | 2010-09-30 | 1 | -2/+2 | |
| | ||||||
* | removing more useless code! yay! | Aaron Patterson | 2010-09-28 | 1 | -6/+2 | |
| | ||||||
* | SqlLiteral is a string, so we can dry up these conditionals | Aaron Patterson | 2010-09-28 | 1 | -4/+3 | |
| | ||||||
* | shorten up or sql literal creation statements | Aaron Patterson | 2010-09-28 | 1 | -4/+2 | |
| | ||||||
* | we only care about arrays and strings | Aaron Patterson | 2010-09-28 | 1 | -1/+1 | |
| | ||||||
* | dry up calls to arel.join() | Aaron Patterson | 2010-09-28 | 1 | -5/+4 | |
| | ||||||
* | removing unused lasgns | Aaron Patterson | 2010-09-28 | 1 | -4/+4 | |
| | ||||||
* | refactoring to remove crazy logic | Aaron Patterson | 2010-09-28 | 1 | -8/+1 | |
| | ||||||
* | performance improvement based on discussion at ↵ | Neeraj Singh | 2010-09-28 | 1 | -9/+3 | |
| | | | | | | http://github.com/rails/rails/commit/fbd1d306b95cc2efb6422e12d26d5818a3a42343 Credit goes to all the participants in the discussion | |||||
* | removing a conditional that is not used | Aaron Patterson | 2010-09-28 | 1 | -2/+0 | |
| | ||||||
* | avoid calling to_sql when we can | Aaron Patterson | 2010-09-28 | 1 | -1/+1 | |
| | ||||||
* | make sure we use the engine assigned to the table when quoting | Aaron Patterson | 2010-09-27 | 1 | -1/+1 | |
| | ||||||
* | Three performance improvements: | Neeraj Singh | 2010-09-27 | 1 | -10/+9 | |
| | | | | | | | | * for simple cases like User.last and User.order('name desc').last no need to perform Array#join operation. * Instead of performing String#blank? do Array#empty? * no need to create variable relation | |||||
* | adds to the API guidelines the proper spelling of Arel | Xavier Noria | 2010-09-19 | 1 | -2/+2 | |
| | ||||||
* | @join_values is passed in, so we should use the parameter | Aaron Patterson | 2010-09-15 | 1 | -1/+1 | |
| | ||||||
* | creating a new array is required. who knew? :-( | Aaron Patterson | 2010-09-09 | 1 | -1/+1 | |
| | ||||||
* | no need for Array.wrap, also avoid array creation | Aaron Patterson | 2010-09-09 | 1 | -5/+4 | |
| | ||||||
* | make apply_modules run faster | Neeraj Singh | 2010-09-09 | 1 | -3/+5 | |
| | ||||||
* | eliminate present? for fewer method calls | Aaron Patterson | 2010-09-08 | 1 | -10/+2 | |
| | ||||||
* | returning arrays lets us avoid Array.wrap | Aaron Patterson | 2010-09-08 | 1 | -4/+4 | |
| |