Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | we should apply the default scope before querying | Aaron Patterson | 2013-06-12 | 1 | -1/+2 | |
| | | | ||||||
* | | | Rather than raising ThrowResult when construct_limited_ids_conditions comes ↵ | Ben Woosley | 2013-05-10 | 1 | -13/+15 | |
|/ / | | | | | | | | | | | up empty, set the relation to NullRelation and rely on its results. This will help avoid errors like 2fcafee250ee2, because in most cases NullRelation will do the right thing. Minor bonus is avoiding the use of exceptions for flow control. | |||||
* | | Extract JoinDependency#join_relation to DRY the repeated application of the ↵ | Ben Woosley | 2013-05-10 | 1 | -4/+1 | |
| | | | | | | | | #join_associations. | |||||
* | | In #apply_join_dependency, we can apply the #where in-place because relation ↵ | Ben Woosley | 2013-05-10 | 1 | -1/+1 | |
| | | | | | | | | | | | | is always a new object. Thanks to the #except we call at the top of the method. | |||||
* | | DRY-up join dependency creation by extracting construct_join_depdency | Ben Woosley | 2013-05-10 | 1 | -7/+5 | |
| | | ||||||
* | | Pull the excepts into apply_join_dependency, for the sake of DRY. | Ben Woosley | 2013-05-10 | 1 | -3/+4 | |
| | | ||||||
* | | Simplify conditions within apply_join_dependency | Ben Woosley | 2013-05-10 | 1 | -9/+5 | |
| | | ||||||
* | | Move the except(:select) inside the construct_limited_ids_condition method ↵ | Ben Woosley | 2013-05-10 | 1 | -2/+2 | |
| | | | | | | | | to pair it closely with its motivation. | |||||
* | | Reject blank order_values within #columns_for_distinct, as the orders aren't ↵ | Ben Woosley | 2013-05-10 | 1 | -2/+2 | |
| | | | | | | | | used at all on non-postgres adapters. | |||||
* | | Fix that #exists? can produce invalid SQL: "SELECT DISTINCT DISTINCT" | Ben Woosley | 2013-05-10 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | The combination of a :uniq => true association and the #distinct call in #construct_limited_ids_condition combine to create invalid SQL, because we're explicitly selecting DISTINCT, and also sending #distinct on to AREL, via the relation#distinct_value. Rather than build a select distinct clause in #construct_limited_ids_condition, I set #distinct! and pass just the columns into the select statement. This requires introducing a #columns_for_distinct method to return the select columns but not the statement itself. | |||||
* | | true/false => truthy falsy | Steve Klabnik | 2013-04-02 | 1 | -2/+2 | |
| | | ||||||
* | | Throwing a RecordNotFound exception when a record is scanned using the | wangjohn | 2013-04-01 | 1 | -11/+24 | |
| | | | | | | | | | | inverse_of option. I've also refactored the code for raising a RecordNotFound exception when searching for records with ids. | |||||
* | | Fixed typos in activerecord | Prathamesh Sonpatki | 2013-03-27 | 1 | -1/+1 | |
| | | ||||||
* | | adds a missing LIMIT 1 in #take docs | Xavier Noria | 2013-02-23 | 1 | -1/+1 | |
|/ | ||||||
* | Do not instantiate intermediate AR objects when eager loading. | Yves Senn | 2012-12-04 | 1 | -2/+4 | |
| | | | | Closes #3313 | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-11-17 | 1 | -1/+1 | |
|\ | | | | | | | | | Conflicts: actionpack/lib/action_dispatch/routing/redirection.rb | |||||
| * | 1.9 Syntax related changes | AvnerCohen | 2012-11-10 | 1 | -1/+1 | |
| | | ||||||
* | | Remove not used indifferent_access requires from Base and FinderMethods | Carlos Antonio da Silva | 2012-11-07 | 1 | -2/+0 | |
| | | ||||||
* | | Use cached quoted_table_name instead of going through the connection | Carlos Antonio da Silva | 2012-11-07 | 1 | -1/+1 | |
| | | ||||||
* | | Remove block given check from private find_with_ids | Carlos Antonio da Silva | 2012-11-07 | 1 | -2/+0 | |
|/ | | | | | This is already handled by #find, it's a duplicate check, since find_with_ids is not called from anywhere else. | |||||
* | Remove ActiveRecord::Model | Jon Leighton | 2012-10-26 | 1 | -1/+1 | |
| | | | | | | | | | | In the end I think the pain of implementing this seamlessly was not worth the gain provided. The intention was that it would allow plain ruby objects that might not live in your main application to be subclassed and have persistence mixed in. But I've decided that the benefit of doing that is not worth the amount of complexity that the implementation introduced. | |||||
* | load active_support/core_ext/object/blank in active_support/rails | Xavier Noria | 2012-08-02 | 1 | -1/+0 | |
| | ||||||
* | AR::Relation#order: make new order prepend old one | Bogdan Gusiev | 2012-07-31 | 1 | -1/+1 | |
| | | | | | | | User.order("name asc").order("created_at desc") # SELECT * FROM users ORDER BY created_at desc, name asc This also affects order defined in `default_scope` or any kind of associations. | |||||
* | Deprecate Relation#all. | Jon Leighton | 2012-07-27 | 1 | -14/+1 | |
| | | | | | | It has been moved to active_record_deprecated_finders. Use #to_a instead. | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-06-30 | 1 | -5/+7 | |
|\ | | | | | | | | | Conflicts: activemodel/lib/active_model/errors.rb | |||||
| * | update AR::FinderMethods#exists?(false) example [ci skip] | Francesco Rodriguez | 2012-06-28 | 1 | -5/+7 | |
| | | ||||||
* | | exists?(false) returns false | Egor Lynko | 2012-06-25 | 1 | -6/+6 | |
|/ | | | | `FinderMethods#exists?` finder method now returns *false* with the *false* argument | |||||
* | Address ORA-00911 errors because of the heading underscore. | Yasuo Honda | 2012-06-11 | 1 | -1/+1 | |
| | ||||||
* | Fix that #exists? raises ThrowResult when called with an empty limited | Ben Woosley | 2012-06-10 | 1 | -0/+2 | |
| | | | | | | | | | reflection. ActiveRecord::FinderMethods#construct_limited_ids_condition will raise ThrowResult if the limited reflection comes back empty. The other callers of #construct_limited_ids_condition handle this exception (more specifically, the callers of construct_relation_for*), but #exists? didn't until now. | |||||
* | Add test to column alias in `exists?` SQL. | Rafael Mendonça França | 2012-06-10 | 1 | -1/+1 | |
| | | | | | | | | This behavior was added in be4ecdcc87984e9421ff5d5c90d33f475e0fbc01. Closes #1139. Fixes #2553, #1141, #1623 and #2062. | |||||
* | Minimal change to query generation of exists? that makes SQLServer and ↵ | iaddict | 2012-06-10 | 1 | -1/+1 | |
| | | | | | | | others happy that do not work without a column alias. Conflicts: activerecord/lib/active_record/relation/finder_methods.rb | |||||
* | fix typo and remove 'examples' noise [ci skip] | Francesco Rodriguez | 2012-05-28 | 1 | -18/+6 | |
| | ||||||
* | Updates examples for FinderMethods [ci skip] | Alvaro Pereyra | 2012-05-28 | 1 | -2/+14 | |
| | ||||||
* | Merge branch 'master' of github.com:lifo/docrails | Alvaro Pereyra | 2012-05-28 | 1 | -0/+1 | |
|\ | ||||||
* | | Adds examples to FinderMethods#first [ci skip] | Alvaro Pereyra | 2012-05-28 | 1 | -0/+1 | |
| | | ||||||
* | | Remove blank trailing comments | Henrik Hodne | 2012-05-20 | 1 | -1/+0 | |
|/ | | | | | | | For future reference, this is the regex I used: ^\s*#\s*\n(?!\s*#). Replace with the first match, and voilà! Note that the regex matches a little bit too much, so you probably want to `git add -i .` and go through every single diff to check if it actually should be changed. | |||||
* | Return false for exists? with new records - fixes #6199. | Andrew White | 2012-05-10 | 1 | -2/+1 | |
| | ||||||
* | Use `take` instead of `first` to avoid unwanted implicit ordering (fixes #6147) | Marcelo Silveira | 2012-05-05 | 1 | -4/+4 | |
| | ||||||
* | clean up implementation of dynamic methods. use method compilation etc. | Jon Leighton | 2012-05-04 | 1 | -41/+0 | |
| | ||||||
* | Use arel nodes instead of raw sql | Marcelo Silveira | 2012-05-02 | 1 | -3/+3 | |
| | ||||||
* | Use Array#first instead of Array#[0] | Marcelo Silveira | 2012-05-02 | 1 | -5/+5 | |
| | ||||||
* | Introducing `take` as a replacement to the old behavior of `first` | Marcelo Silveira | 2012-05-02 | 1 | -0/+27 | |
| | ||||||
* | Document `last`, check for primary key on default order and use quoted table ↵ | Marcelo Silveira | 2012-05-02 | 1 | -2/+5 | |
| | | | | and column names | |||||
* | Made `first` finder consistent among database engines by adding a | Marcelo Silveira | 2012-05-02 | 1 | -2/+18 | |
| | | | | default order clause (fixes #5103) | |||||
* | return value of block is returned | Aaron Patterson | 2012-04-30 | 1 | -2/+5 | |
| | ||||||
* | only yield to finder block if something is found | Aaron Patterson | 2012-04-30 | 1 | -1/+1 | |
| | ||||||
* | extract deprecated code for #find, #first, #last, #all | Jon Leighton | 2012-04-13 | 1 | -105/+36 | |
| | ||||||
* | use a hash to store relation values | Jon Leighton | 2012-04-13 | 1 | -7/+7 | |
| | ||||||
* | mention that coercion only happens when the primary key is an integer and ↵ | Reg Braithwaite | 2012-04-12 | 1 | -2/+2 | |
| | | | | use +to_i+ formatting | |||||
* | Documents that ActiveRecord's find by id uses to_i to coerce its arguments ↵ | Reg Braithwaite | 2012-04-12 | 1 | -1/+3 | |
| | | | | to integers |