Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Remove fall back and column restrictions for `count`. | Yves Senn | 2013-06-09 | 1 | -10/+6 | |
| | ||||||
* | Merge pull request #10561 from Empact/nix-throwresult | Jon Leighton | 2013-06-07 | 1 | -2/+0 | |
|\ | | | | | Rather than raising ThrowResult when construct_limited_ids_conditions comes up empty, set the relation to NullRelation and rely on its results. | |||||
| * | Rather than raising ThrowResult when construct_limited_ids_conditions comes ↵ | Ben Woosley | 2013-05-10 | 1 | -4/+0 | |
| | | | | | | | | | | | | up empty, set the relation to NullRelation and rely on its results. This will help avoid errors like 2fcafee250ee2, because in most cases NullRelation will do the right thing. Minor bonus is avoiding the use of exceptions for flow control. | |||||
| * | Fix that #pluck wasn't rescuing ThrowResult, meaning it would blow up when ↵ | Ben Woosley | 2013-05-10 | 1 | -0/+2 | |
| | | | | | | | | failing to construct_limited_ids_condition. | |||||
* | | Remove #sum with a block was deprecated. | kennyj | 2013-06-01 | 1 | -9/+1 | |
|/ | ||||||
* | Handle aliased attributes in ActiveRecord::Relation. | Godfrey Chan | 2013-05-01 | 1 | -8/+18 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | When using symbol keys, ActiveRecord will now translate aliased attribute names to the actual column name used in the database: With the model class Topic alias_attribute :heading, :title end The call Topic.where(heading: 'The First Topic') should yield the same result as Topic.where(title: 'The First Topic') This also applies to ActiveRecord::Relation::Calculations calls such as `Model.sum(:aliased)` and `Model.pluck(:aliased)`. This will not work with SQL fragment strings like `Model.sum('DISTINCT aliased')`. Github #7839 *Godfrey Chan* | |||||
* | Prefer find_by over dynamic finders in rdoc | Sam Ruby | 2013-04-02 | 1 | -1/+1 | |
| | ||||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-03-30 | 1 | -1/+1 | |
|\ | | | | | | | | | | | | | | | | | Conflicts: activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb activerecord/test/cases/adapter_test.rb guides/source/testing.md [ci skip] | |||||
| * | Uniq cannot be used directly on an ActiveRecord model. 'DISTINCT field' is ↵ | Daniel Lobato | 2013-03-12 | 1 | -1/+1 | |
| | | | | | | | | the only pluck query that translates into the aforementioned SQL | |||||
* | | Deprecate the `:distinct` option for `Relation#count`. | Yves Senn | 2013-03-15 | 1 | -2/+7 | |
| | | | | | | | | | | | | | | We moved more and more away from passing options to finder / calculation methods. The `:distinct` option in `#count` was one of the remaining places. Since we can now combine `Relation#distinct` with `Relation#count` the option is no longer necessary and can be deprecated. | |||||
* | | rename `Relation#uniq` to `Relation#distinct`. `#uniq` still works. | Yves Senn | 2013-03-15 | 1 | -2/+2 | |
|/ | | | | | | | | The similarity of `Relation#uniq` to `Array#uniq` is confusing. Since our Relation API is close to SQL terms I renamed `#uniq` to `#distinct`. There is no deprecation. `#uniq` and `#uniq!` are aliases and will continue to work. I also updated the documentation to promote the use of `#distinct`. | |||||
* | copy edits [ci skip] | Vijay Dev | 2013-02-15 | 1 | -1/+1 | |
| | ||||||
* | Add ActiveRecord.count documentation when used on group relations | Maurizio De Santis | 2013-02-07 | 1 | -0/+6 | |
| | ||||||
* | `#count` in conjunction with `#uniq` performs distinct count. | Yves Senn | 2013-01-26 | 1 | -1/+2 | |
| | | | | closes #6865 | |||||
* | Revert "Merge pull request #8989 from robertomiranda/use-rails-4-find-by" | Guillermo Iguaran | 2013-01-18 | 1 | -1/+1 | |
| | | | | | This reverts commit 637a7d9d357a0f3f725b0548282ca8c5e7d4af4a, reversing changes made to 5937bd02dee112646469848d7fe8a8bfcef5b4c1. | |||||
* | User Rails 4 find_by | robertomiranda | 2013-01-18 | 1 | -1/+1 | |
| | ||||||
* | These are already required through AS/rails | Akira Matsuda | 2013-01-07 | 1 | -2/+0 | |
| | | | | | | * dependencies/autoload * concern * deprecation | |||||
* | warning removed: shadowing outer local variable | Arun Agrawal | 2012-12-30 | 1 | -2/+2 | |
| | ||||||
* | fix time typcasting on group counts in PG | Aaron Patterson | 2012-12-28 | 1 | -2/+5 | |
| | ||||||
* | mysql does not return alias names, so fall back | Aaron Patterson | 2012-12-28 | 1 | -4/+10 | |
| | ||||||
* | fix PG typecasting errors | Aaron Patterson | 2012-12-28 | 1 | -2/+5 | |
| | ||||||
* | Cleans and removes useless 'Examples' tag [ci skip] | Alvaro Pereyra | 2012-12-01 | 1 | -7/+2 | |
| | ||||||
* | copy edits [ci skip] | Vijay Dev | 2012-12-01 | 1 | -1/+1 | |
| | ||||||
* | Fix Calculations#pluck doc to mention several attributes can be selected [ci ↵ | Florent Guilleux | 2012-12-01 | 1 | -3/+3 | |
| | | | | skip] | |||||
* | Deprecate Relation#sum with a block. | Carlos Antonio da Silva | 2012-11-21 | 1 | -0/+6 | |
| | | | | | | | To perform a sum calculation over the array of elements, use to_a.sum(&block). Please check the discussion in f9cb645dfcb5cc89f59d2f8b58a019486c828c73 for more context. | |||||
* | Revert "Yield only one argument instead of splatting." | Carlos Antonio da Silva | 2012-11-21 | 1 | -14/+3 | |
| | | | | | | | | | | | | | | This reverts commit f9cb645dfcb5cc89f59d2f8b58a019486c828c73. Conflicts: activerecord/CHANGELOG.md Revert "Allow blocks for count with ActiveRecord::Relation. Document and test that sum allows blocks" This reverts commit 9cc2bf69ce296b7351dc612a8366193390a305f3. Conflicts: activerecord/lib/active_record/relation/calculations.rb | |||||
* | Remove not used require and some useless test comments | Carlos Antonio da Silva | 2012-11-17 | 1 | -2/+0 | |
| | ||||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-11-17 | 1 | -1/+1 | |
|\ | | | | | | | | | Conflicts: actionpack/lib/action_dispatch/routing/redirection.rb | |||||
| * | 1.9 Syntax related changes | AvnerCohen | 2012-11-10 | 1 | -1/+1 | |
| | | ||||||
* | | arel columns can be used for grouping so that "weird" column names are usable | Aaron Patterson | 2012-11-15 | 1 | -0/+4 | |
| | | ||||||
* | | stop hardcoding FrontBase adapter conditionals | Aaron Patterson | 2012-11-15 | 1 | -1/+1 | |
| | | ||||||
* | | stop passing *args to generate aliases | Aaron Patterson | 2012-11-15 | 1 | -4/+2 | |
| | | ||||||
* | | create fewer relation objects | Aaron Patterson | 2012-11-15 | 1 | -3/+6 | |
| | | ||||||
* | | `#pluck` can be used on a relation with `select` clause. | Yves Senn | 2012-11-12 | 1 | -1/+3 | |
|/ | | | | Closes #7551 | |||||
* | use columns hash to look up the column for the count field | Aaron Patterson | 2012-10-17 | 1 | -1/+1 | |
| | ||||||
* | ActiveRecord: sum expression returns string '0' for no records, fixed | Tim Macfarlane | 2012-10-15 | 1 | -1/+1 | |
| | ||||||
* | Fix pluck when columns/tables are reserved words. | Ian Lesperance | 2012-09-05 | 1 | -1/+1 | |
| | ||||||
* | load active_support/core_ext/object/blank in active_support/rails | Xavier Noria | 2012-08-02 | 1 | -1/+0 | |
| | ||||||
* | Ensure Arel columns are typecasted properly when grouping with calculation | Carlos Antonio da Silva | 2012-06-25 | 1 | -6/+6 | |
| | | | | Fix build issue with postgresql. | |||||
* | Stop assuming strings for grouped calculations | Ernie Miller | 2012-06-24 | 1 | -6/+17 | |
| | | | | | | | | | | | | | | | Execute_grouped_calculation is one of those places where ActiveRecord forgets that it has ARel underpinnings, and assumes that the values provided to group_values are strings. This artificially hobbles otherwise functional code. This patch stops assuming that incoming values respond to to_sym, stops using string interpolation for table aliases on objects that support aliasing, and stops unnecessarily joining group_values on the relation. Additionally, it calls to_sql, if available, on objects sent to column_alias_for, in order to get a more reasonable alias string than a non-string's default to_str method. | |||||
* | Add changelog entry and guide updates for pluck with multiple columns | Carlos Antonio da Silva | 2012-06-22 | 1 | -0/+1 | |
| | ||||||
* | Refactor pluck with multiple columns | Carlos Antonio da Silva | 2012-06-22 | 1 | -26/+13 | |
| | | | | | | | | | | | | Ensure it works with mix of symbols and strings, and with a select clause possibly containing more than one column. Also remove support for pluck with an array of columns, in favor of passing the list of attributes: Model.pluck(:a, :b) See comments: https://github.com/rails/rails/pull/6500#issuecomment-6030292 | |||||
* | ActiveRecord#pluck now accepts multiple columns | jeroeningen | 2012-06-22 | 1 | -15/+35 | |
| | ||||||
* | Extract conditional to a method to avoid duplication | Rafael Mendonça França | 2012-06-19 | 1 | -15/+19 | |
| | | | | Also use if/else block to not use short circuit return | |||||
* | handle joins/includes correctly for pluck and calculation. | Andrey Deryabin | 2012-06-19 | 1 | -1/+6 | |
| | | | | Fix #5990 | |||||
* | Fix wrong example for count method with block [ci skip] | Carlos Antonio da Silva | 2012-05-31 | 1 | -1/+1 | |
| | | | | Thanks @splattael. | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-05-30 | 1 | -1/+1 | |
|\ | ||||||
| * | "a sql" -> "an SQL" per API documentation guidelines | Mark Rushakoff | 2012-05-27 | 1 | -1/+1 | |
| | | ||||||
* | | Yield only one argument instead of splatting. | Carlos Antonio da Silva | 2012-05-28 | 1 | -2/+2 | |
| | | | | | | | | Add Changelog entry. Closes #4003 | |||||
* | | Allow blocks for count with ActiveRecord::Relation. Document and test that ↵ | chrisfinne | 2012-05-28 | 1 | -3/+14 | |
|/ | | | | sum allows blocks |