aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/reflection.rb
Commit message (Collapse)AuthorAgeFilesLines
...
* | Use .to_s on _reflections lookupArthur Neves2014-05-241-1/+1
| |
* | Merge pull request #15210 from arthurnn/fix_hbtm_reflectionArthur Neves2014-05-241-7/+20
|/ | | | | | | | | Fix habtm reflection Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/counter_cache.rb activerecord/lib/active_record/reflection.rb activerecord/test/cases/reflection_test.rb
* deprecate, join, preload, eager load of instance dependent associations.Yves Senn2014-05-101-0/+14
| | | | | | | Closes #15024. These operations happen before instances are created. The current behavior is misleading and can result in broken behavior.
* Refactor AssociationScope#get_bind_valuesEric Chahin2014-05-051-0/+5
| | | | Added #join_id_for(owner) to reflection to avoid accessing the source_macro
* use statement cache for belongs_to relationsAaron Patterson2014-04-221-1/+4
|
* Merge branch 'master' into adequaterecordAaron Patterson2014-04-201-2/+2
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (74 commits) [ci skip] builtin -> built-in Fix code indentation and improve formatting Grammar fix in Getting Started Guide Make URL escaping more consistent Optimize URI escaping Always escape string passed to url helper. Remove statement assuming coffee shop/public space wifi is inherently insecure Don't rely on Arel master in bug report template [ci skip] wrap methods in backticks [ci skip] "subhash" --> "sub-hash" multibyte_conformance.rb --> multibyte_conformance_test.rb Fix inconsistent behavior from String#first/#last `@destroyed` should always be set to `false` when an object is duped. remove warning `warning: ambiguous first argument; put parentheses or even spaces` :uglify -> :uglifier Regression test for irregular inflection on has_many Singularize association names before camelization Fix spelling and proper nouns Optimize select_value, select_values, select_rows and dry up checking whether to exec with cache for Postgresql adapter Include default rails protect_from_forgery with: :exception ... Conflicts: activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb
| * Singularize association names before camelizationJavier Goizueta2014-04-181-2/+2
| | | | | | | | So that irregular multi-word pluralization rules have to be defined only for snake-case strings.
* | oops. should probably double check in the DCLAaron Patterson2014-04-141-1/+3
| |
* | cache scope building on associationsAaron Patterson2014-04-141-0/+9
|/ | | | SQL statements for querying associations are now cached
* Only call uniq on the conditional that actually needs itCarlos Antonio da Silva2014-04-091-1/+1
|
* Remove extra collect callCarlos Antonio da Silva2014-04-091-1/+1
|
* Make the aggregate_reflections cache work with strings as its keys.Lauro Caetano2014-04-091-2/+2
|
* No need to call `to_sym` on reflection name, since the cache now worksLauro Caetano2014-04-091-2/+2
| | | | | | with strings with string keys. Related #14668.
* Make the reflections cache work with strings as its keys.Lauro Caetano2014-04-091-2/+2
|
* The `source` option for `has_many => through` should accept StringLauro Caetano2014-04-091-1/+1
| | | | | | | | values. With the changes introduced by 16b70fddd4dc7e7fb7be108add88bae6e3c2509b it was expecting the value to be a Symbol, while it could be also a String value.
* Ensure we are returning either `true` or `false` for `#==`Godfrey Chan2014-03-291-1/+1
| | | | | | 460eb83d cused `ActiveRecord::Base#==` to sometimes return `nil` in some cases, this ensures we always return a boolean value. Also fixed a similar problem in AR reflections.
* scope_chain should not be mutated for other reflectionsNeeraj Singh2013-10-141-1/+1
| | | | | | | | | | | Currently `scope_chain` uses same array for building different `scope_chain` for different associations. During processing these arrays are sometimes mutated and because of in-place mutation the changed `scope_chain` impacts other reflections. Fix is to dup the value before adding to the `scope_chain`. Fixes #3882.
* Fix the indentationRafael Mendonça França2013-10-081-12/+13
|
* remove HABTM special cases from reflectionsAaron Patterson2013-10-021-14/+2
|
* push constructable? on to the reflectionAaron Patterson2013-10-021-0/+16
|
* Remove conditional adding a new methodRafael Mendonça França2013-09-111-5/+5
| | | | | | At the point we want to add the reflection we already know the reflection is of the AggregateReflection type so we can call a specific method
* support anonymous classes on has_many associationsAaron Patterson2013-09-031-0/+1
|
* pk should not be required for hm:t associationsAaron Patterson2013-08-291-1/+0
|
* Fixing multi-word automatic inverse detection.wangjohn2013-08-151-2/+2
| | | | | Currently, ActiveRecord models with multiple words cannot have their inverse associations detected automatically.
* Revert "all `scope_chain` methods allocate new arrays, no need to dup"Aaron Patterson2013-07-311-1/+1
| | | | This reverts commit 1468a4b89aa4bca99160bfa03572b2c0ab348db5.
* all `scope_chain` methods allocate new arrays, no need to dupAaron Patterson2013-07-301-1/+1
|
* oops!Aaron Patterson2013-07-231-1/+1
|
* eliminate conditional in JoinHelperAaron Patterson2013-07-231-1/+1
|
* acually get the actual source reflection :cry::gun:Aaron Patterson2013-07-231-7/+14
|
* factory methods should not have side effects.Aaron Patterson2013-07-231-3/+1
| | | | Move model mutation to the methods that are called on the model.
* extract mutation from generation methodAaron Patterson2013-07-231-3/+5
|
* habtm can only ever be an association reflectionAaron Patterson2013-07-221-2/+4
|
* use the predicate methodAaron Patterson2013-07-221-1/+1
|
* AR::Base does not need to know how to create reflection objectsAaron Patterson2013-07-221-19/+19
|
* use the superclass implementationAaron Patterson2013-07-181-1/+3
|
* quoted table name is also cachedAaron Patterson2013-06-131-1/+1
|
* table name is cached on the class, so stop caching twiceAaron Patterson2013-06-131-1/+1
|
* calculate types on constructionAaron Patterson2013-06-131-8/+4
|
* only cache the primary key column in one placeAaron Patterson2013-06-131-1/+1
|
* these methods are never called, so remove themAaron Patterson2013-06-131-8/+0
|
* This test does not test anything that happens in the real world. If youAaron Patterson2013-06-131-7/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | recreate the models without mucking with internal caches of the relation objects, then the test fails. For example: class Man < ActiveRecord::Base has_many :interests end class Interest < ActiveRecord::Base belongs_to :man end Then do this test: def test_validate_presence_of_parent_fails_without_inverse_of repair_validations(Interest) do Interest.validates_presence_of(:man) assert_no_difference ['Man.count', 'Interest.count'] do man = Man.create(:name => 'John', :interests_attributes => [{:topic=>'Cars'}, {:topic=>'Sports'}]) assert_not_predicate man.errors[:"interests.man"], :empty? end end end The test will fail. This is a bad test, so I am removing it.
* oops. step away from the keyboard aaron. :cry:Aaron Patterson2013-06-131-1/+1
|
* fix caching of automatic inverse of. :bomb:Aaron Patterson2013-06-131-1/+3
|
* let the object stay in charge of internal cache invalidationAaron Patterson2013-06-131-7/+5
|
* reduce automatic_inverse_of caching logicAaron Patterson2013-06-131-30/+16
|
* active_record should always be set. Do or do not, there is no tryAaron Patterson2013-06-131-1/+1
|
* push ambiguous reflection warning down to reflection name calculationAaron Patterson2013-06-131-23/+28
|
* clean up ivar assignmentAaron Patterson2013-06-131-3/+2
|
* Ambiguous reflections are on :through relationships are no longer supported.Aaron Patterson2013-06-131-1/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For example, you need to change this: class Author < ActiveRecord::Base has_many :posts has_many :taggings, :through => :posts end class Post < ActiveRecord::Base has_one :tagging has_many :taggings end class Tagging < ActiveRecord::Base end To this: class Author < ActiveRecord::Base has_many :posts has_many :taggings, :through => :posts, :source => :tagging end class Post < ActiveRecord::Base has_one :tagging has_many :taggings end class Tagging < ActiveRecord::Base end
* sometimes singularize does not work, so we get a list of two strings. just ↵Aaron Patterson2013-06-121-1/+1
| | | | uniq them
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-06 03:37:15 +0000