Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | removes usage of Object#in? from the code base (the method remains defined ↵ | Xavier Noria | 2012-08-06 | 1 | -1/+0 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | by Active Support) Selecting which key extensions to include in active_support/rails made apparent the systematic usage of Object#in? in the code base. After some discussion in https://github.com/rails/rails/commit/5ea6b0df9a36d033f21b52049426257a4637028d we decided to remove it and use plain Ruby, which seems enough for this particular idiom. In this commit the refactor has been made case by case. Sometimes include? is the natural alternative, others a simple || is the way you actually spell the condition in your head, others a case statement seems more appropriate. I have chosen the one I liked the most in each case. | |||||
* | | Remove `:rails_env` task since it is not needed anymore. | Rafael Mendonça França | 2012-08-02 | 1 | -9/+9 | |
| | | ||||||
* | | Only require the `:rails_env` task where is needed. | Rafael Mendonça França | 2012-07-27 | 1 | -12/+12 | |
|/ | | | | | | | | | | | | | `:rails_env` tasks is not needed in all the tasks that depends of `load_config`, only in the tasks that uses `Rails.env`. Since `:rails_env` task set the `Rails.env` to be "development" if it is not set we don't need the `||` statements too Fix #7175. Conflicts: activerecord/lib/active_record/railties/databases.rake | |||||
* | Fix collation database task to use begin..rescue..end | Carlos Antonio da Silva | 2012-06-30 | 1 | -4/+6 | |
| | ||||||
* | Extract collation tasks to database tasks. | kennyj | 2012-07-01 | 1 | -8/+3 | |
| | ||||||
* | Remove unused responsibilities and add a few load definitions to engines | José Valim | 2012-06-29 | 1 | -1/+1 | |
| | | | | | | | | Since plugins were removed, we can clean up a few methods in engines. We also use this opportunity to move `load_console`, `load_tasks` and `load_runner` to Rails::Engine. This means that, if someone wants to improve script/rails for engines to support console or runner commands, part of the work is already done. | |||||
* | Fix wrong environment. env should be RAILS_ENV or test. | kennyj | 2012-06-28 | 1 | -1/+1 | |
| | ||||||
* | Move to db:structure namespace, because these methods are global. | kennyj | 2012-06-26 | 1 | -8/+9 | |
| | ||||||
* | Remove session_table_name method because this is global and used only once. | kennyj | 2012-06-26 | 1 | -5/+1 | |
| | ||||||
* | Add a description about ENV["SCOPE"] | kennyj | 2012-06-26 | 1 | -1/+1 | |
| | ||||||
* | Change the behavior of db:test:prepare task when schema_format is sql for ↵ | kennyj | 2012-06-26 | 1 | -1/+1 | |
| | | | | consistency. | |||||
* | Change the behavior of db:test:clone task when schema_format is sql for ↵ | kennyj | 2012-06-26 | 1 | -1/+11 | |
| | | | | consistency. | |||||
* | Change an order of methods for readbility. | kennyj | 2012-06-26 | 1 | -7/+7 | |
| | ||||||
* | Refactor db:structure:load task. | kennyj | 2012-06-21 | 1 | -19/+2 | |
| | ||||||
* | Refactor db:structure:dump task. | kennyj | 2012-06-20 | 1 | -13/+3 | |
| | ||||||
* | Refactor db:charset task | Simon Jefford | 2012-06-19 | 1 | -14/+1 | |
| | | | | | In a similar vein to Pat's work on create, drop etc, the db:charset task is now a one liner in databases.rake | |||||
* | Merge pull request #6761 from freelancing-god/db-rake | Jon Leighton | 2012-06-17 | 1 | -156/+6 | |
|\ | | | | | Get logic out of db rake tasks, and into classes and objects | |||||
| * | One line db:create/db:drop tasks. | Pat Allan | 2012-06-17 | 1 | -55/+4 | |
| | | | | | | | | | | | | Now isn't that better? And yes, I know that private has no impact on class methods - it's a visual distinction, not a technical one. | |||||
| * | db:drop and some of db:test:purge. | Pat Allan | 2012-06-17 | 1 | -42/+8 | |
| | | ||||||
| * | db:create for PostgreSQL pulled out into a class. | Pat Allan | 2012-06-17 | 1 | -32/+7 | |
| | | ||||||
| * | db:create for MySQL now much cleaner. | Pat Allan | 2012-06-17 | 1 | -30/+1 | |
| | | ||||||
| * | A beginning of sorts. | Pat Allan | 2012-06-17 | 1 | -12/+1 | |
| | | | | | | | | Minimal implementation that supports db:create SQLite replacement | |||||
* | | Adding `load_config` task as dependency. | Cairo Noleto | 2012-06-16 | 1 | -14/+14 | |
| | | | | | | | | Without this, some tasks won't load configurations like custom engines. | |||||
* | | Don't read csv file during executing db:fixtures:load. | kennyj | 2012-06-17 | 1 | -1/+1 | |
|/ | ||||||
* | Merge pull request #4132 from Juanmcuello/clone_structure | Aaron Patterson | 2012-05-25 | 1 | -0/+1 | |
|\ | | | | | Reset postgreSQL search path in db:test:clone_structure. | |||||
| * | Reset postgreSQL search path in db:test:clone_structure. | Juan M. Cuello | 2011-12-22 | 1 | -0/+1 | |
| | | | | | | | | | | | | | | | | This patch resets the postgres search path in the structure.sql after the structure is dumped in order to find schema_migrations table when multiples schemas are used. Fixes #945 | |||||
* | | Merge pull request #5925 from Juanmcuello/pg_structure_dump | Carlos Antonio da Silva | 2012-05-24 | 1 | -2/+2 | |
| | | | | | | | | Quote arguments in db:structure:dump for PostgreSQL. | |||||
* | | Fix GH #5435. db:structure:dump should be reenable. | kennyj | 2012-03-17 | 1 | -0/+1 | |
| | | ||||||
* | | Merge pull request #5162 from kennyj/schema_cache_dump | Aaron Patterson | 2012-03-07 | 1 | -0/+19 | |
|\ \ | | | | | | | [Proposal] Schema cache dump | |||||
| * | | Add db:schema:cache:dump and db:schema:cache:clear tasks. | kennyj | 2012-03-01 | 1 | -0/+19 | |
| | | | ||||||
* | | | Merge pull request #5305 from arunagw/warning_fix | Vijay Dev | 2012-03-07 | 1 | -1/+1 | |
|\ \ \ | | | | | | | | | warning fix : mismatched indentations at 'end' with 'case' | |||||
| * | | | warning fix : mismatched indentations at 'end' with 'case' | Arun Agrawal | 2012-03-06 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Clean up module docs [ci skip] | Vijay Dev | 2012-03-07 | 1 | -1/+1 | |
|/ / / | | | | | | | | | | Removed some useless docstrings and no-doc'ed some. | |||||
* | | | Merge pull request #4984 from raghunadhd/change_orderhash | Vijay Dev | 2012-03-03 | 1 | -1/+1 | |
|\ \ \ | |/ / |/| | | Refactored code | |||||
| * | | Refactored code | Raghunadh | 2012-02-10 | 1 | -1/+1 | |
| | | | ||||||
* | | | Correctly print names of non-timestamped migrations with db:migrate:status | Peter Mitchell | 2012-02-17 | 1 | -2/+3 | |
| | | | ||||||
* | | | Always reenable _dump task in AR databases rake. Closes #5030 | Carlos Antonio da Silva | 2012-02-14 | 1 | -1/+4 | |
| | | | | | | | | | | | | | | | | | | | | | This allows the internal :_dump task to be called as many times as required. For instance, `rake db:migrate:redo` calls two tasks that internally call :_dump, and without reenabling it to be reinvoked, the database was left in incorrect state. | |||||
* | | | fixes rake db:test:prepare when using postgresql with sql db structure file ↵ | Sean Kirby | 2012-02-01 | 1 | -1/+1 | |
|/ / | | | | | | | and specifying a template in database.yml | |||||
* | | fixes in api docs | Vijay Dev | 2012-01-13 | 1 | -1/+1 | |
| | | ||||||
* | | Rails::Plugin has gone | Santiago Pastorino | 2012-01-03 | 1 | -1/+1 | |
| | | ||||||
* | | Revert "This conditions is required to work with database create task. 1.9.2 ↵ | Arun Agrawal | 2011-12-27 | 1 | -2/+1 | |
| | | | | | | | | | | | | | | is having a bug with "Calling return within begin still executes else". " No need to worry about 1.9.2 with master This reverts commit fbf4bee6ed3682b361d6fbeca8e185e665e26b81. | |||||
* | | Reconnect to the first database after db:create | Tsutomu Kuroda | 2011-12-23 | 1 | -0/+1 | |
|/ | | | | | Otherwise, the schema and seed will be loaded onto the test database. | |||||
* | Fix database tasks in test namespace. | Juan M. Cuello | 2011-12-19 | 1 | -9/+22 | |
| | | | | | This is mostly the same as 876bade5999c51f5031861f703933d50e48512ff that was reverted due to test failures, but now with a correction. | |||||
* | Revert "Merge pull request #4030 from Juanmcuello/database_tasks" | José Valim | 2011-12-19 | 1 | -20/+9 | |
| | | | | | This reverts commit a0edfb4d204857f0885784bd12582ae526af43c3, reversing changes made to 4012fcff22e4fe7833aae53b98e3ca9acfe3d3ad. | |||||
* | Fix database tasks in test namespace. | Juan M. Cuello | 2011-12-19 | 1 | -9/+20 | |
| | ||||||
* | fix a minor typo | Vijay Dev | 2011-12-19 | 1 | -1/+1 | |
| | ||||||
* | Update activerecord/lib/active_record/railties/databases.rake | José Valim | 2011-12-18 | 1 | -1/+1 | |
| | ||||||
* | Rename STRUCTURE to DB_STRUCTURE, update dump task description and add ↵ | Dieter Komendera | 2011-12-18 | 1 | -3/+3 | |
| | | | | simple testcase. | |||||
* | Make structure file configureable in db:structure:dump analog to SCHEMA in ↵ | Dieter Komendera | 2011-12-16 | 1 | -12/+14 | |
| | | | | db:schema dump and clean up a bit. | |||||
* | Allow to run migrations with given scope, with SCOPE=<scope> | Piotr Sarnacki | 2011-12-09 | 1 | -1/+3 | |
| | | | | | | | | | | | Scope in migrations can be defined by adding suffix in filename, like: 01_a_migration.blog.rb. Such migration have blog scope. Scope is automatically added while copying migrations from engine, so if you want to revert all of the migrations from given engine, you can just run db:migrate with SCOPE, like: rake db:migrate SCOPE=blog |