Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Remove blank trailing comments | Henrik Hodne | 2012-05-20 | 1 | -1/+0 |
| | | | | | | | For future reference, this is the regex I used: ^\s*#\s*\n(?!\s*#). Replace with the first match, and voilà! Note that the regex matches a little bit too much, so you probably want to `git add -i .` and go through every single diff to check if it actually should be changed. | ||||
* | Don't destroy readonly models | Johannes Barre | 2012-05-17 | 1 | -0/+1 |
| | |||||
* | Removed extraneous .present? check for AR::Base#reload | Jeremy Friesen | 2012-04-29 | 1 | -1/+1 |
| | |||||
* | Removed deprecation warning for #find as a result of AR::Base#reload | Jeremy Friesen | 2012-04-29 | 1 | -1/+7 |
| | | | | | Cleaned up "DEPRECATION WARNING: Passing options to #find is deprecated. Please build a scope and then call #find on it." | ||||
* | remove deprecate #update_all usage | Jon Leighton | 2012-04-26 | 1 | -2/+2 |
| | |||||
* | clear up duplication between Persistence#destroy and Locking#destroy | Jon Leighton | 2012-03-30 | 1 | -13/+17 |
| | |||||
* | Remove IdentityMap | Carlos Antonio da Silva | 2012-03-13 | 1 | -12/+4 |
| | |||||
* | Removed flag attributes. | Robin Roestenburg | 2012-03-06 | 1 | -2/+2 |
| | |||||
* | Refactor and cleanup in some ActiveRecord modules | Carlos Antonio da Silva | 2012-03-03 | 1 | -3/+8 |
| | | | | | | | | | | | * Avoid double hash lookups in AR::Reflection when reflecting associations/aggregations * Minor cleanups: use elsif, do..end, if..else instead of unless..else * Simplify DynamicMatchers#respond_to? * Use "where" instead of scoped with conditions hash * Extract `scoped_by` method pattern regexp to constant * Extract noisy class_eval from method_missing in dynamic matchers * Extract readonly check, avoid calling column#to_s twice in persistence * Refactor predicate builder, remove some variables | ||||
* | copy over columns hash on reload | Aaron Patterson | 2012-02-07 | 1 | -0/+1 |
| | |||||
* | Clarify what persisted? returns. | Uģis Ozols | 2011-12-25 | 1 | -2/+2 |
| | |||||
* | Remove extra 'be'. | Uģis Ozols | 2011-12-25 | 1 | -1/+1 |
| | |||||
* | removes some unnecessary selfs | Xavier Noria | 2011-12-20 | 1 | -3/+3 |
| | |||||
* | Make read_attribute code path accessible at the class level | Jon Leighton | 2011-12-22 | 1 | -8/+0 |
| | |||||
* | Split out most of the AR::Base code into separate modules :cake: | Jon Leighton | 2011-12-15 | 1 | -0/+47 |
| | |||||
* | `ActiveRecord::Base#becomes` should retain the errors of the original object. | James Adam | 2011-11-16 | 1 | -0/+1 |
| | | | | This commit contains a simple failing test that demonstrates the behaviour we expect, and a fix. When using `becomes` to transform the type of an object, it should retain any error information that was present on the original instance. | ||||
* | Revert "Raise error on unknown primary key." | Jon Leighton | 2011-10-05 | 1 | -1/+1 |
| | | | | This reverts commit ee2be435b1e5c0e94a4ee93a1a310e0471a77d07. | ||||
* | Raise error on unknown primary key. | Jon Leighton | 2011-10-05 | 1 | -1/+1 |
| | | | | | If we don't have a primary key when we ask for it, it's better to fail fast. Fixes GH #2307. | ||||
* | Raise error when using write_attribute with a non-existent attribute. | Jon Leighton | 2011-09-13 | 1 | -1/+1 |
| | | | | | | | | | Previously we would just silently write the attribute. This can lead to subtle bugs (for example, see the change in AutosaveAssociation where a through association would wrongly gain an attribute. Also, ensuring that we never gain any new attributes after initialization will allow me to reduce our dependence on method_missing. | ||||
* | Make it the responsibility of the connection to hold onto an ARel visitor ↵ | Jon Leighton | 2011-08-08 | 1 | -1/+1 |
| | | | | for generating SQL. This improves the code architecture generally, and solves some problems with marshalling. Adapter authors please take note: you now need to define an Adapter.visitor_for method, but it degrades gracefully with a deprecation warning for now. | ||||
* | Fixed Typo | John | 2011-07-24 | 1 | -1/+1 |
| | |||||
* | Destroy association habtm record before destroying the record itself. Fixes ↵ | Tomas D'Stefano | 2011-07-08 | 1 | -0/+7 |
| | | | | issue #402. | ||||
* | cache column defaults for AR object instantiation | Aaron Patterson | 2011-06-27 | 1 | -3/+1 |
| | |||||
* | Do not use default_scope in ActiveRecord::Persistence#touch. | Dmitriy Kiriyenko | 2011-06-07 | 1 | -1/+1 |
| | |||||
* | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2011-05-25 | 1 | -0/+2 |
|\ | | | | | | | | | | | Conflicts: actionmailer/lib/action_mailer/base.rb activesupport/lib/active_support/core_ext/kernel/requires.rb | ||||
| * | Add more doc to #update_column. | Sebastian Martinez | 2011-05-20 | 1 | -0/+2 |
| | | |||||
* | | rescue record invalid exceptions and return false from the save method. ↵ | Aaron Patterson | 2011-05-24 | 1 | -1/+5 |
|/ | | | | fixes #796 | ||||
* | renamed mass-assignment scopes to roles, updated code, tests, docs and ↵ | Josh Kalderimis | 2011-05-08 | 1 | -1/+1 |
| | | | | security guide | ||||
* | postgresql supports prepare statement deletes | Aaron Patterson | 2011-04-29 | 1 | -1/+9 |
| | |||||
* | Fix #update_attributes api format error | Sebastian Martinez | 2011-04-26 | 1 | -1/+1 |
| | |||||
* | AR update_attributes api is updated to reflect the addition of assign_attributes | Josh Kalderimis | 2011-04-26 | 1 | -4/+9 |
| | |||||
* | Added new #update_column method. | Sebastian Martinez | 2011-03-27 | 1 | -0/+14 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Revert "Removed #update_attribute method. New #update_column method." | Sebastian Martinez | 2011-03-27 | 1 | -8/+10 |
| | | | | | | This reverts commit 45c233ef819dc7b67e259dd73f24721fec28b8c8. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Removed #update_attribute method. New #update_column method. | Sebastian Martinez | 2011-03-26 | 1 | -10/+8 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | pushing id insertion and prefetch primary keys down to Relation#insert | Aaron Patterson | 2011-03-22 | 1 | -9/+1 |
| | |||||
* | Merge remote branch 'rails/master' into identity_map | Emilio Tagua | 2011-02-15 | 1 | -3/+6 |
|\ | | | | | | | | | | | | | | | | | | | | | | | Conflicts: activerecord/examples/performance.rb activerecord/lib/active_record/association_preload.rb activerecord/lib/active_record/associations.rb activerecord/lib/active_record/associations/association_proxy.rb activerecord/lib/active_record/autosave_association.rb activerecord/lib/active_record/base.rb activerecord/lib/active_record/nested_attributes.rb activerecord/test/cases/relations_test.rb | ||||
| * | removed some duplication from LH issue 5505 regarding AR touch and ↵ | Josh Kalderimis | 2011-02-09 | 1 | -5/+1 |
| | | | | | | | | | | | | optimistic locking [#5505 state:resolved] Signed-off-by: Santiago Pastorino and José Ignacio Costa <santiago+jose@wyeworks.com> | ||||
| * | The optimistic lock column should be increased when calling touch | Franck Verrot | 2011-02-09 | 1 | -0/+7 |
| | | | | | | | | Signed-off-by: Santiago Pastorino and José Ignacio Costa <santiago+jose@wyeworks.com> | ||||
| * | Do not use primary key on insertion when it's nil | Santiago Pastorino | 2010-12-29 | 1 | -2/+2 |
| | | |||||
| * | Allow primary_key to be an attribute when the model is a new record | Santiago Pastorino | 2010-12-28 | 1 | -1/+1 |
| | | |||||
* | | Merge remote branch 'rails/master' into identity_map | Emilio Tagua | 2010-12-20 | 1 | -6/+8 |
|\| | | | | | | | | | | | | | | | Conflicts: activerecord/lib/active_record/associations/association_proxy.rb activerecord/lib/active_record/autosave_association.rb activerecord/lib/active_record/base.rb activerecord/lib/active_record/persistence.rb | ||||
| * | removing calls to deprecated methods | Aaron Patterson | 2010-12-02 | 1 | -1/+2 |
| | | |||||
| * | refactor `self.class` to a variable | Aaron Patterson | 2010-12-02 | 1 | -1/+2 |
| | | |||||
| * | Partialy revert f1c13b0dd7b22b5f6289ca1a09f1d7a8c7c8584b | José Valim | 2010-11-28 | 1 | -5/+5 |
| | | |||||
* | | Use identity mapper only if enabled. | Emilio Tagua | 2010-11-19 | 1 | -3/+3 |
| | | |||||
* | | IdentityMap - adding and removing of records on create/update | Marcin Raczkowski | 2010-11-19 | 1 | -2/+12 |
|/ | |||||
* | STI type is now updated when calling AR::Base.becomes on subclasses [#5953 ↵ | Franck Verrot | 2010-11-12 | 1 | -0/+1 |
| | | | | state:resolved] | ||||
* | Double negation of an already boolean value produces the same result | Santiago Pastorino | 2010-11-09 | 1 | -1/+1 |
| | |||||
* | Don't check if persisted is defined just initialize it properly | Santiago Pastorino | 2010-11-09 | 1 | -2/+0 |
| | |||||
* | use persisted? instead of new_record? wherever possible | David Chelimsky | 2010-11-09 | 1 | -5/+7 |
| | | | | | | | | | | | - persisted? is the API defined in ActiveModel - makes it easier for extension libraries to conform to ActiveModel APIs without concern for whether the extended object is specifically ActiveRecord [#5927 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> |