aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/persistence.rb
Commit message (Collapse)AuthorAgeFilesLines
* Removing composed_of from ActiveRecord.Steve Klabnik2012-06-181-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This feature adds a lot of complication to ActiveRecord for dubious value. Let's talk about what it does currently: class Customer < ActiveRecord::Base composed_of :balance, :class_name => "Money", :mapping => %w(balance amount) end Instead, you can do something like this: def balance @balance ||= Money.new(value, currency) end def balance=(balance) self[:value] = balance.value self[:currency] = balance.currency @balance = balance end Since that's fairly easy code to write, and doesn't need anything extra from the framework, if you use composed_of today, you'll have to add accessors/mutators like that. Closes #1436 Closes #2084 Closes #3807
* Remove update_attribute.Steve Klabnik2012-06-141-18/+3
| | | | | | | | | | | Historically, update_attribute and update_attributes are similar, but with one big difference: update_attribute does not run validations. These two methods are really easy to confuse given their similar names. Therefore, update_attribute is being removed in favor of update_column. See the thread on rails-core here: https://groups.google.com/forum/?fromgroups#!topic/rubyonrails-core/BWPUTK7WvYA
* + ActiveRecord::Base#destroy!Marc-Andre Lafortune2012-06-061-0/+16
|
* Don't destroy readonly modelsJohannes Barre2012-05-171-0/+1
|
* Removed extraneous .present? check for AR::Base#reloadJeremy Friesen2012-04-291-1/+1
|
* Removed deprecation warning for #find as a result of AR::Base#reloadJeremy Friesen2012-04-291-1/+7
| | | | | Cleaned up "DEPRECATION WARNING: Passing options to #find is deprecated. Please build a scope and then call #find on it."
* remove deprecate #update_all usageJon Leighton2012-04-261-2/+2
|
* clear up duplication between Persistence#destroy and Locking#destroyJon Leighton2012-03-301-13/+17
|
* Remove IdentityMapCarlos Antonio da Silva2012-03-131-12/+4
|
* Removed flag attributes.Robin Roestenburg2012-03-061-2/+2
|
* Refactor and cleanup in some ActiveRecord modulesCarlos Antonio da Silva2012-03-031-3/+8
| | | | | | | | | | | * Avoid double hash lookups in AR::Reflection when reflecting associations/aggregations * Minor cleanups: use elsif, do..end, if..else instead of unless..else * Simplify DynamicMatchers#respond_to? * Use "where" instead of scoped with conditions hash * Extract `scoped_by` method pattern regexp to constant * Extract noisy class_eval from method_missing in dynamic matchers * Extract readonly check, avoid calling column#to_s twice in persistence * Refactor predicate builder, remove some variables
* copy over columns hash on reloadAaron Patterson2012-02-071-0/+1
|
* Clarify what persisted? returns.Uģis Ozols2011-12-251-2/+2
|
* Remove extra 'be'.Uģis Ozols2011-12-251-1/+1
|
* removes some unnecessary selfsXavier Noria2011-12-201-3/+3
|
* Make read_attribute code path accessible at the class levelJon Leighton2011-12-221-8/+0
|
* Split out most of the AR::Base code into separate modules :cake:Jon Leighton2011-12-151-0/+47
|
* `ActiveRecord::Base#becomes` should retain the errors of the original object.James Adam2011-11-161-0/+1
| | | | This commit contains a simple failing test that demonstrates the behaviour we expect, and a fix. When using `becomes` to transform the type of an object, it should retain any error information that was present on the original instance.
* Revert "Raise error on unknown primary key."Jon Leighton2011-10-051-1/+1
| | | | This reverts commit ee2be435b1e5c0e94a4ee93a1a310e0471a77d07.
* Raise error on unknown primary key.Jon Leighton2011-10-051-1/+1
| | | | | If we don't have a primary key when we ask for it, it's better to fail fast. Fixes GH #2307.
* Raise error when using write_attribute with a non-existent attribute.Jon Leighton2011-09-131-1/+1
| | | | | | | | | Previously we would just silently write the attribute. This can lead to subtle bugs (for example, see the change in AutosaveAssociation where a through association would wrongly gain an attribute. Also, ensuring that we never gain any new attributes after initialization will allow me to reduce our dependence on method_missing.
* Make it the responsibility of the connection to hold onto an ARel visitor ↵Jon Leighton2011-08-081-1/+1
| | | | for generating SQL. This improves the code architecture generally, and solves some problems with marshalling. Adapter authors please take note: you now need to define an Adapter.visitor_for method, but it degrades gracefully with a deprecation warning for now.
* Fixed TypoJohn2011-07-241-1/+1
|
* Destroy association habtm record before destroying the record itself. Fixes ↵Tomas D'Stefano2011-07-081-0/+7
| | | | issue #402.
* cache column defaults for AR object instantiationAaron Patterson2011-06-271-3/+1
|
* Do not use default_scope in ActiveRecord::Persistence#touch.Dmitriy Kiriyenko2011-06-071-1/+1
|
* Merge branch 'master' of git://github.com/lifo/docrailsXavier Noria2011-05-251-0/+2
|\ | | | | | | | | | | Conflicts: actionmailer/lib/action_mailer/base.rb activesupport/lib/active_support/core_ext/kernel/requires.rb
| * Add more doc to #update_column.Sebastian Martinez2011-05-201-0/+2
| |
* | rescue record invalid exceptions and return false from the save method. ↵Aaron Patterson2011-05-241-1/+5
|/ | | | fixes #796
* renamed mass-assignment scopes to roles, updated code, tests, docs and ↵Josh Kalderimis2011-05-081-1/+1
| | | | security guide
* postgresql supports prepare statement deletesAaron Patterson2011-04-291-1/+9
|
* Fix #update_attributes api format errorSebastian Martinez2011-04-261-1/+1
|
* AR update_attributes api is updated to reflect the addition of assign_attributesJosh Kalderimis2011-04-261-4/+9
|
* Added new #update_column method.Sebastian Martinez2011-03-271-0/+14
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Revert "Removed #update_attribute method. New #update_column method."Sebastian Martinez2011-03-271-8/+10
| | | | | | This reverts commit 45c233ef819dc7b67e259dd73f24721fec28b8c8. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Removed #update_attribute method. New #update_column method.Sebastian Martinez2011-03-261-10/+8
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* pushing id insertion and prefetch primary keys down to Relation#insertAaron Patterson2011-03-221-9/+1
|
* Merge remote branch 'rails/master' into identity_mapEmilio Tagua2011-02-151-3/+6
|\ | | | | | | | | | | | | | | | | | | | | | | Conflicts: activerecord/examples/performance.rb activerecord/lib/active_record/association_preload.rb activerecord/lib/active_record/associations.rb activerecord/lib/active_record/associations/association_proxy.rb activerecord/lib/active_record/autosave_association.rb activerecord/lib/active_record/base.rb activerecord/lib/active_record/nested_attributes.rb activerecord/test/cases/relations_test.rb
| * removed some duplication from LH issue 5505 regarding AR touch and ↵Josh Kalderimis2011-02-091-5/+1
| | | | | | | | | | | | optimistic locking [#5505 state:resolved] Signed-off-by: Santiago Pastorino and José Ignacio Costa <santiago+jose@wyeworks.com>
| * The optimistic lock column should be increased when calling touchFranck Verrot2011-02-091-0/+7
| | | | | | | | Signed-off-by: Santiago Pastorino and José Ignacio Costa <santiago+jose@wyeworks.com>
| * Do not use primary key on insertion when it's nilSantiago Pastorino2010-12-291-2/+2
| |
| * Allow primary_key to be an attribute when the model is a new recordSantiago Pastorino2010-12-281-1/+1
| |
* | Merge remote branch 'rails/master' into identity_mapEmilio Tagua2010-12-201-6/+8
|\| | | | | | | | | | | | | | | Conflicts: activerecord/lib/active_record/associations/association_proxy.rb activerecord/lib/active_record/autosave_association.rb activerecord/lib/active_record/base.rb activerecord/lib/active_record/persistence.rb
| * removing calls to deprecated methodsAaron Patterson2010-12-021-1/+2
| |
| * refactor `self.class` to a variableAaron Patterson2010-12-021-1/+2
| |
| * Partialy revert f1c13b0dd7b22b5f6289ca1a09f1d7a8c7c8584bJosé Valim2010-11-281-5/+5
| |
* | Use identity mapper only if enabled.Emilio Tagua2010-11-191-3/+3
| |
* | IdentityMap - adding and removing of records on create/updateMarcin Raczkowski2010-11-191-2/+12
|/
* STI type is now updated when calling AR::Base.becomes on subclasses [#5953 ↵Franck Verrot2010-11-121-0/+1
| | | | state:resolved]
* Double negation of an already boolean value produces the same resultSantiago Pastorino2010-11-091-1/+1
|