aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/persistence.rb
Commit message (Collapse)AuthorAgeFilesLines
* Update AR::Base.create and AR:Base#update_attributes docs to remove ↵Guillermo Iguaran2012-09-181-11/+0
| | | | references to mass assignment options
* Remove mass_assignment_options from ActiveRecordGuillermo Iguaran2012-09-161-7/+7
|
* Remove mass assignment security from ActiveRecordGuillermo Iguaran2012-09-161-2/+2
|
* set the configured #inheritance_column on #become (#7503)Yves Senn2012-09-031-1/+1
| | | | | | | | | | | | | | | I had to create a new table because I needed an STI table, which does not have both a "type" and a "custom_type" the test fails with: 1) Error: test_alt_becomes_works_with_sti(InheritanceTest): NoMethodError: undefined method `type=' for #<Cabbage id: 1, name: "my cucumber", custom_type: "Cucumber"> /Users/username/Projects/rails/activemodel/lib/active_model/attribute_methods.rb:432:in `method_missing' /Users/username/Projects/rails/activerecord/lib/active_record/attribute_methods.rb:100:in `method_missing' /Users/username/Projects/rails/activerecord/lib/active_record/persistence.rb:165:in `becomes' test/cases/inheritance_test.rb:134:in `test_becomes_works_with_sti' test/cases/inheritance_test.rb:140:in `test_alt_becomes_works_with_sti'
* Use verify_readonly_attribute in the update_columns methodRafael Mendonça França2012-08-251-1/+1
|
* Revert "Remove private verify readonly attr method"Rafael Mendonça França2012-08-251-1/+5
| | | | This reverts commit 7a8aee08b610f6edbfe5be076dc14e5cdcf1355e.
* Revert "Remove update_attribute."Rafael Mendonça França2012-08-251-4/+18
| | | | | | | | | | | This reverts commit a7f4b0a1231bf3c65db2ad4066da78c3da5ffb01. Conflicts: activerecord/lib/active_record/associations/has_one_association.rb activerecord/lib/active_record/persistence.rb activerecord/test/cases/base_test.rb activerecord/test/cases/dirty_test.rb activerecord/test/cases/timestamp_test.rb
* Remove private verify readonly attr methodCarlos Antonio da Silva2012-08-191-5/+1
| | | | | | | | | | This method was added to be shared between update_attribute and update_column in 50725cec397d4fa0ecf1dda4e6ae845a993f1ba7, but since update_attribute was removed, and update_column has changed to delegate to update_columns, the method is not used anywhere anymore. Also remove "key.to_s" conversion when raising readonly error, since the key is being interpolated.
* load active_support/concern in active_support/railsXavier Noria2012-08-021-1/+0
|
* Remove the deprecation of update_column.Rafael Mendonça França2012-07-301-5/+0
| | | | | | update_column was suggested as replacement of update_attribute at the last release of 3-2-stable, so deprecating it now will confuse the users.
* Revert "Removing composed_of from ActiveRecord."Rafael Mendonça França2012-07-271-0/+1
| | | | | | | | | | | This reverts commit 14fc8b34521f8354a17e50cd11fa3f809e423592. Reason: we need to discuss a better path from this removal. Conflicts: activerecord/lib/active_record/reflection.rb activerecord/test/cases/base_test.rb activerecord/test/models/developer.rb
* Deprecate update_column in favor of update_columns.Rafael Mendonça França2012-07-241-3/+8
| | | | Closes #1190
* Use update_columns to implemente the update_columnRafael Mendonça França2012-07-241-17/+18
|
* New #update_columns method.Sebastian Martinez2012-07-241-0/+17
|
* Removing composed_of from ActiveRecord.Steve Klabnik2012-06-181-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This feature adds a lot of complication to ActiveRecord for dubious value. Let's talk about what it does currently: class Customer < ActiveRecord::Base composed_of :balance, :class_name => "Money", :mapping => %w(balance amount) end Instead, you can do something like this: def balance @balance ||= Money.new(value, currency) end def balance=(balance) self[:value] = balance.value self[:currency] = balance.currency @balance = balance end Since that's fairly easy code to write, and doesn't need anything extra from the framework, if you use composed_of today, you'll have to add accessors/mutators like that. Closes #1436 Closes #2084 Closes #3807
* Remove update_attribute.Steve Klabnik2012-06-141-18/+3
| | | | | | | | | | | Historically, update_attribute and update_attributes are similar, but with one big difference: update_attribute does not run validations. These two methods are really easy to confuse given their similar names. Therefore, update_attribute is being removed in favor of update_column. See the thread on rails-core here: https://groups.google.com/forum/?fromgroups#!topic/rubyonrails-core/BWPUTK7WvYA
* + ActiveRecord::Base#destroy!Marc-Andre Lafortune2012-06-061-0/+16
|
* Don't destroy readonly modelsJohannes Barre2012-05-171-0/+1
|
* Removed extraneous .present? check for AR::Base#reloadJeremy Friesen2012-04-291-1/+1
|
* Removed deprecation warning for #find as a result of AR::Base#reloadJeremy Friesen2012-04-291-1/+7
| | | | | Cleaned up "DEPRECATION WARNING: Passing options to #find is deprecated. Please build a scope and then call #find on it."
* remove deprecate #update_all usageJon Leighton2012-04-261-2/+2
|
* clear up duplication between Persistence#destroy and Locking#destroyJon Leighton2012-03-301-13/+17
|
* Remove IdentityMapCarlos Antonio da Silva2012-03-131-12/+4
|
* Removed flag attributes.Robin Roestenburg2012-03-061-2/+2
|
* Refactor and cleanup in some ActiveRecord modulesCarlos Antonio da Silva2012-03-031-3/+8
| | | | | | | | | | | * Avoid double hash lookups in AR::Reflection when reflecting associations/aggregations * Minor cleanups: use elsif, do..end, if..else instead of unless..else * Simplify DynamicMatchers#respond_to? * Use "where" instead of scoped with conditions hash * Extract `scoped_by` method pattern regexp to constant * Extract noisy class_eval from method_missing in dynamic matchers * Extract readonly check, avoid calling column#to_s twice in persistence * Refactor predicate builder, remove some variables
* copy over columns hash on reloadAaron Patterson2012-02-071-0/+1
|
* Clarify what persisted? returns.Uģis Ozols2011-12-251-2/+2
|
* Remove extra 'be'.Uģis Ozols2011-12-251-1/+1
|
* removes some unnecessary selfsXavier Noria2011-12-201-3/+3
|
* Make read_attribute code path accessible at the class levelJon Leighton2011-12-221-8/+0
|
* Split out most of the AR::Base code into separate modules :cake:Jon Leighton2011-12-151-0/+47
|
* `ActiveRecord::Base#becomes` should retain the errors of the original object.James Adam2011-11-161-0/+1
| | | | This commit contains a simple failing test that demonstrates the behaviour we expect, and a fix. When using `becomes` to transform the type of an object, it should retain any error information that was present on the original instance.
* Revert "Raise error on unknown primary key."Jon Leighton2011-10-051-1/+1
| | | | This reverts commit ee2be435b1e5c0e94a4ee93a1a310e0471a77d07.
* Raise error on unknown primary key.Jon Leighton2011-10-051-1/+1
| | | | | If we don't have a primary key when we ask for it, it's better to fail fast. Fixes GH #2307.
* Raise error when using write_attribute with a non-existent attribute.Jon Leighton2011-09-131-1/+1
| | | | | | | | | Previously we would just silently write the attribute. This can lead to subtle bugs (for example, see the change in AutosaveAssociation where a through association would wrongly gain an attribute. Also, ensuring that we never gain any new attributes after initialization will allow me to reduce our dependence on method_missing.
* Make it the responsibility of the connection to hold onto an ARel visitor ↵Jon Leighton2011-08-081-1/+1
| | | | for generating SQL. This improves the code architecture generally, and solves some problems with marshalling. Adapter authors please take note: you now need to define an Adapter.visitor_for method, but it degrades gracefully with a deprecation warning for now.
* Fixed TypoJohn2011-07-241-1/+1
|
* Destroy association habtm record before destroying the record itself. Fixes ↵Tomas D'Stefano2011-07-081-0/+7
| | | | issue #402.
* cache column defaults for AR object instantiationAaron Patterson2011-06-271-3/+1
|
* Do not use default_scope in ActiveRecord::Persistence#touch.Dmitriy Kiriyenko2011-06-071-1/+1
|
* Merge branch 'master' of git://github.com/lifo/docrailsXavier Noria2011-05-251-0/+2
|\ | | | | | | | | | | Conflicts: actionmailer/lib/action_mailer/base.rb activesupport/lib/active_support/core_ext/kernel/requires.rb
| * Add more doc to #update_column.Sebastian Martinez2011-05-201-0/+2
| |
* | rescue record invalid exceptions and return false from the save method. ↵Aaron Patterson2011-05-241-1/+5
|/ | | | fixes #796
* renamed mass-assignment scopes to roles, updated code, tests, docs and ↵Josh Kalderimis2011-05-081-1/+1
| | | | security guide
* postgresql supports prepare statement deletesAaron Patterson2011-04-291-1/+9
|
* Fix #update_attributes api format errorSebastian Martinez2011-04-261-1/+1
|
* AR update_attributes api is updated to reflect the addition of assign_attributesJosh Kalderimis2011-04-261-4/+9
|
* Added new #update_column method.Sebastian Martinez2011-03-271-0/+14
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Revert "Removed #update_attribute method. New #update_column method."Sebastian Martinez2011-03-271-8/+10
| | | | | | This reverts commit 45c233ef819dc7b67e259dd73f24721fec28b8c8. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Removed #update_attribute method. New #update_column method.Sebastian Martinez2011-03-261-10/+8
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>