Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Simplify AR configuration code. | Jon Leighton | 2012-06-15 | 1 | -2/+6 | |
| | | | | | Get rid of ActiveModel::Configuration, make better use of ActiveSupport::Concern + class_attribute, etc. | |||||
* | Fix #5797. Error calling dup method on AR model with serialized field | kennyj | 2012-05-30 | 1 | -1/+1 | |
| | ||||||
* | clear up duplication between Persistence#destroy and Locking#destroy | Jon Leighton | 2012-03-30 | 1 | -14/+17 | |
| | ||||||
* | Merge pull request #5334 from courtland/master | Jon Leighton | 2012-03-30 | 1 | -0/+2 | |
|\ | | | | | Fix deleting from a HABTM join table upon destroying an object of a model with optimistic locking enabled. | |||||
| * | Fix deleting from a HABTM join table upon destroying an object of a model ↵ | Nick Rogers | 2012-03-07 | 1 | -0/+2 | |
| | | | | | | | | with optimistic locking enabled. Issue #5332. | |||||
* | | Removed flag attributes. | Robin Roestenburg | 2012-03-06 | 1 | -1/+1 | |
|/ | ||||||
* | Remove unusused variables | Jon Leighton | 2012-03-04 | 1 | -2/+1 | |
| | ||||||
* | Improve readonly examples and optimistic locking docs | Carlos Antonio da Silva | 2012-01-31 | 1 | -4/+6 | |
| | | | | | | | | | * Relation#order can receive order attributes as different arguments, add example; * Readonly does not handle deletion of records, only modification; * locking_version column does not need to default to 0, Rails handles nil values; * Change references from "set_locking_column" to "self.locking_column". | |||||
* | Add ActiveRecord::Base#with_lock | Olek Janiszewski | 2012-01-18 | 1 | -0/+22 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a `with_lock` method to ActiveRecord objects, which starts a transaction, locks the object (pessimistically) and yields to the block. The method takes one (optional) parameter and passes it to `lock!`. Before: class Order < ActiveRecord::Base def cancel! transaction do lock! # ... cancelling logic end end end After: class Order < ActiveRecord::Base def cancel! with_lock do # ... cancelling logic end end end | |||||
* | Support configuration on ActiveRecord::Model. | Jon Leighton | 2011-12-28 | 1 | -1/+4 | |
| | | | | | | | | | | | | | | | The problem: We need to be able to specify configuration in a way that can be inherited to models that include ActiveRecord::Model. So it is no longer sufficient to put 'top level' config on ActiveRecord::Base, but we do want configuration specified on ActiveRecord::Base and descendants to continue to work. So we need something like class_attribute that can be defined on a module but that is inherited when ActiveRecord::Model is included. The solution: added ActiveModel::Configuration module which provides a config_attribute macro. It's a bit specific hence I am not putting this in Active Support or making it a 'public API' at present. | |||||
* | Deal with global config better between AR::Base and AR::Model | Jon Leighton | 2011-12-24 | 1 | -4/+1 | |
| | ||||||
* | Make read_attribute code path accessible at the class level | Jon Leighton | 2011-12-22 | 1 | -15/+12 | |
| | ||||||
* | remove deprecated set and original methods for table_name, primary_key, etc | Sergey Nartimov | 2011-12-21 | 1 | -9/+1 | |
| | ||||||
* | Avoid super; speeds up Model.new by about 12% | Jon Leighton | 2011-12-14 | 1 | -1/+1 | |
| | ||||||
* | Deprecate set_locking_column in favour of self.locking_column= | Jon Leighton | 2011-11-29 | 1 | -8/+13 | |
| | ||||||
* | Added a note that optimistic locking also needs a hidden field to function ↵ | Joost Baaij | 2011-10-25 | 1 | -0/+3 | |
| | | | | across web workers. | |||||
* | Consider attempted action in exception message of ActiveRecord::StaleObjectError | Christian Bäuerlein | 2011-10-14 | 1 | -2/+2 | |
| | ||||||
* | Includes stale record in StaleObjectError | Christian Bäuerlein | 2011-10-14 | 1 | -2/+2 | |
| | ||||||
* | Make it the responsibility of the connection to hold onto an ARel visitor ↵ | Jon Leighton | 2011-08-08 | 1 | -2/+2 | |
| | | | | for generating SQL. This improves the code architecture generally, and solves some problems with marshalling. Adapter authors please take note: you now need to define an Adapter.visitor_for method, but it degrades gracefully with a deprecation warning for now. | |||||
* | lock_optimistically is typically true, so evaluate the common failure case first | Aaron Patterson | 2011-06-28 | 1 | -1/+1 | |
| | ||||||
* | Closes GH #1032 | John Paul Ashenfelter | 2011-05-19 | 1 | -1/+1 | |
| | | | | Fixed what looks like minor cut/paste error in documentation for ActiveRecord::Locking:Pessimistic | |||||
* | Better doc styling in ActiveRecord::Locking | Sebastian Martinez | 2011-05-17 | 2 | -17/+17 | |
| | ||||||
* | Don't quote ID's as Arel will quote them -- follow same conventions as the ↵ | Christopher Meiklejohn | 2011-05-08 | 1 | -1/+1 | |
| | | | | delete method. | |||||
* | remove some blanks | Paco Guzman | 2011-03-11 | 2 | -4/+4 | |
| | ||||||
* | fixed broken link to postgresql docs | Sergii Boiko | 2011-02-15 | 1 | -1/+1 | |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | removed some duplication from LH issue 5505 regarding AR touch and ↵ | Josh Kalderimis | 2011-02-09 | 1 | -4/+10 | |
| | | | | | | optimistic locking [#5505 state:resolved] Signed-off-by: Santiago Pastorino and José Ignacio Costa <santiago+jose@wyeworks.com> | |||||
* | removing more calls to deprecated methods | Aaron Patterson | 2010-12-02 | 1 | -2/+4 | |
| | ||||||
* | Remove explicit return. | Emilio Tagua | 2010-11-25 | 1 | -1/+1 | |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Reuse lock_col variable instead calling locking_column class method. | Emilio Tagua | 2010-11-25 | 1 | -3/+4 | |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Don't create local vars. | Emilio Tagua | 2010-11-24 | 1 | -4/+1 | |
| | ||||||
* | use persisted? instead of new_record? wherever possible | David Chelimsky | 2010-11-09 | 2 | -2/+2 | |
| | | | | | | | | | | | - persisted? is the API defined in ActiveModel - makes it easier for extension libraries to conform to ActiveModel APIs without concern for whether the extended object is specifically ActiveRecord [#5927 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Use new finders syntax in docs. | Emilio Tagua | 2010-09-01 | 1 | -3/+3 | |
| | ||||||
* | Set destroyed=true in opt locking's destroy [#5058 state:resolved] | Jacob Lewallen | 2010-07-14 | 1 | -0/+1 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Use arel instead of sql strings | Pratik Naik | 2010-05-11 | 1 | -6/+5 | |
| | ||||||
* | eliminate alias_method_chain from ActiveRecord | wycats | 2010-05-09 | 1 | -19/+8 | |
| | ||||||
* | Destroy respects optimistic locking. | Curtis Hawthorne | 2010-04-27 | 1 | -1/+34 | |
| | | | | | | | | | | Now works with :dependent => :destroy and includes unit tests for that case. Also includes better error messages when updating/deleting stale objects. [#1966 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | Dont delegate Relation#update to arel | Pratik Naik | 2010-01-20 | 1 | -1/+1 | |
| | ||||||
* | Give preference to to_a over arel from Relation#method_missing | Pratik Naik | 2010-01-19 | 1 | -2/+2 | |
| | ||||||
* | Rename Model.active_relation to Model.unscoped | Pratik Naik | 2010-01-17 | 1 | -1/+1 | |
| | ||||||
* | Rename Model.arel_table to Model.active_relation | Pratik Naik | 2010-01-02 | 1 | -4/+4 | |
| | ||||||
* | Remove unncessary arguments passed to arel_table | Pratik Naik | 2010-01-01 | 1 | -1/+1 | |
| | ||||||
* | Revert "Ensure Model#destroy respects optimistic locking" | Jeremy Kemper | 2009-11-17 | 1 | -34/+0 | |
| | | | | | | | | | | [#1966 state:open] This reverts commit 0d922885fb54c19f04680482f024452859218910. Conflicts: activerecord/lib/active_record/locking/optimistic.rb | |||||
* | Merge commit 'rails/master' | Emilio Tagua | 2009-09-14 | 1 | -22/+0 | |
|\ | ||||||
| * | Removed the copyright notice not to show it in the result of 'ri ActiveRecord'. | Shugo Maeda | 2009-09-11 | 1 | -22/+0 | |
| | | ||||||
* | | Cache arel_table when possible, use class method arel_table instead | Emilio Tagua | 2009-08-18 | 1 | -2/+6 | |
| | | | | | | | | instance method. | |||||
* | | Performance: cache/reload arel relation when possible to speed up things. | Emilio Tagua | 2009-07-21 | 1 | -2/+2 | |
| | | ||||||
* | | Merge commit 'rails/master' | Emilio Tagua | 2009-06-02 | 1 | -1/+1 | |
|\| | | | | | | | | | | | Conflicts: activerecord/lib/active_record.rb | |||||
| * | Break up DependencyModule's dual function of providing a "depend_on" DSL and ↵ | Joshua Peek | 2009-05-28 | 1 | -1/+1 | |
| | | | | | | | | "included" block DSL into separate modules. But, unify both approaches under AS::Concern. | |||||
* | | Merge commit 'rails/master' | Emilio Tagua | 2009-05-12 | 1 | -8/+8 | |
|\| | ||||||
| * | Use DependencyModule for included hooks in ActiveRecord | Bryan Helmkamp | 2009-05-11 | 1 | -8/+8 | |
| | |