Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | Remove most type related predicates from `Column` | Sean Griffin | 2015-01-30 | 1 | -3/+3 | |
|/ / | | | | | | | | | | | Remaining are `limit`, `precision`, `scale`, and `type` (the symbol version). These will remain on the column, since they mirror the options to the `column` method in the schema definition DSL | |||||
* | | Fix lookup of fixtures with non-string label | Prathamesh Sonpatki | 2015-01-06 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | - Fixtures with non-string labels such as integers should be accessed using integer label as key. For eg. pirates(1) or pirates(42). - But this results in NotFound error because the label is converted into string before looking up into the fixtures hash. - After this commit, the label is converted into string only if its a symbol. - This issue was fount out while adding a test case for https://github.com/rails/rails/commit/7b910917. | |||||
* | | Fix TypeError in Fixture creation | Matt Hogan | 2015-01-05 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ruby 4.2 started doing `value.gsub('$LABEL', label)` for fixture label interpolation, but you can have have valid YAML where `label` isn't a String. For example: ```YAML 0: name: John email: johndoe@gmail.com 1: name: Jane email: janedoe@gmail.com ``` This YAML will create a label that is a Fixnum, causing `TypeError: no implicit conversion of Fixnum into String.` | |||||
* | | Remove deprecated `ActiveRecord::Fixtures` constant | Rafael Mendonça França | 2015-01-04 | 1 | -6/+0 | |
| | | ||||||
* | | Pass symbol as an argument instead of a block | Erik Michaels-Ober | 2014-11-29 | 1 | -3/+3 | |
| | | ||||||
* | | Fix build failures | Sean Griffin | 2014-11-22 | 1 | -1/+3 | |
| | | | | | | | | | | | | | | | | | | | | For some reason changing `.find` to `.unscoped.find` in https://github.com/rails/rails/commit/f766abd4cf3eb75469d3646cfb6d85e668c619f3 caused `scoping` to leak in some tests when run in isolation (looks like a concurrency issue?). `relation_scoping_test.rb` is a case that failed. From what I can tell it should not be possible, but changing to the block form fixes it. There is a deeper issue that I can't seem to find. /cc @senny | |||||
* | | make it possible to access fixtures excluded by a `default_scope`. | Yves Senn | 2014-11-21 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | Prior to this patch you'd end up with an error like: ``` ActiveRecord::RecordNotFound: Couldn't find <Model> with 'id'=<id> [WHERE (<default_scope condition>)] ``` | |||||
* | | Avoid unnecessary allocations/calls | Pablo Herrero | 2014-11-02 | 1 | -1/+1 | |
|/ | ||||||
* | Merge pull request #17014 from grosser/grosser/fast-fixtures | Aaron Patterson | 2014-10-10 | 1 | -34/+2 | |
|\ | | | | | speed up fixtures by not loading all their classes | |||||
| * | speed up fixtures by not loading all their classes | grosser | 2014-10-06 | 1 | -34/+2 | |
| | | ||||||
* | | Use Hash#each_key instead of Hash#keys.each | Erik Michaels-Ober | 2014-09-29 | 1 | -1/+1 | |
|/ | | | | | | Hash#keys.each allocates an array of keys; Hash#each_key iterates through the keys without allocating a new array. This is the reason why Hash#each_key exists. | |||||
* | fix fixtures not loading if a belongs_to association is defined with a ↵ | Will Bryant | 2014-09-22 | 1 | -1/+1 | |
| | | | | :foreign_key option that's a symbol | |||||
* | Updated comment about features of fixtures | Prathamesh Sonpatki | 2014-09-19 | 1 | -0/+3 | |
| | | | | | | - Added a note about some features which are not dependent on auto-generated ID's. - [ci skip] | |||||
* | extract updating all fixture cache to a method so we can lock later | Aaron Patterson | 2014-09-03 | 1 | -1/+5 | |
| | ||||||
* | [ci skip] Fix example code of ActiveRecord::FixtureSet.context_class | yuuji.yaginuma | 2014-08-29 | 1 | -1/+1 | |
| | ||||||
* | don't log errors when all is fine | Peter Schröder | 2014-07-17 | 1 | -5/+5 | |
| | ||||||
* | Move uuid_v5 and uuid_v3 to Digest::UUID | Rafael Mendonça França | 2014-07-15 | 1 | -2/+2 | |
| | | | | | These methods are not random so they should not belings to SecureRandom module. | |||||
* | Revert code changes at "Copy edits and code font wrap for Active Record [ci ↵ | Rafael Mendonça França | 2014-06-13 | 1 | -1/+7 | |
| | | | | | | | | skip]" This partially reverts commit 1a203d5e07f639332880099fab610b886b1742fc. Reason: It was committed by accident | |||||
* | Copy edits and code font wrap for Active Record [ci skip] | Zachary Scott | 2014-06-13 | 1 | -15/+11 | |
| | ||||||
* | Remove deprecation warning | Akshay Vishnoi | 2014-06-11 | 1 | -4/+0 | |
| | ||||||
* | remove deprecation call while initializing `ClassCache` object | Kuldeep Aggarwal | 2014-06-11 | 1 | -7/+1 | |
| | ||||||
* | Merge branch 'master' of github.com:rails/docrails | Vijay Dev | 2014-06-07 | 1 | -3/+4 | |
|\ | ||||||
| * | [ci skip] remove double "in your" | schneems | 2014-06-04 | 1 | -1/+1 | |
| | | ||||||
| * | [ci skip] less derogatory explanation of defaults | schneems | 2014-06-02 | 1 | -2/+3 | |
| | | ||||||
| * | [ci skip] fix "note" syntax | schneems | 2014-06-02 | 1 | -1/+1 | |
| | | ||||||
* | | fix polymorphic? method and reuse it | eileencodes | 2014-06-02 | 1 | -1/+1 | |
|/ | | | | | | Fix polymorphic to check for `options[:polymorphic]` instead of `options.key? :polymorphic` and then reuse the method `polymorphic?` method instead of constantly checking the same `options[:polymorphic]`. | |||||
* | Merge pull request #15210 from arthurnn/fix_hbtm_reflection | Arthur Neves | 2014-05-24 | 1 | -1/+1 | |
| | | | | | | | | | Fix habtm reflection Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/counter_cache.rb activerecord/lib/active_record/reflection.rb activerecord/test/cases/reflection_test.rb | |||||
* | No need to call send | Rafael Mendonça França | 2014-04-10 | 1 | -1/+1 | |
| | ||||||
* | Merge pull request #12016 from roderickvd/uuid_fixes | Rafael Mendonça França | 2014-04-04 | 1 | -9/+24 | |
|\ | | | | | | | | | | | | | | | | | | | Auto-generate stable fixture UUIDs on PostgreSQL Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/fixtures.rb activerecord/test/cases/adapters/postgresql/uuid_test.rb activesupport/CHANGELOG.md | |||||
| * | Auto-generate stable fixture UUIDs on PostgreSQL. | Roderick van Domburg | 2014-01-07 | 1 | -9/+24 | |
| | | | | | | | | Fixes: #11524 | |||||
* | | Extend fixture label replacement to allow string interpolation | Eric Steele | 2014-03-15 | 1 | -1/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allows fixtures to use their $LABEL as part of a string instead of limiting use to the entire value. mark: first_name: $LABEL username: $LABEL1973 email: $LABEL@$LABELmail.com users(:mark).first_name # => mark users(:mark).username # => mark1973 users(:mark).email # => mark@markmail.com | |||||
* | | Fixed typo in comment about MAX_ID. | Vajrasky Kok | 2014-02-23 | 1 | -1/+1 | |
| | | ||||||
* | | Update deprecation warning to give more information about caller | T.J. Schuck | 2014-01-16 | 1 | -2/+2 | |
| | | ||||||
* | | Revert "ask the fixture set for the sql statements" | Aaron Patterson | 2014-01-09 | 1 | -12/+10 | |
|/ | | | | | | | | | This reverts commit 026d0555685087845b74dd87a0417b5a164b1c13. Conflicts: activerecord/lib/active_record/fixtures.rb Fixes #13383 | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-12-20 | 1 | -1/+1 | |
|\ | ||||||
| * | Typos. return -> returns. [ci skip] | Lauro Caetano | 2013-12-03 | 1 | -1/+1 | |
| | | ||||||
* | | Introduce a context for rendering fixtures ERB. | Victor Costan | 2013-12-03 | 1 | -0/+32 | |
|/ | | | | | | | | | | Fixture files are passed through an ERB renderer before being read as YAML. The rendering is currently done in the context of the main object, so method definitons leak into other fixtures, and there is no clean place to define fixture helpers. After this commit, the ERB renderer will use a new subclass of ActiveRecord::FixtureSet.context_class each time a fixture is rendered. | |||||
* | ask the fixture set for the sql statements | Aaron Patterson | 2013-11-04 | 1 | -10/+12 | |
| | ||||||
* | remove HABTM special cases from the fixtures | Aaron Patterson | 2013-10-02 | 1 | -12/+0 | |
| | ||||||
* | let the class cache object clean up user input | Aaron Patterson | 2013-09-09 | 1 | -8/+20 | |
| | ||||||
* | Fix fixtures regression that required table names to map to classes only, ↵ | Jeremy Kemper | 2013-09-08 | 1 | -1/+1 | |
| | | | | not class names | |||||
* | use polymorphic proxies to remove duplicate code | Aaron Patterson | 2013-09-06 | 1 | -24/+43 | |
| | ||||||
* | reduce duplication somewhat | Aaron Patterson | 2013-09-06 | 1 | -14/+14 | |
| | ||||||
* | make the duplicate code more similar | Aaron Patterson | 2013-09-06 | 1 | -4/+10 | |
| | ||||||
* | auto link hm:t fixture join tables like habtm | Aaron Patterson | 2013-09-06 | 1 | -0/+16 | |
| | ||||||
* | don't depend on object state when reading fixture files | Aaron Patterson | 2013-09-06 | 1 | -8/+7 | |
| | ||||||
* | ensure @model_class is initialized | Aaron Patterson | 2013-09-06 | 1 | -0/+1 | |
| | ||||||
* | no need to dup | Aaron Patterson | 2013-09-05 | 1 | -1/+1 | |
| | ||||||
* | push logic outside the FixtureSet constructor | Aaron Patterson | 2013-09-05 | 1 | -3/+3 | |
| | ||||||
* | only construct the FixtureSet with AR models | Aaron Patterson | 2013-09-05 | 1 | -2/+11 | |
| |