Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Refactor | Santiago Pastorino | 2012-10-03 | 1 | -5/+4 | |
| | ||||||
* | Fix reset_counters() crashing on has_many :through associations. | lulalala | 2012-10-02 | 1 | -2/+7 | |
| | | | | | The counter column name in the intermediate model need to be access via the through reflection. | |||||
* | reset_counters() was crashing when there were multiple belongs_to ↵ | Dave Desrochers | 2012-08-21 | 1 | -1/+1 | |
| | | | | | | associations with the same foreign key. This closes #5200. | |||||
* | Simplify AR configuration code. | Jon Leighton | 2012-06-15 | 1 | -98/+102 | |
| | | | | | Get rid of ActiveModel::Configuration, make better use of ActiveSupport::Concern + class_attribute, etc. | |||||
* | remove deprecate #update_all usage | Jon Leighton | 2012-04-26 | 1 | -1/+1 | |
| | ||||||
* | Remove IdentityMap | Carlos Antonio da Silva | 2012-03-13 | 1 | -2/+0 | |
| | ||||||
* | Refactor and cleanup in some ActiveRecord modules | Carlos Antonio da Silva | 2012-03-03 | 1 | -1/+1 | |
| | | | | | | | | | | | * Avoid double hash lookups in AR::Reflection when reflecting associations/aggregations * Minor cleanups: use elsif, do..end, if..else instead of unless..else * Simplify DynamicMatchers#respond_to? * Use "where" instead of scoped with conditions hash * Extract `scoped_by` method pattern regexp to constant * Extract noisy class_eval from method_missing in dynamic matchers * Extract readonly check, avoid calling column#to_s twice in persistence * Refactor predicate builder, remove some variables | |||||
* | Remove not used if..else clause | Carlos Antonio da Silva | 2012-01-23 | 1 | -6/+0 | |
| | | | | Related to #4614. | |||||
* | Unused var removed | Arun Agrawal | 2012-01-23 | 1 | -1/+1 | |
| | ||||||
* | Fix bug where reset_counters resets the wrong counter cache. | David Peter | 2012-01-16 | 1 | -1/+2 | |
| | | | | | | | | If a model belongs_to two associations with the same class, then reset_counters will reset the wrong counter cache. Finding the right reflection should use the foreign_key instead, which should be unique. | |||||
* | Remove unnecessary comma. | Uģis Ozols | 2011-12-26 | 1 | -1/+1 | |
| | ||||||
* | Make it the responsibility of the connection to hold onto an ARel visitor ↵ | Jon Leighton | 2011-08-08 | 1 | -1/+1 | |
| | | | | for generating SQL. This improves the code architecture generally, and solves some problems with marshalling. Adapter authors please take note: you now need to define an Adapter.visitor_for method, but it degrades gracefully with a deprecation warning for now. | |||||
* | Remove extra white spaces on ActiveRecord docs. | Sebastian Martinez | 2011-05-23 | 1 | -1/+1 | |
| | ||||||
* | Merge remote branch 'rails/master' into identity_map | Emilio Tagua | 2010-12-20 | 1 | -1/+2 | |
|\ | | | | | | | | | | | | | | | Conflicts: activerecord/lib/active_record/associations/association_proxy.rb activerecord/lib/active_record/autosave_association.rb activerecord/lib/active_record/base.rb activerecord/lib/active_record/persistence.rb | |||||
| * | removing more calls to deprecated methods | Aaron Patterson | 2010-12-02 | 1 | -1/+2 | |
| | | ||||||
* | | Added method to IM to remove objects by class and id. Then used it to remove ↵ | Emilio Tagua | 2010-11-19 | 1 | -0/+2 | |
|/ | | | | objects when updating counters. | |||||
* | Use COALESCE in update_counters docs to reflect the implementation | Carlos Antonio da Silva | 2010-08-18 | 1 | -3/+3 | |
| | ||||||
* | Refactor previous commits a bit. | José Valim | 2010-07-08 | 1 | -7/+10 | |
| | ||||||
* | reset_counter should work with non-traditional belongs_to and polymorphic ↵ | Neeraj Singh | 2010-07-08 | 1 | -3/+9 | |
| | | | | | | | | belongs_to [#4984 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Adds title and basic description where needed. | Rizwan Reza | 2010-06-15 | 1 | -0/+1 | |
| | ||||||
* | fix `reset_counters` to work even with complex class names | Mislav Marohnić | 2010-05-24 | 1 | -4/+6 | |
| | | | | | | e.g. it guesses that a belongs_to association to Namespace::MyModel is named "my_model", unlike before where it would look up an association named "namespace::mymodel" and fail. | |||||
* | cleanup `update/reset_counters`: less SQL strings, more ActiveRecord/Arel | Mislav Marohnić | 2010-05-24 | 1 | -12/+8 | |
| | ||||||
* | eliminate alias_method_chain from ActiveRecord | wycats | 2010-05-09 | 1 | -0/+107 | |