aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/connection_adapters
Commit message (Collapse)AuthorAgeFilesLines
* Make sure options is a hashRafael Mendonça França2013-03-081-1/+3
|
* Merge pull request #8868 from tehgeekmeister/masterRafael Mendonça França2013-03-081-0/+6
|\ | | | | | | | | | | | | | | | | Use the index name explicitly provided in a migration when reverting. Fixes #8868 Conflicts: activerecord/CHANGELOG.md
| * If an index can't be found by column, use the index name.Ezekiel Smithburg2013-03-071-0/+6
| | | | | | | | schema_statements uses the column name by default to construct the index name, and then raises an exception if it doesn't exist, even if the name option is specified, which causes #8858. this commit makes index_name_for_remove fall back to constructing the index name to remove based on the name option.
* | Unprepared Visitor + unprepared_statementCédric FABIANSKI2013-03-084-3/+14
|/
* SQLite3 3.6.8+ supports savepointsNeeraj Singh2013-03-071-1/+2
| | | | | http://www.sqlite.org/lang_savepoint.html https://github.com/rails/rails/blob/master/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L130-L132
* `Connection#structure_dump` is no longer used. #9518Yves Senn2013-03-062-19/+0
| | | | | | | As of ccc6910c we use `mysqldump` to create the `structure.sql`. The old `#structure_dump` code is still in AR but never used. I removed all relevant parts from the code-base.
* Remove hard coded references to Active Record in railtiesJosé Valim2013-03-021-2/+2
|
* Fix PostgreSQL TIMESTAMP WITH TIME ZONE to return ActiveSupport::TimeTroy Kruthoff2013-03-011-4/+1
| | | | | | | | | | In an AR model a timestamptz attribute would return a ruby string and AR tests did not check for any type casting. Previous tests would pass only because an assert_equal was being used on a Time.utc object, which will parse the right side of the eq to a valid Time instance for comparision. switch to test instance of Time instead of ActiveSupport::TimeWithZone
* Wrong exception is occured when raising no translatable exceptionkennyj2013-03-011-0/+2
|
* Support PostgreSQL specific column types when using `change_table`.Yves Senn2013-02-282-6/+22
| | | | | | | | Closes #9480. We use `TableDefinition` for `#create_table` and `Table` for `#change_table`. The PostgreSQL sepcifc types were only defined on `TableDefinition` so I also added them to `Table`.
* update docs, change_table does not use TableDefinition.Yves Senn2013-02-281-3/+3
|
* Revert "Merge pull request #9207 from dylanahsmith/mysql-quote-numeric"Steve Klabnik2013-02-272-8/+4
| | | | | This reverts commit 408227d9c5ed7de26310d72a1a99c1ee02311c63, reversing changes made to dca0b57d03deffc933763482e615c3cf0b9a1d97.
* Fix default output for postgres network address typesErik Peterson2013-02-261-0/+11
|
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-02-261-1/+1
|\
| * Typo fixCarson McDonald2013-02-251-1/+1
| |
* | Do not type cast all the database url values.Rafael Mendonça França2013-02-246-32/+29
| | | | | | | | | | | | We should only type cast when we need to use. Related to 4b005fb371c2e7af80df7da63be94509b1db038c
* | Indent comment block by two spaces.Marc Schütz2013-02-211-4/+4
| | | | | | | | | | As requested by @fxn https://github.com/schuetzm/rails/commit/743d15bba182df80d003d205690ead988970299c#commitcomment-2661417
* | Add more documentation for create_join_table.Marc Schütz2013-02-201-0/+8
| | | | | | | | | | Explain that it doesn't create indices by default and that it also has a block form.
* | also rename indexes when a table or column is renamedYves Senn2013-02-204-5/+34
| | | | | | | | When a table or a column is renamed related indexes kept their name. This will lead to confusing names. This patch renames related indexes when a column or a table is renamed. Only indexes with names generated by rails will be renamed. Indexes with custom names will not be renamed.
* | reserve less chars for internal sqlite3 operationsYves Senn2013-02-201-7/+7
| |
* | reserve index name chars for internal rails operationsYves Senn2013-02-203-4/+22
| | | | | | | | | | | | | | | | | | | | | | Some adapter (SQLite3) need to perform renaming operations to support the rails DDL. These rename prefixes operate with prefixes. When an index name already uses up the full space provieded by `index_name_length` these internal operations will fail. This patch introduces `allowed_index_name_length` which respects the amount of characters used for internal operations. It will always be <= `index_name_length` and every adapter can define how many characters need to be reserved.
* | Merge pull request #9342 from hone/db_migrate_with_database_urlRafael Mendonça França2013-02-201-1/+1
|\ \ | | | | | | Fix ActiveRecord::ConnectionAdapters::ConnectionSpecification::ResolverTest
| * | make type_cast_value a class level methodTerence Lee2013-02-211-1/+1
| | |
* | | Reduced memory leak problem in transactions by lazily updating AR objects ↵wangjohn2013-02-201-3/+10
|/ / | | | | | | with new transaction state. If AR object has a callback, the callback will be performed immediately (non-lazily) so the transaction still has to keep records with callbacks.
* | standardize database_configuration to a hashTerence Lee2013-02-211-2/+2
| | | | | | | | | | | | | | make connection_url_to_hash a class method This als prevents loading database.yml if it doesn't exist but DATABASE_URL does
* | descriptive error message when AR adapter was not found. Closes #7313.Yves Senn2013-02-201-2/+5
| |
* | Gist URLs are now namespacedAkira Matsuda2013-02-181-4/+4
| | | | | | | | see: https://github.com/blog/1406-namespaced-gists
* | copy-edits RDoc in fba496fXavier Noria2013-02-161-4/+4
| | | | | | | | | | | | | | This revision makes the terminology uniform with the rest of the file. In general we describe these methods in terms of the adapter, rather than the database. (As a side note, if we wanted to refer to the database we would write "PostgreSQL".)
* | Remove valid_type? methodJon Leighton2013-02-154-17/+0
|/ | | | | It was supposed to be removed by the preceding two reversions but I did them in the wrong order.
* Revert "Make valid_type? public"Jon Leighton2013-02-154-12/+17
| | | | | | This reverts commit 5d528f835e871f5f9d4b68e8a81cfbe900b7e718. Relates to f8c8ad5 which is also getting reverted due to failing test.
* Revert "Revert "Merge pull request #9206 from ranjaykrishna/use_define_method""Jon Leighton2013-02-151-18/+13
| | | | | | This reverts commit 8aa4603a5adaa56c818a7bd1c0b761b4ecca3d3e. Reverting the revert because I reverted the wrong thing! Fail.
* Revert "Merge pull request #9206 from ranjaykrishna/use_define_method"Jon Leighton2013-02-151-13/+18
| | | | | | | | | | | | | This reverts commit 1fc6876b57f2e1d31731e74eb4271b5655e746d2, reversing changes made to 0268b5d8cdc3c5a1337462135f0a326a2654ba1a. Reason: failing test 1) Error: test_valid_column(ActiveRecord::ConnectionAdapters::SQLite3AdapterTest): NoMethodError: undefined method `column' for test/cases/adapters/sqlite3/sqlite3_adapter_test.rb:29:in `test_valid_column'
* Make valid_type? publicSam Ruby2013-02-144-17/+12
|
* 9253: Before writing a numeric attribute value, ActiveRecord does an implicitRyan Warnick2013-02-131-4/+5
| | | | | | conversion of boolean types (true => 1 and false => 0). If the numeric value being assigned is a BigDecimal, then ActiveRecord compares a BigDecimal to true and false. This is known to be very slow in Ruby 1.9.3.
* Merge pull request #9204 from ranjaykrishna/col-probAaron Patterson2013-02-124-0/+15
|\ | | | | schema dumper tests now conducted by ActiveRecord::Base.Connection
| * checking in the abstractions for valid type checking:Ranjay Krishna2013-02-124-0/+15
| |
* | Merge pull request #9206 from ranjaykrishna/use_define_methodCarlos Antonio da Silva2013-02-121-18/+13
|\ \ | | | | | | Use define method instead of class_eval
| * | reverted back our changes and added in the new define_methodRanjay Krishna2013-02-121-18/+13
| |/
* | active_record: Quote numeric values compared to string columns.Dylan Smith2013-02-072-4/+8
| |
* | Call super to use the abstract adapter implementation insteadCarlos Antonio da Silva2013-02-061-1/+1
| |
* | Add changelog entry for #9203 about schema dumper with db extensionsCarlos Antonio da Silva2013-02-061-2/+2
| | | | | | | | [ci skip]
* | add ActiveRecord::AbstractAdapter#extensions and ↵Justin George2013-02-062-0/+15
| | | | | | | | ActiveRecord::ConnectionAdapters::PostgreSQLAdapter#extensions to allow dumping of enabled extensions to schema.rb, add ActiveRecord::SchemaDumper#extensions to dump extensions to schema.rb
* | Fix typo :bomb:Rafael Mendonça França2013-01-311-1/+1
| |
* | Fix typoRafael Mendonça França2013-01-311-2/+2
| |
* | Strict regexpRafael Mendonça França2013-01-311-2/+2
| |
* | Extract the value casting to a methodRafael Mendonça França2013-01-311-15/+23
| |
* | DATABASE_URL parsing should turn numeric strings into numeric types, andAaron Stone2013-01-311-0/+19
| | | | | | | | | | | | the strings true and false into boolean types, in order to match how YAML would parse the same values from database.yml and prevent unexpected type errors in the database adapters.
* | reloading type map on extension changingAaron Patterson2013-01-292-2/+15
| |
* | fixing commentAaron Patterson2013-01-291-1/+1
| |
* | Fix typoRafael Mendonça França2013-01-291-1/+1
| |