| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|\
| |
| |
| |
| |
| |
| | |
Fair connection pool2
Conflicts:
activerecord/test/cases/associations/eager_test.rb
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The core of this fix is a threadsafe, fair Queue class. It is
very similar to Queue in stdlib except that it supports waiting
with a timeout.
The issue this solves is that if several threads are contending for
database connections, an unfair queue makes is possible that a thread
will timeout even while other threads successfully acquire and release
connections. A fair queue means the thread that has been waiting the
longest will get the next available connection.
This includes a few test fixes to avoid test ordering issues that
cropped up during development of this patch.
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Properly discover a connection is closed in postgresql_adapter
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
PQstatus doesn't properly test if future operations will succeed. A
PQping function is added to libpq in PostgreSQL 9.1, but if we rely
on it, everyone on earlier versions of Postgres is out of luck,
and the pg gem wouldn't have the 'fix' until the next release.
Thanks to @cbrecabarren and @ged for handling all the dirty details.
Closes #3392.
|
|\ \ \
| | | |
| | | | |
Fix logs name consistency.
|
| | | | |
|
| |_|/
|/| | |
|
|\ \ \
| | | |
| | | | |
Remove prepared statement from system query in postgresql adapter
|
| | | | |
|
|\ \ \ \
| |_|_|/
|/| | |
| | | | |
Maximum wait_timeout on Windows is 2147483
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This option was added on cb6f839359bd894feb0a1105b79af72b336aa41e
renaming the :wait_timeout option.
Fix build http://travis-ci.org/#!/rails/rails/jobs/1413405
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
#6441
An AR ConnectionSpec `wait_timeout` is pre-patch used for three
different things:
* mysql2 uses it for MySQL's own wait_timeout (how long MySQL
should allow an idle connection before closing it), and
defaults to 2592000 seconds.
* ConnectionPool uses it for "number of seconds to block and
wait for a connection before giving up and raising a timeout error",
default 5 seconds.
* ConnectionPool uses it for the Reaper, for deciding if a 'dead'
connection can be reaped. Default 5 seconds.
Previously, if you want to change these from defaults, you need
to change them all together. This is problematic _especially_
for the mysql2/ConnectionPool conflict, you will generally _not_
want them to be the same, as evidenced by their wildly different
defaults. This has caused real problems for people #6441 #2894
But as long as we're changing this, forcing renaming the
ConnectionPool key to be more specific, it made sense
to seperate the two ConnectionPool uses too -- these two
types of ConnectionPool timeouts ought to be able to be
changed independently, you won't neccesarily want them
to be the same, even though the defaults are (currently)
the same.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit d2901f0fc4270a765717ad572d559dc49a56b3a8, reversing
changes made to 525839fdd8cc34d6d524f204528d5b6f36fe410c.
Conflicts:
activerecord/test/cases/connection_pool_test.rb
Reason: This change broke the build (http://travis-ci.org/#!/rails/rails/builds/1391490)
and we don't have any solution until now. I asked the author to try to
fix it and open a new pull request.
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Fix a problem of translate_exception method in a Japanese (non English) environment.
|
| | |_|/
| |/| | |
|
|/ / /
| | |
| | |
| | | |
concurrency error.
|
|\ \ \
| | | |
| | | | |
Postgresql doesn't accept limits on binary (bytea) columns.
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
danmcclain/add_inet_and_cidr_types_to_postgresql_adapter
Add support for macaddr, inet, and cidr types to PostgreSQL adapter
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Integer limit out of range should be allowed to raise. Closes #6272
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
SQLite3 doesn't actually support the 'time' type.
|
| |/ / / / / |
|
|/ / / / / |
|
| | | | | |
|
| | | | | |
|
|\ \ \ \ \
| |_|_|_|/
|/| | | |
| | | | |
| | | | | |
acapilleri/missplelling_error_in_abstract_mysql_adapter
missplelling error in abstract_mysql_adapter
|
| | | | | |
|
| |_|/ /
|/| | | |
|
|\ \ \ \
| | | | |
| | | | | |
Fixed bug in ActiveRecord that caused classes to be quoted incorrectly
|
| | |_|/
| |/| | |
|
|\ \ \ \
| | | | |
| | | | | |
Use strict mode in mysql
|
| | | | | |
|
| | |_|/
| |/| | |
|
|/ / /
| | |
| | |
| | | |
Issue #6045
|
|\ \ \
| | | |
| | | | |
postgresql adapter should quote not a number and infinity correctly for float columns
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|