aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/connection_adapters
Commit message (Collapse)AuthorAgeFilesLines
...
* Support Descending Indexes for MySQLRyuta Kamizono2017-04-162-3/+2
| | | | | | | MySQL 8.0.1 and higher supports descending indexes: `DESC` in an index definition is no longer ignored. See https://dev.mysql.com/doc/refman/8.0/en/descending-indexes.html.
* Refactor `indexes` things in connection adaptersRyuta Kamizono2017-04-166-67/+114
| | | | | | | * Use keyword arguments in `IndexDefinition` to ease to ignore unused options and to avoid to initialize incorrect empty value. * Place it in `SchemaStatements` for consistency. * And tiny tweaks.
* Merge pull request #28726 from matthewd/transaction-lockingMatthew Draper2017-04-133-52/+70
|\ | | | | Add comprehensive locking around DB transactions
| * Add comprehensive locking around DB transactionsMatthew Draper2017-04-113-52/+70
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Transactional-fixture using tests with racing threads and inter-thread synchronisation inside transaction blocks will now deadlock... but without this, they would just crash. In 5.0, the threads didn't share a connection at all, so it would've worked... but with the main thread inside the fixture transaction, they wouldn't've been able to see each other. So: as far as I can tell, the set of operations this "breaks" never had a compelling use case. Meanwhile, it provides an increased level of coherency to the operational feel of transactional fixtures. If this does cause anyone problems, they're probably best off disabling transactional fixtures on the affected tests, and managing transactions themselves.
* | Use a query that's compatible with PostgreSQL 9.2Matthew Draper2017-04-121-7/+11
|/ | | | | | Also, explicitly apply the order: generate_subscripts is unlikely to start returning values out of order, but we should still be clear about what we want.
* Fix example usage of ActiveRecord::Base.establish_connectionSimon Dawson2017-03-301-1/+1
| | | `ActiveRecord::Base.establish_connection` accepts a single symbol argument to specify a named connection; a single string argument appears to be interpreted as a connection URI
* Merge pull request #28478 from kamipo/fix_primary_keys_across_multiple_schemasAndrew White2017-03-291-9/+7
|\ | | | | Fix `primary_keys` across multiple schemas
| * Fix `primary_keys` across multiple schemasRyuta Kamizono2017-03-201-9/+7
| | | | | | | | Fixes #28470.
* | Merge pull request #28052 from kamipo/make_internal_methods_to_privateRafael França2017-03-2811-184/+180
|\ \ | | | | | | Make internal methods to private
| * | Make internal methods to privateRyuta Kamizono2017-03-2711-184/+180
| | |
* | | Use `SET CONSTRAINTS` for `disable_referential_integrity` without superuser ↵Fumiaki MATSUSHIMA2017-03-262-4/+49
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | privileges (take 2) Re-create https://github.com/rails/rails/pull/21233 eeac6151a5 was reverted (127509c071b4) because it breaks tests. ---------------- ref: 72c1557254 - We must use `authors` fixture with `author_addresses` because of its foreign key constraint. - Tests require PostgreSQL >= 9.4.2 because it had a bug about `ALTER CONSTRAINTS` and fixed in 9.4.2.
* | Move comment to inside the method [ci skip]Fumiaki MATSUSHIMA2017-03-231-1/+1
| | | | | | | | | | | | Because this comment is not document for `supports_ranges?` ref: https://github.com/rails/rails/pull/27636#discussion_r107560081
* | Merge pull request #28526 from kamipo/fix_log_subscriber_to_allow_legacy_bindsRafael França2017-03-221-8/+7
|\ \ | | | | | | Fix `LogSubscriber` to allow legacy `binds`
| * | Fix `LogSubscriber` to allow legacy `binds`Ryuta Kamizono2017-03-231-8/+7
| | | | | | | | | | | | Follow up of #27939.
* | | [PostgreSQL]: Replace deprecated PG constants.Lars Kanis2017-03-225-16/+16
|/ / | | | | | | | | The old top level classes PGconn, PGresult and PGError were deprecated since pg-0.13.0: https://github.com/ged/ruby-pg/blob/master/History.rdoc#v0130-2012-02-09-michael-granger-gedfaeriemudorg
* | Merge pull request #28487 from kamipo/remove_duplicated_columns_definitionRafael França2017-03-202-11/+5
|\ \ | | | | | | Remove duplicated `columns` definition
| * | Remove duplicated `columns` definitionRyuta Kamizono2017-03-202-11/+5
| |/
* | Merge pull request #27939 from kamipo/fix_select_all_with_legacy_bindsRafael França2017-03-201-1/+5
|\ \ | |/ |/| Fix `select_all` with legacy `binds`
| * Fix `select_all` with legacy `binds`Ryuta Kamizono2017-02-121-1/+5
| | | | | | | | Fixes #27923.
* | Revert "Merge pull request #28369 from ↵Matthew Draper2017-03-141-2/+2
| | | | | | | | | | | | | | | | | | mylake/reduce-postgresql-adapter-memory-bloat" This reverts commit 192db64452d148c7b51713979459e38407380dc6, reversing changes made to 9893955363cf6358556ed3b36f4538d5b54e9d17. We can't sacrifice correctness for performance.
* | Merge pull request #28369 from mylake/reduce-postgresql-adapter-memory-bloatRafael França2017-03-131-2/+2
|\ \ | | | | | | 500x memory reduction of 10k schemas for postgresql adapter
| * | Use “distinct” to filter redundant types from pg_typeto reduce memory ↵mylake2017-03-101-2/+2
| | | | | | | | | | | | bloat especially in multi-schema structure database
* | | Merge pull request #28068 from kamipo/refactor_data_sourcesRafael França2017-03-137-201/+154
|\ \ \ | | | | | | | | Extract `data_source_sql` to refactor data source statements
| * | | Prefer `USING (column_list)` for joining information_schemaRyuta Kamizono2017-02-251-3/+1
| | | |
| * | | Extract `data_source_sql` to refactor data source statementsRyuta Kamizono2017-02-207-198/+153
| | | |
* | | | Merge pull request #28017 from mtsmfm/suppress-dep-warnMatthew Draper2017-03-132-0/+4
|\ \ \ \ | |_|/ / |/| | | Suppress deprecation warning `implementing to_yaml is deprecated`
| * | | Suppress deprecation warning `implementing to_yaml is deprecated`Fumiaki MATSUSHIMA2017-02-152-0/+4
| |/ /
* | | Merge pull request #28305 from kamipo/extract_schema_migration_all_versionsAndrew White2017-03-061-2/+2
|\ \ \ | | | | | | | | Extract `SchemaMigration.all_versions`
| * | | Extract `SchemaMigration.all_versions`Ryuta Kamizono2017-03-061-2/+2
| | | | | | | | | | | | | | | | | | | | Use `SchemaMigration.all_versions` instead of `SchemaMigration.all.map(&:version)` to avoid to instantiate AR objects.
* | | | Fix `deserialize` with JSON arrayRyuta Kamizono2017-03-061-1/+1
|/ / / | | | | | | | | | Fixes #28285.
* | | Remove useless `Migrator.schema_migrations_table_name`Ryuta Kamizono2017-03-051-2/+2
| | | | | | | | | | | | Simply use `SchemaMigration.table_name` instead.
* | | Don't hide method that's been documented API since Rails 2.1Andrew White2017-03-041-3/+3
| | |
* | | Fix `rake db:schema:load` with subdirectoriesRyuta Kamizono2017-03-051-5/+4
| | | | | | | | | | | | | | | | | | | | | | | | Related #25174. `db:schema:load` doesn't work with subdirectories like previous `db:migrate:status`. `Migrator.migration_files` should be used in `assume_migrated_upto_version` to fix the issue.
* | | Don't share `options` with a reference type columnRyuta Kamizono2017-03-041-7/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | Sharing `options` causes some unexpected behavior. If `limit: 2` is specified, this means that 2 bytes integer for a reference id column and 2 chars string for a reference type column. Another example, if `unsigned: true` is specified, this means that unsigned integer for a reference id column, but a invalid option for a reference type column. So `options` should not be shared with a reference type column.
* | | Merge pull request #28220 from kamipo/valid_type_accept_only_supported_typesRafael França2017-03-011-4/+0
|\ \ \ | | | | | | | | `valid_type?` should accept only supported types
| * | | `valid_type?` should accept only supported typesRyuta Kamizono2017-02-281-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `valid_type?` is used in schema dumper to determine if a type is supported. So if `valid_type?(:foobar)` is true, it means that schema dumper is allowed to create `t.foobar`. But it doesn't work. I think that `valid_type?` should accept only supported types. https://github.com/rails/rails/blob/v5.1.0.beta1/activerecord/lib/active_record/schema_dumper.rb#L135-L142 ```ruby columns.each do |column| raise StandardError, "Unknown type '#{column.sql_type}' for column '#{column.name}'" unless @connection.valid_type?(column.type) next if column.name == pk type, colspec = @connection.column_spec(column) tbl.print " t.#{type} #{column.name.inspect}" tbl.print ", #{format_colspec(colspec)}" if colspec.present? tbl.puts end ```
* | | | `create_join_table` should respect `references` column typeRyuta Kamizono2017-02-281-7/+5
|/ / / | | | | | | | | | | | | | | | | | | | | | Follow up of #26266. The default type of `primary_key` and `references` were changed to `bigint` since #26266. But `create_join_table` column type is still `integer`. It should respect `references` column type.
* | | Use `max_identifier_length` for `index_name_length` in PostgreSQL adapterRyuta Kamizono2017-02-272-6/+3
| | | | | | | | | | | | | | | Actually `index_name_length` depend on `max_identifier_length`, not always 63.
* | | Deprecate `supports_migrations?` on connection adaptersRyuta Kamizono2017-02-274-18/+3
| | | | | | | | | | | | | | | | | | | | | `supports_migrations?` was added at 4160b518 to determine if schema statements (`create_table`, `drop_table`, etc) are implemented in the adapter. But all tested databases has been supported migrations since a4fc93c3 at least.
* | | Merge pull request #28176 from kamipo/push_valid_type_up_to_abstract_adapterAndrew White2017-02-264-11/+3
|\ \ \ | | | | | | | | Push `valid_type?` up to abstract adapter
| * | | Push `valid_type?` up to abstract adapterRyuta Kamizono2017-02-264-11/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | `valid_type?` should return true if a type exists in `native_database_types` at least. https://github.com/rails/rails/blob/v5.1.0.beta1/activerecord/lib/active_record/schema_dumper.rb#L136
* | | | Fix typo 'affect' -> 'effect' [ci skip]Rebecca Skinner2017-02-261-1/+1
| | | |
* | | | Fix `change_column` to drop default with `null: false`Ryuta Kamizono2017-02-263-5/+4
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently `change_column` cannot drop default if `null: false` is specified at the same time. This change fixes the issue. ```ruby # cannot drop default change_column "tests", "contributor", :boolean, default: nil, null: false # we need the following workaround currently change_column "tests", "contributor", :boolean, null: false change_column "tests", "contributor", :boolean, default: nil ``` Closes #26582
* | | Merge pull request #28167 from kirs/deprecate-verify-argsMatthew Draper2017-02-261-0/+3
|\ \ \ | | | | | | | | Deprecate AbstractAdapter#verify! with arguments
| * | | Deprecate AbstractAdapter#verify! with argumentsKir Shatrov2017-02-251-0/+3
| | | |
* | | | Merge pull request #25285 from ↵Rafael França2017-02-231-0/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | kamipo/fix_remove_reference_to_multiple_foreign_keys_in_the_same_table Fix `remove_reference` to multiple foreign keys in the same table
| * | | | Fix `remove_reference` to multiple foreign keys in the same tableRyuta Kamizono2017-02-111-0/+1
| | |_|/ | |/| |
* | | | Deprecate using `#quoted_id` in quotingRyuta Kamizono2017-02-241-0/+2
| | | | | | | | | | | | | | | | | | | | Originally `quoted_id` was used in legacy quoting mechanism. Now we use type casting mechanism for that. Let's deprecate `quoted_id`.
* | | | Fix type casting AR object to respect the primary key cast type's serializationRyuta Kamizono2017-02-241-2/+13
| | | |
* | | | Fix `wait_timeout` to configurable for mysql2 adapterRyuta Kamizono2017-02-241-2/+2
| | | | | | | | | | | | | | | | Fixes #26556.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-21 22:37:14 +0000