Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #10664 from aderyabin/docpatch | Yves Senn | 2013-10-29 | 1 | -1/+1 |
|\ | | | | | Fix doc in Postgres database creation [ci skip] | ||||
| * | Fix doc in Postgres database creation | Andrey Deryabin | 2013-06-25 | 1 | -1/+1 |
| | | |||||
* | | Remove confusing generated-code commentary | Jeremy Kemper | 2013-10-28 | 1 | -4/+4 |
| | | |||||
* | | Add a note about ensuring the version is right for the adapter (since you ↵ | David Heinemeier Hansson | 2013-10-27 | 1 | -1/+1 |
| | | | | | | | | might well have specified the right gem, but locked it to too low of a version) | ||||
* | | cast json values on write to be consistent with reading from the db. | Severin Schoepke | 2013-10-25 | 1 | -0/+4 |
| | | | | | | | | See also commit 5ac2341fab689344991b2a4817bd2bc8b3edac9d | ||||
* | | `ActiveRecord::Store` works together with PG `hstore` columns. | Yves Senn | 2013-10-25 | 2 | -0/+12 |
| | | | | | | | | | | | | This is necessary because as of 5ac2341 `hstore` columns are always stored as `Hash` with `String` keys. `ActiveRecord::Store` expected the attribute to be an instance of `HashWithIndifferentAccess`, which led to the bug. | ||||
* | | Escape the parentheses in the default function regexp | Rafael Mendonça França | 2013-10-21 | 1 | -1/+1 |
| | | | | | | | | | | | | | | This is causing every default value in PostreSQL database to being handled as default function. Fixes #12581 | ||||
* | | Remove `default_primary_key_type` and extract contains of ↵ | Vipul A M | 2013-10-14 | 1 | -18/+16 |
| | | | | | | | | `native_database_types` to a constant since they aren't conditional now in SQLite3Adapter. Makes it more like other adapters. | ||||
* | | Merge pull request #11833 from vipulnsward/remove_autoincrement | Rafael Mendonça França | 2013-10-14 | 1 | -10/+1 |
|\ \ | | | | | | | Remove sqlite specific`supports_autoincrement?` which defaults to true | ||||
| * | | Remove sqlite specific`supports_autoincrement?` which always defaults to true | Vipul A M | 2013-08-10 | 1 | -10/+1 |
| | | | |||||
* | | | Extract a function to determine if the default value is a function | Rafael Mendonça França | 2013-10-14 | 1 | -1/+5 |
| | | | |||||
* | | | Push default_function to superclass to avoid method check | Rafael Mendonça França | 2013-10-14 | 2 | -14/+17 |
| | | | |||||
* | | | log the statement name along with the SQL | Aaron Patterson | 2013-10-04 | 2 | -6/+7 |
| | | | |||||
* | | | log every sql statement, even when they error | Aaron Patterson | 2013-10-04 | 1 | -25/+25 |
| | | | |||||
* | | | prepare the statement inside the begin / rescue block | Aaron Patterson | 2013-10-04 | 1 | -4/+4 |
| | | | |||||
* | | | wrap logging around the actual query call itself. | Aaron Patterson | 2013-10-04 | 2 | -50/+50 |
| | | | | | | | | | | | | This is to be consistent with the way the mysql2 adapter times queries | ||||
* | | | extract adapter savepoint implementations into `abstract/savepoints.rb`. | Yves Senn | 2013-09-30 | 6 | -46/+27 |
| | | | |||||
* | | | change the savepoint interface to allow passing the name. | Yves Senn | 2013-09-30 | 4 | -21/+21 |
| | | | |||||
* | | | Fixed issue #12327 | Marc Lennox | 2013-09-27 | 1 | -2/+2 |
| | | | |||||
* | | | ActiveRecord::ConnectionAdapters::Column.string_to_time method respects ↵ | kennyj | 2013-09-25 | 1 | -3/+11 |
| | | | | | | | | | | | | string with timezone. Closes #12278. | ||||
* | | | Merge pull request #11382 from kennyj/fix_10751-2 | Rafael Mendonça França | 2013-09-22 | 1 | -3/+6 |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | Dump UUID default functions to schema.rb [2nd version]. Fixes #10751. Conflicts: activerecord/CHANGELOG.md | ||||
| * | | | Migration dump UUID default functions to schema.rb. Fixes #10751. | kennyj | 2013-07-10 | 1 | -3/+6 |
| | | | | |||||
* | | | | Disable prepared statements in the unprepared_statement block | Rafael Mendonça França | 2013-09-12 | 1 | -2/+3 |
| | | | | |||||
* | | | | Fix inverted conditional | Rafael Mendonça França | 2013-09-11 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | Oops, I should had run the tests | ||||
* | | | | Remove invalid comment | Rafael Mendonça França | 2013-09-11 | 1 | -4/+0 |
| | | | | | | | | | | | | | | | | This is not valid anymore after 08477a651648ba4417ded128aa37b9ae0dcbc9ce | ||||
* | | | | Check if the SQL is not a prepared statement | Rafael Mendonça França | 2013-09-11 | 8 | -7/+15 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the adapter is with prepared statement disabled and the binds array is not empty the connection adapter will try to set the binds values and will fail. Now we are checking if the adapter has the prepared statement disabled. Fixes #12023 | ||||
* | | | | Revert "Do not dup the binds when visiting the AST" | Rafael Mendonça França + Kassio Borges | 2013-08-31 | 2 | -2/+3 |
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 71ff7d9c6592b93e2c810a1f464943dd7bd02c7f. Reason: I need to check with @jeremy if we can do this. | ||||
* | | | | Do not dup the binds when visiting the AST | Rafael Mendonça França | 2013-08-31 | 2 | -3/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | The visitor have to consume the bind parameters to make the statements work when the prepared statement option is disabled. Fixes #12023 | ||||
* | | | | Perf: fields in pg gem causes an allocation, cache it | Sam | 2013-08-27 | 1 | -2/+3 |
| | | | | |||||
* | | | | Merge pull request #11827 from vipulnsward/remove_extra_case | Santiago Pastorino | 2013-08-26 | 1 | -1/+0 |
|\ \ \ \ | | | | | | | | | | | Remove extra case. | ||||
| * | | | | Remove extra case. | Vipul A M | 2013-08-10 | 1 | -1/+0 |
| | |/ / | |/| | | |||||
* | | | | PG adapter deals with negative money values formatted with parenthesis. | Yves Senn | 2013-08-26 | 1 | -0/+5 |
| | | | | | | | | | | | | | | | | Closes #11899. | ||||
* | | | | Use infinity const | Konstantin Shabanov | 2013-08-22 | 1 | -2/+2 |
| | | | | |||||
* | | | | Stop interpreting SQL 'string' columns as :string type. | Ben Woosley | 2013-08-17 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | SQL doesn't have a string type, and interpreting 'string' as text is contrary to at least SQLite3's behavior: "Note that a declared type of 'STRING' has an affinity of NUMERIC, not TEXT." http://www.sqlite.org/datatype3.html | ||||
* | | | | Rescue invalid ip address exceptions on assign. | Paul Nikitochkin | 2013-08-14 | 1 | -1/+5 |
| | | | | | | | | | | | | | | | | In order that set attribute should not be bang method | ||||
* | | | | Merge pull request #11838 from vipulnsward/drop_extra_var | Steve Klabnik | 2013-08-12 | 1 | -2/+2 |
|\ \ \ \ | | | | | | | | | | | drop extra variable | ||||
| * | | | | drop extra variable | Vipul A M | 2013-08-12 | 1 | -2/+2 |
| |/ / / | |||||
* / / / | chmod -x | Akira Matsuda | 2013-08-12 | 3 | -0/+0 |
|/ / / | |||||
* | | | Remove redundant `string_to_binary` from type-casting | Vipul A M | 2013-08-09 | 5 | -18/+4 |
| | | | |||||
* | | | Merge pull request #11802 from ko1/fix_field_encoding_for_mysql | Aaron Patterson | 2013-08-07 | 3 | -1/+14 |
|\ \ \ | | | | | | | | | Set field encoding to client_encoding for mysql adapter. | ||||
| * | | | Set field encoding to client_encoding for mysql adapter. | Koichi Sasada | 2013-08-08 | 3 | -1/+14 |
| | | | | |||||
* | | | | cast hstore values on write to be consistent with reading from the db. | Yves Senn | 2013-08-08 | 2 | -4/+12 |
|/ / / | |||||
* | | | Merge pull request #11331 from vipulnsward/remove_conditional | Aaron Patterson | 2013-08-07 | 1 | -8/+1 |
|\ \ \ | | | | | | | | | Remove conditional, results are always an instance of `ActiveRecord::Result` | ||||
| * | | | Remove conditional, since results are always an instance of ↵ | Vipul A M | 2013-07-06 | 1 | -8/+1 |
| | | | | | | | | | | | | | | | | `ActiveRecord::Result` | ||||
* | | | | Fix multidimensional PG arrays containing non-string items | Yves Senn | 2013-08-07 | 1 | -1/+9 |
| | | | | |||||
* | | | | config[:database] should be a string | Rafael Mendonça França | 2013-08-05 | 1 | -3/+3 |
| | | | | | | | | | | | | | | | | | | | | This change was breaking the Railties tests. See https://travis-ci.org/rails/rails/jobs/9865969 | ||||
* | | | | Merge pull request #11762 from peterkovacs/patch-2 | Carlos Antonio da Silva | 2013-08-05 | 1 | -1/+1 |
|\ \ \ \ | | | | | | | | | | | Free result_metadata directly instead of freeing 2nd, redundant call. | ||||
| * | | | | Free result_metadata directly instead of freeing 2nd, redundant call. | Peter Kovacs | 2013-08-05 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | `result_metadata` returns a new object each time it is called, so calling `result_metadata.free` is essentially a noop. Instead call `free` directly on the metadata when we're done with it. | ||||
* | | | | | Create sqlite3 directory if not present | schneems | 2013-08-05 | 1 | -3/+5 |
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the `db/` directory is not present on a remote machine it will blow up in unexpected ways with error messages that do not indicate there is a missing directory: ``` SQLite3::CantOpenException: unable to open database file ``` This PR checks to see if a directory exists for the sqlite3 file and if not creates it for you. This PR is an alternative to #11692 as suggested by @josevalim | ||||
* | | | | Merge pull request #11455 from antonio/fix_enable_extension_not_being_defined | Rafael Mendonça França | 2013-08-02 | 1 | -0/+8 |
|\ \ \ \ | | | | | | | | | | | Define enable_extension method to prevent undefined method error |