Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | use `connect_poll` on pg so that reaping does not hurt the connection | Aaron Patterson | 2013-03-20 | 2 | -3/+4 |
| | |||||
* | Revert "default the reaping frequency to 10 seconds" | Aaron Patterson | 2013-03-20 | 1 | -1/+1 |
| | | | | | | | mysql can't handle a parallel thread pinging the connection, so we can get wrong results or segvs This reverts commit 7cc588b684f6d1af3e7fab1edfa6715e269e41a2. | ||||
* | Revert "Merge pull request #9784 from ↵ | Carlos Antonio da Silva | 2013-03-18 | 1 | -4/+4 |
| | | | | | | | | | | vipulnsward/change_from_blank_to_empty_on_string" This reverts commit 9c4c05fc82e997b722dec4068c3aa27eaee69eb8, reversing changes made to 4620bdcefd0c88905a005f191496df887877b8f3. Reason: They're not completely interchangeable, since blank? will also check for strings containing spaces. | ||||
* | Merge pull request #9784 from vipulnsward/change_from_blank_to_empty_on_string | Carlos Antonio da Silva | 2013-03-18 | 1 | -4/+4 |
|\ | | | | | Change from blank? to empty? on obvious string values to save extra calls | ||||
| * | change from blank? to empty? on obvious string values to save extra method ↵ | Vipul A M | 2013-03-19 | 1 | -4/+4 |
| | | | | | | | | calls | ||||
* | | fix typos in AR. lots of them. | Vipul A M | 2013-03-19 | 2 | -2/+2 |
|/ | |||||
* | sets limit 191 for schema_migrations#version in mysql2 if the encoding is ↵ | Xavier Noria | 2013-03-17 | 1 | -0/+9 |
| | | | | | | "utf8mb4" Please, see rationale in the included CHANGELOG patch. | ||||
* | Refactored to reuse method | Anupam Choudhury | 2013-03-15 | 1 | -2/+2 |
| | |||||
* | Merge pull request #9686 from strzalek/cast_number_to_string_in_pg | Jon Leighton | 2013-03-15 | 1 | -3/+6 |
|\ | | | | | Cast number to string in Postgres | ||||
| * | Cast number to string in Postgres | Łukasz Strzałkowski | 2013-03-12 | 1 | -3/+6 |
| | | | | | | | | fixes #9170 | ||||
* | | ask column if it is a pk | Aaron Patterson | 2013-03-14 | 1 | -1/+5 |
| | | |||||
* | | fix hash duping on 1.9 | Aaron Patterson | 2013-03-14 | 1 | -1/+1 |
| | | |||||
* | | clean up pk delclaration in `create_table` | Aaron Patterson | 2013-03-14 | 1 | -1/+8 |
| | | |||||
* | | just access the ivars rather than rb_iv_get | Aaron Patterson | 2013-03-14 | 1 | -5/+3 |
| | | |||||
* | | hide more data in the schema cache | Aaron Patterson | 2013-03-14 | 1 | -1/+21 |
| | | |||||
* | | safely publish columns and columns hash info | Aaron Patterson | 2013-03-14 | 1 | -4/+12 |
| | | |||||
* | | dup and set the default proc to nil rather than looping through everything | Aaron Patterson | 2013-03-14 | 1 | -1/+3 |
| | | |||||
* | | you can provide uuid_generate_v4 as the default value for uuid columns | Aaron Patterson | 2013-03-14 | 2 | -2/+9 |
| | | |||||
* | | pg is the only adapter that supports the xml type, so push the method down | Aaron Patterson | 2013-03-14 | 2 | -9/+4 |
| | | |||||
* | | Apparently people were mutating this array. :'( | Aaron Patterson | 2013-03-14 | 1 | -3/+3 |
| | | | | | | | | This reverts commit abba61e2bbe320894ba8449ebdf778a1d2af545b. | ||||
* | | hashes are ordered, so just use the columns_hash ivar | Aaron Patterson | 2013-03-14 | 1 | -3/+3 |
| | | |||||
* | | use the method so we do not depend on internal ivars | Aaron Patterson | 2013-03-14 | 1 | -1/+1 |
| | | |||||
* | | extract factory method and push common code up to abstract adapter | Aaron Patterson | 2013-03-14 | 2 | -7/+7 |
| | | |||||
* | | Also quote extension name in disable_extension | Stephen Touset | 2013-03-12 | 1 | -1/+1 |
|/ | | | A patch was committed recently which quoted the extension name in the SQL for `enable_extension`. But the same wasn't done for `disable_extension`. | ||||
* | Pass column to quote when copying a sqlite table. | Matthew M. Boedicker | 2013-03-11 | 1 | -1/+9 |
| | | | | To make quote escape binary data correctly it needs the column passed in. | ||||
* | Fix typo [ci skip] | Carlos Antonio da Silva | 2013-03-11 | 1 | -1/+1 |
| | |||||
* | promotes change_column_null to the migrations API | Xavier Noria | 2013-03-11 | 1 | -0/+20 |
| | |||||
* | quick pass over the RDoc of schema_statements.rb [ci skip] | Xavier Noria | 2013-03-11 | 1 | -122/+190 |
| | |||||
* | documents how to DROP DEFAULT [ci skip] | Xavier Noria | 2013-03-11 | 1 | -3/+7 |
| | |||||
* | default the reaping frequency to 10 seconds | Aaron Patterson | 2013-03-11 | 1 | -1/+1 |
| | |||||
* | fixes enable_extension bug in postgresql_adapter | Darren Woodley | 2013-03-08 | 1 | -1/+1 |
| | | | | | | | | | The use of quotations is required to install extensions with certain characters in them (e.g. uuid-ossp). removes CHANGELOG entry Deemed unnecessary. | ||||
* | Make sure options is a hash | Rafael Mendonça França | 2013-03-08 | 1 | -1/+3 |
| | |||||
* | Merge pull request #8868 from tehgeekmeister/master | Rafael Mendonça França | 2013-03-08 | 1 | -0/+6 |
|\ | | | | | | | | | | | | | | | | | Use the index name explicitly provided in a migration when reverting. Fixes #8868 Conflicts: activerecord/CHANGELOG.md | ||||
| * | If an index can't be found by column, use the index name. | Ezekiel Smithburg | 2013-03-07 | 1 | -0/+6 |
| | | | | | | | | schema_statements uses the column name by default to construct the index name, and then raises an exception if it doesn't exist, even if the name option is specified, which causes #8858. this commit makes index_name_for_remove fall back to constructing the index name to remove based on the name option. | ||||
* | | Unprepared Visitor + unprepared_statement | Cédric FABIANSKI | 2013-03-08 | 4 | -3/+14 |
|/ | |||||
* | SQLite3 3.6.8+ supports savepoints | Neeraj Singh | 2013-03-07 | 1 | -1/+2 |
| | | | | | http://www.sqlite.org/lang_savepoint.html https://github.com/rails/rails/blob/master/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L130-L132 | ||||
* | `Connection#structure_dump` is no longer used. #9518 | Yves Senn | 2013-03-06 | 2 | -19/+0 |
| | | | | | | | As of ccc6910c we use `mysqldump` to create the `structure.sql`. The old `#structure_dump` code is still in AR but never used. I removed all relevant parts from the code-base. | ||||
* | Remove hard coded references to Active Record in railties | José Valim | 2013-03-02 | 1 | -2/+2 |
| | |||||
* | Fix PostgreSQL TIMESTAMP WITH TIME ZONE to return ActiveSupport::Time | Troy Kruthoff | 2013-03-01 | 1 | -4/+1 |
| | | | | | | | | | | In an AR model a timestamptz attribute would return a ruby string and AR tests did not check for any type casting. Previous tests would pass only because an assert_equal was being used on a Time.utc object, which will parse the right side of the eq to a valid Time instance for comparision. switch to test instance of Time instead of ActiveSupport::TimeWithZone | ||||
* | Wrong exception is occured when raising no translatable exception | kennyj | 2013-03-01 | 1 | -0/+2 |
| | |||||
* | Support PostgreSQL specific column types when using `change_table`. | Yves Senn | 2013-02-28 | 2 | -6/+22 |
| | | | | | | | | Closes #9480. We use `TableDefinition` for `#create_table` and `Table` for `#change_table`. The PostgreSQL sepcifc types were only defined on `TableDefinition` so I also added them to `Table`. | ||||
* | update docs, change_table does not use TableDefinition. | Yves Senn | 2013-02-28 | 1 | -3/+3 |
| | |||||
* | Revert "Merge pull request #9207 from dylanahsmith/mysql-quote-numeric" | Steve Klabnik | 2013-02-27 | 2 | -8/+4 |
| | | | | | This reverts commit 408227d9c5ed7de26310d72a1a99c1ee02311c63, reversing changes made to dca0b57d03deffc933763482e615c3cf0b9a1d97. | ||||
* | Fix default output for postgres network address types | Erik Peterson | 2013-02-26 | 1 | -0/+11 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-02-26 | 1 | -1/+1 |
|\ | |||||
| * | Typo fix | Carson McDonald | 2013-02-25 | 1 | -1/+1 |
| | | |||||
* | | Do not type cast all the database url values. | Rafael Mendonça França | 2013-02-24 | 6 | -32/+29 |
| | | | | | | | | | | | | We should only type cast when we need to use. Related to 4b005fb371c2e7af80df7da63be94509b1db038c | ||||
* | | Indent comment block by two spaces. | Marc Schütz | 2013-02-21 | 1 | -4/+4 |
| | | | | | | | | | | As requested by @fxn https://github.com/schuetzm/rails/commit/743d15bba182df80d003d205690ead988970299c#commitcomment-2661417 | ||||
* | | Add more documentation for create_join_table. | Marc Schütz | 2013-02-20 | 1 | -0/+8 |
| | | | | | | | | | | Explain that it doesn't create indices by default and that it also has a block form. | ||||
* | | also rename indexes when a table or column is renamed | Yves Senn | 2013-02-20 | 4 | -5/+34 |
| | | | | | | | | When a table or a column is renamed related indexes kept their name. This will lead to confusing names. This patch renames related indexes when a column or a table is renamed. Only indexes with names generated by rails will be renamed. Indexes with custom names will not be renamed. |