aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/connection_adapters
Commit message (Collapse)AuthorAgeFilesLines
* also rename indexes when a table or column is renamedYves Senn2013-02-204-5/+34
| | | | When a table or a column is renamed related indexes kept their name. This will lead to confusing names. This patch renames related indexes when a column or a table is renamed. Only indexes with names generated by rails will be renamed. Indexes with custom names will not be renamed.
* reserve less chars for internal sqlite3 operationsYves Senn2013-02-201-7/+7
|
* reserve index name chars for internal rails operationsYves Senn2013-02-203-4/+22
| | | | | | | | | | | Some adapter (SQLite3) need to perform renaming operations to support the rails DDL. These rename prefixes operate with prefixes. When an index name already uses up the full space provieded by `index_name_length` these internal operations will fail. This patch introduces `allowed_index_name_length` which respects the amount of characters used for internal operations. It will always be <= `index_name_length` and every adapter can define how many characters need to be reserved.
* Merge pull request #9342 from hone/db_migrate_with_database_urlRafael Mendonça França2013-02-201-1/+1
|\ | | | | Fix ActiveRecord::ConnectionAdapters::ConnectionSpecification::ResolverTest
| * make type_cast_value a class level methodTerence Lee2013-02-211-1/+1
| |
* | Reduced memory leak problem in transactions by lazily updating AR objects ↵wangjohn2013-02-201-3/+10
|/ | | | with new transaction state. If AR object has a callback, the callback will be performed immediately (non-lazily) so the transaction still has to keep records with callbacks.
* standardize database_configuration to a hashTerence Lee2013-02-211-2/+2
| | | | | | | make connection_url_to_hash a class method This als prevents loading database.yml if it doesn't exist but DATABASE_URL does
* descriptive error message when AR adapter was not found. Closes #7313.Yves Senn2013-02-201-2/+5
|
* Gist URLs are now namespacedAkira Matsuda2013-02-181-4/+4
| | | | see: https://github.com/blog/1406-namespaced-gists
* copy-edits RDoc in fba496fXavier Noria2013-02-161-4/+4
| | | | | | | This revision makes the terminology uniform with the rest of the file. In general we describe these methods in terms of the adapter, rather than the database. (As a side note, if we wanted to refer to the database we would write "PostgreSQL".)
* Remove valid_type? methodJon Leighton2013-02-154-17/+0
| | | | | It was supposed to be removed by the preceding two reversions but I did them in the wrong order.
* Revert "Make valid_type? public"Jon Leighton2013-02-154-12/+17
| | | | | | This reverts commit 5d528f835e871f5f9d4b68e8a81cfbe900b7e718. Relates to f8c8ad5 which is also getting reverted due to failing test.
* Revert "Revert "Merge pull request #9206 from ranjaykrishna/use_define_method""Jon Leighton2013-02-151-18/+13
| | | | | | This reverts commit 8aa4603a5adaa56c818a7bd1c0b761b4ecca3d3e. Reverting the revert because I reverted the wrong thing! Fail.
* Revert "Merge pull request #9206 from ranjaykrishna/use_define_method"Jon Leighton2013-02-151-13/+18
| | | | | | | | | | | | | This reverts commit 1fc6876b57f2e1d31731e74eb4271b5655e746d2, reversing changes made to 0268b5d8cdc3c5a1337462135f0a326a2654ba1a. Reason: failing test 1) Error: test_valid_column(ActiveRecord::ConnectionAdapters::SQLite3AdapterTest): NoMethodError: undefined method `column' for test/cases/adapters/sqlite3/sqlite3_adapter_test.rb:29:in `test_valid_column'
* Make valid_type? publicSam Ruby2013-02-144-17/+12
|
* 9253: Before writing a numeric attribute value, ActiveRecord does an implicitRyan Warnick2013-02-131-4/+5
| | | | | | conversion of boolean types (true => 1 and false => 0). If the numeric value being assigned is a BigDecimal, then ActiveRecord compares a BigDecimal to true and false. This is known to be very slow in Ruby 1.9.3.
* Merge pull request #9204 from ranjaykrishna/col-probAaron Patterson2013-02-124-0/+15
|\ | | | | schema dumper tests now conducted by ActiveRecord::Base.Connection
| * checking in the abstractions for valid type checking:Ranjay Krishna2013-02-124-0/+15
| |
* | Merge pull request #9206 from ranjaykrishna/use_define_methodCarlos Antonio da Silva2013-02-121-18/+13
|\ \ | | | | | | Use define method instead of class_eval
| * | reverted back our changes and added in the new define_methodRanjay Krishna2013-02-121-18/+13
| |/
* | active_record: Quote numeric values compared to string columns.Dylan Smith2013-02-072-4/+8
| |
* | Call super to use the abstract adapter implementation insteadCarlos Antonio da Silva2013-02-061-1/+1
| |
* | Add changelog entry for #9203 about schema dumper with db extensionsCarlos Antonio da Silva2013-02-061-2/+2
| | | | | | | | [ci skip]
* | add ActiveRecord::AbstractAdapter#extensions and ↵Justin George2013-02-062-0/+15
| | | | | | | | ActiveRecord::ConnectionAdapters::PostgreSQLAdapter#extensions to allow dumping of enabled extensions to schema.rb, add ActiveRecord::SchemaDumper#extensions to dump extensions to schema.rb
* | Fix typo :bomb:Rafael Mendonça França2013-01-311-1/+1
| |
* | Fix typoRafael Mendonça França2013-01-311-2/+2
| |
* | Strict regexpRafael Mendonça França2013-01-311-2/+2
| |
* | Extract the value casting to a methodRafael Mendonça França2013-01-311-15/+23
| |
* | DATABASE_URL parsing should turn numeric strings into numeric types, andAaron Stone2013-01-311-0/+19
| | | | | | | | | | | | the strings true and false into boolean types, in order to match how YAML would parse the same values from database.yml and prevent unexpected type errors in the database adapters.
* | reloading type map on extension changingAaron Patterson2013-01-292-2/+15
| |
* | fixing commentAaron Patterson2013-01-291-1/+1
| |
* | Fix typoRafael Mendonça França2013-01-291-1/+1
| |
* | Only search for enabled extension if the PostgreSQL version supportsRafael Mendonça França2013-01-291-3/+5
| | | | | | | | extensions
* | add API to pg for enabling / disabling hstoreAaron Patterson2013-01-282-0/+25
| |
* | updates a dynamic method heredoc docXavier Noria2013-01-281-2/+2
| |
* | explains why the query cache checks arel.lockedXavier Noria2013-01-281-0/+2
| |
* | Fix typo: adaptors => adapters [ci skip]Carlos Antonio da Silva2013-01-271-1/+1
| |
* | Fix cases where delete_records on a has_many association caused errorsDerek Kraan2013-01-273-0/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | because of an ambiguous column name. This happened if the association model had a default scope that referenced a third table, and the third table also referenced the original table (with an identical foreign_key). Mysql requires that ambiguous columns are deambiguated by using the full table.column syntax. Postgresql and Sqlite use a different syntax for updates altogether (and don't tolerate table.name syntax), so the fix requires always including the full table.column and discarding it later for Sqlite and Postgresql.
* | Default dead_connection_timeout to 5Akira Matsuda2013-01-241-1/+1
| | | | | | | | or the ConnectionPool silently fails to close connections inside the Thread
* | Fix PostgreSQL tests on TravisAndrew White2013-01-241-0/+5
| | | | | | | | Travis only has PostgreSQL 9.1.x but 9.2 is required for range datatypes.
* | Add postgresql range types supportbUg2013-01-237-71/+117
| |
* | Refactored transaction state into its own object. Each transaction creates a ↵wangjohn2013-01-211-5/+24
|/ | | | new transaction state object upon initialization.
* Created state for a transaction and added tests.wangjohn2013-01-201-0/+12
|
* fix anonymous class issueDavid2013-01-201-0/+1
|
* Don't rely on Hash key's orderingVitor Baptista2013-01-162-3/+5
| | | | | | | | | | | | | | | | | | | If we set encoding latin1 for a PostgreSQL database, it calls PostgreSQLAdapter::create_database with options that have, among other things: { 'encoding' => 'latin1' } Then, we use reverse_merge(:encoding => "utf8") to setup the default encoding. In the end, the hash looks like: { :encoding => 'utf8', 'encoding' => 'latin1' } The call to options.symbolize_keys calls to_sym on each_key of this Hash. It usually means that the encoding passed overwrites the default utf8, but it's not guaranteed. So, we shouldn't rely on it. The same was happening in ActiveRecord::ConnectionHandling.
* Use whitelist to pass valid connection parameters to PGConn.Rafael Mendonça França2013-01-061-7/+10
| | | | | | | | | All the valids parameters for libpq are used. See http://www.postgresql.org/docs/9.1/static/libpq-connect.html for the full list Fixes #8784
* Remove the configuration key in the correct placeRafael Mendonça França2013-01-061-3/+1
|
* Fix error when assigning NaN to an integer columnTristan Harward2013-01-061-5/+1
| | | | | | | | | Also covers any non-castable case by returning nil, which is in-line with the intention of the former implementation, but covers the odd cases which respond to to_i but raise an error when it's called, such as NaN, Infinity and -Infinity. Fixes #8757
* These are already required through AS/railsAkira Matsuda2013-01-073-4/+0
| | | | | | * dependencies/autoload * concern * deprecation
* Remove unnecessary begin..rescue..end, use only rescueAkira Matsuda2013-01-061-25/+23
|