| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
Many of the methods defined in `AttributeMethods::Serialization` can be
refactored onto this type as well, but this is a reasonable small step.
Removes the `Type` class, and the need for `decorate_columns` to handle
serialized types.
|
| |
| |
| |
| |
| |
| | |
- Create a consistent API across adapters for building new columns
- Use it for custom properties so we don't get `UndefinedMethodError`s
in stuff I'm implementing elsewhere.
|
| | |
|
|\ \
| | |
| | | |
Move types to the top level `ActiveRecord` namespace
|
| | |
| | |
| | |
| | |
| | | |
`ActiveRecord::ConnectionAdapters::Type::Value` =>
`ActiveRecord::Type::Value`
|
|\ \ \
| | | |
| | | | |
Remove unused `Column#coder`
|
| |/ /
| | |
| | |
| | |
| | | |
It appears this property was added, but never actually used. It would be
broken if it were, as it only type casts one way.
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The solution presented in this patch is not efficient. We should replace it
in the near future. The following needs to be worked out:
* Is `@attributes` storing the Ruby or SQL representation?
* `cacheable_column?` is broken but `hstore` and `json` rely on that behavior
Refs #15369.
/cc @sgrif @rafaelfranca
|
| |
| |
| |
| |
| | |
Making this part of the public API was premature, let's make it private
again while I continue to work on the surrounding code.
|
|\ \
| | |
| | | |
Deprecate decimal columns being automatically treated as integers
|
| | |
| | |
| | |
| | |
| | |
| | | |
With ActiveRecord::Properties, we now have a reasonable path for users
to continue to keep this behavior if they want it. This is an edge case
that has added a lot of complexity to the code base.
|
|\ \ \
| | | |
| | | | |
remove unwanted `to_sym` call.
|
| | | | |
|
|\ \ \ \
| |_|/ /
|/| | | |
Remove unnecessary branch from quoting in Mysql
|
| | | |
| | | |
| | | |
| | | | |
This is already the behavior for `BigDecimal` in the abstract adapter.
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
As a result of all of the refactoring that's been done, it's now
possible for us to define a public API to allow users to specify
behavior. This is an initial implementation so that I can work off of it
in smaller pieces for additional features/refactorings.
The current behavior will continue to stay the same, though I'd like to
refactor towards the automatic schema detection being built off of this
API, and add the ability to opt out of automatic schema detection.
Use cases:
- We can deprecate a lot of the edge cases around types, now that there
is an alternate path for users who wish to maintain the same behavior.
- I intend to refactor serialized columns to be built on top of this
API.
- Gem and library maintainers are able to interact with `ActiveRecord`
at a slightly lower level in a more stable way.
- Interesting ability to reverse the work flow of adding to the schema.
Model can become the single source of truth for the structure. We can
compare that to what the database says the schema is, diff them, and
generate a migration.
|
| | |
| | |
| | |
| | |
| | | |
Database specific adapters shouldn't need to override `type_cast` to
define types which are already in an acceptable state.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
The intention is to eventually remove `column` from the arguments list
both for `quote` and for `type_cast` entirely. This is the first step
to that end.
|
|\ \ \
| | | |
| | | | |
Add an interface for type objects to control Ruby => SQL
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Adds the ability to save custom types, which type cast to non-primitive
ruby objects.
|
| | | | |
|
| |/ /
|/| | |
|
| | | |
|
|/ /
| |
| |
| |
| |
| |
| | |
This mirrors the layout of abstract adapter and puts the definitions
inside the `PostgreSQL` namespace (no longer under the adapter namespace).
/cc @kares
|
| | |
|
|\ \
| | |
| | | |
Simplify the code in schema cache
|
| | |
| | |
| | |
| | |
| | | |
The use of default procs was unnessecary, made the code confusing to
follow, and made marshalling needlessly complex.
|
|\ \ \
| | | |
| | | | |
Remove `Column#primary`
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
It appears to have been used at some point in the past, but is no longer
used in any meaningful way. Whether a column is considered primary is
a property of the model, not the schema/column. This also removes the
need for yet another layer of caching of the model's schema, and we can
leave that to the schema cache.
|
|\ \ \
| | | |
| | | | |
Move parsing of PG sql strings for defaults out of column
|
| |/ / |
|
|/ / |
|
| |
| |
| |
| |
| | |
Columns and injected types no longer have any conditionals based on the
format of SQL type strings! Hooray!
|
| | |
|
| |
| |
| |
| |
| |
| | |
Ideally types will be usable without having to specify a sql type
string, so we should keep the information related to parsing them on the
adapter or another object.
|
| | |
|
|\ \
| | |
| | | |
Use the generic type map for all PG type registrations
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We're going to want all of the benefits of the type map object for
registrations, including block registration and real aliasing. Moves
type name registrations to the adapter, and aliases the OIDs to the
named types
|
|/ /
| |
| |
| |
| |
| |
| |
| | |
Determining things like precision and scale in postgresql will require
the given blocks to take additional arguments besides the OID.
- Adds the ability to handle additional arguments to `TypeMap`
- Passes the column type to blocks when looking up PG types
|
|\ \
| | |
| | | |
Move extract_scale to decimal type
|
| | |
| | |
| | |
| | |
| | |
| | | |
The only type that has a scale is decimal. There's a special case where
decimal columns with 0 scale are type cast to integers if the scale is
not specified. Appears to only affect schema dumping.
|
|\ \ \
| | | |
| | | | |
Move PG OID types to their own files
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
As we promote these classes to first class concepts, these classes are
starting to gain enough behavior to warrant being moved into their own
files. Many of them will become quite large as we move additional
behavior to the type objects.
|
| |/ /
|/| | |
|
|/ / |
|
| |
| |
| |
| |
| |
| |
| | |
- `extract_precision`, `extract_limit`, and `extract_default` probably need to follow.
- would be good to remove the delegation `Column#extract_scale`.
/cc @sgrif
|
| | |
|