| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
| |
| |
| |
| |
| |
| |
| | |
p PostgreSQLAdapter::OID::Money.precision
# => 19
p PostgreSQLAdapter::OID::Money.new.precision
# => nil
|
| |
| |
| |
| |
| |
| |
| | |
This reverts commit ff835f90800a3e4122d64606cb328908c2e0e071, reversing
changes made to c4d85dfbc71043e2a746acd310e32f4f04db801a.
Reason: This broke the tests. We will add back after investigated.
|
|\ \
| | |
| | |
| | |
| | | |
yui-knk/warning_when_composite_primary_key_is_detected
Warn if `AR.primary_key` is called for a table who has composite prim…
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If `AR.primary_key` is called for a table who has composite primary key,
the method returns `nil`. This behavior sometimes generates invalid SQL.
The first time developers notice to invalid SQL is when they execute
SQL. This commit enables developers to know they are doing something
dangerous as soon as possible.
|
|\ \ \
| | | |
| | | | |
Refactor `column_exists?` in `SchemaStatements`
|
| |/ / |
|
|\ \ \
| | | |
| | | | |
Fix `bigint?` for Enum columns in MySQL
|
| |/ /
| | |
| | |
| | | |
Follow up to #22896.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
kamipo/remove_unused_lost_connection_error_messages
Remove unused `LOST_CONNECTION_ERROR_MESSAGES`
|
| |/ /
| | |
| | |
| | |
| | | |
`LOST_CONNECTION_ERROR_MESSAGES` was added by f384582.
But currently unused from anywhere.
|
|\ \ \
| | | |
| | | | |
Explicitly define `columns` method as an interface
|
| |/ /
| | |
| | |
| | |
| | |
| | | |
`ActiveRecord::ConnectionAdapters::SchemaStatements#columns` is defined
here as an interface method here. So changes to raise `NotImplementedError`
same as `tables`, `views` ...etc.
|
|/ / |
|
|\ \
| | |
| | | |
Remove `limit: 11` as backward-compatibility with Rails 2.0
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Integer limit as a byte size was introduced from Rails 2.1.
`limit: 11` is not a byte size, but take care for backward-compatibility
with Rails 2.0 (a892af6). Integer limit out of range should be allowed
to raise by #6349. I think we should remove this backward-compatibility.
|
|\ \ \
| | | |
| | | | |
Clarify DatabaseStatements#execute docs re: memory usage.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This line causes an error when executing the command: `rails db:drop db:create db:schema:load`
ActiveRecord::StatementInvalid: PG::SyntaxError: ERROR: syntax error at or near "{"
LINE 1: ...NSERT INTO "schema_migrations" (version) VALUES (#{v}), (#{v...
|
| |/ /
|/| |
| | |
| | |
| | |
| | |
| | | |
We found that inserting all 600 schema_migrations for our mid-sized app takes about a minute on a cloud based CI environment.
I assume that the original code did not use multi-row-insert because SQLite3 was not supporting the syntax back then,
but it's been supported since 3.7.11: http://www.sqlite.org/releaselog/3_7_11.html
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- Using `references` or `belongs_to` in migrations will always add index
for the referenced column by default, without adding `index:true` option
to generated migration file.
- Users can opt out of this by passing `index: false`.
- Legacy migrations won't be affected by this change. They will continue
to run as they were before.
- Fixes #18146
|
|\ \
| | |
| | | |
Add `:expression` option support on the schema default
|
| | | |
|
| | |
| | |
| | |
| | | |
The default 'now'::date is CURRENT_DATE.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Example:
create_table :posts do |t|
t.datetime :published_at, default: -> { 'NOW()' }
end
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
kamipo/sql_for_insert_returns_values_for_passing_to_exec_insert
`sql_for_insert` returns values for passing to `exec_insert`
|
| | | | |
|
|/ / /
| | |
| | |
| | | |
These methods are private and unused from anywhere.
|
|/ /
| |
| |
| | |
Arel handles substitution for bind parameters by now.
|
| |
| |
| |
| | |
Closes #22584.
|
| |
| |
| |
| | |
`connection_adapters/mysql/type_metadata.rb`
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is an alternate implementation to #22875, that generalizes a lot of
the logic that type decorators are going to need, in order to have them
work with arrays, ranges, etc. The types have the ability to map over a
value, with the default implementation being to just yield that given
value. Array and Range give more appropriate definitions.
This does not automatically make ranges time zone aware, as they need to
be added to the `time_zone_aware` types config, but we could certainly
make that change if we feel it is appropriate. I do think this would be
a breaking change however, and should at least have a deprecation cycle.
Closes #22875.
/cc @matthewd
|
|\ \
| | |
| | | |
Prevent destructive action on production database
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This PR introduces a key/value type store to Active Record that can be used for storing internal values. It is an alternative implementation to #21237 cc @sgrif @matthewd.
It is possible to run your tests against your production database by accident right now. While infrequently, but as an anecdotal data point, Heroku receives a non-trivial number of requests for a database restore due to this happening. In these cases the loss can be large.
To prevent against running tests against production we can store the "environment" version that was used when migrating the database in a new internal table. Before executing tests we can see if the database is a listed in `protected_environments` and abort. There is a manual escape valve to force this check from happening with environment variable `DISABLE_DATABASE_ENVIRONMENT_CHECK=1`.
|
|\ \ \
| | | |
| | | | |
Fix `select_values` method signature for consistency
|
| | | | |
|
|/ / /
| | |
| | |
| | | |
Simply `{update|delete}_sql` aliases to `{update|delete}`.
|
| | |
| | |
| | |
| | |
| | | |
`sql += " WHERE 1=1"` was introduced in 69cb942.
But it is not needed. ref https://www.sqlite.org/lang_delete.html
|
| | |
| | |
| | |
| | | |
`connection.insert_sql` is almost the same as `connection.insert`.
|
|\ \ \
| | | |
| | | | |
Autoload ReferenceDefinition class in abstract adapter so that it can be used by #add_reference in schema_statements
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
used by #add_reference in schema_statements
- Fixes #22916.
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
Add short-hand methods for text and blob types in MySQL
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In Pg and Sqlite3, `:text` and `:binary` have variable unlimited length.
But in MySQL, these have limited length for each types (ref #21591, #21619).
This change adds short-hand methods for each text and blob types.
Example:
create_table :foos do |t|
t.tinyblob :tiny_blob
t.mediumblob :medium_blob
t.longblob :long_blob
t.tinytext :tiny_text
t.mediumtext :medium_text
t.longtext :long_text
end
|
|\ \ \ \
| |/ / /
|/| | | |
Fix `connection#create` in PG adapter
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Originally `connection#create` had aliased to `connection#insert` in PG
adapter. But it was broken by #7447. Re-alias `create` to `insert` for
fixing it.
|
|\ \ \ \
| |/ / /
|/| | | |
Fix `unsigned?` and `blob_or_text_column` for Enum columns in MySQL
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | | |
Allow add_to_transaction with null transaction
|
| | | |
| | | |
| | | |
| | | | |
Fixes https://github.com/rails/rails/issues/22819
|