| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Respect limit for PG bit strings
|
| | |
|
|\ \
| |/
|/| |
Refactor determination of whether the field has changed
|
| |
| |
| |
| |
| | |
The types know more about what is going on than the dirty module. Let's
ask them!
|
|/ |
|
| |
|
|
|
|
|
|
|
|
| |
This inlines casting for the most obvious types. The rest will
follow eventually. I need to put some tests in place, to make sure
that the inlining is not causing regressions.
/cc @sgrif
|
|
|
|
|
|
|
|
|
|
|
| |
Nearly completely implemented in terms of custom properties.
`_before_type_cast` now stores the raw serialized string consistently,
which removes the need to keep track of "state". The following is now
consistently true:
- `model.serialized == model.reload.serialized`
- A model can be dumped and loaded infinitely without changing
- A model can be saved and reloaded infinitely without changing
|
|
|
|
|
|
|
| |
This removes the case statement in `SchemaDumper` and gives every `Type`
the possibility to control the SchemaDumper default value output.
/cc @sgrif
|
|
|
|
|
| |
This is an intermediate solution. It is related to the refactoring @sgrif
is making and will change in the future.
|
| |
|
|\
| |
| |
| |
| |
| |
| | |
Fixed #columns_for_distinct of postgresql adapter
Conflicts:
activerecord/CHANGELOG.md
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
Many of the methods defined in `AttributeMethods::Serialization` can be
refactored onto this type as well, but this is a reasonable small step.
Removes the `Type` class, and the need for `decorate_columns` to handle
serialized types.
|
| |
| |
| |
| |
| |
| | |
- Create a consistent API across adapters for building new columns
- Use it for custom properties so we don't get `UndefinedMethodError`s
in stuff I'm implementing elsewhere.
|
| | |
|
|\ \
| | |
| | | |
Move types to the top level `ActiveRecord` namespace
|
| | |
| | |
| | |
| | |
| | | |
`ActiveRecord::ConnectionAdapters::Type::Value` =>
`ActiveRecord::Type::Value`
|
|\ \ \
| | | |
| | | | |
Remove unused `Column#coder`
|
| |/ /
| | |
| | |
| | |
| | | |
It appears this property was added, but never actually used. It would be
broken if it were, as it only type casts one way.
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The solution presented in this patch is not efficient. We should replace it
in the near future. The following needs to be worked out:
* Is `@attributes` storing the Ruby or SQL representation?
* `cacheable_column?` is broken but `hstore` and `json` rely on that behavior
Refs #15369.
/cc @sgrif @rafaelfranca
|
| |
| |
| |
| |
| | |
Making this part of the public API was premature, let's make it private
again while I continue to work on the surrounding code.
|
|\ \
| | |
| | | |
Deprecate decimal columns being automatically treated as integers
|
| | |
| | |
| | |
| | |
| | |
| | | |
With ActiveRecord::Properties, we now have a reasonable path for users
to continue to keep this behavior if they want it. This is an edge case
that has added a lot of complexity to the code base.
|
|\ \ \
| | | |
| | | | |
remove unwanted `to_sym` call.
|
| | | | |
|
|\ \ \ \
| |_|/ /
|/| | | |
Remove unnecessary branch from quoting in Mysql
|
| | | |
| | | |
| | | |
| | | | |
This is already the behavior for `BigDecimal` in the abstract adapter.
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
As a result of all of the refactoring that's been done, it's now
possible for us to define a public API to allow users to specify
behavior. This is an initial implementation so that I can work off of it
in smaller pieces for additional features/refactorings.
The current behavior will continue to stay the same, though I'd like to
refactor towards the automatic schema detection being built off of this
API, and add the ability to opt out of automatic schema detection.
Use cases:
- We can deprecate a lot of the edge cases around types, now that there
is an alternate path for users who wish to maintain the same behavior.
- I intend to refactor serialized columns to be built on top of this
API.
- Gem and library maintainers are able to interact with `ActiveRecord`
at a slightly lower level in a more stable way.
- Interesting ability to reverse the work flow of adding to the schema.
Model can become the single source of truth for the structure. We can
compare that to what the database says the schema is, diff them, and
generate a migration.
|
| | |
| | |
| | |
| | |
| | | |
Database specific adapters shouldn't need to override `type_cast` to
define types which are already in an acceptable state.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
The intention is to eventually remove `column` from the arguments list
both for `quote` and for `type_cast` entirely. This is the first step
to that end.
|
|\ \ \
| | | |
| | | | |
Add an interface for type objects to control Ruby => SQL
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Adds the ability to save custom types, which type cast to non-primitive
ruby objects.
|
| | | | |
|
| |/ /
|/| | |
|
| | | |
|
|/ /
| |
| |
| |
| |
| |
| | |
This mirrors the layout of abstract adapter and puts the definitions
inside the `PostgreSQL` namespace (no longer under the adapter namespace).
/cc @kares
|
| | |
|
|\ \
| | |
| | | |
Simplify the code in schema cache
|
| | |
| | |
| | |
| | |
| | | |
The use of default procs was unnessecary, made the code confusing to
follow, and made marshalling needlessly complex.
|
|\ \ \
| | | |
| | | | |
Remove `Column#primary`
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
It appears to have been used at some point in the past, but is no longer
used in any meaningful way. Whether a column is considered primary is
a property of the model, not the schema/column. This also removes the
need for yet another layer of caching of the model's schema, and we can
leave that to the schema cache.
|
|\ \ \
| | | |
| | | | |
Move parsing of PG sql strings for defaults out of column
|
| |/ / |
|
|/ / |
|
| |
| |
| |
| |
| | |
Columns and injected types no longer have any conditionals based on the
format of SQL type strings! Hooray!
|