Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #5437 from kennyj/fix_5430 | Aaron Patterson | 2012-03-15 | 1 | -1/+1 |
| | | | | Fix GH #5430. A Payload name for schema_search_path should be SCHEMA. | ||||
* | ConnectionPool.checkout takes account of ruby using 'non-blocking condition ↵ | Jonathan Rochkind | 2012-03-13 | 1 | -9/+18 |
| | | | | variables' in mutex ConditionVariables | ||||
* | make sure connections returned after close are marked as in_use | Aaron Patterson | 2012-03-12 | 1 | -0/+16 |
| | |||||
* | inline docs for clear_active_connections! no longer says it cleans dead ↵ | Jonathan Rochkind | 2012-03-12 | 1 | -3/+1 |
| | | | | threads, it doesn't since 3.2.0 | ||||
* | make active_connection? return true only if there is an open connection in ↵ | Aaron Patterson | 2012-03-08 | 1 | -3/+4 |
| | | | | use for the current thread. fixes #5330 | ||||
* | only log an error if there is a logger. fixes #5226 | Aaron Patterson | 2012-03-02 | 2 | -2/+2 |
| | | | | | | Conflicts: activerecord/lib/active_record/connection_adapters/sqlite_adapter.rb | ||||
* | revert setting NOT NULL constraints in add_timestamps | Xavier Noria | 2012-03-01 | 1 | -2/+2 |
| | | | | | | | | | | | Commit 3dbedd2 added NOT NULL constraints both to table creation and modification. For creation the new default makes sense, but the generic situation for changing a table is that there exist records. Those records have no creation or modification timestamps, and in the general case you don't even know them, so when updating a table these constraints are not going to work. See a bug report for this use case in #3334. | ||||
* | Fix type_to_sql with text and limit on mysql/mysql2. Fix GH #3931. | kennyj | 2012-02-29 | 1 | -9/+20 |
| | |||||
* | Revert "No need to pass options which is never used" | Rafael Mendonça França | 2012-02-26 | 1 | -2/+2 |
| | | | | | | | | | Options is needed for some Rails extensions to determine when referential integrity should be disabled This reverts commit bcb466c543451dce69403aaae047295758589d8e. Fixes #5052 | ||||
* | prepared statements can be disabled | Aaron Patterson | 2012-02-21 | 6 | -28/+53 |
| | |||||
* | tag bind params with a bind param object | Aaron Patterson | 2012-02-21 | 3 | -3/+3 |
| | |||||
* | more ruby 2.0 respond_to? changes | Aaron Patterson | 2012-02-21 | 1 | -1/+1 |
| | |||||
* | Merge pull request #5096 from lawso017/master | Aaron Patterson | 2012-02-21 | 1 | -16/+36 |
| | | | | Restoring ability to derive id/sequence from tables with nonstandard sequences for primary keys | ||||
* | Handle nil in add_index :length option in MySQL | Paul Sadauskas | 2012-02-08 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | Our schema.rb is being generated with an `add_index` line similar to this: add_index "foo", ["foo", "bar"], :name => "xxx", :length => {"foo"=>8, "bar=>nil} This is the same as it was on Rails 3.1.3, however, now when that schema.rb is evaluated, its generating bad SQL in MySQL: Mysql::Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '))' at line 1: CREATE UNIQUE INDEX `xxx` ON `foo` (`foo`(8), `bar`()) This commit adds a check for nil on the length attribute to prevent the empty parens from being output. Conflicts: activerecord/test/cases/migration/index_test.rb Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Fix Issue #4819 | densya203 | 2012-02-04 | 1 | -1/+1 |
| | | | | | | 'uninitialized constant ActiveRecord::Deprecation in Rails3.2.1' Just a typo of 'ActiveSupport::...' | ||||
* | Merge pull request #4809 from cfeist/feist-sqlite-binary-corruption | Aaron Patterson | 2012-02-02 | 1 | -16/+1 |
| | | | | Fix for SQLite binary data corrupter (to master branch) | ||||
* | Merge pull request #4763 from kennyj/fix_4754 | Jon Leighton | 2012-01-31 | 1 | -1/+1 |
| | | | | [MySQL] Fix GH #4754. Remove double-quote characters around PK when using sql_mode=ANSI_QUOTES | ||||
* | query cache instrumentation should included the bindings in the payload ↵ | Xavier Noria | 2012-01-30 | 1 | -1/+1 |
| | | | | [closes #4750] | ||||
* | on and ON are type casted to a true boolean column | Santiago Pastorino | 2012-01-11 | 1 | -2/+2 |
| | |||||
* | Document that index names are made up of all columns, not just the first. | Jo Liss | 2011-12-29 | 1 | -9/+2 |
| | | | | | | | | | | | index_name has been using the following expression "index_#{table_name}_on_#{Array.wrap(options[:column]) * '_and_'}" since at least 2006 (bc7f2315), and that's how they come out in my DB. Please check that this is correct before merging into master, perhaps I'm misunderstanding the section I changed. | ||||
* | Should clear the primary keys cache also | Jon Leighton | 2011-12-16 | 1 | -0/+1 |
| | |||||
* | Don't store defaults in the schema cache | Jon Leighton | 2011-12-16 | 1 | -3/+2 |
| | |||||
* | Defaults hash can go on the model | Jon Leighton | 2011-12-16 | 1 | -14/+1 |
| | |||||
* | Cache columns at the model level. | Jon Leighton | 2011-12-16 | 1 | -9/+2 |
| | | | | Allows two models to use the same table but have different primary keys. | ||||
* | Revert naive O(1) table_exists? implementation. | Jon Leighton | 2011-12-13 | 3 | -12/+15 |
| | | | | | | | | | | It was a bad idea to rescue exceptions here. This can interfere with transaction rollbacks which seems to be the cause of current CI failure. Instead, each adapter should implement its own DB-specific O(1) implementation, and we fall back on the generic, slower, implementation otherwise. | ||||
* | Use `table_exists?` from the schema cache. | Aaron Patterson | 2011-12-09 | 1 | -4/+2 |
| | |||||
* | don't need a begin / end. | Aaron Patterson | 2011-12-09 | 1 | -6/+4 |
| | |||||
* | squelch table exists? queries. | Aaron Patterson | 2011-12-09 | 1 | -1/+1 |
| | |||||
* | Exceptions should read from the spec configu | Aaron Patterson | 2011-12-08 | 1 | -1/+1 |
| | |||||
* | fix nodocs | Vijay Dev | 2011-12-09 | 1 | -3/+3 |
| | |||||
* | fix comments | Vijay Dev | 2011-12-09 | 1 | -4/+2 |
| | |||||
* | Use a hash to look up column definitions | Aaron Patterson | 2011-12-07 | 1 | -2/+3 |
| | |||||
* | try to normalize the objects passed to column() | Aaron Patterson | 2011-12-07 | 1 | -9/+11 |
| | |||||
* | automatically add the column definition to the columns list if creating a ↵ | Aaron Patterson | 2011-12-07 | 1 | -12/+21 |
| | | | | new one | ||||
* | stop calling String#to_s so frequently | Aaron Patterson | 2011-12-07 | 1 | -3/+4 |
| | |||||
* | the required sqlite3 adapter responds to encoding, so stop checking. | Aaron Patterson | 2011-12-07 | 1 | -5/+1 |
| | |||||
* | Quitoting the table name before querying. | Aaron Patterson | 2011-12-05 | 1 | -1/+1 |
| | |||||
* | Speed up table_exists? for databases with a large number of tables | Jade Rubick | 2011-12-05 | 1 | -1/+6 |
| | | | | | | At New Relic, we have hundreds of thousands of tables, and our migrations took 30 minutes without this similar patch. This cuts it down to a more reasonable amount of time. The rescue false part is ugly, but necessary as far as I can tell. I don't know of a cross-database statement you can make that will work without trapping errors. | ||||
* | SQlite3 Bump | Arun Agrawal | 2011-12-04 | 1 | -1/+1 |
| | |||||
* | Use show create table. | kennyj | 2011-12-03 | 1 | -3/+8 |
| | |||||
* | implements automatic EXPLAIN logging for slow queries | Xavier Noria | 2011-12-02 | 5 | -78/+98 |
| | |||||
* | push synchronization in to each method. Reduces method calls and makes | Aaron Patterson | 2011-11-29 | 1 | -25/+29 |
| | | | | it clear which methods are synchronized. | ||||
* | Automatic closure of connections in threads is deprecated. For example | Aaron Patterson | 2011-11-29 | 1 | -1/+7 |
| | | | | | | | | | | | | | | | | | the following code is deprecated: Thread.new { Post.find(1) }.join It should be changed to close the database connection at the end of the thread: Thread.new { Post.find(1) Post.connection.close }.join Only people who spawn threads in their application code need to worry about this change. | ||||
* | AbstractAdapter#close can be called to add the connection back to the | Aaron Patterson | 2011-11-29 | 2 | -11/+19 |
| | | | | pool. | ||||
* | Start implementing @reserved_connections in terms of connection leases. | Aaron Patterson | 2011-11-29 | 1 | -3/+3 |
| | |||||
* | Rename `checked_out` to more descriptive `active_connections` | Aaron Patterson | 2011-11-29 | 1 | -3/+3 |
| | |||||
* | Use connection lease to determine "checked_out" connections | Aaron Patterson | 2011-11-29 | 1 | -17/+21 |
| | |||||
* | expire will set in_use to false | Aaron Patterson | 2011-11-29 | 1 | -0/+5 |
| | |||||
* | Leased connections return false on second lease | Aaron Patterson | 2011-11-29 | 1 | -2/+4 |
| | |||||
* | Adapters keep in_use flag when leased | Aaron Patterson | 2011-11-29 | 1 | -1/+14 |
| |