Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | added comments to test_invalid_type in sqlite3 adapter test and added ↵ | Ranjay Krishna | 2013-03-28 | 1 | -4/+0 |
| | | | | valid_type? method to abstract_adapter.rb and removed unnecessary method from sqlite3 adapter | ||||
* | Created a layer of abstraction for the valid type checking in schema dumper. ↵ | Ranjay Krishna | 2013-03-25 | 1 | -0/+4 |
| | | | | Now, connection handles the check for valid types so that each database can handle the changes individually. | ||||
* | keep ivars private, do not manipulate them outside their owner object | Aaron Patterson | 2013-03-22 | 1 | -1/+1 |
| | |||||
* | Pass column to quote when copying a sqlite table. | Matthew M. Boedicker | 2013-03-11 | 1 | -1/+9 |
| | | | | To make quote escape binary data correctly it needs the column passed in. | ||||
* | Unprepared Visitor + unprepared_statement | Cédric FABIANSKI | 2013-03-08 | 1 | -1/+1 |
| | |||||
* | Do not type cast all the database url values. | Rafael Mendonça França | 2013-02-24 | 1 | -3/+3 |
| | | | | | | We should only type cast when we need to use. Related to 4b005fb371c2e7af80df7da63be94509b1db038c | ||||
* | also rename indexes when a table or column is renamed | Yves Senn | 2013-02-20 | 1 | -2/+4 |
| | | | | When a table or a column is renamed related indexes kept their name. This will lead to confusing names. This patch renames related indexes when a column or a table is renamed. Only indexes with names generated by rails will be renamed. Indexes with custom names will not be renamed. | ||||
* | reserve less chars for internal sqlite3 operations | Yves Senn | 2013-02-20 | 1 | -7/+7 |
| | |||||
* | reserve index name chars for internal rails operations | Yves Senn | 2013-02-20 | 1 | -1/+8 |
| | | | | | | | | | | | Some adapter (SQLite3) need to perform renaming operations to support the rails DDL. These rename prefixes operate with prefixes. When an index name already uses up the full space provieded by `index_name_length` these internal operations will fail. This patch introduces `allowed_index_name_length` which respects the amount of characters used for internal operations. It will always be <= `index_name_length` and every adapter can define how many characters need to be reserved. | ||||
* | Remove valid_type? method | Jon Leighton | 2013-02-15 | 1 | -5/+0 |
| | | | | | It was supposed to be removed by the preceding two reversions but I did them in the wrong order. | ||||
* | Revert "Make valid_type? public" | Jon Leighton | 2013-02-15 | 1 | -0/+5 |
| | | | | | | This reverts commit 5d528f835e871f5f9d4b68e8a81cfbe900b7e718. Relates to f8c8ad5 which is also getting reverted due to failing test. | ||||
* | Make valid_type? public | Sam Ruby | 2013-02-14 | 1 | -5/+0 |
| | |||||
* | Merge pull request #9204 from ranjaykrishna/col-prob | Aaron Patterson | 2013-02-12 | 1 | -0/+4 |
|\ | | | | | schema dumper tests now conducted by ActiveRecord::Base.Connection | ||||
| * | checking in the abstractions for valid type checking: | Ranjay Krishna | 2013-02-12 | 1 | -0/+4 |
| | | |||||
* | | Fix cases where delete_records on a has_many association caused errors | Derek Kraan | 2013-01-27 | 1 | -0/+4 |
|/ | | | | | | | | | | | | | because of an ambiguous column name. This happened if the association model had a default scope that referenced a third table, and the third table also referenced the original table (with an identical foreign_key). Mysql requires that ambiguous columns are deambiguated by using the full table.column syntax. Postgresql and Sqlite use a different syntax for updates altogether (and don't tolerate table.name syntax), so the fix requires always including the full table.column and discarding it later for Sqlite and Postgresql. | ||||
* | Differentiate between remove_column and remove_columns. Make remove_column ↵ | Marc-Andre Lafortune | 2012-12-21 | 1 | -7/+3 |
| | | | | | | reversible. [#8267] | ||||
* | Keep index names when using with sqlite3 | Yves Senn | 2012-12-19 | 1 | -2/+1 |
| | |||||
* | SQLite3Adapter#type_cast should not mutate arguments | Stefan Rusterholz | 2012-10-28 | 1 | -1/+1 |
| | |||||
* | refactor `SQLite3Adapter#copy_table` to prevent primary key redefinitions. #6378 | Yves Senn | 2012-10-28 | 1 | -5/+3 |
| | |||||
* | Support for partial inserts. | Jon Leighton | 2012-09-28 | 1 | -4/+0 |
| | | | | | | | | | | | When inserting new records, only the fields which have been changed from the defaults will actually be included in the INSERT statement. The other fields will be populated by the database. This is more efficient, and also means that it will be safe to remove database columns without getting subsequent errors in running app processes (so long as the code in those processes doesn't contain any references to the removed column). | ||||
* | Query for loading index info should be marked as SCHEMA. | kennyj | 2012-09-15 | 1 | -1/+1 |
| | |||||
* | Ensure disconnecting or reconnecting resets the transaction state | Jon Leighton | 2012-09-15 | 1 | -1/+7 |
| | |||||
* | column default extraction should handle newlines. | Aaron Patterson | 2012-08-17 | 1 | -2/+2 |
| | | | | Fixes #7374 | ||||
* | Revert "Merge pull request #6344" | Piotr Sarnacki | 2012-06-25 | 1 | -1/+1 |
| | | | | | | | | | | | | | | This commit needs to be reverted because it introduces difficulties when using sqlite3 in development and other databases in production. This happens because when you create time column in sqlite3, it's dumped as datetime in schema.rb file. This reverts commit 57d534ee9e441d078fcc161c0c78ebaa5aacd736, reversing changes made to 20f049fb50daee0c5e5a69b55b529af5737e8e3f. Conflicts: activerecord/test/cases/adapters/sqlite3/sqlite3_adapter_test.rb | ||||
* | Fix logs name consistency. | kennyj | 2012-05-19 | 1 | -8/+6 |
| | |||||
* | Merge pull request #6344 from erichmenge/patch_sqlite_time_type | Piotr Sarnacki | 2012-05-15 | 1 | -1/+1 |
|\ | | | | | SQLite3 doesn't actually support the 'time' type. | ||||
| * | SQLite3 doesn't actually support the 'time' type. | Erich Menge | 2012-05-15 | 1 | -1/+1 |
| | | |||||
* | | Remove useless check of adapter | Oscar Del Ben | 2012-05-15 | 1 | -4/+0 |
|/ | |||||
* | Remove unnecessary calls to primary_key on sqlite3_adapter | Carlos Galdino | 2012-05-15 | 1 | -1/+1 |
| | |||||
* | Set the primary key during #copy_table if necessary. Fixes [#2312] | Sean Scally | 2012-05-14 | 1 | -1/+5 |
| | |||||
* | Refactored remove_column | Edgars Beigarts | 2012-05-02 | 1 | -1/+1 |
| | |||||
* | renamed class SQLiteColumn to SQLite3Column | Andrey Deryabin | 2012-04-27 | 1 | -3/+3 |
| | |||||
* | removed tail of old sqlite versions | Andrey Deryabin | 2012-04-27 | 1 | -9/+9 |
| | |||||
* | fix SQLite3Adapter doc | Andrey Deryabin | 2012-04-27 | 1 | -2/+2 |
| | |||||
* | Upgrade sqlite3 version to 1.3.6 | Andrey Deryabin | 2012-04-27 | 1 | -1/+1 |
| | |||||
* | merged sqlite and sqlite3 adapters | Andrey Deryabin | 2012-04-27 | 1 | -7/+538 |
| | |||||
* | EXPLAIN only for sqlite3 | Andrey Deryabin | 2012-04-26 | 1 | -0/+25 |
| | |||||
* | Support establishing connection on ActiveRecord::Model. | Jon Leighton | 2011-12-28 | 1 | -1/+1 |
| | | | | | This is the 'top level' connection, inherited by any models that include ActiveRecord::Model or inherit from ActiveRecord::Base. | ||||
* | I herd you like modules. | Jon Leighton | 2011-12-24 | 1 | -2/+2 |
| | |||||
* | the required sqlite3 adapter responds to encoding, so stop checking. | Aaron Patterson | 2011-12-07 | 1 | -5/+1 |
| | |||||
* | SQlite3 Bump | Arun Agrawal | 2011-12-04 | 1 | -1/+1 |
| | |||||
* | add the gem requirement for sqlite3 | Aaron Patterson | 2011-08-10 | 1 | -0/+2 |
| | |||||
* | escaping binary data encoding when inserting to sqlite3. Thanks Naruse! ↵ | Aaron Patterson | 2011-03-21 | 1 | -0/+8 |
| | | | | [#6559 state:resolved] | ||||
* | Avoid creating local var. | Emilio Tagua | 2010-11-24 | 1 | -2/+1 |
| | |||||
* | just use if rather than nil? | Aaron Patterson | 2010-09-29 | 1 | -1/+1 |
| | |||||
* | just require sqlite3 when the database adapter is required | Aaron Patterson | 2010-09-29 | 1 | -4/+1 |
| | |||||
* | moving parse_sqlite_config to the sqlite3_connection method (where it ↵ | Aaron Patterson | 2010-07-08 | 1 | -1/+11 |
| | | | | | | belongs) [#5071 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | removing useless code. [#5070 state:resolved] | Aaron Patterson | 2010-07-08 | 1 | -2/+1 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | adding adapter tests, avoiding private apis, fixing code in 1.9 [#4986 ↵ | Aaron Patterson | 2010-06-26 | 1 | -3/+7 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Added encoding qery support for SQLite3 to make rake db:charset work on all ↵ | Mikel Lindsaar | 2010-02-03 | 1 | -0/+11 |
| | | | | databases shipping with Rails 3 |