aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb
Commit message (Collapse)AuthorAgeFilesLines
...
| * | Add `unsigned` types for numeric data types in MySQLRyuta Kamizono2015-09-181-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the case of using `unsigned` as the type: create_table :foos do |t| t.unsigned_integer :unsigned_integer t.unsigned_bigint :unsigned_bigint t.unsigned_float :unsigned_float t.unsigned_decimal :unsigned_decimal, precision: 10, scale: 2 end
| * | Add `unsigned` support for numeric data types in MySQLRyuta Kamizono2015-09-181-4/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Example: create_table :foos do |t| t.integer :unsigned_integer, unsigned: true t.bigint :unsigned_bigint, unsigned: true t.float :unsigned_float, unsigned: true t.decimal :unsigned_decimal, unsigned: true, precision: 10, scale: 2 end
* | | Merge pull request #19086 from kamipo/move_explain_into_abstract_mysql_adapterJeremy Daer2015-09-191-0/+78
|\ \ \ | | | | | | | | | | | | Move `explain` into `AbstractMysqlAdapter`
| * | | Move `explain` into `AbstractMysqlAdapter`Ryuta Kamizono2015-03-011-0/+78
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Common methods in both mysql adapters are should be added to `AbstractMysqlAdapter`, but some methods had been added to `Mysql2Adapter`. (8744632f, 0306f82e, #14359) Some methods already moved from `Mysql2Adapter` to `AbstractMysqlAdapter`. (#17601, #17998) Common methods in both mysql adapters are remaining only the `explain` method in `Mysql2Adapter`.
* | | | Merge pull request #20645 from kamipo/fix_mysql_set_type_bugJeremy Daer2015-09-191-1/+6
|\ \ \ \ | | | | | | | | | | Fix undesired type lookup with `SET` in MySQL
| * | | | Fix infinite loop and lookup miss when `SET` type includes other typesRyuta Kamizono2015-06-201-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit fixes the following problems: * cause infinit type lookup loop when SET includes aliased types * For example: when SET('set') includes aliased type `set`, then aliased `varchar('set')` by type lookup, but type lookup infinit matching same rule. * cause type lookup miss when SET includes registered types * For example: when SET('time') includes registered type `time`, then aliased `varchar('time')` by type lookup, then matching `time` type.
* | | | | Merge pull request #21589 from ↵Jeremy Daer2015-09-191-14/+0
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | kamipo/eliminate_duplicated_visit_table_definition Eliminate the duplication code of `visit_TableDefinition`
| * | | | | Eliminate the duplication code of `visit_TableDefinition`Ryuta Kamizono2015-09-161-13/+0
| | |_|/ / | |/| | |
* | | | | Merge pull request #21609 from kamipo/do_not_dump_view_as_tableJeremy Daer2015-09-191-0/+16
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | Do not dump a view as a table in sqlite3, mysql and mysql2 adapters
| * | | | | Add `#views` and `#view_exists?` methods on connection adaptersRyuta Kamizono2015-09-131-0/+16
| |/ / / /
* | | | | Merge pull request #21607 from kamipo/remove_unnecessary_display_widthJeremy Daer2015-09-191-2/+3
|\ \ \ \ \ | | | | | | | | | | | | Remove unnecessary display width
| * | | | | Remove unnecessary display widthRyuta Kamizono2015-09-161-2/+3
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The **(11)** does not affect the storage size of the data type, which for an INT will always be 4 bytes. It affects the **display width**. http://www.tocker.ca/2015/07/02/proposal-to-deprecate-mysql-integer-display-width-and-zerofill.html
* | | | | Merge pull request #21664 from kamipo/reduce_call_create_table_infoJeremy Daer2015-09-191-2/+7
|\ \ \ \ \ | | | | | | | | | | | | Reduce the calling `create_table_info` query
| * | | | | Reduce the calling `create_table_info` queryRyuta Kamizono2015-09-181-2/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently in schema dumping, `create_table_info` query is called twice for each tables. It means if 100 tables exists, the query is called 200 times. This change is that the query is called once for each tables in schema dumping.
* | | | | | Correctly dump composite primary keyRyuta Kamizono2015-09-201-12/+17
| |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Example: create_table :barcodes, primary_key: ["region", "code"] do |t| t.string :region t.integer :code end
* | | | | Merge pull request #21591 from kamipo/text_and_blob_limit_is_byte_lengthRafael Mendonça França2015-09-131-2/+2
|\ \ \ \ \ | | | | | | | | | | | | TEXT and BLOB limit is byte length, not character length.
| * | | | | TEXT and BLOB limit is byte length, not character length.Ryuta Kamizono2015-09-111-2/+2
| |/ / / /
* / / / / Updated MySQL documentation link to MySQL latest version 5.7 everywhere [ci ↵amitkumarsuroliya2015-09-101-2/+2
|/ / / / | | | | | | | | | | | | | | | | skip] Bumps from `5.6` to `5.7`
* | | | No need to get the exception variableRafael Mendonça França2015-09-011-6/+4
| | | |
* | | | Merge pull request #21318 from yahonda/pr21108Rafael Mendonça França2015-09-011-2/+6
|\ \ \ \ | | | | | | | | | | Support MySQL 5.7.8 which enables show_compatibility_56=off
| * | | | Support MySQL 5.7.8 which enables show_compatibility_56=offYasuo Honda2015-08-211-2/+6
| | | | |
* | | | | JSON is still an adapter specific type.Sean Griffin2015-08-211-1/+1
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Several changes were made in #21110 which I am strongly opposed to. (this is what I get for going on vacation. :trollface:) No type should be introduced into the generic `ActiveRecord::Type` namespace, and *certainly* should not be registered into the registry unconstrained unless it is supported by *all* adapters (which basically means that it was specified in the ANSI SQL standard). I do not think `# :nodoc:` ing the type is sufficient, as it still makes the code of Rails itself very unclear as to what the role of that class is. While I would argue that this shouldn't even be a super class, and that MySql and PG's JSON types are only superficially duplicated (they might look the same but will change for different reasons in the future). However, I don't feel strongly enough about it as a point of contention (and the biggest cost of harming the blameability has already occured), so I simply moved the superclass into a namespace where its role is absolutely clear. After this change, `attribute :foo, :json` will once again work with MySQL and PG, but not with Sqlite3 or any third party adapters. Unresolved questions -------------------- The types that and adapter publishes (at least those are unique to that adapter, and not adding additional behavior like `MysqlString` should probably be part of the adapter's public API. Should we standardize the namespace for these, and document them?
* | | | Add a native JSON data type support in MySQLRyuta Kamizono2015-08-181-11/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As of MySQL 5.7.8, MySQL supports a native JSON data type. Example: create_table :json_data_type do |t| t.json :settings end
* | | | Ensure that microsecond precision is only used for version of mysql that ↵Jori Hardman2015-07-201-5/+13
| | | | | | | | | | | | | | | | support it. Fixes #19711
* | | | Add reversible syntax for change_column_defaultPrem Sichanugrist2015-06-261-1/+2
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Passing `:from` and `:to` to `change_column_default` makes this command reversible as user has defined its previous state. So, instead of having the migration command as: change_column_default(:posts, :state, "draft") They can write it as: change_column_default(:posts, :state, from: nil, to: "draft")
* | | If specify `strict: :default` explicitly, do not set sql_mode.Ryuta Kamizono2015-05-261-2/+4
| | | | | | | | | | | | Related with #17370.
* | | Remove `require 'arel/visitors/bind_visitor'`Ryuta Kamizono2015-05-191-1/+0
| | | | | | | | | | | | | | | This line introduced by the commit fd398475 for using `Arel::Visitors::BindVisitor`. Currently it is not used.
* | | Divide methods for handling column options separatelyRyuta Kamizono2015-05-181-6/+10
| | |
* | | Refactor abstract_mysql_adapter type_to_sql methodMehmet Emin İNAÇ2015-05-131-21/+33
| | |
* | | Merge pull request #20047 from mcfiredrill/make-subquery-for-privateRafael Mendonça França2015-05-061-13/+13
|\ \ \ | | | | | | | | make AbstractAdapter#subquery_for private
| * | | make AbstractAdapter#subquery_for privateTony Miller2015-05-061-13/+13
| | | |
* | | | More exercise the create index sql testsRyuta Kamizono2015-05-041-2/+3
| | | |
* | | | Do not use options that does not supportRyuta Kamizono2015-05-041-4/+4
| | | | | | | | | | | | | | | | | | | | MySQL does not support partial index. And, the create index algorithm in create table can not be specified.
* | | | Merge pull request #17569 from kamipo/dump_table_optionsRafael Mendonça França2015-05-031-0/+10
|\ \ \ \ | | | | | | | | | | | | | | | Correctly dump `:options` on `create_table` for MySQL
| * | | | Correctly dump `:options` on `create_table` for MySQLRyuta Kamizono2015-05-031-0/+10
| | | | |
* | | | | Merge pull request #19978 from kamipo/collation_option_support_for_postgresqlRafael Mendonça França2015-05-031-20/+17
|\ \ \ \ \ | | | | | | | | | | | | PostgreSQL: `:collation` support for string and text columns
| * | | | | Move the collation handling code from the MySQL adapter to common classesRyuta Kamizono2015-05-041-20/+17
| | |/ / / | |/| | | | | | | | | | | | | | | | | | Some databases like MySQL allow defining collation charset for specific columns.
* / | | | Change the `visit_AddColumn` visiblity for the internal APIRyuta Kamizono2015-05-031-5/+5
|/ / / /
* / / / :nodoc: change_column_null in the implmenting adaptersTony Miller2015-05-031-1/+1
|/ / / | | | | | | | | | | | | | | | `change_column_null` is doc'ed only in ActiveRecord::ConnectionAdapters::SchemaStatements, so it would make sense to :nodoc: it elsewhere.
* | | Merge pull request #17574 from kamipo/charset_collation_optionsJeremy Kemper2015-04-071-0/+38
|\ \ \ | | | | | | | | | | | | Add charset and collation options support for MySQL string and text columns.
| * | | Add `:charset` and `:collation` options support for MySQL string and text ↵Ryuta Kamizono2015-03-061-0/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | columns Example: create_table :foos do |t| t.string :string_utf8_bin, charset: 'utf8', collation: 'utf8_bin' t.text :text_ascii, charset: 'ascii' end
* | | | No need to document drop_table in the PostgreSQLAdapterRafael Mendonça França2015-04-061-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | It behaves in the same way that the abstract adapter. [ci skip]
* | | | change the explanation of :if_exists option [ci skip]Mehmet Emin İNAÇ2015-04-061-1/+1
| | | |
* | | | drop_table method documentation for mysql and postgresql adapters [ci skip]Mehmet Emin İNAÇ2015-04-061-0/+11
| | | |
* | | | Merge pull request #19449 from Gaurav2728/gaurav-unavailable_linkRafael Mendonça França2015-03-231-2/+1
|\ \ \ \ | | | | | | | | | | remove old unavailable link with relevant fix patch 1
| * | | | remove old unavailable link with relevant fixGaurav Sharma2015-03-231-2/+1
| | | | |
* | | | | update mysql link that has been replacedGaurav Sharma2015-03-231-1/+1
|/ / / /
* | | | Updated MySQL documentation link to MySQL latest version 5.6 everywhere [ci ↵amitkumarsuroliya2015-03-191-2/+2
| | | | | | | | | | | | | | | | skip]
* | | | Materialize subqueries by adding `DISTINCT`Yasuo Honda2015-03-161-1/+3
|/ / / | | | | | | | | | to support MySQL 5.7.6 `optimizer_switch='derived_merge=on'`
* / / Add `Column#bigint?` methodRyuta Kamizono2015-03-041-2/+2
|/ /