aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb
Commit message (Collapse)AuthorAgeFilesLines
* fix mysql buildsLuke Steensen2014-03-301-1/+1
|
* No need to gsub the stringRafael Mendonça França2014-03-261-1/+1
|
* Don't use send when we own the methodRafael Mendonça França2014-03-261-1/+1
|
* Make method privateRafael Mendonça França2014-03-261-5/+6
|
* Improve the methodRafael Mendonça França2014-03-261-5/+6
| | | | | | * cache `o.name` value * Avoid extra `concat` call * Avoid extra `<<` call
* Fixes bugs for using indexes in CREATE TABLE by adding checks for table ↵Steve Rice2014-03-251-1/+1
| | | | | | | | existence Also: - updates tests by stubbing table_exists? method - adds entry for creating indexes in CREATE TABLE to changelog
* create indexes inline in CREATE TABLE for MySQLCody Cutrer2014-03-251-0/+20
| | | | | | | | This is important, because adding an index on a temporary table after it has been created would commit the transaction Conflicts: activerecord/CHANGELOG.md
* Merge pull request #13040 from kamipo/case_sensitive_comparisonRafael Mendonça França2014-03-121-0/+8
|\ | | | | | | | | | | | | Only use BINARY for mysql case sensitive uniqueness check when column has a case insensitive collation. Conflicts: activerecord/CHANGELOG.md
| * Only use BINARY for mysql case sensitive uniqueness check when column has a ↵Ryuta Kamizono2013-11-261-0/+8
| | | | | | | | case insensitive collation.
* | Replace map.flatten with flat_map in activerecordErik Michaels-Ober2014-03-031-2/+2
| |
* | `execute` is a hotspot, so let's reduce branchesAaron Patterson2014-02-121-6/+2
| |
* | MySQL: remove the old-school 'packets out of order' messageJeremy Kemper2013-12-171-6/+0
| | | | | | | | Blast from the past, MySQL 4 era, when the password hashing style changed.
* | support creating temporary tables from queriesCody Cutrer2013-12-141-0/+4
| | | | | | | | | | also override drop_table in AbstractMySQLAdapter to properly drop temporary tables without committing the transaction
* | Remove `DEFAULT NULL` for primary key column to support MySQL 5.7.3Yasuo Honda2013-12-101-1/+1
| | | | | | | | Since MySQL 5.7.3 m13 does now allow primary key column is null.
* | Remove unused variableRafael Mendonça França2013-11-291-1/+1
| | | | | | | | | | This method is not using the block variable directly since it is calling yield
* | Merge pull request #13100 from akshay-vishnoi/f-refactorCarlos Antonio da Silva2013-11-291-3/+8
|\ \ | | | | | | #type_cast - improve performance & readability
| * | #type_cast - improve performance & readabilityAkshay Vishnoi2013-11-291-3/+8
| |/
* | fix mysql version check in rename_indexCody Cutrer2013-11-281-1/+1
| | | | | | | | also clarify native rename_index support is >= 5.7, not > 5.7
* | implement rename_index natively for MySQL > 5.7Cody Cutrer2013-11-281-0/+8
|/
* Merge pull request #12779 from ↵Aaron Patterson2013-11-151-8/+0
|\ | | | | | | | | dougbarth/dont_swallow_exceptions_during_transactional_statements_in_mysql Don't swallow exceptions in transctional statements
| * Don't swallow exceptions in transctional statementsDoug Barth2013-11-051-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The MySQL connection adapater swallows all StandardError exceptions, which includes Mysql::Error and Mysql2::Error. The comment in the exception clause claims errors thrown here indicate that transactions aren't supported by the server but that isn't necessarily true. It's possible the MySQL server has gone away and swallowing a failed commit may let the application return a successful response when the data has not been saved. Also, replication libraries like Galera require that the application handle exceptions thrown at BEGIN/COMMIT. I'm unable to determine what version of MySQL threw an exception for transactional statements. I tried as far back as 3.23.49 with InnoDB disabled but BEGIN & COMMIT statements do not throw an error. If there's a real case for this logic to continue, we could instead push this behavior into a configuration setting. The exception swallowing has been there since the beginning: db045dbbf60b53dbe013ef25554fd013baf88134
* | Unifies mysql and mysql2 casting of booleans.Yves Senn2013-11-111-0/+6
|/
* extract adapter savepoint implementations into `abstract/savepoints.rb`.Yves Senn2013-09-301-17/+2
|
* change the savepoint interface to allow passing the name.Yves Senn2013-09-301-6/+6
|
* Check if the SQL is not a prepared statementRafael Mendonça França2013-09-111-0/+1
| | | | | | | | | When the adapter is with prepared statement disabled and the binds array is not empty the connection adapter will try to set the binds values and will fail. Now we are checking if the adapter has the prepared statement disabled. Fixes #12023
* chmod -xAkira Matsuda2013-08-121-0/+0
|
* Remove redundant `string_to_binary` from type-castingVipul A M2013-08-091-2/+2
|
* Set field encoding to client_encoding for mysql adapter.Koichi Sasada2013-08-081-1/+2
|
* Revert "Merge pull request #11120 from awilliams/ar_mysql2_boolean_quoting"Yves Senn2013-07-171-6/+0
| | | | | This reverts commit cb1d07e43926bcec95cb8b4a663ca9889173395a, reversing changes made to 754a373e301d2df0b12a11083405252722bc8366.
* Unifies mysql and mysql2 casting of booleansawilliams2013-07-161-0/+6
| | | | | Using the mysql2 adapter, boolean values were sometimes being incorrectly cast to 't' or 'f'. This changes the cast to match the mysql adapter behavior, ie 1 and 0.
* Merge pull request #10425 from ↵Rafael Mendonça França2013-06-131-18/+22
|\ | | | | | | | | ranjaykrishna/push_add_column_options_to_schema_creation Push add column options to schema creation
| * Moving add_column_options! up to SchemaCreationjeran2013-06-121-18/+22
| | | | | | | | | | | | | | | | removed two instances of add_column_options! from abstract_mysql_adapter reworked rename_column_sql to remove add_column_options from schema_statements changed to use new hash syntax.
* | maintain return value for recreate_databaseAaron Patterson2013-04-301-1/+2
| |
* | mysql needs to reconnect after recreate. Thanks @mperhamAaron Patterson2013-04-301-0/+1
| |
* | StatementInvalid takes WrappedDatabaseException's placeJeremy Kemper2013-04-281-1/+1
| |
* | fix detect column type of enummasarakki2013-04-011-2/+2
|/ | | | enum includes text or blob or ... hooked by wrong regex
* Add support for FULLTEXT and SPATIAL indexes using the :type flag for MySQL.Ken Mazaika2013-03-271-2/+8
|
* Merge pull request #9928 from vipulnsward/fix_rename_auto_increment_mysqlRafael Mendonça França2013-03-261-6/+7
|\ | | | | respect auto_increment in rename_column for mysql
| * respect auto_increment in rename_column for mysqlVipul A M2013-03-271-6/+7
| |
* | Adds support for concurrent indexing in PostgreSQL adapterDan McClain2013-03-251-6/+6
|/ | | | | | | | Adds support for algorithm option in MySQL indexes Moves USING and algorithm options upstream The syntax is still specific to the Adapter, so the actual executed string happens in the corresponding adapter
* Created a layer of abstraction for the valid type checking in schema dumper. ↵Ranjay Krishna2013-03-251-0/+4
| | | | Now, connection handles the check for valid types so that each database can handle the changes individually.
* Custom index type support with :using.doabit2013-03-241-0/+10
|
* push the mysql add_column up to the abstract adapterAaron Patterson2013-03-221-4/+21
|
* Unprepared Visitor + unprepared_statementCédric FABIANSKI2013-03-081-1/+1
|
* `Connection#structure_dump` is no longer used. #9518Yves Senn2013-03-061-14/+0
| | | | | | | As of ccc6910c we use `mysqldump` to create the `structure.sql`. The old `#structure_dump` code is still in AR but never used. I removed all relevant parts from the code-base.
* Revert "Merge pull request #9207 from dylanahsmith/mysql-quote-numeric"Steve Klabnik2013-02-271-0/+2
| | | | | This reverts commit 408227d9c5ed7de26310d72a1a99c1ee02311c63, reversing changes made to dca0b57d03deffc933763482e615c3cf0b9a1d97.
* Do not type cast all the database url values.Rafael Mendonça França2013-02-241-4/+4
| | | | | | We should only type cast when we need to use. Related to 4b005fb371c2e7af80df7da63be94509b1db038c
* also rename indexes when a table or column is renamedYves Senn2013-02-201-0/+2
| | | | When a table or a column is renamed related indexes kept their name. This will lead to confusing names. This patch renames related indexes when a column or a table is renamed. Only indexes with names generated by rails will be renamed. Indexes with custom names will not be renamed.
* Remove valid_type? methodJon Leighton2013-02-151-4/+0
| | | | | It was supposed to be removed by the preceding two reversions but I did them in the wrong order.
* Revert "Make valid_type? public"Jon Leighton2013-02-151-4/+4
| | | | | | This reverts commit 5d528f835e871f5f9d4b68e8a81cfbe900b7e718. Relates to f8c8ad5 which is also getting reverted due to failing test.