Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | push the collectors up to the abstract adapter | Aaron Patterson | 2014-04-09 | 1 | -20/+0 |
| | |||||
* | mysql tests are passing again | Aaron Patterson | 2014-04-09 | 1 | -1/+7 |
| | |||||
* | all tests passing on mysql2 | Aaron Patterson | 2014-04-09 | 1 | -1/+0 |
| | |||||
* | working against arel/collector branch | Aaron Patterson | 2014-04-09 | 1 | -12/+4 |
| | |||||
* | fix bind collecting for mysql | Aaron Patterson | 2014-04-09 | 1 | -2/+22 |
| | |||||
* | wrap the literal value before handing it to arel | Aaron Patterson | 2014-04-07 | 1 | -1/+2 |
| | | | | this lets arel know how to correctly quote the value | ||||
* | fix mysql builds | Luke Steensen | 2014-03-30 | 1 | -1/+1 |
| | |||||
* | No need to gsub the string | Rafael Mendonça França | 2014-03-26 | 1 | -1/+1 |
| | |||||
* | Don't use send when we own the method | Rafael Mendonça França | 2014-03-26 | 1 | -1/+1 |
| | |||||
* | Make method private | Rafael Mendonça França | 2014-03-26 | 1 | -5/+6 |
| | |||||
* | Improve the method | Rafael Mendonça França | 2014-03-26 | 1 | -5/+6 |
| | | | | | | * cache `o.name` value * Avoid extra `concat` call * Avoid extra `<<` call | ||||
* | Fixes bugs for using indexes in CREATE TABLE by adding checks for table ↵ | Steve Rice | 2014-03-25 | 1 | -1/+1 |
| | | | | | | | | existence Also: - updates tests by stubbing table_exists? method - adds entry for creating indexes in CREATE TABLE to changelog | ||||
* | create indexes inline in CREATE TABLE for MySQL | Cody Cutrer | 2014-03-25 | 1 | -0/+20 |
| | | | | | | | | This is important, because adding an index on a temporary table after it has been created would commit the transaction Conflicts: activerecord/CHANGELOG.md | ||||
* | Merge pull request #13040 from kamipo/case_sensitive_comparison | Rafael Mendonça França | 2014-03-12 | 1 | -0/+8 |
|\ | | | | | | | | | | | | | Only use BINARY for mysql case sensitive uniqueness check when column has a case insensitive collation. Conflicts: activerecord/CHANGELOG.md | ||||
| * | Only use BINARY for mysql case sensitive uniqueness check when column has a ↵ | Ryuta Kamizono | 2013-11-26 | 1 | -0/+8 |
| | | | | | | | | case insensitive collation. | ||||
* | | Replace map.flatten with flat_map in activerecord | Erik Michaels-Ober | 2014-03-03 | 1 | -2/+2 |
| | | |||||
* | | `execute` is a hotspot, so let's reduce branches | Aaron Patterson | 2014-02-12 | 1 | -6/+2 |
| | | |||||
* | | MySQL: remove the old-school 'packets out of order' message | Jeremy Kemper | 2013-12-17 | 1 | -6/+0 |
| | | | | | | | | Blast from the past, MySQL 4 era, when the password hashing style changed. | ||||
* | | support creating temporary tables from queries | Cody Cutrer | 2013-12-14 | 1 | -0/+4 |
| | | | | | | | | | | also override drop_table in AbstractMySQLAdapter to properly drop temporary tables without committing the transaction | ||||
* | | Remove `DEFAULT NULL` for primary key column to support MySQL 5.7.3 | Yasuo Honda | 2013-12-10 | 1 | -1/+1 |
| | | | | | | | | Since MySQL 5.7.3 m13 does now allow primary key column is null. | ||||
* | | Remove unused variable | Rafael Mendonça França | 2013-11-29 | 1 | -1/+1 |
| | | | | | | | | | | This method is not using the block variable directly since it is calling yield | ||||
* | | Merge pull request #13100 from akshay-vishnoi/f-refactor | Carlos Antonio da Silva | 2013-11-29 | 1 | -3/+8 |
|\ \ | | | | | | | #type_cast - improve performance & readability | ||||
| * | | #type_cast - improve performance & readability | Akshay Vishnoi | 2013-11-29 | 1 | -3/+8 |
| |/ | |||||
* | | fix mysql version check in rename_index | Cody Cutrer | 2013-11-28 | 1 | -1/+1 |
| | | | | | | | | also clarify native rename_index support is >= 5.7, not > 5.7 | ||||
* | | implement rename_index natively for MySQL > 5.7 | Cody Cutrer | 2013-11-28 | 1 | -0/+8 |
|/ | |||||
* | Merge pull request #12779 from ↵ | Aaron Patterson | 2013-11-15 | 1 | -8/+0 |
|\ | | | | | | | | | dougbarth/dont_swallow_exceptions_during_transactional_statements_in_mysql Don't swallow exceptions in transctional statements | ||||
| * | Don't swallow exceptions in transctional statements | Doug Barth | 2013-11-05 | 1 | -8/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The MySQL connection adapater swallows all StandardError exceptions, which includes Mysql::Error and Mysql2::Error. The comment in the exception clause claims errors thrown here indicate that transactions aren't supported by the server but that isn't necessarily true. It's possible the MySQL server has gone away and swallowing a failed commit may let the application return a successful response when the data has not been saved. Also, replication libraries like Galera require that the application handle exceptions thrown at BEGIN/COMMIT. I'm unable to determine what version of MySQL threw an exception for transactional statements. I tried as far back as 3.23.49 with InnoDB disabled but BEGIN & COMMIT statements do not throw an error. If there's a real case for this logic to continue, we could instead push this behavior into a configuration setting. The exception swallowing has been there since the beginning: db045dbbf60b53dbe013ef25554fd013baf88134 | ||||
* | | Unifies mysql and mysql2 casting of booleans. | Yves Senn | 2013-11-11 | 1 | -0/+6 |
|/ | |||||
* | extract adapter savepoint implementations into `abstract/savepoints.rb`. | Yves Senn | 2013-09-30 | 1 | -17/+2 |
| | |||||
* | change the savepoint interface to allow passing the name. | Yves Senn | 2013-09-30 | 1 | -6/+6 |
| | |||||
* | Check if the SQL is not a prepared statement | Rafael Mendonça França | 2013-09-11 | 1 | -0/+1 |
| | | | | | | | | | When the adapter is with prepared statement disabled and the binds array is not empty the connection adapter will try to set the binds values and will fail. Now we are checking if the adapter has the prepared statement disabled. Fixes #12023 | ||||
* | chmod -x | Akira Matsuda | 2013-08-12 | 1 | -0/+0 |
| | |||||
* | Remove redundant `string_to_binary` from type-casting | Vipul A M | 2013-08-09 | 1 | -2/+2 |
| | |||||
* | Set field encoding to client_encoding for mysql adapter. | Koichi Sasada | 2013-08-08 | 1 | -1/+2 |
| | |||||
* | Revert "Merge pull request #11120 from awilliams/ar_mysql2_boolean_quoting" | Yves Senn | 2013-07-17 | 1 | -6/+0 |
| | | | | | This reverts commit cb1d07e43926bcec95cb8b4a663ca9889173395a, reversing changes made to 754a373e301d2df0b12a11083405252722bc8366. | ||||
* | Unifies mysql and mysql2 casting of booleans | awilliams | 2013-07-16 | 1 | -0/+6 |
| | | | | | Using the mysql2 adapter, boolean values were sometimes being incorrectly cast to 't' or 'f'. This changes the cast to match the mysql adapter behavior, ie 1 and 0. | ||||
* | Merge pull request #10425 from ↵ | Rafael Mendonça França | 2013-06-13 | 1 | -18/+22 |
|\ | | | | | | | | | ranjaykrishna/push_add_column_options_to_schema_creation Push add column options to schema creation | ||||
| * | Moving add_column_options! up to SchemaCreation | jeran | 2013-06-12 | 1 | -18/+22 |
| | | | | | | | | | | | | | | | | removed two instances of add_column_options! from abstract_mysql_adapter reworked rename_column_sql to remove add_column_options from schema_statements changed to use new hash syntax. | ||||
* | | maintain return value for recreate_database | Aaron Patterson | 2013-04-30 | 1 | -1/+2 |
| | | |||||
* | | mysql needs to reconnect after recreate. Thanks @mperham | Aaron Patterson | 2013-04-30 | 1 | -0/+1 |
| | | |||||
* | | StatementInvalid takes WrappedDatabaseException's place | Jeremy Kemper | 2013-04-28 | 1 | -1/+1 |
| | | |||||
* | | fix detect column type of enum | masarakki | 2013-04-01 | 1 | -2/+2 |
|/ | | | | enum includes text or blob or ... hooked by wrong regex | ||||
* | Add support for FULLTEXT and SPATIAL indexes using the :type flag for MySQL. | Ken Mazaika | 2013-03-27 | 1 | -2/+8 |
| | |||||
* | Merge pull request #9928 from vipulnsward/fix_rename_auto_increment_mysql | Rafael Mendonça França | 2013-03-26 | 1 | -6/+7 |
|\ | | | | | respect auto_increment in rename_column for mysql | ||||
| * | respect auto_increment in rename_column for mysql | Vipul A M | 2013-03-27 | 1 | -6/+7 |
| | | |||||
* | | Adds support for concurrent indexing in PostgreSQL adapter | Dan McClain | 2013-03-25 | 1 | -6/+6 |
|/ | | | | | | | | Adds support for algorithm option in MySQL indexes Moves USING and algorithm options upstream The syntax is still specific to the Adapter, so the actual executed string happens in the corresponding adapter | ||||
* | Created a layer of abstraction for the valid type checking in schema dumper. ↵ | Ranjay Krishna | 2013-03-25 | 1 | -0/+4 |
| | | | | Now, connection handles the check for valid types so that each database can handle the changes individually. | ||||
* | Custom index type support with :using. | doabit | 2013-03-24 | 1 | -0/+10 |
| | |||||
* | push the mysql add_column up to the abstract adapter | Aaron Patterson | 2013-03-22 | 1 | -4/+21 |
| | |||||
* | Unprepared Visitor + unprepared_statement | Cédric FABIANSKI | 2013-03-08 | 1 | -1/+1 |
| |