| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ \
| | | | |
| | | | | |
Move quoting methods to `Quoting` module
|
| | | | |
| | | | |
| | | | |
| | | | | |
`MysqlString`
|
| | | | |
| | | | |
| | | | |
| | | | | |
methods to `Quoting` module
|
| | | | | |
|
|/ / / /
| | | |
| | | | |
The hard-coded back-ticks made it hard to use a different char for quoting db fields. This checkin replaces it with quote_table_name.
|
| |_|/
|/| |
| | |
| | |
| | |
| | | |
Because we define `QUOTED_TRUE` as `"1"` and `QUOTED_FALSE` as `"0"`.
And add test cases to ensure this commit does not break current
behavior even if the value of `attributes_before_type_cast` is false.
|
| | | |
|
|\ \ \
| | | |
| | | | |
Make to private the visibility of `_quote` and `_type_cast`
|
| | | | |
|
|/ / / |
|
| | |
| | |
| | |
| | | |
For keep the default SQL mode.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
kamipo/case_sensitive_comparison_for_non_string_column
The BINARY Operator is only needed for string columns
|
| |/ /
| | |
| | |
| | | |
Follow up to #13040.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
working
Currently the results of `column.serial?` is not correct. For
`column.serial?` correctly working, initialize `column.table_name`
immediately.
|
|/ / |
|
|/
|
|
| |
Simply it is sufficient to override `can_perform_case_insensitive_comparison_for?`.
|
|
|
|
|
| |
Currently some features uses `information_schema` (e.g. foreign key
support). `information_schema` introduced since MySQL 5.0.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
`initialize_schema_migrations_table` is called in every migrations.
https://github.com/rails/rails/blob/v5.0.0.beta1/activerecord/lib/active_record/migration.rb#L1080
https://github.com/rails/rails/blob/v5.0.0.beta1/activerecord/lib/active_record/schema.rb#L51
This means that extra `show variables` is called regardless of the
existence of `schema_migrations` table.
This change is to avoid extra `show variables` if `schema_migrations`
table exists.
|
| |
|
|
|
|
|
| |
`LOST_CONNECTION_ERROR_MESSAGES` was added by f384582.
But currently unused from anywhere.
|
|
|
|
|
|
|
| |
Integer limit as a byte size was introduced from Rails 2.1.
`limit: 11` is not a byte size, but take care for backward-compatibility
with Rails 2.0 (a892af6). Integer limit out of range should be allowed
to raise by #6349. I think we should remove this backward-compatibility.
|
| |
|
|
|
|
| |
`connection_adapters/mysql/type_metadata.rb`
|
| |
|
|\
| |
| | |
Prevent destructive action on production database
|
| | |
|
| |
| |
| |
| | |
Simply `{update|delete}_sql` aliases to `{update|delete}`.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Before:
```
SELECT 1 AS one FROM "topics" WHERE "topics"."title" = 'abc' LIMIT $1 [["LIMIT", 1]]
```
After:
```
SELECT 1 AS one FROM "topics" WHERE "topics"."title" = $1 LIMIT $2 [["title", "abc"], ["LIMIT", 1]]
```
|
|\ \
| | |
| | | |
Add `columns_for_distinct` for MySQL 5.7 with ONLY_FULL_GROUP_BY
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In MySQL 5.7.5 and up, ONLY_FULL_GROUP_BY affects handling of queries
that use DISTINCT and ORDER BY. It requires the ORDER BY columns in the
select list for distinct queries, and requires that the ORDER BY include
the distinct column.
See https://dev.mysql.com/doc/refman/5.7/en/group-by-handling.html
|
| | |
| | |
| | |
| | | |
Follow up to #19359 and avoid #22241.
|
|\ \ \
| | | |
| | | | |
Correctly cache create_table_info
|
| | |/
| |/|
| | |
| | | |
Follow up to #21664.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
A `(?:var)?binary` with default '' is a correct definition.
Remove `missing_default_forged_as_empty_string?` method for fixing this
issue because this method is a workaround for older mysql legacy adapter
(19c99ac, f7015336).
|
|\ \ \
| | | |
| | | | |
`join_to_delete` is same as `join_to_update`
|
| | | |
| | | |
| | | |
| | | | |
Reapply #22615.
|
| | | |
| | | |
| | | |
| | | | |
Follow up to #22642.
|
| |_|/
|/| | |
|
|/ / |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
kamipo/join_to_delete_is_same_as_join_to_update"
This reverts commit 4d06ea9a829de8f6f5a345589828e182eacab6a3, reversing
changes made to e9d15072a94e2ae4dec5b7a121c84a5db38547b8.
Reason: This will break oracle-enhanced, see
https://github.com/rsim/oracle-enhanced/blob/3c42131db82b64ac41645db3affc6e4650289df6/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb#L1254
|
|/ |
|
|
|
|
| |
`pool` in args is unused anymore. And `config` is used in all adapters.
|
|
|
|
| |
Not needed for `Mysql2Adapter` and `AbstractMysqlAdapter`.
|
| |
|
| |
|
|\
| |
| |
| |
| | |
kamipo/not_passing_native_database_types_to_table_definition
Not passing `native_database_types` to `TableDefinition`
|
| |
| |
| |
| |
| |
| | |
The `native_database_types` only used in `TableDefinition` for look up
the default `:limit` option. But this is duplicated process with
`type_to_sql`. Passing `native_database_types` is not needed.
|
| |
| |
| |
| | |
Not needed for `Mysql2Adapter` and `AbstractMysqlAdapter`.
|