aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb
Commit message (Collapse)AuthorAgeFilesLines
...
* Disable prepared statements in the unprepared_statement blockRafael Mendonça França2013-09-121-2/+3
|
* Fix inverted conditionalRafael Mendonça França2013-09-111-1/+1
| | | | Oops, I should had run the tests
* Check if the SQL is not a prepared statementRafael Mendonça França2013-09-111-0/+5
| | | | | | | | | When the adapter is with prepared statement disabled and the binds array is not empty the connection adapter will try to set the binds values and will fail. Now we are checking if the adapter has the prepared statement disabled. Fixes #12023
* Merge pull request #11455 from antonio/fix_enable_extension_not_being_definedRafael Mendonça França2013-08-021-0/+8
|\ | | | | Define enable_extension method to prevent undefined method error
| * Define enable_extension method to prevent undefined method errorAntonio Santos2013-08-021-0/+8
| | | | | | | | | | | | | | When mixing postgresql and another adapter like sqlite3 (for dev and test respectively), the task `db:test:prepare` will fail due to the `enable_extension` method not being defined in the abstract adapter. This patch simply adds an empty definition to prevent it.
* | Move initializing process for query cache to ↵kennyj2013-07-161-2/+0
|/ | | | ActiveRecord::ConnectionAdapters::QueryCache module.
* Merge pull request #11174 from vipulnsward/remove_column_passingRafael Mendonça França2013-07-091-2/+2
|\ | | | | Stop sending column info to `substitute_at` as it doesn't get utilized.
| * Document where `column` param gets utilized in `substitute_at`.Vipul A M2013-07-011-2/+2
| |
* | Remove deprecated `transaction_joinable=`Arun Agrawal2013-07-031-6/+0
| | | | | | | | | | in favor of `begin_transaction` with `:joinable` option.
* | Remove deprecated `decrement_open_transactions`.Arun Agrawal2013-07-031-4/+0
| |
* | removed deprecated increment_open_transactionsArun Agrawal2013-07-031-4/+0
|/
* Merge pull request #10425 from ↵Rafael Mendonça França2013-06-131-9/+22
|\ | | | | | | | | ranjaykrishna/push_add_column_options_to_schema_creation Push add column options to schema creation
| * Moving add_column_options! up to SchemaCreationjeran2013-06-121-9/+22
| | | | | | | | | | | | | | | | removed two instances of add_column_options! from abstract_mysql_adapter reworked rename_column_sql to remove add_column_options from schema_statements changed to use new hash syntax.
* | StatementInvalid takes WrappedDatabaseException's placeJeremy Kemper2013-04-281-1/+1
| |
* | Minor doc improvement about index algorithms [ci skip]Carlos Antonio da Silva2013-03-301-3/+2
| |
* | added comments to test_invalid_type in sqlite3 adapter test and added ↵Ranjay Krishna2013-03-281-0/+4
|/ | | | valid_type? method to abstract_adapter.rb and removed unnecessary method from sqlite3 adapter
* Adds support for concurrent indexing in PostgreSQL adapterDan McClain2013-03-251-0/+7
| | | | | | | | Adds support for algorithm option in MySQL indexes Moves USING and algorithm options upstream The syntax is still specific to the Adapter, so the actual executed string happens in the corresponding adapter
* Autoload the AlterTable classRafael Mendonça França2013-03-231-0/+1
|
* push the mysql add_column up to the abstract adapterAaron Patterson2013-03-221-7/+7
|
* allow multiple add columnsAaron Patterson2013-03-221-1/+1
|
* push alter table add column sql in to the schema modification visitorAaron Patterson2013-03-221-5/+21
|
* push SQL generation inside the schema creation objectAaron Patterson2013-03-221-1/+9
|
* remove to_sql from TableDefinitionAaron Patterson2013-03-221-0/+4
|
* remove knowledge of SQL from the column definition objectAaron Patterson2013-03-221-0/+41
|
* Unprepared Visitor + unprepared_statementCédric FABIANSKI2013-03-081-0/+11
|
* Do not type cast all the database url values.Rafael Mendonça França2013-02-241-0/+18
| | | | | | We should only type cast when we need to use. Related to 4b005fb371c2e7af80df7da63be94509b1db038c
* copy-edits RDoc in fba496fXavier Noria2013-02-161-4/+4
| | | | | | | This revision makes the terminology uniform with the rest of the file. In general we describe these methods in terms of the adapter, rather than the database. (As a side note, if we wanted to refer to the database we would write "PostgreSQL".)
* Remove valid_type? methodJon Leighton2013-02-151-4/+0
| | | | | It was supposed to be removed by the preceding two reversions but I did them in the wrong order.
* Revert "Make valid_type? public"Jon Leighton2013-02-151-4/+4
| | | | | | This reverts commit 5d528f835e871f5f9d4b68e8a81cfbe900b7e718. Relates to f8c8ad5 which is also getting reverted due to failing test.
* Make valid_type? publicSam Ruby2013-02-141-4/+4
|
* Merge pull request #9204 from ranjaykrishna/col-probAaron Patterson2013-02-121-0/+4
|\ | | | | schema dumper tests now conducted by ActiveRecord::Base.Connection
| * checking in the abstractions for valid type checking:Ranjay Krishna2013-02-121-0/+4
| |
* | Add changelog entry for #9203 about schema dumper with db extensionsCarlos Antonio da Silva2013-02-061-2/+2
| | | | | | | | [ci skip]
* | add ActiveRecord::AbstractAdapter#extensions and ↵Justin George2013-02-061-0/+6
| | | | | | | | ActiveRecord::ConnectionAdapters::PostgreSQLAdapter#extensions to allow dumping of enabled extensions to schema.rb, add ActiveRecord::SchemaDumper#extensions to dump extensions to schema.rb
* | add API to pg for enabling / disabling hstoreAaron Patterson2013-01-281-0/+6
|/
* These are already required through AS/railsAkira Matsuda2013-01-071-1/+0
| | | | | | * dependencies/autoload * concern * deprecation
* Make caller attribute in deprecation methods optionalAlexey Gaziev2012-10-301-4/+4
|
* Provide a call stack for deprecation warnings where needed.Nikita Afanasenko2012-10-291-3/+4
| | | | It's sometimes hard to quickly find where deprecated call was performed, especially in case of migrating between Rails versions. So this is an attempt to improve the call stack part of the warning message by providing caller explicitly.
* Support for specifying transaction isolation levelJon Leighton2012-09-211-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If your database supports setting the isolation level for a transaction, you can set it like so: Post.transaction(isolation: :serializable) do # ... end Valid isolation levels are: * `:read_uncommitted` * `:read_committed` * `:repeatable_read` * `:serializable` You should consult the documentation for your database to understand the semantics of these different levels: * http://www.postgresql.org/docs/9.1/static/transaction-iso.html * https://dev.mysql.com/doc/refman/5.0/en/set-transaction.html An `ActiveRecord::TransactionIsolationError` will be raised if: * The adapter does not support setting the isolation level * You are joining an existing open transaction * You are creating a nested (savepoint) transaction The mysql, mysql2 and postgresql adapters support setting the transaction isolation level. However, support is disabled for mysql versions below 5, because they are affected by a bug (http://bugs.mysql.com/bug.php?id=39170) which means the isolation level gets persisted outside the transaction.
* Merge pull request #7547 from danmcclain/pg-arraysRafael Mendonça França2012-09-161-0/+2
|\ | | | | Adds migration and type casting support for PostgreSQL Array datatype
| * Moves column dump specific code to a module included in AbstractAdapterDan McClain2012-09-141-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Having column related schema dumper code in the AbstractAdapter. The code remains the same, but by placing it in the AbstractAdapter, we can then overwrite it with Adapter specific methods that will help with Adapter specific data types. The goal of moving this code here is to create a new migration key for PostgreSQL's array type. Since any datatype can be an array, the goal is to have ':array => true' as a migration option, turning the datatype into an array. I've implemented this in postgres_ext, the syntax is shown here: https://github.com/dockyard/postgres_ext#arrays Adds array migration support Adds array_test.rb outlining the test cases for array data type Adds pg_array_parser to Gemfile for testing Adds pg_array_parser to postgresql_adapter (unused in this commit) Adds schema dump support for arrays Adds postgres array type casting support Updates changelog, adds note for inet and cidr support, which I forgot to add before Removing debugger, Adds pg_array_parser to JRuby platform Removes pg_array_parser requirement, creates ArrayParser module used by PostgreSQLAdapter
* | Ensure disconnecting or reconnecting resets the transaction stateJon Leighton2012-09-151-5/+6
| |
* | Move transaction joinability into the transaction objectJon Leighton2012-09-151-3/+4
| |
* | Alter the naming structure a bitJon Leighton2012-09-151-1/+6
| |
* | Store the transaction number in the transaction objectJon Leighton2012-09-151-4/+6
| | | | | | | | This avoids us having to manually increment and decrement it.
* | Start to tease out transaction handling into a state machineJon Leighton2012-09-151-0/+1
| |
* | Revert "create a transaction object and point AR objects at that object ↵Jon Leighton2012-09-151-20/+3
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | during a" This reverts commit c24c885209ac2334dc6f798c394a821ee270bec6. Here's the explanation I just sent to @tenderlove: Hey, I've been thinking about about the transaction memory leak thing that we were discussing. Example code: post = nil Post.transaction do N.times { post = Post.create } end Post.transaction is going to create a real transaction and there will also be a (savepoint) transaction inside each Post.create. In an idea world, we'd like all but the last Post instance to be GC'd, and for the last Post instance to receive its after_commit callback when Post.transaction returns. I can't see how this can work using your solution where the Post itself holds a reference to the transaction it is in; when Post.transaction returns, control does not switch to any of Post's instance methods, so it can't trigger the callbacks itself. What we really want is for the transaction itself to hold weak references to the objects within the transaction. So those objects can be GC'd, but if they are not GC'd then the transaction can iterate them and execute their callbacks. I've looked into WeakRef implementations that are available. On 1.9.3, the stdlib weakref library is broken and we shouldn't use it. There is a better implementation here: https://github.com/bdurand/ref/blob/master/lib/ref/weak_reference/pure_ruby.rb We could use that, either by pulling in the gem or just copying the code in, but it still suffers from the limitation that it uses ObjectSpace finalizers. In my testing, this finalizers make GC quite expensive: https://gist.github.com/3722432 Ruby 2.0 will have a native WeakRef implementation (via ObjectSpace::WeakMap), hence won't be reliant on finalizers: http://bugs.ruby-lang.org/issues/4168 So the ultimate solution will be for everyone to use Ruby 2.0, and for us to just use ObjectSpace::WeakMap. In the meantime, we have basically 3 options: The first is to leave it as it is. The second is to use a finalizer-based weakref implementation and take the GC perf hit. The final option is to store object ids rather than the actual objects. Then use ObjectSpace._id2ref to deference the objects at the end of the transaction, if they exist. This won't stop memory use growing within the transaction, but it'll grow more slowly. I benchmarked the performance of _id2ref this if the object does or does not exist: https://gist.github.com/3722550 If it does exist it seems decent, but it's hugely more expensive if it doesn't, probably because we have to do the rescue nil. Probably most of the time the objects will exist. However the point of doing this optimisation is to allow people to create a large number of objects inside a transaction and have them be GC'd. So for that use case, we'd be replacing one problem with another. I'm not sure which of the two problems is worse. My feeling is that we should just leave this for now and come back to it when Ruby 2.0 is out. I'm going to revert your commit because I can't see how it solves this. Hope you don't mind... if I've misunderstood then let me know! Jon
* create a transaction object and point AR objects at that object during aAaron Patterson2012-09-071-3/+20
| | | | transaction.
* load active_support/deprecation in active_support/railsXavier Noria2012-08-021-1/+0
|
* Avoid unnecessary catching of Exception instead of StandardError.Dylan Smith2012-06-171-1/+1
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-30 19:30:45 +0000