Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Remove redundant `string_to_binary` from type-casting | Vipul A M | 2013-08-09 | 2 | -4/+0 | |
| | ||||||
* | Merge pull request #11331 from vipulnsward/remove_conditional | Aaron Patterson | 2013-08-07 | 1 | -8/+1 | |
|\ | | | | | Remove conditional, results are always an instance of `ActiveRecord::Result` | |||||
| * | Remove conditional, since results are always an instance of ↵ | Vipul A M | 2013-07-06 | 1 | -8/+1 | |
| | | | | | | | | `ActiveRecord::Result` | |||||
* | | Fix indentation. | kennyj | 2013-07-24 | 1 | -8/+8 | |
| | | ||||||
* | | Simplify select_one method. | kennyj | 2013-07-24 | 1 | -2/+1 | |
| | | | | | | | | | | | | The select_all method always returns ActiveRecord::Result instance, and the ActiveRecord::Result includes Enumerable mixin. If #empty?, #first method returns nil. Thus we can simplify this method. | |||||
* | | Defines the return type of select / select_all method. | kennyj | 2013-07-23 | 1 | -4/+2 | |
| | | ||||||
* | | rescue from all exceptions in `ConnectionManagement#call` | Vipul A M | 2013-07-22 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | Fixes #11497 As `ActiveRecord::ConnectionAdapters::ConnectionManagement` middleware does not rescue from Exception (but only from StandardError), the Connection Pool quickly runs out of connections when multiple erroneous Requests come in right after each other. Recueing from all exceptions and not just StandardError, fixes this behaviour. | |||||
* | | Move initializing process for query cache to ↵ | kennyj | 2013-07-16 | 1 | -0/+6 | |
|/ | | | | ActiveRecord::ConnectionAdapters::QueryCache module. | |||||
* | Removed deprecated method `columns_for_remove` | Neeraj Singh | 2013-07-03 | 1 | -6/+0 | |
| | ||||||
* | Remove deprecated SchemaStatements#distinct | Francesco Rodriguez | 2013-07-02 | 1 | -9/+0 | |
| | ||||||
* | Remove deprecated AR::Connection#clear_stale_cached_connections! method | Francesco Rodriguez | 2013-07-01 | 1 | -5/+0 | |
| | ||||||
* | Fix documents for create_join_table | Satoshi Ebisawa | 2013-06-21 | 1 | -2/+2 | |
| | ||||||
* | Merge pull request #10425 from ↵ | Rafael Mendonça França | 2013-06-13 | 2 | -11/+3 | |
|\ | | | | | | | | | ranjaykrishna/push_add_column_options_to_schema_creation Push add column options to schema creation | |||||
| * | Moving add_column_options! up to SchemaCreation | jeran | 2013-06-12 | 2 | -11/+3 | |
| | | | | | | | | | | | | | | | | removed two instances of add_column_options! from abstract_mysql_adapter reworked rename_column_sql to remove add_column_options from schema_statements changed to use new hash syntax. | |||||
* | | Fixes #10432 add_column not creating array columns in PostgreSQL | Adam Anderson | 2013-06-04 | 1 | -0/+1 | |
| | | | | | | | | | | | | When then PostgreSQL visitor was [added](https://github.com/rails/rails/commit/6b7fdf3bf3675a14eae74acc5241089308153a34) `add_column` was no longer receiving the column options directly. This caused the options to be lost along the way. | |||||
* | | Remove behavior that deals with a string as third argument of `add_index`, ↵ | kennyj | 2013-06-02 | 1 | -28/+14 | |
| | | | | | | | | | | | | because this was deprecated. Some testcases is failed, so I replaced nil to empty hash in add_reference. | |||||
* | | Merge pull request #10556 from Empact/deprecate-schema-statements-distinct | Rafael Mendonça França | 2013-05-12 | 1 | -1/+2 | |
| | | | | | | | | | | | | Deprecate SchemaStatements#distinct, and make SchemaStatements#columns_for_distinct nodoc. Conflicts: activerecord/CHANGELOG.md | |||||
* | | Merge pull request #10572 from nertzy/dont-modify-options-hash-in-primary-key | Rafael Mendonça França | 2013-05-11 | 1 | -2/+1 | |
| | | | | | | | | Don't modify args in TableDefinition#primary_key | |||||
* | | Fix that #exists? can produce invalid SQL: "SELECT DISTINCT DISTINCT" | Ben Woosley | 2013-05-10 | 1 | -3/+11 | |
| | | | | | | | | | | | | | | | | | | | | | | | | The combination of a :uniq => true association and the #distinct call in #construct_limited_ids_condition combine to create invalid SQL, because we're explicitly selecting DISTINCT, and also sending #distinct on to AREL, via the relation#distinct_value. Rather than build a select distinct clause in #construct_limited_ids_condition, I set #distinct! and pass just the columns into the select statement. This requires introducing a #columns_for_distinct method to return the select columns but not the statement itself. | |||||
* | | Move method used only in the test to the test code itself | Ivan Kataitsev | 2013-04-25 | 1 | -8/+0 | |
| | | ||||||
* | | Make references with index:true pass Hash options to add_index. | Victor Costan | 2013-04-01 | 1 | -1/+1 | |
| | | ||||||
* | | Refactor index algorithm lookup so that it only builds the available options ↵ | Carlos Antonio da Silva | 2013-03-30 | 1 | -4/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | once This way the available options are only built for actually fetching the algorithm in case the option is given. The options are going to be necessary a second time only in case the option is given but does not exist, which is supposed to be due to a typo or something like that, so no problem. | |||||
* | | Make docs a little bit more consistent with colons [ci skip] | Carlos Antonio da Silva | 2013-03-30 | 1 | -9/+9 | |
| | | ||||||
* | | Fix code examples indent in new index options docs [ci skip] | Carlos Antonio da Silva | 2013-03-30 | 1 | -3/+3 | |
| | | ||||||
* | | Use new hash style in doc examples [ci skip] | Carlos Antonio da Silva | 2013-03-30 | 1 | -2/+2 | |
|/ | ||||||
* | Add support for FULLTEXT and SPATIAL indexes using the :type flag for MySQL. | Ken Mazaika | 2013-03-27 | 2 | -2/+15 | |
| | ||||||
* | Merge pull request #9928 from vipulnsward/fix_rename_auto_increment_mysql | Rafael Mendonça França | 2013-03-26 | 1 | -0/+3 | |
|\ | | | | | respect auto_increment in rename_column for mysql | |||||
| * | respect auto_increment in rename_column for mysql | Vipul A M | 2013-03-27 | 1 | -0/+3 | |
| | | ||||||
* | | Checks :algorithm argument for valid values | Dan McClain | 2013-03-26 | 1 | -1/+7 | |
| | | ||||||
* | | Adds support for concurrent indexing in PostgreSQL adapter | Dan McClain | 2013-03-25 | 1 | -2/+5 | |
|/ | | | | | | | | Adds support for algorithm option in MySQL indexes Moves USING and algorithm options upstream The syntax is still specific to the Adapter, so the actual executed string happens in the corresponding adapter | |||||
* | The sql_type method called here is from | Rafael Mendonça França | 2013-03-25 | 1 | -1/+1 | |
| | | | | | | | ActiveRecord::ConnectionAdapters::Column See https://github.com/rails/rails/blob/28b8ca766e3e7c6c43d3ae900c99f8377153c62/activerecord/lib/active_record/connection_adapters/column.rb#L16 | |||||
* | Custom index type support with :using. | doabit | 2013-03-24 | 2 | -3/+10 | |
| | ||||||
* | add uuid primary key support | Aaron Patterson | 2013-03-22 | 2 | -3/+4 | |
| | ||||||
* | separate primary key from column type | Aaron Patterson | 2013-03-22 | 1 | -10/+11 | |
| | ||||||
* | push the mysql add_column up to the abstract adapter | Aaron Patterson | 2013-03-22 | 1 | -1/+3 | |
| | ||||||
* | allow multiple add columns | Aaron Patterson | 2013-03-22 | 1 | -4/+4 | |
| | ||||||
* | push alter table add column sql in to the schema modification visitor | Aaron Patterson | 2013-03-22 | 2 | -9/+30 | |
| | ||||||
* | there is no reason to check for an already defined column | Aaron Patterson | 2013-03-22 | 1 | -1/+1 | |
| | ||||||
* | push column initialization down to the factory method | Aaron Patterson | 2013-03-22 | 1 | -13/+13 | |
| | ||||||
* | @columns list is no longer necessary | Aaron Patterson | 2013-03-22 | 1 | -8/+4 | |
| | ||||||
* | keep ivars private, do not manipulate them outside their owner object | Aaron Patterson | 2013-03-22 | 1 | -0/+4 | |
| | ||||||
* | factory methods should not alter object state | Aaron Patterson | 2013-03-22 | 1 | -5/+7 | |
| | ||||||
* | push SQL generation inside the schema creation object | Aaron Patterson | 2013-03-22 | 2 | -9/+9 | |
| | ||||||
* | mostly decouple TableDefinition from the database connection | Aaron Patterson | 2013-03-22 | 2 | -4/+4 | |
| | ||||||
* | remove to_sql from TableDefinition | Aaron Patterson | 2013-03-22 | 2 | -9/+1 | |
| | ||||||
* | decouple column definition from the database connection | Aaron Patterson | 2013-03-22 | 1 | -6/+6 | |
| | ||||||
* | remove knowledge of SQL from the column definition object | Aaron Patterson | 2013-03-22 | 1 | -21/+2 | |
| | ||||||
* | use `connect_poll` on pg so that reaping does not hurt the connection | Aaron Patterson | 2013-03-20 | 1 | -1/+3 | |
| | ||||||
* | Revert "default the reaping frequency to 10 seconds" | Aaron Patterson | 2013-03-20 | 1 | -1/+1 | |
| | | | | | | | mysql can't handle a parallel thread pinging the connection, so we can get wrong results or segvs This reverts commit 7cc588b684f6d1af3e7fab1edfa6715e269e41a2. | |||||
* | fix typos in AR. lots of them. | Vipul A M | 2013-03-19 | 2 | -2/+2 | |
| |