Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Refactor references schema definitions | Aleksey Magusev | 2012-07-03 | 1 | -18/+12 |
| | |||||
* | Add references schema statements | Aleksey Magusev | 2012-07-03 | 1 | -0/+37 |
| | | | | | | | | | | Examples: add_reference :products, :supplier, polymorphic: true, index: true remove_reference :products, :user `add_belongs_to` and `remove_belongs_to` are acceptable. | ||||
* | Add more options to column_exists? method | Aleksey Magusev | 2012-06-30 | 1 | -4/+6 |
| | | | | Also fix failures in check options for nil | ||||
* | add :nodoc: to internal implementations [ci skip] | Francesco Rodriguez | 2012-06-22 | 1 | -1/+1 |
| | |||||
* | Avoid unnecessary catching of Exception instead of StandardError. | Dylan Smith | 2012-06-17 | 1 | -2/+2 |
| | |||||
* | Simplify AR configuration code. | Jon Leighton | 2012-06-15 | 1 | -6/+8 |
| | | | | | Get rid of ActiveModel::Configuration, make better use of ActiveSupport::Concern + class_attribute, etc. | ||||
* | Merge pull request #6492 from pmahoney/fair-connection-pool2 | Rafael Mendonça França | 2012-06-11 | 1 | -37/+174 |
|\ | | | | | | | | | | | | | Fair connection pool2 Conflicts: activerecord/test/cases/associations/eager_test.rb | ||||
| * | Make connection pool fair with respect to waiting threads. | Patrick Mahoney | 2012-05-25 | 1 | -37/+174 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The core of this fix is a threadsafe, fair Queue class. It is very similar to Queue in stdlib except that it supports waiting with a timeout. The issue this solves is that if several threads are contending for database connections, an unfair queue makes is possible that a thread will timeout even while other threads successfully acquire and release connections. A fair queue means the thread that has been waiting the longest will get the next available connection. This includes a few test fixes to avoid test ordering issues that cropped up during development of this patch. | ||||
* | | Symbol responds_to :upcase & :downcase in Ruby >= 1.9 | Akira Matsuda | 2012-06-06 | 1 | -1/+1 |
| | | |||||
* | | Work around undiagnosed bug that's draining a relation's bind_values | Jeremy Kemper | 2012-05-31 | 1 | -0/+1 |
| | | |||||
* | | SchemaMigration should be loaded lazily. | kennyj | 2012-05-29 | 1 | -1/+0 |
|/ | |||||
* | Whitespaces :scissors: | Rafael Mendonça França | 2012-05-23 | 1 | -6/+6 |
| | |||||
* | ConnectionPool wait_timeout no longer used for different types of timeouts. ↵ | Jonathan Rochkind | 2012-05-23 | 1 | -7/+16 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #6441 An AR ConnectionSpec `wait_timeout` is pre-patch used for three different things: * mysql2 uses it for MySQL's own wait_timeout (how long MySQL should allow an idle connection before closing it), and defaults to 2592000 seconds. * ConnectionPool uses it for "number of seconds to block and wait for a connection before giving up and raising a timeout error", default 5 seconds. * ConnectionPool uses it for the Reaper, for deciding if a 'dead' connection can be reaped. Default 5 seconds. Previously, if you want to change these from defaults, you need to change them all together. This is problematic _especially_ for the mysql2/ConnectionPool conflict, you will generally _not_ want them to be the same, as evidenced by their wildly different defaults. This has caused real problems for people #6441 #2894 But as long as we're changing this, forcing renaming the ConnectionPool key to be more specific, it made sense to seperate the two ConnectionPool uses too -- these two types of ConnectionPool timeouts ought to be able to be changed independently, you won't neccesarily want them to be the same, even though the defaults are (currently) the same. | ||||
* | Revert "Merge pull request #6416 from pmahoney/threadsafe-connection-pool" | Rafael Mendonça França | 2012-05-22 | 1 | -86/+34 |
| | | | | | | | | | | | | This reverts commit d2901f0fc4270a765717ad572d559dc49a56b3a8, reversing changes made to 525839fdd8cc34d6d524f204528d5b6f36fe410c. Conflicts: activerecord/test/cases/connection_pool_test.rb Reason: This change broke the build (http://travis-ci.org/#!/rails/rails/builds/1391490) and we don't have any solution until now. I asked the author to try to fix it and open a new pull request. | ||||
* | Make connection pool fair with respect to waiting threads. | Patrick Mahoney | 2012-05-20 | 1 | -34/+86 |
| | |||||
* | Synchronize read and modification of @reserved_connections hash to avoid ↵ | Patrick Mahoney | 2012-05-19 | 1 | -4/+8 |
| | | | | concurrency error. | ||||
* | Integer limit out of range should be allowed to raise. Closes #6272 | Erich Menge | 2012-05-16 | 1 | -1/+1 |
| | |||||
* | remove unnecessary 'examples' noise [ci skip] | Vijay Dev | 2012-05-11 | 2 | -28/+18 |
| | |||||
* | Merge pull request #5362 from zenprogrammer/quoting_bug | Aaron Patterson | 2012-05-09 | 1 | -0/+1 |
|\ | | | | | Fixed bug in ActiveRecord that caused classes to be quoted incorrectly | ||||
| * | Fixed bug in Quoting that caused classes to be quoted incorrectly | Ryan Oblak | 2012-03-09 | 1 | -0/+1 |
| | | |||||
* | | Refactored remove_column | Edgars Beigarts | 2012-05-02 | 2 | -3/+1 |
| | | |||||
* | | Remove unused assignments | Mark Rushakoff | 2012-04-29 | 1 | -5/+3 |
| | | |||||
* | | Merge pull request #5698 from dougcole/support_postgresql_partitioning | Aaron Patterson | 2012-04-27 | 1 | -2/+2 |
|\ \ | | | | | | | Support postgresql partitioning by making INSERT RETURNING optional | ||||
| * | | add use_returning as a postgresql connection config | Doug Cole | 2012-03-31 | 1 | -2/+2 |
| | | | |||||
* | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-04-18 | 1 | -1/+1 |
|\ \ \ | |||||
| * | | | Fix typo on the add_index. | kennyj | 2012-04-13 | 1 | -1/+1 |
| | | | | |||||
* | | | | opening a connection will block if the pool is full | Aaron Patterson | 2012-04-15 | 1 | -20/+39 |
| | | | | |||||
* | | | | Automatically create indexes for references/belongs_to statements in migrations. | Joshua Wood | 2012-04-14 | 2 | -4/+21 |
|/ / / | |||||
* | | | Fix delete_all when chained with joins. | Rafael Mendonça França | 2012-04-10 | 1 | -3/+17 |
| | | | | | | | | | | | | Closes #5202 and #919 | ||||
* | | | Merge pull request #5716 from jurriaan/tr-gsub-cleanup | Santiago Pastorino | 2012-04-04 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | Updated/changed unneeded tr/gsubs | ||||
| * | | | Updated/changed useless tr/gsubs | Jurriaan Pruis | 2012-04-03 | 1 | -1/+1 |
| |/ / | |||||
* / / | Remove unnecessary articles. | Waseem Ahmad | 2012-04-03 | 1 | -3/+3 |
|/ / | |||||
* | | Use one 'be'. | Waseem Ahmad | 2012-03-24 | 1 | -1/+1 |
| | | |||||
* | | make sure connections returned after close are marked as in_use | Aaron Patterson | 2012-03-12 | 1 | -4/+17 |
| | | |||||
* | | deprecated clear_stale_active_connections! can call #reap instead of ↵ | Jonathan Rochkind | 2012-03-12 | 1 | -1/+2 |
| | | | | | | | | no-op'ing, #reap does the same thing | ||||
* | | make active_connection? return true only if there is an open connection in ↵ | Aaron Patterson | 2012-03-08 | 1 | -7/+4 |
| | | | | | | | | use for the current thread. fixes #5330 | ||||
* | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-03-03 | 1 | -0/+3 |
|\ \ | |/ |/| | |||||
| * | Add documentation for IndexDefinition. | Waseem Ahmad | 2012-03-02 | 1 | -0/+3 |
| | | |||||
* | | revert setting NOT NULL constraints in add_timestamps | Xavier Noria | 2012-03-01 | 1 | -2/+2 |
|/ | | | | | | | | | | | Commit 3dbedd2 added NOT NULL constraints both to table creation and modification. For creation the new default makes sense, but the generic situation for changing a table is that there exist records. Those records have no creation or modification timestamps, and in the general case you don't even know them, so when updating a table these constraints are not going to work. See a bug report for this use case in #3334. | ||||
* | use bind values for join columns | Aaron Patterson | 2012-02-27 | 1 | -4/+4 |
| | |||||
* | removes verify_active_connections! | Xavier Noria | 2012-02-24 | 1 | -15/+0 |
| | | | | | | | The method verify_active_connections! was used in the old days (up to 2.1 I think) by the dispatcher to verify the connections, but nowadays we do that in a different way and this method is obsolete. | ||||
* | prepared statements can be disabled | Aaron Patterson | 2012-02-21 | 2 | -8/+10 |
| | |||||
* | use Process.pid rather than $$ | Aaron Patterson | 2012-02-16 | 1 | -5/+5 |
| | |||||
* | database connections are automatically established after forking. | Aaron Patterson | 2012-02-16 | 1 | -13/+47 |
| | | | | Connection pools are 1:1 with pids. | ||||
* | Revert "No need to pass options which is never used" | Rafael Mendonça França | 2012-02-15 | 1 | -2/+2 |
| | | | | | | | | | Options is needed for some Rails extensions to determine when referential integrity should be disabled This reverts commit bcb466c543451dce69403aaae047295758589d8e. Fixes #5052 | ||||
* | Made schema dumper recognize partial indices' where statements | Marcelo Silveira | 2012-02-09 | 1 | -1/+1 |
| | |||||
* | Added where option to add_index to support postgresql partial indices | Marcelo Silveira | 2012-02-09 | 1 | -3/+13 |
| | | | | | | | | | | | The `add_index` method now supports a `where` option that receives a string with the partial index criteria. add_index(:accounts, :code, :where => "active") Generates CREATE INDEX index_accounts_on_code ON accounts(code) WHERE active | ||||
* | Remove useless argument in #columns. | Sebastian Martinez | 2012-02-02 | 1 | -1/+1 |
| | |||||
* | QueryCache will just dup an AR::Result, AR::Result can deep copy | Aaron Patterson | 2012-01-31 | 1 | -9/+15 |
| | |||||
* | query cache instrumentation should included the bindings in the payload ↵ | Xavier Noria | 2012-01-30 | 1 | -1/+1 |
| | | | | [closes #4750] |