Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | push SQL generation inside the schema creation object | Aaron Patterson | 2013-03-22 | 2 | -9/+9 |
| | |||||
* | mostly decouple TableDefinition from the database connection | Aaron Patterson | 2013-03-22 | 2 | -4/+4 |
| | |||||
* | remove to_sql from TableDefinition | Aaron Patterson | 2013-03-22 | 2 | -9/+1 |
| | |||||
* | decouple column definition from the database connection | Aaron Patterson | 2013-03-22 | 1 | -6/+6 |
| | |||||
* | remove knowledge of SQL from the column definition object | Aaron Patterson | 2013-03-22 | 1 | -21/+2 |
| | |||||
* | use `connect_poll` on pg so that reaping does not hurt the connection | Aaron Patterson | 2013-03-20 | 1 | -1/+3 |
| | |||||
* | Revert "default the reaping frequency to 10 seconds" | Aaron Patterson | 2013-03-20 | 1 | -1/+1 |
| | | | | | | | mysql can't handle a parallel thread pinging the connection, so we can get wrong results or segvs This reverts commit 7cc588b684f6d1af3e7fab1edfa6715e269e41a2. | ||||
* | fix typos in AR. lots of them. | Vipul A M | 2013-03-19 | 2 | -2/+2 |
| | |||||
* | Refactored to reuse method | Anupam Choudhury | 2013-03-15 | 1 | -2/+2 |
| | |||||
* | ask column if it is a pk | Aaron Patterson | 2013-03-14 | 1 | -1/+5 |
| | |||||
* | clean up pk delclaration in `create_table` | Aaron Patterson | 2013-03-14 | 1 | -1/+8 |
| | |||||
* | you can provide uuid_generate_v4 as the default value for uuid columns | Aaron Patterson | 2013-03-14 | 1 | -1/+2 |
| | |||||
* | pg is the only adapter that supports the xml type, so push the method down | Aaron Patterson | 2013-03-14 | 1 | -9/+0 |
| | |||||
* | Apparently people were mutating this array. :'( | Aaron Patterson | 2013-03-14 | 1 | -3/+3 |
| | | | | This reverts commit abba61e2bbe320894ba8449ebdf778a1d2af545b. | ||||
* | hashes are ordered, so just use the columns_hash ivar | Aaron Patterson | 2013-03-14 | 1 | -3/+3 |
| | |||||
* | use the method so we do not depend on internal ivars | Aaron Patterson | 2013-03-14 | 1 | -1/+1 |
| | |||||
* | extract factory method and push common code up to abstract adapter | Aaron Patterson | 2013-03-14 | 1 | -2/+5 |
| | |||||
* | Fix typo [ci skip] | Carlos Antonio da Silva | 2013-03-11 | 1 | -1/+1 |
| | |||||
* | promotes change_column_null to the migrations API | Xavier Noria | 2013-03-11 | 1 | -0/+20 |
| | |||||
* | quick pass over the RDoc of schema_statements.rb [ci skip] | Xavier Noria | 2013-03-11 | 1 | -122/+190 |
| | |||||
* | documents how to DROP DEFAULT [ci skip] | Xavier Noria | 2013-03-11 | 1 | -3/+7 |
| | |||||
* | default the reaping frequency to 10 seconds | Aaron Patterson | 2013-03-11 | 1 | -1/+1 |
| | |||||
* | Make sure options is a hash | Rafael Mendonça França | 2013-03-08 | 1 | -1/+3 |
| | |||||
* | If an index can't be found by column, use the index name. | Ezekiel Smithburg | 2013-03-07 | 1 | -0/+6 |
| | | | | schema_statements uses the column name by default to construct the index name, and then raises an exception if it doesn't exist, even if the name option is specified, which causes #8858. this commit makes index_name_for_remove fall back to constructing the index name to remove based on the name option. | ||||
* | SQLite3 3.6.8+ supports savepoints | Neeraj Singh | 2013-03-07 | 1 | -1/+2 |
| | | | | | http://www.sqlite.org/lang_savepoint.html https://github.com/rails/rails/blob/master/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L130-L132 | ||||
* | `Connection#structure_dump` is no longer used. #9518 | Yves Senn | 2013-03-06 | 1 | -5/+0 |
| | | | | | | | As of ccc6910c we use `mysqldump` to create the `structure.sql`. The old `#structure_dump` code is still in AR but never used. I removed all relevant parts from the code-base. | ||||
* | Support PostgreSQL specific column types when using `change_table`. | Yves Senn | 2013-02-28 | 1 | -4/+8 |
| | | | | | | | | Closes #9480. We use `TableDefinition` for `#create_table` and `Table` for `#change_table`. The PostgreSQL sepcifc types were only defined on `TableDefinition` so I also added them to `Table`. | ||||
* | update docs, change_table does not use TableDefinition. | Yves Senn | 2013-02-28 | 1 | -3/+3 |
| | |||||
* | Revert "Merge pull request #9207 from dylanahsmith/mysql-quote-numeric" | Steve Klabnik | 2013-02-27 | 1 | -8/+2 |
| | | | | | This reverts commit 408227d9c5ed7de26310d72a1a99c1ee02311c63, reversing changes made to dca0b57d03deffc933763482e615c3cf0b9a1d97. | ||||
* | Fix default output for postgres network address types | Erik Peterson | 2013-02-26 | 1 | -0/+11 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-02-26 | 1 | -1/+1 |
|\ | |||||
| * | Typo fix | Carson McDonald | 2013-02-25 | 1 | -1/+1 |
| | | |||||
* | | Indent comment block by two spaces. | Marc Schütz | 2013-02-21 | 1 | -4/+4 |
| | | | | | | | | | | As requested by @fxn https://github.com/schuetzm/rails/commit/743d15bba182df80d003d205690ead988970299c#commitcomment-2661417 | ||||
* | | Add more documentation for create_join_table. | Marc Schütz | 2013-02-20 | 1 | -0/+8 |
| | | | | | | | | | | Explain that it doesn't create indices by default and that it also has a block form. | ||||
* | | also rename indexes when a table or column is renamed | Yves Senn | 2013-02-20 | 1 | -0/+22 |
| | | | | | | | | When a table or a column is renamed related indexes kept their name. This will lead to confusing names. This patch renames related indexes when a column or a table is renamed. Only indexes with names generated by rails will be renamed. Indexes with custom names will not be renamed. | ||||
* | | reserve index name chars for internal rails operations | Yves Senn | 2013-02-20 | 2 | -3/+14 |
| | | | | | | | | | | | | | | | | | | | | | | Some adapter (SQLite3) need to perform renaming operations to support the rails DDL. These rename prefixes operate with prefixes. When an index name already uses up the full space provieded by `index_name_length` these internal operations will fail. This patch introduces `allowed_index_name_length` which respects the amount of characters used for internal operations. It will always be <= `index_name_length` and every adapter can define how many characters need to be reserved. | ||||
* | | Reduced memory leak problem in transactions by lazily updating AR objects ↵ | wangjohn | 2013-02-20 | 1 | -3/+10 |
| | | | | | | | | with new transaction state. If AR object has a callback, the callback will be performed immediately (non-lazily) so the transaction still has to keep records with callbacks. | ||||
* | | Gist URLs are now namespaced | Akira Matsuda | 2013-02-18 | 1 | -4/+4 |
|/ | | | | see: https://github.com/blog/1406-namespaced-gists | ||||
* | Revert "Revert "Merge pull request #9206 from ranjaykrishna/use_define_method"" | Jon Leighton | 2013-02-15 | 1 | -18/+13 |
| | | | | | | This reverts commit 8aa4603a5adaa56c818a7bd1c0b761b4ecca3d3e. Reverting the revert because I reverted the wrong thing! Fail. | ||||
* | Revert "Merge pull request #9206 from ranjaykrishna/use_define_method" | Jon Leighton | 2013-02-15 | 1 | -13/+18 |
| | | | | | | | | | | | | | This reverts commit 1fc6876b57f2e1d31731e74eb4271b5655e746d2, reversing changes made to 0268b5d8cdc3c5a1337462135f0a326a2654ba1a. Reason: failing test 1) Error: test_valid_column(ActiveRecord::ConnectionAdapters::SQLite3AdapterTest): NoMethodError: undefined method `column' for test/cases/adapters/sqlite3/sqlite3_adapter_test.rb:29:in `test_valid_column' | ||||
* | Merge pull request #9206 from ranjaykrishna/use_define_method | Carlos Antonio da Silva | 2013-02-12 | 1 | -18/+13 |
|\ | | | | | Use define method instead of class_eval | ||||
| * | reverted back our changes and added in the new define_method | Ranjay Krishna | 2013-02-12 | 1 | -18/+13 |
| | | |||||
* | | active_record: Quote numeric values compared to string columns. | Dylan Smith | 2013-02-07 | 1 | -2/+8 |
| | | |||||
* | | updates a dynamic method heredoc doc | Xavier Noria | 2013-01-28 | 1 | -2/+2 |
| | | |||||
* | | explains why the query cache checks arel.locked | Xavier Noria | 2013-01-28 | 1 | -0/+2 |
| | | |||||
* | | Fix typo: adaptors => adapters [ci skip] | Carlos Antonio da Silva | 2013-01-27 | 1 | -1/+1 |
| | | |||||
* | | Fix cases where delete_records on a has_many association caused errors | Derek Kraan | 2013-01-27 | 1 | -0/+12 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | because of an ambiguous column name. This happened if the association model had a default scope that referenced a third table, and the third table also referenced the original table (with an identical foreign_key). Mysql requires that ambiguous columns are deambiguated by using the full table.column syntax. Postgresql and Sqlite use a different syntax for updates altogether (and don't tolerate table.name syntax), so the fix requires always including the full table.column and discarding it later for Sqlite and Postgresql. | ||||
* | | Default dead_connection_timeout to 5 | Akira Matsuda | 2013-01-24 | 1 | -1/+1 |
| | | | | | | | | or the ConnectionPool silently fails to close connections inside the Thread | ||||
* | | Add postgresql range types support | bUg | 2013-01-23 | 1 | -0/+3 |
| | | |||||
* | | Refactored transaction state into its own object. Each transaction creates a ↵ | wangjohn | 2013-01-21 | 1 | -5/+24 |
|/ | | | | new transaction state object upon initialization. |