Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Revert naive O(1) table_exists? implementation. | Jon Leighton | 2011-12-13 | 1 | -6/+1 |
| | | | | | | | | | | It was a bad idea to rescue exceptions here. This can interfere with transaction rollbacks which seems to be the cause of current CI failure. Instead, each adapter should implement its own DB-specific O(1) implementation, and we fall back on the generic, slower, implementation otherwise. | ||||
* | don't need a begin / end. | Aaron Patterson | 2011-12-09 | 1 | -6/+4 |
| | |||||
* | squelch table exists? queries. | Aaron Patterson | 2011-12-09 | 1 | -1/+1 |
| | |||||
* | Exceptions should read from the spec configu | Aaron Patterson | 2011-12-08 | 1 | -1/+1 |
| | |||||
* | fix nodocs | Vijay Dev | 2011-12-09 | 1 | -3/+3 |
| | |||||
* | fix comments | Vijay Dev | 2011-12-09 | 1 | -4/+2 |
| | |||||
* | Use a hash to look up column definitions | Aaron Patterson | 2011-12-07 | 1 | -2/+3 |
| | |||||
* | try to normalize the objects passed to column() | Aaron Patterson | 2011-12-07 | 1 | -9/+11 |
| | |||||
* | automatically add the column definition to the columns list if creating a ↵ | Aaron Patterson | 2011-12-07 | 1 | -12/+21 |
| | | | | new one | ||||
* | stop calling String#to_s so frequently | Aaron Patterson | 2011-12-07 | 1 | -3/+4 |
| | |||||
* | Quitoting the table name before querying. | Aaron Patterson | 2011-12-05 | 1 | -1/+1 |
| | |||||
* | Speed up table_exists? for databases with a large number of tables | Jade Rubick | 2011-12-05 | 1 | -1/+6 |
| | | | | | | At New Relic, we have hundreds of thousands of tables, and our migrations took 30 minutes without this similar patch. This cuts it down to a more reasonable amount of time. The rescue false part is ugly, but necessary as far as I can tell. I don't know of a cross-database statement you can make that will work without trapping errors. | ||||
* | push synchronization in to each method. Reduces method calls and makes | Aaron Patterson | 2011-11-29 | 1 | -25/+29 |
| | | | | it clear which methods are synchronized. | ||||
* | Automatic closure of connections in threads is deprecated. For example | Aaron Patterson | 2011-11-29 | 1 | -1/+7 |
| | | | | | | | | | | | | | | | | | the following code is deprecated: Thread.new { Post.find(1) }.join It should be changed to close the database connection at the end of the thread: Thread.new { Post.find(1) Post.connection.close }.join Only people who spawn threads in their application code need to worry about this change. | ||||
* | AbstractAdapter#close can be called to add the connection back to the | Aaron Patterson | 2011-11-29 | 1 | -0/+1 |
| | | | | pool. | ||||
* | Start implementing @reserved_connections in terms of connection leases. | Aaron Patterson | 2011-11-29 | 1 | -3/+3 |
| | |||||
* | Rename `checked_out` to more descriptive `active_connections` | Aaron Patterson | 2011-11-29 | 1 | -3/+3 |
| | |||||
* | Use connection lease to determine "checked_out" connections | Aaron Patterson | 2011-11-29 | 1 | -17/+21 |
| | |||||
* | Deprecate set_primary_key in favour of self.primary_key= | Jon Leighton | 2011-11-29 | 1 | -1/+1 |
| | |||||
* | respond_to? information of AR is not the responsibility of the spec | Aaron Patterson | 2011-11-29 | 1 | -7/+9 |
| | | | | resolver. | ||||
* | remove unused instance variable | Aaron Patterson | 2011-11-28 | 1 | -1/+0 |
| | |||||
* | just check in all connections | Aaron Patterson | 2011-11-28 | 1 | -6/+2 |
| | |||||
* | Move connection resoluion logic to it's own testable class. | Aaron Patterson | 2011-11-28 | 1 | -58/+74 |
| | |||||
* | clean up string => hash conversion for connection pool | Aaron Patterson | 2011-11-28 | 1 | -19/+17 |
| | |||||
* | pools are 1:1 with spec now rather than 1:1 with class | Aaron Patterson | 2011-11-28 | 2 | -4/+8 |
| | |||||
* | break establish_connection to smaller methods | Aaron Patterson | 2011-11-28 | 1 | -30/+40 |
| | |||||
* | oops! I suck! :bomb: | Aaron Patterson | 2011-11-20 | 1 | -1/+0 |
| | |||||
* | pushing caching and visitors down to the connection | Aaron Patterson | 2011-11-19 | 1 | -77/+31 |
| | |||||
* | Revert "Merge pull request #1163 from amatsuda/sexier_migration_31" | Aaron Patterson | 2011-11-17 | 1 | -8/+2 |
| | | | | | | | | | | This reverts commit 0e407a90413d8a19002b85508d811ccdf2190783, reversing changes made to 533a9f84b035756eedf9fdccf0c494dc9701ba72. Conflicts: activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb activerecord/test/cases/migration_test.rb | ||||
* | Revert "Merge pull request #3603 from vijaydev/change_table_without_block_arg" | Aaron Patterson | 2011-11-17 | 1 | -12/+7 |
| | | | | | | | | | This reverts commit 81fad6a270ec3cbbb88553c9f2e8200c34fd4d13, reversing changes made to 23101de283de13517e30c4c3d1ecc65525264886. Conflicts: activerecord/test/cases/migration_test.rb | ||||
* | Adding a deprecation warning for use of the schema_info table. | Aaron Patterson | 2011-11-16 | 1 | -0/+2 |
| | |||||
* | Fix pull request #3609 | Noé Froidevaux | 2011-11-13 | 1 | -1/+1 |
| | |||||
* | Prevent multiple SHOW TABLES calls when a table don't exists in database. | Noé Froidevaux | 2011-11-11 | 1 | -3/+3 |
| | |||||
* | Modify change_table to remove the need for the block argument. | Vijay Dev | 2011-11-11 | 1 | -7/+12 |
| | |||||
* | Checking the arity of the block passed to create_table | Vijay Dev | 2011-11-10 | 1 | -1/+7 |
| | | | | | | A recent change made to create_table does away with the need for the block argument. Checking the arity will prevent the mixing up of the two syntaxes. | ||||
* | self.up, self.down => up, down | Akira Matsuda | 2011-11-07 | 1 | -3/+2 |
| | |||||
* | AR changes to support creating ordered (asc, desc) indexes | Vlad Jebelev | 2011-11-04 | 2 | -2/+30 |
| | |||||
* | Merge pull request #1163 from amatsuda/sexier_migration_31 | Aaron Patterson | 2011-11-04 | 1 | -2/+2 |
|\ | | | | | Sexier migrations | ||||
| * | No "t." for the migration DSL! | Akira Matsuda | 2011-05-20 | 1 | -2/+2 |
| | | | | | | | | | | Now you can omit |t| block parameter and all the t. from your migration code, that means, the syntax looks more Rails-3-ish, like the routes DSL and ActionMailer DSL. Also, this change won't break any of your existing migration files, since the traditional syntax is still available. | ||||
* | | dump_schema_information: explicitly order inserts into schema_migrations table | Laust Rud Jacobsen | 2011-10-31 | 1 | -1/+1 |
| | | | | | | | | | | | | | | This change reduces churn in the db/development_structure.sql file when using :sql as active_record.schema_format, and makes comparing diffs much easier. Test ensures the output SQL-statements are lexically ordered by version. | ||||
* | | Default timestamps to non-null | Mike Perham | 2011-10-14 | 2 | -3/+3 |
| | | |||||
* | | use thread locals and an instance variable within QueryCache#BodyProxy to ↵ | Mark J. Titorenko | 2011-10-07 | 2 | -1/+9 |
| | | | | | | | | maintain appropriate linkage with AR database connection across threads | ||||
* | | Merge pull request #2897 from rsutphin/ar31-remove_connection | Aaron Patterson | 2011-09-06 | 2 | -2/+2 |
| | | | | | | | | Patch for issue #2820 | ||||
* | | Make the logic easier to read | Jon Leighton | 2011-09-06 | 1 | -4/+7 |
| | | |||||
* | | Use new SelectManager#projections= method | Jon Leighton | 2011-08-15 | 1 | -2/+2 |
| | | |||||
* | | use update.key instead of update.ast.key. make better use of select manager. | Jon Leighton | 2011-08-15 | 1 | -2/+2 |
| | | |||||
* | | Refactor building the update manager | Jon Leighton | 2011-08-15 | 1 | -5/+3 |
| | | |||||
* | | Support for multi-table updates with limits, offsets and orders | Jon Leighton | 2011-08-15 | 1 | -0/+3 |
| | | |||||
* | | Support updates with joins. Fixes #522. | Jon Leighton | 2011-08-15 | 1 | -0/+9 |
| | | |||||
* | | Make it the responsibility of the connection to hold onto an ARel visitor ↵ | Jon Leighton | 2011-08-08 | 3 | -20/+41 |
| | | | | | | | | for generating SQL. This improves the code architecture generally, and solves some problems with marshalling. Adapter authors please take note: you now need to define an Adapter.visitor_for method, but it degrades gracefully with a deprecation warning for now. |