Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | Revert "Explicitly included hashes in sentence regarding SQL-injection-safe ↵ | Xavier Noria | 2011-08-04 | 1 | -3/+3 | |
| | | | | | | | | | | | | | | | | forms" Reason: The hash form is secure, and preferred over the array form if possible. This reverts commit 6dc749596c328c44c80f898d5fa860fff6cab783. | |||||
* | | Explicitly included hashes in sentence regarding SQL-injection-safe forms | Pete Campbell | 2011-08-04 | 1 | -3/+3 | |
|/ | ||||||
* | fix after_initialize edge case (close #2074 and close #2175) | Les Fletcher | 2011-07-24 | 1 | -2/+1 | |
| | | | | fix behavior when after_initialize is defined and a block is passed to Base.create | |||||
* | Merge pull request #2185 from castlerock/lazy_load_abstract_adapter | Aaron Patterson | 2011-07-23 | 1 | -2/+0 | |
|\ | | | | | lazy load ConnectionAdapters remove require. | |||||
| * | lazy load ConnectionAdapters remove require. | Vishnu Atrai | 2011-07-22 | 1 | -2/+0 | |
| | | ||||||
* | | Merge pull request #2086 from amatsuda/date_multiparameter_nil | Xavier Noria | 2011-07-23 | 1 | -3/+6 | |
|\ \ | | | | | | | convert multiple Date parameters into a nil if any of its bits were blank | |||||
| * | | convert multiple Date parameters into a nil if any of its bits were blank | Akira Matsuda | 2011-07-15 | 1 | -3/+6 | |
| | | | ||||||
* | | | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2011-07-23 | 1 | -1/+1 | |
|\ \ \ | |_|/ |/| | | ||||||
| * | | use simpler words in docs | Vijay Dev | 2011-07-10 | 1 | -1/+1 | |
| | | | ||||||
* | | | Refactor the code a bit to reduce the duplication | Prem Sichanugrist | 2011-07-17 | 1 | -17/+8 | |
| | | | ||||||
* | | | Raise an ArgumentError if user passing less number of argument in the ↵ | Prem Sichanugrist | 2011-07-17 | 1 | -0/+10 | |
| |/ |/| | | | | | | | | | | | | | | | | | | | | | | | dynamic finder The previous behavior was unintentional, and some people was relying on it. Now the dynamic finder will always expecting the number of arguments to be equal or greater (so you can still pass the options to it.) So if you were doing this and expecting the second argument to be nil: User.find_by_username_and_group("sikachu") You'll now get `ArgumentError: wrong number of arguments (1 for 2).` You'll then have to do this: User.find_by_username_and_group("sikachu", nil) | |||||
* | | Fix and unit test for https://github.com/rails/rails/issues/2059 | Evan Light | 2011-07-14 | 1 | -1/+2 | |
|/ | | | | | | | | | | | | Cache key was incorrectly using timezone-dependent record#updated_at when it should be using a timezone-independent value to generate the cache key Minor refactoring to cache_key timezone test Closes #2059 Adds a test to validate the format of the cache_key for nil and present updated_at values Correctly handles updated_at == nil | |||||
* | Merge pull request #1273 from jeremyf/feature-association-proxy-send | Santiago Pastorino | 2011-07-06 | 1 | -1/+1 | |
|\ | | | | | Addresses an inconsistency in the ActiveRecord::Base.method_missing handl | |||||
| * | Addresses an inconsistency in the ActiveRecord::Base.method_missing handling ↵ | Jeremy Friesen | 2011-05-24 | 1 | -1/+1 | |
| | | | | | | | | of dynamic finder methods and the passing of the &block parameter for :find_by_attributes. | |||||
* | | Use an instance variable to store the current masss assignment options | Andrew White | 2011-07-04 | 1 | -9/+14 | |
| | | ||||||
* | | call super rather than delegating to the other objects equal? method | Aaron Patterson | 2011-06-30 | 1 | -1/+1 | |
| | | ||||||
* | | just alias eql? to == for frewer method calls | Aaron Patterson | 2011-06-30 | 1 | -5/+1 | |
| | | ||||||
* | | Define to_ary on ActiveRecord::Base to return nil. Improve performance of ↵ | Jon Leighton | 2011-06-30 | 1 | -0/+12 | |
| | | | | | | | | Array#flatten under 1.9, see comment for details. | |||||
* | | Merge pull request #1860 from dmathieu/comparison | Aaron Patterson | 2011-06-28 | 1 | -0/+9 | |
|\ \ | | | | | | | Allow comparison on model objects - Closes #1858 | |||||
| * | | comparing different classes returns nil | Damien Mathieu | 2011-06-26 | 1 | -1/+5 | |
| | | | ||||||
| * | | allow comparison on model objects - Closes #1858 | Damien Mathieu | 2011-06-26 | 1 | -0/+5 | |
| | | | ||||||
* | | | remove useless assignment | Aaron Patterson | 2011-06-28 | 1 | -2/+1 | |
| | | | ||||||
* | | | reduce object allocation during AR instantiation | Aaron Patterson | 2011-06-28 | 1 | -0/+2 | |
| | | | ||||||
* | | | remove the check for needs_type_condition? because ensure_proper_type will ↵ | Aaron Patterson | 2011-06-27 | 1 | -2/+3 | |
| | | | | | | | | | | | | pick up the type column | |||||
* | | | stop using && for the short circuit side effect | Aaron Patterson | 2011-06-27 | 1 | -1/+1 | |
| | | | ||||||
* | | | let strings be converted to symbols inside the interpreter | Aaron Patterson | 2011-06-27 | 1 | -2/+2 | |
| | | | ||||||
* | | | avoice paying hash cost if there are no serialized attributes | Aaron Patterson | 2011-06-27 | 1 | -3/+4 | |
| | | | ||||||
* | | | cache column defaults for AR object instantiation | Aaron Patterson | 2011-06-27 | 1 | -0/+6 | |
| | | | ||||||
* | | | AR object instantiation is ~30% faster in the simple case | Aaron Patterson | 2011-06-27 | 1 | -1/+1 | |
| | | | ||||||
* | | | initialize instance variables | Aaron Patterson | 2011-06-27 | 1 | -0/+2 | |
|/ / | ||||||
* | | Perf fix - Use an instance variable instead of a class_attribute. Thanks ↵ | Jon Leighton | 2011-06-16 | 1 | -8/+4 | |
| | | | | | | | | @josevalim and @jhawthorn for the prompting. | |||||
* | | Pass mass-assignment options to nested models - closes #1673. | Andrew White | 2011-06-13 | 1 | -3/+6 | |
| | | ||||||
* | | don't reinitialize the arel_table unless the table_name changes | Damien Mathieu | 2011-06-09 | 1 | -1/+2 | |
| | | ||||||
* | | No need to create a new Arel::Table, as the arel_table method already ↵ | Rodrigo Navarro | 2011-06-08 | 1 | -1/+0 | |
| | | | | | | | | creates a new one | |||||
* | | remove warning: assigned but unused variable | Santiago Pastorino | 2011-06-08 | 1 | -1/+1 | |
| | | ||||||
* | | Raise NameError instead of ArgumentError in ActiveSupport::Dependencies | Andrew White | 2011-06-01 | 1 | -1/+0 | |
| | | | | | | | | | | | | | | | | ActiveSupport::Dependencies now raises NameError if it finds an existing constant in load_missing_constant. This better reflects the nature of the error which is usually caused by calling constantize on a nested constant. Closes #1423 | |||||
* | | Merge pull request #1285 from joshk/remove_active_record_deprecations | Aaron Patterson | 2011-05-25 | 1 | -15/+2 | |
|\ \ | | | | | | | removed deprecated methods, and related tests, from ActiveRecord | |||||
| * | | removed deprecated methods, and related tests, from ActiveRecord | Josh Kalderimis | 2011-05-25 | 1 | -15/+2 | |
| | | | ||||||
* | | | Fix the AR::Base#inspect method [closes #1294] | Franck Verrot | 2011-05-25 | 1 | -6/+10 | |
|/ / | ||||||
* / | Fix infinite recursion where a lazy default scope references a scope. Fixes ↵ | Jon Leighton | 2011-05-25 | 1 | -3/+12 | |
|/ | | | | #1264. | |||||
* | Merge pull request #1180 from Karunakar/documentation_change | Xavier Noria | 2011-05-21 | 1 | -3/+13 | |
|\ | | | | | Documentation Error Fixed for ticket #839 | |||||
| * | Documentation Error Fixed for ticket #839 | Karunakar (Ruby) | 2011-05-21 | 1 | -3/+13 | |
| | | ||||||
* | | Merge pull request #1162 from guilleiguaran/singularize_individual_table_name | Jon Leighton | 2011-05-21 | 1 | -2/+2 | |
|\ \ | |/ |/| | Singularize individual table name | |||||
| * | Allow pluralize_table_names for individual model | Guillermo Iguaran | 2011-05-20 | 1 | -2/+2 | |
| | | ||||||
* | | Syntax cleanup: for in => each | Guillermo Iguaran | 2011-05-19 | 1 | -1/+1 | |
|/ | ||||||
* | Add doc to #attribute_names | Sebastian Martinez | 2011-05-15 | 1 | -0/+3 | |
| | ||||||
* | Add ActiveRecord::attribute_names to retrieve a list of attribute names. ↵ | Prem Sichanugrist | 2011-05-15 | 1 | -0/+8 | |
| | | | | This method will also return an empty array on an abstract class or a model that the table doesn't exists. | |||||
* | Fix assigning protected attributes by attributes= | knapo | 2011-05-11 | 1 | -4/+3 | |
| | ||||||
* | fix bug in usage example of #unscoped | Corin Langosch | 2011-05-11 | 1 | -1/+1 | |
| | ||||||
* | Ensure assign_attributes and update_attributes do not fail on nil, closes #478. | José Valim | 2011-05-10 | 1 | -0/+2 | |
| |