aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/attribute_methods
Commit message (Collapse)AuthorAgeFilesLines
* make sure de-serialization happens on object instantiationAaron Patterson2011-02-012-3/+2
|
* store the serialized column values in the @attributes hashAaron Patterson2011-02-011-1/+2
|
* move the coders to the serialized_attributes hashAaron Patterson2011-02-011-7/+3
|
* Make before_type_cast available for datetime fieldsAkira Matsuda2011-02-011-2/+3
| | | | | | [#3973 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* use an identity conversion to avoid conditional codesAaron Patterson2011-01-281-2/+2
|
* join the cult of cargo. reduce the number of NoMethodErrors in the systemAaron Patterson2011-01-071-1/+1
|
* no need for to_symAaron Patterson2011-01-071-1/+1
|
* String#insert() mutates the string, so no need for lasgnAaron Patterson2011-01-071-1/+1
|
* fewer funcalls to the cached attributes variableAaron Patterson2011-01-071-1/+1
|
* stop redifining methods on every call to set_primary_keyAaron Patterson2010-12-241-4/+11
|
* returning id (for some yet to be discovered reason)Aaron Patterson2010-12-201-1/+1
|
* define_attr_method must serialize nil correctlyAaron Patterson2010-12-201-2/+6
|
* if there is no base name, we cannot determine a primary keyAaron Patterson2010-12-201-2/+4
|
* remove some lasignsAaron Patterson2010-12-201-6/+6
|
* Ensure that boolean false is properly serialized [#6079 state:resolved]Aditya Sanghi2010-12-081-1/+2
|
* Fix indentation hereSantiago Pastorino2010-12-041-7/+8
|
* attributes_before_type_cast are just the value of @attributesSantiago Pastorino2010-12-041-1/+1
|
* class inheritable attributes is used no more! all internal use of class ↵Josh Kalderimis2010-11-202-3/+6
| | | | | | inheritable has been changed to class_attribute. class inheritable attributes has been deprecated. Signed-off-by: José Valim <jose.valim@gmail.com>
* use persisted? instead of new_record? wherever possibleDavid Chelimsky2010-11-091-3/+4
| | | | | | | | | | | - persisted? is the API defined in ActiveModel - makes it easier for extension libraries to conform to ActiveModel APIs without concern for whether the extended object is specifically ActiveRecord [#5927 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Make should_record_timestamps? serialization aware rather than object#changed?Pratik Naik2010-11-021-4/+0
|
* Ensure save always updates timestamps when serialized attributes are presentPratik Naik2010-11-021-0/+4
|
* No need for parenthesis hereSantiago Pastorino2010-10-171-1/+1
|
* no need to check for nilNeeraj Singh2010-10-171-1/+1
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* No need to use inject here, use map instead.Emilio Tagua2010-09-221-4/+1
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Cheaper attribute reads and respond_to?. Add underscore-prefixed method ↵Jeremy Kemper2010-09-092-5/+10
| | | | aliased to the attribute name so it can be overridden but still called internally.
* Cache unserialized attributesJeremy Kemper2010-09-091-5/+9
|
* Replacing superclass_delegating_accessoror with class_attribute.Neeraj Singh2010-08-311-1/+1
| | | | | | | :partial_attributes will have value true or false so there is no danger of mutability here. Signed-off-by: José Valim <jose.valim@gmail.com>
* Revert "Makes AR use AMo to_key implementation"Santiago Pastorino2010-08-151-0/+6
| | | | This reverts commit 36a84a4f15f29b41c7cac2f8de410055006a8a8d.
* Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵Santiago Pastorino2010-08-142-2/+2
| | | | 's/[ \t]*$//' -i {} \;)
* Makes AR use AMo to_key implementationSantiago Pastorino2010-08-131-6/+0
| | | | [#5249]
* ensuring that description does not exceed 100 columnsNeeraj Singh2010-08-022-3/+4
|
* Make sure timestamp is properly referencedBlake Smith2010-05-111-1/+1
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Make sure valid? preceives the context as in ActiveModel API (ht: Carlos ↵José Valim2010-05-101-1/+1
| | | | Antonio)
* eliminate alias_method_chain from ActiveRecordwycats2010-05-091-50/+50
|
* fix stack trace lines on class_evalSantiago Pastorino2010-04-091-4/+4
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Dirty datetime attributes should be aware of time zone info [#3658 ↵Kristopher Murata2010-04-081-0/+6
| | | | | | state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Fix dom_id for ActiveRecord [#4296 state:resolved]José Valim2010-03-301-16/+6
|
* adds missing requires for Object#blank? and Object#present?Xavier Noria2010-03-282-0/+4
|
* fisting uninitialized ivar warnings. [#4198 state:resolved]Aaron Patterson2010-03-161-8/+8
| | | | Signed-off-by: wycats <wycats@gmail.com>
* clean up more warnings, remove unnecessary methods, fix eval line numbers. ↵Aaron Patterson2010-03-161-1/+1
| | | | | | [#4193 state:resolved] Signed-off-by: wycats <wycats@gmail.com>
* Add to_key and to_param methods to ActiveModel::Conversion.José Valim2010-02-211-1/+1
|
* AMo #key is now #to_key and CI is probably happysnusnu2010-02-201-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Obviously #key is a too common name to be included in the AMo interface, #to_key fits better and also relates nicely to #to_param. Thx wycats, koz and josevalim for the suggestion. AR's #to_key implementation now takes customized primary keys into account and there's a testcase for that too. The #to_param AMo lint makes no assumptions on how the method behaves in the presence of composite primary keys. It leaves the decision wether to provide a default, or to raise and thus signal to the user that implementing this method will need his special attention, up to the implementers. All AMo cares about is that #to_param is implemented and returns nil in case of a new_record?. The default CompliantObject used in lint_test provides a naive default implementation that just joins all key attributes with '-'. The #to_key default implementation in lint_test's CompliantObject now returns [id] instead of [1]. This was previously causing the (wrong) tests I added for AR's #to_key implementation to pass. The #to_key tests added with this patch should be better. The CI failure was caused by my lack of knowledge about the test:isolated task. The tests for the record_identifier code in action_controller are using fake non AR models and I forgot to stub the #to_key method over there. This issue didn't come up when running the test task, only test:isolated revealed it. This patch fixes that. All tests pass isolated or not, well, apart from one previously unpended test in action_controller that is unrelated to my patch.
* Adds #key and #to_param to the AMo interfacesnusnu2010-02-191-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit introduces two new methods that every AMo compliant object must implement. Below are the default implementations along with the implied interface contract. # Returns an Enumerable of all (primary) key # attributes or nil if new_record? is true def key new_record? ? nil : [1] end # Returns a string representing the object's key # suitable for use in URLs, or nil if new_record? # is true def to_param key ? key.first.to_s : nil end 1) The #key method Previously rails' record_identifier code, which is used in the #dom_id helper, relied on calling #id on the record to provide a reasonable DOM id. Now with rails3 being all ORM agnostic, it's not safe anymore to assume that every record ever will have an #id as its primary key attribute. Having a #key method available on every AMo object means that #dom_id can be implemented using record.to_model.key # instead of record.id Using this we're able to take composite primary keys into account (e.g. available in datamapper) by implementing #dom_id using a newly added record_key_for_dom_id(record) method. The user can overwrite this method to provide customized versions of the object's key used in #dom_id. Also, dealing with more complex keys that can contain arbitrary strings, means that we need to make sure that we only provide DOM ids that are valid according to the spec. For this reason, this patch sends the key provided through a newly added sanitize_dom_id(candidate_id) method, that makes sure we only produce valid HTML The reason to not just add #dom_id to the AMo interface was that it feels like providing a DOM id should not be a model concern. Adding #dom_id to the AMo interface would force these concern on the model, while it's better left to be implemented in a helper. Now one could say the same is true for #to_param, and actually I think that it doesn't really fit into the model either, but it's used in AR and it's a main part of integrating into the rails router. This is different from #dom_id which is only used in view helpers and can be implemented on top of a semantically more meaningful method like #key. 2) The #to_param method Since the rails router relies on #to_param to be present, AR::Base implements it and returns the id by default, allowing the user to overwrite the method if desired. Now with different ORMs integrating into rails, every ORM railtie needs to implement it's own #to_param implementation while already providing code to be AMo compliant. Since the whole point of AMo compliance seems to be to integrate any ORM seamlessly into rails, it seems fair that all we really need to do as another ORM, is to be AMo compliant. By including #to_param into the official interface, we can make sure that this code can be centralized in the various AMo compliance layers, and not be added separately by every ORM railtie. 3) All specs pass
* Revert "Refactoring attributes/types" [#3348 state:open]Pratik Naik2010-01-225-22/+117
| | | | | | | | | | | | | | | | | This reverts commit f936a1f100e75082081e782e5cceb272885c2df7. Conflicts: activerecord/lib/active_record.rb activerecord/lib/active_record/base.rb Revert "Fixed: #without_typecast should only disable typecasting on the duplicated attributes" [#3387 state:open] This reverts commit 2831996483c6a045f1f38d8030256eb58d9771c3. Reason : It's not generating attribute methods properly, making object.column 5x slower.
* Object#tap is not needed for Ruby >= 1.8.7Xavier Noria2009-11-091-2/+0
|
* Refactoring attributes/types [#3348 state:resolved]Eric Chapweske2009-10-175-117/+22
| | | | Signed-off-by: Joshua Peek <josh@joshpeek.com>
* I added this feature so that a Map of changed fields could be retrievedJosh Sharpe2009-08-311-2/+9
| | | | | | | | | | | | | | | | | | | | after a model had been saved. This is useful in the after_save callback when you need to know what fields changed. At present there is no way to do this other than have code in the before_save callback that takes a copy of the changes Map, which I thought was a bit messy. Example. person = Person.find_by_name('bob') person.name = 'robert' person.changes # => {'name' => ['bob, 'robert']} person.save person.changes # => {} person.previous_changes # => {'name' => ['bob, 'robert']} person.reload person.previous_changes # => {} Signed-off-by: Joshua Peek <josh@joshpeek.com>
* Extract common dirty tracking methods in AMoJoshua Peek2009-08-101-114/+9
|
* AMo overrides alias_attribute and manages aliasing all known attribute ↵Joshua Peek2009-08-101-17/+0
| | | | method matchers
* Serialized attributes should only be saved with partial_updates when the ↵Mike Breen2009-08-091-1/+1
| | | | | | serialized attribute is present [#2397 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-05 08:12:14 +0000