Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Rename attribute related instance variables to better express intent | Sean Griffin | 2014-05-30 | 6 | -16/+16 | |
| | | | | | | | | | `@attributes` was actually used for `_before_type_cast` and friends, while `@attributes_cache` is the type cast version (and caching is the wrong word there, but I'm working on removing the conditionals around that). I opted for `@raw_attributes`, because `_before_type_cast` is also semantically misleading. The values in said hash are in the state given by the form builder or database, so raw seemed to be a good word. | |||||
* | Don't reference comments that do not exist | Sean Griffin | 2014-05-29 | 1 | -2/+0 | |
| | ||||||
* | Move `type_cast_for_write` behavior over to the serialized type object | Sean Griffin | 2014-05-29 | 2 | -48/+8 | |
| | ||||||
* | Refactor serialized types to be partially defined as custom properties | Sean Griffin | 2014-05-29 | 1 | -20/+6 | |
| | | | | | | | Many of the methods defined in `AttributeMethods::Serialization` can be refactored onto this type as well, but this is a reasonable small step. Removes the `Type` class, and the need for `decorate_columns` to handle serialized types. | |||||
* | Add an interface for type objects to control Ruby => SQL | Sean Griffin | 2014-05-26 | 2 | -8/+4 | |
| | | | | | Adds the ability to save custom types, which type cast to non-primitive ruby objects. | |||||
* | Merge pull request #14613 from Sirupsen/fix-serialize-update-column | Rafael Mendonça França | 2014-05-21 | 2 | -14/+30 | |
|\ | | | | | | | | | | | | | Fix serialized field returning serialized data after update_column Conflicts: activerecord/CHANGELOG.md | |||||
| * | Fix serialized field returning serialized data after update_column | Simon Eskildsen | 2014-04-05 | 2 | -14/+30 | |
| | | ||||||
* | | Remove :timestamp column type | Sean Griffin | 2014-05-19 | 2 | -4/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | The `:timestamp` type for columns is unused. All database adapters treat them as the same database type. All code in `ActiveRecord` which changes its behavior based on the column's type acts the same in both cases. However, when the type is passed to code that checks for the `:datetime` type, but not `:timestamp` (such as XML serialization), the result is unexpected behavior. Existing schema definitions will continue to work, and the `timestamp` type is transparently aliased to `datetime`. | |||||
* | | docs, double meaning of `serialize` argument. Closes #14284. | Yves Senn | 2014-04-14 | 1 | -5/+16 | |
|/ | | | | | | | | The second argument to serialize has double meaning: * `class_name` of the Type to serialize * `coder` to use then serializing. The new variable name and the docs better describe that behavior. | |||||
* | [Active Record] Renamed private methods create_record and update_record | Prathamesh Sonpatki | 2014-02-20 | 1 | -2/+2 | |
| | | | | | | This is to ensure that they are not accidentally called by the app code. They are renamed to _create_record and _update_record respectively. Closes #11645 | |||||
* | Aesthetic | Rafael Mendonça França | 2014-01-29 | 1 | -6/+5 | |
| | ||||||
* | Fixing issue with activerecord serialization not being able to dump a record ↵ | Mauricio Linhares | 2014-01-29 | 1 | -0/+11 | |
| | | | | after loading it from YAML - fixes #13861 | |||||
* | Merge pull request #13799 from kbrock/better_dirty | Jeremy Kemper | 2014-01-22 | 2 | -1/+29 | |
|\ | | | | | Better ActiveRecord hierarchy for Dirty and others | |||||
| * | Move changed_attributes into dirty.rb | Keenan Brock | 2014-01-22 | 2 | -1/+29 | |
| | | | | | | Move serialization dirty into serialization.rb | |||||
* | | Add more tests for the dirty feature for enums | Rafael Mendonça França | 2014-01-21 | 1 | -1/+0 | |
| | | ||||||
* | | Extract all attribute changed work to its own method | Rafael Mendonça França | 2014-01-21 | 1 | -3/+7 | |
|/ | | | | This will make easier to hook on this feature to customize the behavior | |||||
* | Fix typo: data --> date | Alex Ghiculescu | 2013-12-19 | 1 | -1/+1 | |
| | ||||||
* | Merge branch 'master' of github.com:rails/docrails | Vijay Dev | 2013-11-07 | 1 | -0/+3 | |
|\ | ||||||
| * | warning about saving models with dirty attributes | Damien Mathieu | 2013-10-23 | 1 | -0/+3 | |
| | | | | | | | | See #8328 | |||||
* | | `ActiveRecord::Store` works together with PG `hstore` columns. | Yves Senn | 2013-10-25 | 1 | -0/+4 | |
|/ | | | | | | This is necessary because as of 5ac2341 `hstore` columns are always stored as `Hash` with `String` keys. `ActiveRecord::Store` expected the attribute to be an instance of `HashWithIndifferentAccess`, which led to the bug. | |||||
* | Merge pull request #10816 from bogdan/less-dirty-dirty | Rafael Mendonça França | 2013-09-23 | 1 | -9/+6 | |
| | | | | Make AM::Dirty less dirty to plugin into AR or other library | |||||
* | Merge pull request #12188 from SamSaffron/master | Aaron Patterson | 2013-09-11 | 1 | -7/+8 | |
|\ | | | | | Perf: avoid dupes add fallback logic for coders | |||||
| * | Perf: avoid dupes add fallback logic for coders | Sam | 2013-09-11 | 1 | -7/+8 | |
| | | ||||||
* | | Perf: avoid array allocation where not needed | Sam | 2013-08-27 | 1 | -1/+1 | |
|/ | ||||||
* | method transplanting between modules isn't supported on 1.9 | Aaron Patterson | 2013-07-03 | 2 | -10/+51 | |
| | ||||||
* | refactor the method cache objects to have a superclass | Aaron Patterson | 2013-07-03 | 2 | -51/+16 | |
| | ||||||
* | keep a cache of writer methods | Aaron Patterson | 2013-07-03 | 1 | -11/+34 | |
| | ||||||
* | move the reader method cache in to the read module | Aaron Patterson | 2013-07-03 | 1 | -1/+49 | |
| | ||||||
* | keep a cache of the reader methods so we can reuse them | Aaron Patterson | 2013-07-03 | 1 | -34/+2 | |
| | ||||||
* | reduce the amount of code Ruby has to parse | Aaron Patterson | 2013-07-02 | 1 | -3/+8 | |
| | ||||||
* | making the comment more accurate | Aaron Patterson | 2013-07-02 | 1 | -2/+5 | |
| | ||||||
* | stop storing multiple copies of a particular attribute name | Aaron Patterson | 2013-07-02 | 2 | -4/+6 | |
| | ||||||
* | eagerly assign the attribute name cache, remove const_missing | Aaron Patterson | 2013-07-02 | 2 | -0/+4 | |
| | ||||||
* | Removed deprecated methods partial_updates and family | Neeraj Singh | 2013-07-02 | 1 | -11/+0 | |
| | | | | | Removed deprecated methods `partial_updates`, `partial_updates?` and `partial_updates=` | |||||
* | fix serialization type cast when value is already unserialized | Jan Berdajs | 2013-06-05 | 1 | -1/+5 | |
| | ||||||
* | the typecast value should be passed to the serializer. fixes #10830 | Aaron Patterson | 2013-06-05 | 1 | -5/+5 | |
| | ||||||
* | Remove instance level serialized_attributes setting was deprecated. | kennyj | 2013-06-02 | 1 | -7/+0 | |
| | ||||||
* | read_attribute_before_type_cast should accept symbol | Neeraj Singh | 2013-05-11 | 1 | -1/+2 | |
| | ||||||
* | fix :nodoc: mark on AR::AttributeMethods::Serialization [ci skip] | Francesco Rodriguez | 2013-04-12 | 1 | -2/+2 | |
| | ||||||
* | update ActiveRecord::AttributeMethods::Serialization documentation [ci skip] | Francesco Rodriguez | 2013-04-04 | 1 | -0/+7 | |
| | ||||||
* | safely publish columns and columns hash info | Aaron Patterson | 2013-03-14 | 1 | -1/+1 | |
| | ||||||
* | assigning '0.0' to a nullable numeric column does not make it dirty | Yves Senn | 2013-03-05 | 1 | -1/+5 | |
| | ||||||
* | Reduced memory leak problem in transactions by lazily updating AR objects ↵ | wangjohn | 2013-02-20 | 1 | -0/+5 | |
| | | | | with new transaction state. If AR object has a callback, the callback will be performed immediately (non-lazily) so the transaction still has to keep records with callbacks. | |||||
* | Gist URLs are now namespaced | Akira Matsuda | 2013-02-18 | 1 | -1/+1 | |
| | | | | see: https://github.com/blog/1406-namespaced-gists | |||||
* | Simplify type casting code for timezone aware attributes | Andrew White | 2013-01-26 | 1 | -10/+5 | |
| | | | | | | With the addition of String#in_time_zone and Date#in_time_zone we can simplify the type casting code by checking if the value has an `in_time_zone` method. | |||||
* | Fix handling of dirty time zone aware attributes | Lilibeth De La Cruz | 2013-01-26 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, when `time_zone_aware_attributes` were enabled, after changing a datetime or timestamp attribute and then changing it back to the original value, `changed_attributes` still tracked the attribute as changed. This caused `[attribute]_changed?` and `changed?` methods to return true incorrectly. Example: in_time_zone 'Paris' do order = Order.new original_time = Time.local(2012, 10, 10) order.shipped_at = original_time order.save order.changed? # => false # changing value order.shipped_at = Time.local(2013, 1, 1) order.changed? # => true # reverting to original value order.shipped_at = original_time order.changed? # => false, used to return true end | |||||
* | Revert "Round usec when writing timestamp attribute." | Andrew White | 2013-01-22 | 1 | -13/+5 | |
| | | | | | | | | | | This reverts commit e9d2ad395ec2ef929d74752f3d71c80674044fbe. Closes #8460 Conflicts: activerecord/lib/active_record/attribute_methods/time_zone_conversion.rb activerecord/test/cases/dirty_test.rb | |||||
* | change unless !blank? to if blank? in get_primary_key | Angelo capilleri | 2013-01-08 | 1 | -1/+1 | |
| | ||||||
* | These are already required through AS/rails | Akira Matsuda | 2013-01-07 | 1 | -1/+0 | |
| | | | | | | * dependencies/autoload * concern * deprecation | |||||
* | Rename update_attributes method to update, keep update_attributes as an alias | Amparo Luna + Guillermo Iguaran | 2013-01-03 | 1 | -2/+2 | |
| |