Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fixes performance issue introduced in 3.0.6 (issue #6695) | Stian Grytøyr | 2011-04-14 | 1 | -3/+5 |
| | |||||
* | Remove `#among?` from Active Support | Prem Sichanugrist | 2011-04-13 | 1 | -1/+1 |
| | | | | | | After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now. It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`. | ||||
* | Change Object#either? to Object#among? -- thanks to @jamesarosen for the ↵ | David Heinemeier Hansson | 2011-04-12 | 1 | -1/+1 |
| | | | | suggestion! | ||||
* | Using Object#in? and Object#either? in various places | Prem Sichanugrist | 2011-04-11 | 1 | -1/+2 |
| | | | | There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?. | ||||
* | Quote find_in_batches ORDER BY clause [#6620 state:resolved] | Andrew White | 2011-03-29 | 1 | -1/+12 |
| | |||||
* | Added new #update_column method. | Sebastian Martinez | 2011-03-27 | 1 | -0/+1 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Fix before_type_cast for timezone aware attributes by caching converted ↵ | Adam Meehan | 2011-03-23 | 1 | -4/+5 |
| | | | | value on write. Also remove read method reload arg on timezone attributes. | ||||
* | use class_eval with a string when it's possible | Santiago Pastorino | 2011-03-22 | 2 | -5/+13 |
| | |||||
* | Allow to read and write AR attributes with non valid identifiers | Santiago Pastorino | 2011-03-22 | 2 | -2/+7 |
| | |||||
* | Merge remote branch 'rails/master' into identity_map | Emilio Tagua | 2011-02-15 | 3 | -26/+37 |
|\ | | | | | | | | | | | | | | | | | | | | | | | Conflicts: activerecord/examples/performance.rb activerecord/lib/active_record/association_preload.rb activerecord/lib/active_record/associations.rb activerecord/lib/active_record/associations/association_proxy.rb activerecord/lib/active_record/autosave_association.rb activerecord/lib/active_record/base.rb activerecord/lib/active_record/nested_attributes.rb activerecord/test/cases/relations_test.rb | ||||
| * | primary keys should not be cleared on cache clear, fixing oracle tests | Aaron Patterson | 2011-02-08 | 1 | -0/+1 |
| | | |||||
| * | avoid nil.dup | Akira Matsuda | 2011-02-07 | 1 | -1/+1 |
| | | | | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
| * | make sure de-serialization happens on object instantiation | Aaron Patterson | 2011-02-01 | 2 | -3/+2 |
| | | |||||
| * | store the serialized column values in the @attributes hash | Aaron Patterson | 2011-02-01 | 1 | -1/+2 |
| | | |||||
| * | move the coders to the serialized_attributes hash | Aaron Patterson | 2011-02-01 | 1 | -7/+3 |
| | | |||||
| * | Make before_type_cast available for datetime fields | Akira Matsuda | 2011-02-01 | 1 | -2/+3 |
| | | | | | | | | | | | | [#3973 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
| * | use an identity conversion to avoid conditional codes | Aaron Patterson | 2011-01-28 | 1 | -2/+2 |
| | | |||||
| * | join the cult of cargo. reduce the number of NoMethodErrors in the system | Aaron Patterson | 2011-01-07 | 1 | -1/+1 |
| | | |||||
| * | no need for to_sym | Aaron Patterson | 2011-01-07 | 1 | -1/+1 |
| | | |||||
| * | String#insert() mutates the string, so no need for lasgn | Aaron Patterson | 2011-01-07 | 1 | -1/+1 |
| | | |||||
| * | fewer funcalls to the cached attributes variable | Aaron Patterson | 2011-01-07 | 1 | -1/+1 |
| | | |||||
| * | stop redifining methods on every call to set_primary_key | Aaron Patterson | 2010-12-24 | 1 | -4/+11 |
| | | |||||
| * | returning id (for some yet to be discovered reason) | Aaron Patterson | 2010-12-20 | 1 | -1/+1 |
| | | |||||
| * | define_attr_method must serialize nil correctly | Aaron Patterson | 2010-12-20 | 1 | -2/+6 |
| | | |||||
| * | if there is no base name, we cannot determine a primary key | Aaron Patterson | 2010-12-20 | 1 | -2/+4 |
| | | |||||
| * | remove some lasigns | Aaron Patterson | 2010-12-20 | 1 | -6/+6 |
| | | |||||
* | | Merge remote branch 'rails/master' into identity_map | Emilio Tagua | 2010-12-20 | 4 | -12/+17 |
|\| | | | | | | | | | | | | | | | Conflicts: activerecord/lib/active_record/associations/association_proxy.rb activerecord/lib/active_record/autosave_association.rb activerecord/lib/active_record/base.rb activerecord/lib/active_record/persistence.rb | ||||
| * | Ensure that boolean false is properly serialized [#6079 state:resolved] | Aditya Sanghi | 2010-12-08 | 1 | -1/+2 |
| | | |||||
| * | Fix indentation here | Santiago Pastorino | 2010-12-04 | 1 | -7/+8 |
| | | |||||
| * | attributes_before_type_cast are just the value of @attributes | Santiago Pastorino | 2010-12-04 | 1 | -1/+1 |
| | | |||||
| * | class inheritable attributes is used no more! all internal use of class ↵ | Josh Kalderimis | 2010-11-20 | 2 | -3/+6 |
| | | | | | | | | | | | | inheritable has been changed to class_attribute. class inheritable attributes has been deprecated. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | Remove objects from identity map if save! failed, otherwise finding again ↵ | Emilio Tagua | 2010-11-19 | 1 | -0/+3 |
| | | | | | | | | the same record will have invalid attributes. | ||||
* | | Remove objects from identity map if save failed, otherwise finding again the ↵ | Emilio Tagua | 2010-11-19 | 1 | -0/+2 |
|/ | | | | same record will have invalid attributes. | ||||
* | use persisted? instead of new_record? wherever possible | David Chelimsky | 2010-11-09 | 1 | -3/+4 |
| | | | | | | | | | | | - persisted? is the API defined in ActiveModel - makes it easier for extension libraries to conform to ActiveModel APIs without concern for whether the extended object is specifically ActiveRecord [#5927 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Make should_record_timestamps? serialization aware rather than object#changed? | Pratik Naik | 2010-11-02 | 1 | -4/+0 |
| | |||||
* | Ensure save always updates timestamps when serialized attributes are present | Pratik Naik | 2010-11-02 | 1 | -0/+4 |
| | |||||
* | No need for parenthesis here | Santiago Pastorino | 2010-10-17 | 1 | -1/+1 |
| | |||||
* | no need to check for nil | Neeraj Singh | 2010-10-17 | 1 | -1/+1 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | No need to use inject here, use map instead. | Emilio Tagua | 2010-09-22 | 1 | -4/+1 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Cheaper attribute reads and respond_to?. Add underscore-prefixed method ↵ | Jeremy Kemper | 2010-09-09 | 2 | -5/+10 |
| | | | | aliased to the attribute name so it can be overridden but still called internally. | ||||
* | Cache unserialized attributes | Jeremy Kemper | 2010-09-09 | 1 | -5/+9 |
| | |||||
* | Replacing superclass_delegating_accessoror with class_attribute. | Neeraj Singh | 2010-08-31 | 1 | -1/+1 |
| | | | | | | | :partial_attributes will have value true or false so there is no danger of mutability here. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Revert "Makes AR use AMo to_key implementation" | Santiago Pastorino | 2010-08-15 | 1 | -0/+6 |
| | | | | This reverts commit 36a84a4f15f29b41c7cac2f8de410055006a8a8d. | ||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 2 | -2/+2 |
| | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | Makes AR use AMo to_key implementation | Santiago Pastorino | 2010-08-13 | 1 | -6/+0 |
| | | | | [#5249] | ||||
* | ensuring that description does not exceed 100 columns | Neeraj Singh | 2010-08-02 | 2 | -3/+4 |
| | |||||
* | Make sure timestamp is properly referenced | Blake Smith | 2010-05-11 | 1 | -1/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Make sure valid? preceives the context as in ActiveModel API (ht: Carlos ↵ | José Valim | 2010-05-10 | 1 | -1/+1 |
| | | | | Antonio) | ||||
* | eliminate alias_method_chain from ActiveRecord | wycats | 2010-05-09 | 1 | -50/+50 |
| | |||||
* | fix stack trace lines on class_eval | Santiago Pastorino | 2010-04-09 | 1 | -4/+4 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> |