Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Remove obsolete require to active_record/associations/nested_has_many_through | Jon Leighton | 2010-10-19 | 1 | -1/+0 |
| | |||||
* | Remove various comments and code which were just being used during the ↵ | Jon Leighton | 2010-10-19 | 2 | -162/+0 |
| | | | | development of nested through association support (OMFGZ, I might just have nearly finished this\! | ||||
* | Support the :primary_key option on a through reflection in a nested through ↵ | Jon Leighton | 2010-10-19 | 1 | -5/+2 |
| | | | | association | ||||
* | Bugfix/refactoring | Jon Leighton | 2010-10-19 | 1 | -5/+5 |
| | |||||
* | Support for :primary_key option on the source reflection of a through ↵ | Jon Leighton | 2010-10-19 | 1 | -2/+2 |
| | | | | association, where the source is a has_one or has_many | ||||
* | Respect the :primary_key option on the through_reflection of (non-nested) ↵ | Jon Leighton | 2010-10-19 | 3 | -8/+8 |
| | | | | through associations | ||||
* | Properly support conditions on any of the reflections involved in a nested ↵ | Jon Leighton | 2010-10-19 | 1 | -67/+60 |
| | | | | through association | ||||
* | Refactoring: replace the mix of variables like @finder_sql, @counter_sql, ↵ | Jon Leighton | 2010-10-17 | 10 | -152/+136 |
| | | | | etc with just a single scope hash (created on initialization of the proxy). This is now used consistently across all associations. Therefore, all you have to do to ensure finding/counting etc is done correctly is implement the scope correctly. | ||||
* | Make sure nested through associations are read only | Jon Leighton | 2010-10-15 | 3 | -9/+30 |
| | |||||
* | Added ↵ | Jon Leighton | 2010-10-14 | 1 | -2/+6 |
| | | | | test_has_many_through_has_many_with_has_many_through_habtm_source_reflection and make it pass | ||||
* | Fix bug in previous refactoring | Jon Leighton | 2010-10-14 | 1 | -6/+6 |
| | |||||
* | Add ↵ | Jon Leighton | 2010-10-13 | 1 | -3/+28 |
| | | | | test_has_many_through_has_and_belongs_to_many_with_has_many_source_reflection and make it work | ||||
* | Refactoring ThroughAssociationScope#construct_through_joins | Jon Leighton | 2010-10-13 | 1 | -54/+62 |
| | |||||
* | First bit of support for habtm in through assocs - ↵ | Jon Leighton | 2010-10-13 | 1 | -13/+32 |
| | | | | test_has_many_through_has_many_with_has_and_belongs_to_many_source_reflection now passes | ||||
* | Hook ThroughAssociationScope up to use the AliasTracker class | Jon Leighton | 2010-10-13 | 1 | -9/+30 |
| | |||||
* | Some small tweaks on the last commit | Jon Leighton | 2010-10-12 | 1 | -2/+7 |
| | |||||
* | Extract aliasing code from JoinDependency and JoinAssociation into a ↵ | Jon Leighton | 2010-10-12 | 1 | -0/+68 |
| | | | | separate AliasTracker class. This can then be used by ThroughAssociationScope as well. | ||||
* | Add a commented, failing test for using a habtm in a has many through ↵ | Jon Leighton | 2010-10-12 | 1 | -46/+50 |
| | | | | association. I want to refactor how aliasing works first. | ||||
* | Adding test_has_many_through_has_one_with_has_many_through_source_reflection ↵ | Jon Leighton | 2010-10-12 | 1 | -1/+1 |
| | | | | and modifying ThroughAssociationScope to make it work correctly. | ||||
* | Support has_one through assocs as the source association | Jon Leighton | 2010-10-12 | 1 | -10/+21 |
| | |||||
* | Add support for nested through associations in JoinAssociation. Hence ↵ | Jon Leighton | 2010-10-09 | 1 | -0/+4 |
| | | | | Foo.joins(:bar) will work for through associations. There is some duplicated code now, which will be refactored. | ||||
* | Merge branch 'master' into nested_has_many_through | Jon Leighton | 2010-10-06 | 1 | -0/+12 |
|\ | |||||
| * | Refactor AssociationCollection#include? with objects in memory | Carlos Antonio da Silva | 2010-10-02 | 1 | -4/+3 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | AssociationCollection#include? working properly for objects added with build ↵ | Marcelo Giorgi | 2010-09-30 | 1 | -0/+13 |
| | | | | | | | | method [#3472 state:resolved] | ||||
* | | Add support for table aliasing, with a test that needs aliasing in order to ↵ | Jon Leighton | 2010-10-02 | 1 | -13/+37 |
| | | | | | | | | work correctly. This test incidentally provides a more complicated test case (4 inner joins, 2 using polymorphism). | ||||
* | | Integrate nested support into ThroughAssociationScope, using my concept of ↵ | Jon Leighton | 2010-10-02 | 3 | -37/+55 |
| | | | | | | | | generating a 'chain' of reflections to be joined. It seems to work at the moment, all existing tests are passing. There may be further complications as we add more test cases for nested associations, though. | ||||
* | | Started implementing nested :through associations by using the existing ↵ | Jon Leighton | 2010-10-01 | 2 | -19/+32 |
| | | | | | | | | structure of ThroughAssociationScope rather than layering a module over the top | ||||
* | | Merge branch 'master' into nested_has_many_through_2 | Jon Leighton | 2010-09-30 | 1 | -1/+1 |
|\| | |||||
| * | no need of nil check | Neeraj Singh | 2010-09-29 | 1 | -1/+1 |
| | | |||||
* | | Initial nested_has_many_through support [#1152] | Bodaniel Jeanes | 2010-09-26 | 2 | -0/+158 |
|/ | |||||
* | Refactor association_collection uniq method. | Emilio Tagua | 2010-09-22 | 1 | -4/+3 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Perf: refactor method. | Emilio Tagua | 2010-09-22 | 1 | -11/+8 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | do not pass nil values to arel | Aaron Patterson | 2010-09-21 | 1 | -1/+1 |
| | |||||
* | Use scoped here to get the scoped where | Santiago Pastorino | 2010-09-05 | 1 | -5/+3 |
| | |||||
* | mark SQL literals as SQL literals | Aaron Patterson | 2010-08-25 | 1 | -1/+1 |
| | |||||
* | marking sql literals as sql literals | Aaron Patterson | 2010-08-23 | 1 | -1/+1 |
| | |||||
* | While creating a new record using has_many create method default scope of ↵ | Neeraj Singh | 2010-08-19 | 1 | -1/+6 |
| | | | | | | | | | | | child should be respected. author.posts.create should take into account default_scope defined on post. [#3939: state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 3 | -10/+10 |
| | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | Removing most of the symbol to proc usage in Active Record | Prem Sichanugrist | 2010-08-13 | 1 | -1/+1 |
| | | | | This will hopefully make Active Record run a bit more faster. | ||||
* | removing references to arel constants | Aaron Patterson | 2010-08-13 | 1 | -1/+1 |
| | |||||
* | avoiding symbol to proc again | Aaron Patterson | 2010-08-13 | 1 | -1/+1 |
| | |||||
* | do not use arel constants directly | Aaron Patterson | 2010-08-13 | 1 | -1/+1 |
| | |||||
* | symbol to proc is slow, we should avoid it | Aaron Patterson | 2010-08-13 | 1 | -1/+1 |
| | |||||
* | dry up the hash dup and avoid sending nil values | Aaron Patterson | 2010-08-11 | 2 | -11/+15 |
| | |||||
* | standarizes the use of the article "an" for "SQL" and "SQLite" | Xavier Noria | 2010-08-05 | 1 | -1/+1 |
| | |||||
* | ensuring that description does not exceed 100 columns | Neeraj Singh | 2010-08-02 | 2 | -6/+8 |
| | |||||
* | Don't increment and then decrement the same counter when re-assigning a ↵ | Tarmo Tänav | 2010-07-29 | 1 | -1/+1 |
| | | | | | | | | belongs_to association [#2786 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | fixed joining of attributes when using find_or_create_by with multiple ↵ | Jon Buda | 2010-07-28 | 1 | -1/+1 |
| | | | | | | attributes through an association Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | No need to check for :uniq | Neeraj Singh | 2010-07-26 | 1 | -6/+3 |
| | | | | | | [#5170 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Make use of tap to return a previously used var | Santiago Pastorino | 2010-07-21 | 1 | -4/+4 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> |