Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge branch 'master' into preload | Aaron Patterson | 2013-09-25 | 1 | -3/+3 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (62 commits) Getting Started Guide: Hello Rails! -> Hello, Rails! and wrap code tag Add CHANGELOG entry for #12344 Add regression test to #12343 Fix typo in number_to_human docs: you -> your [Documentation] Add a missing validation to I18n docs Use the given name in html_options for the hidden field in collection_check_boxes assign_attributes should return if argument is blank. No need the else clause Use join to concat the both side of the AST Add a CHANGELOG entry about Web Console inclusion added column type to example in section 2.3 Include web-console in new projects Gemfile ActiveRecord::ConnectionAdapters::Column.string_to_time method respects string with timezone. Closes #12278. add test_scoped_root_as_name Getting Started Guide: update RubyGems Guides link [ci skip] Deprecate unused quoted_locking_column method. Update references to wycats/thor to erikhuda/thor. bcrypt-ruby v3.1.2 supports Ruby 2.0 on Windows Fix the model name in the association basics guides We shouldn't override PostgreSQLAdapter's superclass inheritance while monkeypatching ... | ||||
| * | Merge pull request #10500 from kennyj/fix_10450 | Rafael Mendonça França | 2013-09-22 | 1 | -3/+3 |
| |\ | | | | | | | | | | | | | | | | | | | Fixed a bug in when using has_many association with :inverse_of option and UUID primary key. Conflicts: activerecord/CHANGELOG.md | ||||
| | * | Fixed a bug in when using has_many association with :inverse_of option and ↵ | kennyj | 2013-05-08 | 1 | -3/+3 |
| | | | | | | | | | | | | UUID primary key. | ||||
* | | | remove initialize method | Aaron Patterson | 2013-09-25 | 1 | -4/+0 |
| | | | |||||
* | | | extract association resetting to a method | Aaron Patterson | 2013-09-25 | 1 | -9/+16 |
| | | | |||||
* | | | hash insertion order doesn't matter anymore, so only loop over the | Aaron Patterson | 2013-09-25 | 1 | -4/+2 |
| | | | | | | | | | | | | owners once | ||||
* | | | always populate the preloaded records instance variable so we can remove | Aaron Patterson | 2013-09-25 | 2 | -10/+5 |
| | | | | | | | | | | | | the @associated_records_by_owner ivar | ||||
* | | | keep preloaded records in a list rather than extract from a hash | Aaron Patterson | 2013-09-25 | 3 | -16/+21 |
| | | | |||||
* | | | push slice loading to it's own method so we can remove the type casting | Aaron Patterson | 2013-09-24 | 2 | -24/+20 |
| | | | | | | | | | | | | code | ||||
* | | | guarantee that `klass` is not nil inside the preloader objects | Aaron Patterson | 2013-09-24 | 2 | -5/+12 |
| | | | |||||
* | | | eliminate unused ivar | Aaron Patterson | 2013-09-24 | 1 | -1/+0 |
| | | | |||||
* | | | all records have a preloaded, so eliminate that conditional | Aaron Patterson | 2013-09-24 | 1 | -11/+7 |
| | | | |||||
* | | | eliminate the `loaded?` conditional | Aaron Patterson | 2013-09-24 | 3 | -12/+7 |
| | | | |||||
* | | | push preloaded test up to the factory method so we can eliminate | Aaron Patterson | 2013-09-24 | 3 | -8/+21 |
| | | | | | | | | | | | | conditionals from the individual preloaded classes | ||||
* | | | we can't sort by lhs since the middle records have difference classes | Aaron Patterson | 2013-09-23 | 1 | -19/+19 |
| | | | | | | | | | | | | and possibly different rules for finding those objects | ||||
* | | | pass the preloader down so we only have to construct one | Aaron Patterson | 2013-09-23 | 7 | -21/+21 |
| | | | |||||
* | | | remove state from the preloader | Aaron Patterson | 2013-09-23 | 2 | -27/+16 |
| | | | |||||
* | | | pass the scope all the way down to the constructors | Aaron Patterson | 2013-09-23 | 1 | -10/+10 |
| | | | |||||
* | | | only do the should_reset test once | Aaron Patterson | 2013-09-23 | 1 | -6/+6 |
| | | | |||||
* | | | fix variable names and speed up relation ordering | Aaron Patterson | 2013-09-23 | 2 | -16/+12 |
| | | | |||||
* | | | hm:t preloading will respect order set on the RHS association | Aaron Patterson | 2013-09-23 | 5 | -8/+53 |
| | | | |||||
* | | | cache associated target records hash | Aaron Patterson | 2013-09-20 | 1 | -17/+11 |
| | | | |||||
* | | | combine methods so we can reuse preloaders | Aaron Patterson | 2013-09-20 | 1 | -19/+18 |
| | | | |||||
* | | | return a list rather than hash | Aaron Patterson | 2013-09-20 | 1 | -7/+13 |
| | | | |||||
* | | | preserve order on the RHS query | Aaron Patterson | 2013-09-20 | 1 | -0/+8 |
| | | | |||||
* | | | split up construction and mutation | Aaron Patterson | 2013-09-20 | 1 | -1/+4 |
| | | | |||||
* | | | fix method name | Aaron Patterson | 2013-09-20 | 1 | -3/+5 |
| | | | |||||
* | | | access preloaders independently of model mutations | Aaron Patterson | 2013-09-20 | 1 | -12/+12 |
| | | | |||||
* | | | push running the preloaders up | Aaron Patterson | 2013-09-20 | 1 | -19/+7 |
| | | | |||||
* | | | push `run` up to preload | Aaron Patterson | 2013-09-20 | 3 | -14/+41 |
| | | | |||||
* | | | the hash should only ever be length one, so decompose it | Aaron Patterson | 2013-09-20 | 1 | -4/+5 |
| | | | |||||
* | | | stop depending on preloader interals so we can create fewer preloader | Aaron Patterson | 2013-09-20 | 1 | -19/+23 |
| | | | | | | | | | | | | objects | ||||
* | | | lhs preload is always a single preload, so just preload one | Aaron Patterson | 2013-09-20 | 1 | -3/+3 |
| | | | |||||
* | | | just read the attribute rather than `send`ing | Aaron Patterson | 2013-09-20 | 1 | -1/+1 |
| | | | |||||
* | | | extract exception raising, clean up group_by statement | Aaron Patterson | 2013-09-20 | 1 | -6/+7 |
| | | | |||||
* | | | generate fewer objects when grouping | Aaron Patterson | 2013-09-20 | 1 | -5/+7 |
| | | | |||||
* | | | do not access internal data structures | Aaron Patterson | 2013-09-20 | 1 | -1/+1 |
| | | | |||||
* | | | exposing target records on the preloader | Aaron Patterson | 2013-09-20 | 2 | -16/+29 |
|/ / | |||||
* | | Merge pull request #12137 from lann/fix_association_first_last | Rafael Mendonça França | 2013-09-12 | 1 | -3/+1 |
|\ \ | | | | | | | | | | | | | | | | | | | Make CollectionAssociation first/last with integer fetch with query Conflicts: activerecord/CHANGELOG.md | ||||
| * | | Make CollectionAssociation first/last with integer fetch with query | Lann Martin | 2013-09-09 | 1 | -3/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When first or last is called with an integer on an unloaded association, the entire collection is loaded. This differs surprisingly from the behavior of Relation#first/last, which translate the call into a limit query. For large collections this can make a big difference in performance. Change CollectionAssociation#fetch_first_or_last_using_find? to make this kind of call delegate to Relation. | ||||
* | | | Merge pull request #12135 from dylanahsmith/avoid_empty_transaction | Rafael Mendonça França | 2013-09-11 | 1 | -1/+3 |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | Avoid empty transaction from setting has_one association on new record. Conflicts: activerecord/CHANGELOG.md | ||||
| * | | | Avoid empty transaction from setting has_one association on new record. | Dylan Thacker-Smith | 2013-09-11 | 1 | -1/+2 |
| | | | | |||||
* | | | | Whitespaces | Rafael Mendonça França | 2013-09-11 | 1 | -1/+2 |
| | | | | |||||
* | | | | Merge pull request #12185 from SamSaffron/join_dep | Rafael Mendonça França | 2013-09-11 | 1 | -1/+13 |
|\ \ \ \ | | | | | | | | | | | Reduce allocations when extracting AR models | ||||
| * | | | | Reduce allocations when extracting AR models | Sam | 2013-09-11 | 1 | -1/+13 |
| | | | | | |||||
* | | | | | fix deleting join models with no pk | Aaron Patterson | 2013-09-11 | 1 | -1/+15 |
| |/ / / |/| | | | |||||
* | | | | ask the association for records rather than calling `send` | Aaron Patterson | 2013-09-10 | 1 | -1/+2 |
|/ / / | |||||
* / / | hm:t join tables may not have a primary key | Aaron Patterson | 2013-09-06 | 1 | -1/+5 |
|/ / | |||||
* | | support anonymous classes on has_many associations | Aaron Patterson | 2013-09-03 | 1 | -1/+1 |
| | | |||||
* | | Remove useless comment and white spaces :scissors: [ci skip] | Carlos Antonio da Silva | 2013-09-01 | 2 | -3/+2 |
| | |