Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Don't increment and then decrement the same counter when re-assigning a ↵ | Tarmo Tänav | 2010-07-29 | 1 | -1/+1 |
| | | | | | | | | belongs_to association [#2786 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | fixed joining of attributes when using find_or_create_by with multiple ↵ | Jon Buda | 2010-07-28 | 1 | -1/+1 |
| | | | | | | attributes through an association Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | No need to check for :uniq | Neeraj Singh | 2010-07-26 | 1 | -6/+3 |
| | | | | | | [#5170 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Make use of tap to return a previously used var | Santiago Pastorino | 2010-07-21 | 1 | -4/+4 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Ensure all join table attributes will be in the same timestamp. | José Valim | 2010-07-21 | 1 | -11/+21 |
| | |||||
* | Timestamp columns of HABTM join table should record timestamps | Neeraj Singh | 2010-07-21 | 1 | -1/+5 |
| | | | | [#5161 state:resolved] | ||||
* | association load target shouldn't replace records | Szetobo | 2010-07-21 | 1 | -3/+4 |
| | | | | | | | | from db if it is already loaded by nested attributes assignment [#5053 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | In nested_attributes when association is not loaded and association | Subba Rao Pasupuleti | 2010-07-21 | 1 | -1/+8 |
| | | | | | | | | record is saved and then in memory record attributes should be saved [#5053 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | id is a public method | Santiago Pastorino | 2010-07-21 | 1 | -2/+2 |
| | |||||
* | Ensure that primary_keys of HABTM records is not double quoted | Neeraj Singh | 2010-07-20 | 1 | -2/+2 |
| | | | | [#5152 state:reslved] | ||||
* | Removed warnings when a variable is shadowed | Łukasz Strzałkowski | 2010-07-19 | 1 | -3/+3 |
| | |||||
* | Remove unintentional API changes. [#1108] | Pratik Naik | 2010-07-14 | 1 | -9/+4 |
| | |||||
* | count method should not take options if it is operated on has_many ↵ | Neeraj Singh | 2010-07-13 | 1 | -2/+5 |
| | | | | | | | | association which has finder_sql or counter_sql [#2395 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | string IDs are now quoted correctly [#5064 state:resolved] | Will St. Clair + Neeraj Singh | 2010-07-13 | 1 | -1/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | fix ActiveRecord `destroy_all` so it returns destroyed records | Mislav Marohnić | 2010-07-08 | 1 | -3/+4 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Don't remove scheduled destroys when loading an association. [#4642 ↵ | James Le Cuirot | 2010-07-01 | 1 | -1/+6 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | AssociationCollection#create_by_*, find_or_create_by_* work properly now. ↵ | Aaron Patterson | 2010-06-29 | 1 | -0/+11 |
| | | | | | | [#1108 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | splitting a really long line into multiple lines which is easy on eyes | Neeraj Singh | 2010-06-29 | 1 | -1/+5 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Don't define block, just yield if block is given. | Emilio Tagua | 2010-06-24 | 1 | -7/+7 |
| | |||||
* | Merge remote branch 'rails/master' | Xavier Noria | 2010-06-20 | 1 | -1/+5 |
|\ | | | | | | | | | Conflicts: actionpack/lib/abstract_controller/base.rb | ||||
| * | Don't overwrite unsaved updates when loading an association but preserve the ↵ | James Le Cuirot | 2010-06-20 | 1 | -1/+5 |
| | | | | | | | | | | | | | | | | order of the loaded records. Reapplied from before but now allows already-saved records to be refreshed. [#4830 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | Adds title to activerecord/lib/active_record/associations/* | Rizwan Reza | 2010-06-16 | 10 | -0/+12 |
| | | |||||
* | | Fix a bunch of minor spelling mistakes | Evgeniy Dolzhenko | 2010-06-15 | 1 | -1/+1 |
|\ \ | |||||
| * | | Fix a bunch of minor spelling mistakes | Evgeniy Dolzhenko | 2010-06-11 | 1 | -1/+1 |
| | | | |||||
* | | | Revert "removing the extra \" | Neeraj Singh | 2010-06-15 | 1 | -1/+1 |
| | | | | | | | | | | | | This reverts commit 51a9703b1e80caa30d699f30615f023079874623. | ||||
* | | | removing the extra \ | Neeraj Singh | 2010-06-15 | 1 | -1/+1 |
| |/ |/| | |||||
* | | Revert "Don't overwrite unsaved updates when loading an association but ↵ | José Valim | 2010-06-11 | 1 | -1/+1 |
|/ | | | | | | | | preserve the order of the loaded records. [#4642 state:open]" This commit introduced a regression described in ticket [#4830]. This reverts commit 0265c708b9696c3943518ad5f3dabdc22c5eba11. | ||||
* | Don't overwrite unsaved updates when loading an association but preserve the ↵ | James Le Cuirot | 2010-06-09 | 1 | -1/+1 |
| | | | | | | order of the loaded records. [#4642 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Properly cache association_collection#scopes calls having arguments | Pratik Naik | 2010-06-04 | 1 | -1/+2 |
| | |||||
* | Prevent calling regexp on symbol in Ruby 1.9 in association_proxy | Ernie Miller | 2010-05-05 | 1 | -1/+1 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Ensure not to load the entire association when bulk updating existing ↵ | Pratik Naik | 2010-04-14 | 1 | -10/+10 |
| | | | | records using nested attributes | ||||
* | Avoid deprecated String#to_a by using Array.wrap(...) instead of Array(...) | Jeremy Kemper | 2010-04-10 | 2 | -2/+5 |
| | |||||
* | Some doc updates reflecting the new query API | Pratik Naik | 2010-04-08 | 1 | -1/+1 |
| | |||||
* | Reset named scope cache whenever the @target is reset | Pratik Naik | 2010-04-07 | 1 | -2/+9 |
| | |||||
* | Memoize association.named_scope calls | Pratik Naik | 2010-04-05 | 1 | -0/+3 |
| | |||||
* | Sanitize association conditions using the correct class | Carl Lerche | 2010-04-03 | 1 | -1/+1 |
| | |||||
* | adds missing requires for Object#blank? and Object#present? | Xavier Noria | 2010-03-28 | 1 | -0/+1 |
| | |||||
* | fisting uninitialized ivar warnings. [#4198 state:resolved] | Aaron Patterson | 2010-03-16 | 1 | -0/+1 |
| | | | | Signed-off-by: wycats <wycats@gmail.com> | ||||
* | clean up more warnings, remove unnecessary methods, fix eval line numbers. ↵ | Aaron Patterson | 2010-03-16 | 1 | -0/+4 |
| | | | | | | [#4193 state:resolved] Signed-off-by: wycats <wycats@gmail.com> | ||||
* | keep AssociationProxy#to_a to avoid warning in Array(post.author), and ↵ | Xavier Noria | 2010-03-12 | 2 | -1/+2 |
| | | | | | | | | delegate it to @target in association collections [#4165 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Get rid of construct_count_options_from_args | Pratik Naik | 2010-01-19 | 1 | -3/+4 |
| | |||||
* | Inherit named scope class Scope from Relation | Pratik Naik | 2010-01-18 | 1 | -2/+0 |
| | |||||
* | save(false) is gone, use save(:validate => false) instead. | José Valim | 2010-01-17 | 3 | -3/+3 |
| | |||||
* | Make type_condition return Arel predicate and not a string condition | Pratik Naik | 2010-01-16 | 1 | -1/+1 |
| | |||||
* | Make scopes use relations under the hood | Pratik Naik | 2010-01-16 | 3 | -7/+7 |
| | |||||
* | Add Relation#includes to be an equivalent of current finder option :include | Pratik Naik | 2010-01-03 | 1 | -1/+1 |
| | |||||
* | Get rid of Model.construct_finder_arel_with_includes. Use ↵ | Pratik Naik | 2010-01-03 | 1 | -1/+1 |
| | | | | construct_finder_arel instead | ||||
* | Use Arel::Table instead of ActiveRecord::Relation from HABTM and ↵ | Pratik Naik | 2010-01-01 | 2 | -4/+4 |
| | | | | has_many#delete_records | ||||
* | Make sure association proxy does not pass quoted table name to sanitize_sql | Pratik Naik | 2010-01-01 | 1 | -1/+1 |
| | |||||
* | Add Relation#delete [Pratik Naik, Emilio Tagua] | Pratik Naik | 2010-01-01 | 1 | -1/+1 |
| |