Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| | * | Just use primary_key here, AR::Relation will resolve the ambiguity before it ↵ | Jon Leighton | 2011-01-30 | 1 | -1/+1 | |
| | | | | | | | | | | | | is converted to SQL | |||||
| | * | Call sum on the scope directly, rather than relying on method_missing and ↵ | Jon Leighton | 2011-01-30 | 1 | -2/+2 | |
| | | | | | | | | | | | | calculate | |||||
| | * | Condense first_or_last a bit more | Jon Leighton | 2011-01-30 | 1 | -7/+5 | |
| | | | ||||||
| | * | Get rid of separate reset_target! and reset_scopes_cache! methods | Jon Leighton | 2011-01-30 | 1 | -26/+17 | |
| | | | ||||||
| | * | target is always an array | Jon Leighton | 2011-01-30 | 1 | -5/+0 | |
| | | | ||||||
| | * | load_target will return the target. it also will not load if loaded? is true. | Jon Leighton | 2011-01-30 | 1 | -2/+1 | |
| | | | ||||||
| | * | DRY up first/last and hence make last benefit from the bugfix in first | Jon Leighton | 2011-01-30 | 1 | -15/+13 | |
| | | | ||||||
| | * | Use scoped.find directly rather than having a find_by_sql method | Jon Leighton | 2011-01-30 | 1 | -5/+1 | |
| | | | ||||||
| | * | Use scoped.first and scoped.last instead of find(:first, ...) and ↵ | Jon Leighton | 2011-01-30 | 1 | -2/+2 | |
| | | | | | | | | | | | | find(:last, ...) | |||||
| | * | Try to make fetch_first_or_last_using_find? more readable | Jon Leighton | 2011-01-30 | 1 | -2/+20 | |
| | | | ||||||
| | * | load_target returns the target | Jon Leighton | 2011-01-30 | 1 | -2/+1 | |
| | | | ||||||
| | * | Rename AssociationProxy#loaded to loaded! as it mutates the association | Jon Leighton | 2011-01-30 | 4 | -6/+6 | |
| | | | ||||||
| | * | Abstract load_target conditional logic | Jon Leighton | 2011-01-30 | 2 | -6/+7 | |
| | | | ||||||
| | * | Remove unused methods conditions, sql_conditions and sanitize_sql | Jon Leighton | 2011-01-30 | 1 | -12/+0 | |
| | | | ||||||
| | * | Don't pass around conditions as strings in ThroughAssociation | Jon Leighton | 2011-01-30 | 1 | -30/+25 | |
| | | | ||||||
| | * | Indent methods under private/protected sections | Jon Leighton | 2011-01-30 | 2 | -115/+115 | |
| | | | ||||||
| | * | Let's be less blasé about method visibility on association proxies | Jon Leighton | 2011-01-30 | 9 | -117/+135 | |
| | | | ||||||
| | * | We shouldn't be using scoped.scoping { ... } to build associated records, as ↵ | Jon Leighton | 2011-01-30 | 2 | -14/+14 | |
| | | | | | | | | | | | | this can affect validations/callbacks/etc inside the record itself [#6252 state:resolved] | |||||
| | * | Nested attributes and in-memory changed values #first and #[] behaviour ↵ | Alexey Nayden | 2011-01-28 | 1 | -1/+1 | |
| | | | | | | | | | | | | consistency fix | |||||
| | * | Removed support for accessing attributes on a has_and_belongs_to_many join ↵ | Jon Leighton | 2011-01-16 | 1 | -62/+6 | |
| | | | | | | | | | | | | table. This has been documented as deprecated behaviour since April 2006. Please use has_many :through instead. A deprecation warning will be added to the 3-0-stable branch for the 3.0.4 release. | |||||
| | * | Rename some variables | Jon Leighton | 2011-01-16 | 1 | -11/+11 | |
| | | | ||||||
| | * | Use self.target= in HasOneThroughAssociation too | Jon Leighton | 2011-01-16 | 1 | -4/+3 | |
| | | | ||||||
| | * | find_target can also go into SingularAssociation | Jon Leighton | 2011-01-16 | 3 | -8/+4 | |
| | | | ||||||
| | * | Abstract a bit more into SingularAssociation | Jon Leighton | 2011-01-16 | 3 | -4/+8 | |
| | | | ||||||
| | * | Use self.target= rather than @target= as the former automatically sets loaded | Jon Leighton | 2011-01-16 | 2 | -5/+2 | |
| | | | ||||||
| | * | Abstract common code from BelongsToAssociation and HasOneAssociation into ↵ | Jon Leighton | 2011-01-16 | 4 | -41/+42 | |
| | | | | | | | | | | | | SingularAssociation | |||||
| | * | belongs_to records should be initialized within the association scope | Jon Leighton | 2011-01-16 | 1 | -2/+8 | |
| | | | ||||||
| | * | Add create_association! for belongs_to | Jon Leighton | 2011-01-16 | 1 | -0/+4 | |
| | | | ||||||
| | * | push !loaded? conditional up | Aaron Patterson | 2011-01-14 | 1 | -10/+8 | |
| | | | ||||||
| | * | return early in case the left or right side lists are empty | Aaron Patterson | 2011-01-14 | 1 | -5/+4 | |
| | | | ||||||
| | * | only find_target can raise the exception, so isolate the rescue around that call | Aaron Patterson | 2011-01-14 | 1 | -5/+9 | |
| | | | ||||||
| | * | we always have a target, so stop checking | Aaron Patterson | 2011-01-14 | 1 | -1/+1 | |
| | | | ||||||
| | * | we should use [] instead of Array.new | Aaron Patterson | 2011-01-14 | 1 | -1/+1 | |
| | | | ||||||
| | * | @target is always a list, so stop doing is_a? checks | Aaron Patterson | 2011-01-14 | 1 | -1/+1 | |
| | | | ||||||
| | * | move complex logic to it's own method | Aaron Patterson | 2011-01-14 | 1 | -15/+19 | |
| | | | ||||||
| | * | loaded? will not raise an AR::RecordNotFound exception, so move the rescue ↵ | Aaron Patterson | 2011-01-14 | 1 | -4/+4 | |
| | | | | | | | | | | | | inside the conditional | |||||
| | * | reduce funcalls by using falsey objects | Aaron Patterson | 2011-01-14 | 1 | -2/+2 | |
| | | | ||||||
| | * | write the delegate method directly to avoid `delegate` callstack overhead | Aaron Patterson | 2011-01-14 | 1 | -1/+5 | |
| | | | ||||||
| | * | reduce some lasigns | Aaron Patterson | 2011-01-14 | 1 | -2/+1 | |
| | | | ||||||
| | * | include_in_memory? should check against @target list in case of new records. ↵ | Aaron Patterson | 2011-01-12 | 1 | -2/+2 | |
| | | | | | | | | | | | | [#6257 state:resolved] | |||||
| | * | use array maths rather than *args | Aaron Patterson | 2011-01-12 | 1 | -2/+4 | |
| | | | ||||||
| | * | just use return value of load_target | Aaron Patterson | 2011-01-12 | 1 | -2/+1 | |
| | | | ||||||
| | * | just call methods on return value of `load_target` | Aaron Patterson | 2011-01-12 | 1 | -8/+3 | |
| | | | ||||||
| | * | default return value is nil | Aaron Patterson | 2011-01-12 | 1 | -1/+0 | |
| | | | ||||||
| | * | @loaded is defined in initialize, so we should not need this | Aaron Patterson | 2011-01-12 | 1 | -2/+0 | |
| | | | ||||||
| | * | just use respond_to? and super rather than aliasing around methods | Aaron Patterson | 2011-01-12 | 2 | -5/+4 | |
| | | | ||||||
| | * | adding a test for no method error | Aaron Patterson | 2011-01-11 | 1 | -11/+5 | |
| | | | ||||||
| | * | test_with_polymorphic_and_condition works without the conditions methods in ↵ | Jon Leighton | 2011-01-11 | 1 | -5/+0 | |
| | | | | | | | | | | | | BelongsToPolymorphicAssociation because the conditions are added straight to the association_scope as of a few days ago | |||||
| | * | Support for create_association! for has_one associations | Jon Leighton | 2011-01-11 | 1 | -1/+4 | |
| | | | ||||||
| | * | Get rid of set_association_target and association_loaded? as the parts of ↵ | Jon Leighton | 2011-01-11 | 2 | -2/+4 | |
| | | | | | | | | | | | | the code that need that can now just use association_proxy(:name).loaded?/target= |