| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | Construct an actual ActiveRecord::Relation object for the association scope, ↵ | Jon Leighton | 2011-01-07 | 8 | -113/+72 |
| | | | | | rather than a hash which is passed to apply_finder_options. This allows more flexibility in how the scope is created, for example because scope.where(a, b) and scope.where(a).where(b) mean different things. | ||||
| * | just use a hash for doing association caching | Aaron Patterson | 2011-01-07 | 1 | -2/+2 |
| | | |||||
| * | no need to send a symbol to send() | Aaron Patterson | 2011-01-05 | 1 | -1/+1 |
| | | |||||
| * | avoid creating so many Arel::Table objects | Aaron Patterson | 2011-01-05 | 1 | -6/+9 |
| | | |||||
| * | use attr_reader and alias methods to access instance variables | Aaron Patterson | 2011-01-05 | 1 | -8/+4 |
| | | |||||
| * | we have a method for this, so let's use it | Aaron Patterson | 2011-01-05 | 1 | -2/+2 |
| | | |||||
| * | use arel ast construction rather than generating strings | Aaron Patterson | 2011-01-05 | 1 | -1/+7 |
| | | |||||
| * | use arel to construct AST rather than generate strings | Aaron Patterson | 2011-01-05 | 1 | -2/+3 |
| | | |||||
| * | Explicitly select * from has_and_belongs_to_many association tables, ↵ | Raimonds Simanovskis | 2011-01-04 | 1 | -1/+2 |
| | | | | | | simplify exists? query Previous version (after commit 3103296a61709e808aa89c3d37cf22bcdbc5a675) was generating wrong SQL for Oracle when calling exists? method on HABTM association. | ||||
| * | Remove undocumented feature from has_one where you could pass false as the ↵ | Jon Leighton | 2011-01-03 | 1 | -20/+8 |
| | | | | | | | | | | | | | second parameter to build_assoc or create_assoc, and the existing associated object would be untouched (the foreign key would not be nullified, and it would not be deleted). If you want behaviour similar to this you can do the following things: * Use :dependent => :nullify (or don't specify :dependent) if you want to prevent the existing associated object from being deleted * Use has_many if you actually want multiple associated objects * Explicitly set the foreign key if, for some reason, you really need to have multiple objects associated with the same has_one. E.g. previous = obj.assoc obj.create_assoc previous.update_attributes(:obj_id => obj.id) | ||||
| * | When preloading a belongs_to, the target should still be set (to nil) if ↵ | Jon Leighton | 2011-01-03 | 1 | -3/+1 |
| | | | | | there is no foreign key present. And the loaded flag should be set on the association proxy. This then allows us to remove the foreign_key_present? check from BelongsToAssociation#find_target. Also added a test for the same thing on polymorphic associations. | ||||
| * | Create the association scope directly rather than going through with_scope | Jon Leighton | 2011-01-03 | 7 | -31/+32 |
| | | |||||
| * | Use the association directly in other places too | Jon Leighton | 2011-01-03 | 3 | -20/+13 |
| | | |||||
| * | Let AssociationCollection#find use #scoped to do its finding. Note that I am ↵ | Jon Leighton | 2011-01-03 | 6 | -97/+66 |
| | | | | | removing test_polymorphic_has_many_going_through_join_model_with_disabled_include, since this specifies different behaviour for an association than for a regular scope. It seems reasonable to expect scopes and association proxies to behave in roughly the same way rather than having subtle differences. | ||||
| * | Rename AssociationProxy#foreign_key_present to foreign_key_present? | Jon Leighton | 2011-01-03 | 4 | -7/+7 |
| | | |||||
| * | Allow assignment on has_one :through where the owner is a new record [#5137 ↵ | Jon Leighton | 2011-01-03 | 7 | -51/+39 |
| | | | | | | | | | | | state:resolved] This required changing the code to keep the association proxy for a belongs_to around, despite its target being nil. Which in turn required various changes to the way that stale target checking is handled, in order to support various edge cases (loaded target is nil then foreign key added, foreign key is changed and then changed back, etc). A side effect is that the code is nicer and more succinct. Note that I am removing test_no_unexpected_aliasing since that is basically checking that the proxy for a belongs_to *does* change, which is the exact opposite of the intention of this commit. Also adding various tests for various edge cases and related things. Phew, long commit message! | ||||
| * | Have a proper AssociationReflection#foreign_type method rather than using ↵ | Jon Leighton | 2011-01-03 | 3 | -6/+6 |
| | | | | | options[:foreign_type] | ||||
| * | Rename AssociationReflection#primary_key_name to foreign_key, since the ↵ | Jon Leighton | 2010-12-31 | 9 | -26/+26 |
| | | | | | options key which it relates to is :foreign_key | ||||
| * | Support for :counter_cache on polymorphic belongs_to | Jon Leighton | 2010-12-31 | 1 | -1/+1 |
| | | |||||
| * | Refactor BelongsToAssociation to allow BelongsToPolymorphicAssociation to ↵ | Jon Leighton | 2010-12-31 | 5 | -114/+91 |
| | | | | | inherit from it | ||||
| * | Specify the STI type condition using SQL IN rather than a whole load of ORs. ↵ | Jon Leighton | 2010-12-31 | 1 | -1/+1 |
| | | | | | Required a fix to ActiveRecord::Relation#merge for properly merging create_with_value. This also fixes a situation where the type condition was appearing twice in the resultant SQL query. | ||||
| * | And owner_quoted_id can go too | Jon Leighton | 2010-12-31 | 3 | -22/+0 |
| | | |||||
| * | I N C E P T I O N: flatten_deeper works around a bug in Ruby 1.8.2. | Aaron Patterson | 2010-12-27 | 3 | -15/+3 |
| | | |||||
| * | Refactor we_can_set_the_inverse_on_this? to use a less bizarre name amongst ↵ | Jon Leighton | 2010-12-26 | 9 | -49/+39 |
| | | | | | other things | ||||
| * | Add a HasAssociation module for common code for has_* associations | Jon Leighton | 2010-12-26 | 7 | -61/+67 |
| | | |||||
| * | Remove AssociationProxy#dependent? - it's badly named and only used in one place | Jon Leighton | 2010-12-26 | 2 | -6/+1 |
| | | |||||
| * | Associations: DRY up the code which is generating conditions, and make it ↵ | Jon Leighton | 2010-12-26 | 6 | -64/+50 |
| | | | | | all use arel rather than SQL strings | ||||
| * | Remove custom_select param from construct_select, as it isn't used | Jon Leighton | 2010-12-26 | 1 | -3/+3 |
| | | |||||
| * | Remove construct_from from ThroughAssociationScope - it's not called from ↵ | Jon Leighton | 2010-12-26 | 1 | -4/+0 |
| | | | | | anywhere | ||||
| * | Set the create scope to an empty hash in ThroughAssociationScope. For ↵ | Jon Leighton | 2010-12-26 | 1 | -1/+5 |
| | | | | | reasoning please see the inline code comments. | ||||
| * | Use conditionals and implicit returns rather than explicit returns and ↵ | Jon Leighton | 2010-12-26 | 1 | -3/+7 |
| | | | | | postfix ifs (it's easier to read) | ||||
| * | Remove has_cached_counter? and cached_counter_attribute_name from ↵ | Jon Leighton | 2010-12-26 | 1 | -8/+0 |
| | | | | | HasManyThroughAssociation, as the exact same methods are inherited from HasManyAssociation | ||||
| * | Remove pointless use of 'private' | Jon Leighton | 2010-12-26 | 1 | -1/+0 |
| | | |||||
| * | Use the through association proxy for operations on the through record, so ↵ | Jon Leighton | 2010-12-26 | 3 | -17/+17 |
| | | | | | that those operations are automatically scoped and therefore construct_join_attributes does not need to use construct_owner_attributes. | ||||
| * | Remove target_obsolete? which is not called from anywhere | Jon Leighton | 2010-12-26 | 1 | -4/+0 |
| | | |||||
| * | scoped.where_values_hash is never nil | Jon Leighton | 2010-12-26 | 1 | -1/+1 |
| | | |||||
| * | using arel to compile sql statements | Aaron Patterson | 2010-12-25 | 1 | -1/+2 |
| | | |||||
| * | If a has_many goes :through a belongs_to, and the foreign key of the ↵ | Jon Leighton | 2010-12-23 | 5 | -3/+31 |
| | | | | | belongs_to changes, then the has_many should be considered stale. | ||||
| * | Improved strategy for updating a belongs_to association when the foreign key ↵ | Jon Leighton | 2010-12-23 | 3 | -0/+27 |
| | | | | | changes. Rather than resetting each affected association when the foreign key changes, we should lazily check for 'staleness' (where fk does not match target id) when the association is accessed. | ||||
| * | When a has_many association is not :uniq, appending the same record multiple ↵ | Jon Leighton | 2010-12-23 | 1 | -2/+2 |
| | | | | | times should append it to the @target multiple times [#5964 state:resolved] | ||||
| * | Fix behaviour of foo.has_many_through_association.select('custom select') ↵ | Michał Łomnicki | 2010-12-23 | 1 | -2/+2 |
| | | | | | [#6089 state:resolved] | ||||
| * | Fix creation of has_many through records with custom primary_key option on ↵ | Szymon Nowak | 2010-12-23 | 1 | -1/+6 |
| | | | | | belongs_to [#2990 state:resolved] | ||||
| * | no use for set, no need to to_ary, reduce extra objects | Aaron Patterson | 2010-12-20 | 1 | -3/+2 |
| | | |||||
| * | use array arithmetic rather than create sets | Aaron Patterson | 2010-12-20 | 1 | -4/+2 |
| | | |||||
| * | Avoid Symbol#to_proc for performance reasons in Ruby 1.8 | Jon Leighton | 2010-12-20 | 1 | -3/+3 |
| | | |||||
| * | has_many associations with :dependent => :delete_all should update the ↵ | Jon Leighton | 2010-12-20 | 1 | -1/+3 |
| | | | | | counter cache when deleting records | ||||
| * | Refactor delete_records in HasManyAssociation | Jon Leighton | 2010-12-20 | 1 | -7/+8 |
| | | |||||
| * | Fix problem where wrong keys are used in JoinAssociation when an association ↵ | Jon Leighton | 2010-12-20 | 1 | -9/+12 |
| | | | | | goes :through a belongs_to [#2801 state:resolved] | ||||
| * | Remove unnecessary overloaded methods create, create! and create_record from ↵ | Jon Leighton | 2010-12-20 | 1 | -18/+0 |
| | | | | | HasAndBelongsToManyAssociation | ||||
| * | Refactor create_record and build_record in AssociationCollection | Jon Leighton | 2010-12-20 | 1 | -17/+5 |
| | | |||||
 |
index : rails.git | |
| Mirror of official rails repo with custom fixes. | Harald Eilertsen |
| aboutsummaryrefslogtreecommitdiffstats |