Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | If a has_many goes :through a belongs_to, and the foreign key of the ↵ | Jon Leighton | 2010-12-23 | 5 | -3/+31 | |
| | | | | belongs_to changes, then the has_many should be considered stale. | |||||
* | Improved strategy for updating a belongs_to association when the foreign key ↵ | Jon Leighton | 2010-12-23 | 3 | -0/+27 | |
| | | | | changes. Rather than resetting each affected association when the foreign key changes, we should lazily check for 'staleness' (where fk does not match target id) when the association is accessed. | |||||
* | When a has_many association is not :uniq, appending the same record multiple ↵ | Jon Leighton | 2010-12-23 | 1 | -2/+2 | |
| | | | | times should append it to the @target multiple times [#5964 state:resolved] | |||||
* | Fix behaviour of foo.has_many_through_association.select('custom select') ↵ | Michał Łomnicki | 2010-12-23 | 1 | -2/+2 | |
| | | | | [#6089 state:resolved] | |||||
* | Fix creation of has_many through records with custom primary_key option on ↵ | Szymon Nowak | 2010-12-23 | 1 | -1/+6 | |
| | | | | belongs_to [#2990 state:resolved] | |||||
* | no use for set, no need to to_ary, reduce extra objects | Aaron Patterson | 2010-12-20 | 1 | -3/+2 | |
| | ||||||
* | use array arithmetic rather than create sets | Aaron Patterson | 2010-12-20 | 1 | -4/+2 | |
| | ||||||
* | Avoid Symbol#to_proc for performance reasons in Ruby 1.8 | Jon Leighton | 2010-12-20 | 1 | -3/+3 | |
| | ||||||
* | has_many associations with :dependent => :delete_all should update the ↵ | Jon Leighton | 2010-12-20 | 1 | -1/+3 | |
| | | | | counter cache when deleting records | |||||
* | Refactor delete_records in HasManyAssociation | Jon Leighton | 2010-12-20 | 1 | -7/+8 | |
| | ||||||
* | Fix problem where wrong keys are used in JoinAssociation when an association ↵ | Jon Leighton | 2010-12-20 | 1 | -9/+12 | |
| | | | | goes :through a belongs_to [#2801 state:resolved] | |||||
* | Remove unnecessary overloaded methods create, create! and create_record from ↵ | Jon Leighton | 2010-12-20 | 1 | -18/+0 | |
| | | | | HasAndBelongsToManyAssociation | |||||
* | Refactor create_record and build_record in AssociationCollection | Jon Leighton | 2010-12-20 | 1 | -17/+5 | |
| | ||||||
* | Delete create, create! and create_record from HasManyThroughAssociation in ↵ | Jon Leighton | 2010-12-20 | 2 | -30/+14 | |
| | | | | exchange for more generic versions in AssociationCollection | |||||
* | Specify insert_record with NotImplementedError in AssociationCollection, to ↵ | Jon Leighton | 2010-12-20 | 4 | -11/+14 | |
| | | | | indicate that subclasses should implement it. Also add save_record to reduce duplication. | |||||
* | Fix various issues with the :primary_key option in :through associations ↵ | Jon Leighton | 2010-12-15 | 1 | -17/+9 | |
| | | | | [#2421 state:resolved] | |||||
* | Replace rudimentary named_scope with scope. [#6052 state:resolved] | Pavel Gorbokon | 2010-12-15 | 1 | -8/+8 | |
| | | | | | | | * rename method names (actually in tests) * rename instance variable @_named_scopes_cache to @_scopes_cache * rename references in doc comments * don't touch CHANGELOG :) | |||||
* | Respect the default_scope on a join model when reading a through association | Jon Leighton | 2010-12-16 | 3 | -2/+9 | |
| | ||||||
* | Fix hm:t to self table aliasing in construct_scope | Ernie Miller | 2010-12-16 | 1 | -2/+10 | |
| | ||||||
* | class names are already strings, so we do not need to call to_s on the ↵ | Aaron Patterson | 2010-12-16 | 1 | -2/+2 | |
| | | | | strings that are already strings | |||||
* | build SQL AST nodes rather than generate strings | Aaron Patterson | 2010-12-16 | 1 | -10/+8 | |
| | ||||||
* | construct_joins no longer needs an argument | Aaron Patterson | 2010-12-16 | 1 | -1/+1 | |
| | ||||||
* | supporting arel AST nodes when building join statements | Aaron Patterson | 2010-12-16 | 1 | -15/+17 | |
| | ||||||
* | just copy the joins to the list | Aaron Patterson | 2010-12-16 | 1 | -1/+1 | |
| | ||||||
* | taking advantage of the JoinSource node in the SQL AST | Aaron Patterson | 2010-12-16 | 2 | -15/+6 | |
| | ||||||
* | just use the regexp directly | Aaron Patterson | 2010-12-16 | 1 | -6/+4 | |
| | ||||||
* | combine regexp | Aaron Patterson | 2010-12-16 | 1 | -4/+2 | |
| | ||||||
* | move ivar to initialize, use triple dot rather than minus | Aaron Patterson | 2010-12-16 | 1 | -1/+1 | |
| | ||||||
* | explicitly set prefix | Aaron Patterson | 2010-12-16 | 1 | -1/+1 | |
| | ||||||
* | remove lasgn since AST is mutated | Aaron Patterson | 2010-12-16 | 1 | -2/+8 | |
| | ||||||
* | use table alias nodes rather than Table nodes | Aaron Patterson | 2010-12-10 | 1 | -3/+2 | |
| | ||||||
* | use alias nodes to represent table aliases | Aaron Patterson | 2010-12-10 | 1 | -3/+2 | |
| | ||||||
* | avoid *args on join_target_table | Aaron Patterson | 2010-12-10 | 1 | -3/+5 | |
| | ||||||
* | only quote the table name once per call | Aaron Patterson | 2010-12-10 | 1 | -6/+7 | |
| | ||||||
* | move join creation a little closer to where it is used | Aaron Patterson | 2010-12-09 | 1 | -3/+3 | |
| | ||||||
* | use inject rather than lasgn | Aaron Patterson | 2010-12-09 | 1 | -6/+5 | |
| | ||||||
* | removing useless lasgn | Aaron Patterson | 2010-12-09 | 1 | -1/+1 | |
| | ||||||
* | use sort_by | Aaron Patterson | 2010-12-08 | 1 | -1/+1 | |
| | ||||||
* | just allocate the table in initialize | Aaron Patterson | 2010-12-08 | 1 | -6/+4 | |
| | ||||||
* | fewer method calls, fewer code branches | Aaron Patterson | 2010-12-08 | 1 | -5/+4 | |
| | ||||||
* | only call active_record once | Aaron Patterson | 2010-12-08 | 1 | -2/+4 | |
| | ||||||
* | dry up calls to table_aliases | Aaron Patterson | 2010-12-08 | 1 | -4/+6 | |
| | ||||||
* | remove code that could never be executed | Aaron Patterson | 2010-12-08 | 1 | -4/+0 | |
| | ||||||
* | have table_aliases call count_aliases to set the default value | Aaron Patterson | 2010-12-08 | 2 | -5/+3 | |
| | ||||||
* | arel ignores the columns parameter | Aaron Patterson | 2010-12-08 | 1 | -2/+1 | |
| | ||||||
* | passing the ast to a table when the relation is a table | Aaron Patterson | 2010-12-07 | 1 | -2/+0 | |
| | ||||||
* | JoinDependency is always created with an AST now | Aaron Patterson | 2010-12-07 | 1 | -4/+10 | |
| | ||||||
* | passing the ast to JoinDependency | Aaron Patterson | 2010-12-07 | 1 | -2/+11 | |
| | ||||||
* | arel is lazy about column information, so no need to pass it around | Aaron Patterson | 2010-12-07 | 1 | -1/+1 | |
| | ||||||
* | reduce string objects, reduce method calls | Aaron Patterson | 2010-12-07 | 1 | -4/+5 | |
| |