Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | super automatically passes on the implicit block | Aaron Patterson | 2010-11-16 | 1 | -5/+1 |
| | |||||
* | use unless instead of if ! | Aaron Patterson | 2010-11-16 | 1 | -1/+1 |
| | |||||
* | removing space errors | Aaron Patterson | 2010-11-16 | 2 | -5/+5 |
| | |||||
* | reloading an association will properly set attributes of instantiated ↵ | Aaron Patterson | 2010-11-16 | 1 | -1/+3 |
| | | | | objects. Thanks Brian Palmer [#5802 state:resolved] | ||||
* | refactoring uniq method | Aaron Patterson | 2010-11-16 | 1 | -7/+4 |
| | |||||
* | if association is already loaded and if a find operation is performed on the ↵ | Neeraj Singh | 2010-11-15 | 1 | -1/+2 |
| | | | | | | already loaded association list with an empty hash then do not perform another sql [#5972 state:resolved] | ||||
* | Remove unused var | Santiago Pastorino | 2010-11-14 | 1 | -1/+1 |
| | |||||
* | Fix bug where size of through association is not correct after adding a ↵ | Jason Cheow | 2010-11-14 | 1 | -1/+0 |
| | | | | | | | | has_many association (occurs only before main object has been reloaded). [#5968 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Execute less operations | Santiago Pastorino | 2010-11-09 | 1 | -2/+1 |
| | |||||
* | use persisted? instead of new_record? wherever possible | David Chelimsky | 2010-11-09 | 7 | -25/+26 |
| | | | | | | | | | | | - persisted? is the API defined in ActiveModel - makes it easier for extension libraries to conform to ActiveModel APIs without concern for whether the extended object is specifically ActiveRecord [#5927 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Association Proxy should not undefine the default respond_to_missing | sblackstone | 2010-11-04 | 1 | -1/+1 |
| | |||||
* | Refactoring: replace the mix of variables like @finder_sql, @counter_sql, ↵ | Jon Leighton | 2010-10-30 | 10 | -157/+144 |
| | | | | etc with just a single scope hash (created on initialization of the proxy). This is now used consistently across all associations. Therefore, all you have to do to ensure finding/counting etc is done correctly is implement the scope correctly. | ||||
* | Refactor AssociationCollection#include? with objects in memory | Carlos Antonio da Silva | 2010-10-02 | 1 | -4/+3 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | AssociationCollection#include? working properly for objects added with build ↵ | Marcelo Giorgi | 2010-09-30 | 1 | -0/+13 |
| | | | | method [#3472 state:resolved] | ||||
* | no need of nil check | Neeraj Singh | 2010-09-29 | 1 | -1/+1 |
| | |||||
* | Refactor association_collection uniq method. | Emilio Tagua | 2010-09-22 | 1 | -4/+3 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Perf: refactor method. | Emilio Tagua | 2010-09-22 | 1 | -11/+8 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | do not pass nil values to arel | Aaron Patterson | 2010-09-21 | 1 | -1/+1 |
| | |||||
* | Use scoped here to get the scoped where | Santiago Pastorino | 2010-09-05 | 1 | -5/+3 |
| | |||||
* | mark SQL literals as SQL literals | Aaron Patterson | 2010-08-25 | 1 | -1/+1 |
| | |||||
* | marking sql literals as sql literals | Aaron Patterson | 2010-08-23 | 1 | -1/+1 |
| | |||||
* | While creating a new record using has_many create method default scope of ↵ | Neeraj Singh | 2010-08-19 | 1 | -1/+6 |
| | | | | | | | | | | | child should be respected. author.posts.create should take into account default_scope defined on post. [#3939: state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 3 | -10/+10 |
| | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | Removing most of the symbol to proc usage in Active Record | Prem Sichanugrist | 2010-08-13 | 1 | -1/+1 |
| | | | | This will hopefully make Active Record run a bit more faster. | ||||
* | removing references to arel constants | Aaron Patterson | 2010-08-13 | 1 | -1/+1 |
| | |||||
* | avoiding symbol to proc again | Aaron Patterson | 2010-08-13 | 1 | -1/+1 |
| | |||||
* | do not use arel constants directly | Aaron Patterson | 2010-08-13 | 1 | -1/+1 |
| | |||||
* | symbol to proc is slow, we should avoid it | Aaron Patterson | 2010-08-13 | 1 | -1/+1 |
| | |||||
* | dry up the hash dup and avoid sending nil values | Aaron Patterson | 2010-08-11 | 2 | -11/+15 |
| | |||||
* | standarizes the use of the article "an" for "SQL" and "SQLite" | Xavier Noria | 2010-08-05 | 1 | -1/+1 |
| | |||||
* | ensuring that description does not exceed 100 columns | Neeraj Singh | 2010-08-02 | 2 | -6/+8 |
| | |||||
* | Don't increment and then decrement the same counter when re-assigning a ↵ | Tarmo Tänav | 2010-07-29 | 1 | -1/+1 |
| | | | | | | | | belongs_to association [#2786 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | fixed joining of attributes when using find_or_create_by with multiple ↵ | Jon Buda | 2010-07-28 | 1 | -1/+1 |
| | | | | | | attributes through an association Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | No need to check for :uniq | Neeraj Singh | 2010-07-26 | 1 | -6/+3 |
| | | | | | | [#5170 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Make use of tap to return a previously used var | Santiago Pastorino | 2010-07-21 | 1 | -4/+4 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Ensure all join table attributes will be in the same timestamp. | José Valim | 2010-07-21 | 1 | -11/+21 |
| | |||||
* | Timestamp columns of HABTM join table should record timestamps | Neeraj Singh | 2010-07-21 | 1 | -1/+5 |
| | | | | [#5161 state:resolved] | ||||
* | association load target shouldn't replace records | Szetobo | 2010-07-21 | 1 | -3/+4 |
| | | | | | | | | from db if it is already loaded by nested attributes assignment [#5053 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | In nested_attributes when association is not loaded and association | Subba Rao Pasupuleti | 2010-07-21 | 1 | -1/+8 |
| | | | | | | | | record is saved and then in memory record attributes should be saved [#5053 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | id is a public method | Santiago Pastorino | 2010-07-21 | 1 | -2/+2 |
| | |||||
* | Ensure that primary_keys of HABTM records is not double quoted | Neeraj Singh | 2010-07-20 | 1 | -2/+2 |
| | | | | [#5152 state:reslved] | ||||
* | Removed warnings when a variable is shadowed | Łukasz Strzałkowski | 2010-07-19 | 1 | -3/+3 |
| | |||||
* | Remove unintentional API changes. [#1108] | Pratik Naik | 2010-07-14 | 1 | -9/+4 |
| | |||||
* | count method should not take options if it is operated on has_many ↵ | Neeraj Singh | 2010-07-13 | 1 | -2/+5 |
| | | | | | | | | association which has finder_sql or counter_sql [#2395 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | string IDs are now quoted correctly [#5064 state:resolved] | Will St. Clair + Neeraj Singh | 2010-07-13 | 1 | -1/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | fix ActiveRecord `destroy_all` so it returns destroyed records | Mislav Marohnić | 2010-07-08 | 1 | -3/+4 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Don't remove scheduled destroys when loading an association. [#4642 ↵ | James Le Cuirot | 2010-07-01 | 1 | -1/+6 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | AssociationCollection#create_by_*, find_or_create_by_* work properly now. ↵ | Aaron Patterson | 2010-06-29 | 1 | -0/+11 |
| | | | | | | [#1108 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | splitting a really long line into multiple lines which is easy on eyes | Neeraj Singh | 2010-06-29 | 1 | -1/+5 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Don't define block, just yield if block is given. | Emilio Tagua | 2010-06-24 | 1 | -7/+7 |
| |