Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix nil assignment to polymorphic belongs_to | Jeremy Kemper | 2013-12-18 | 1 | -0/+5 |
| | | | | | | | | Assigning nil to a polymorphic belongs_to would nullify its _id field by not its _type field. Fixes failing test from c141dfc838a5dca9f197814410fa5d44c143129c. Regression from 1678e959e973de32287b65c52ebc6cce87148951. | ||||
* | extract cache counter logic to one method | Aaron Patterson | 2013-12-12 | 1 | -11/+10 |
| | |||||
* | remove duplicate code | Aaron Patterson | 2013-12-12 | 1 | -15/+6 |
| | |||||
* | extract a method for updating without a record object | Aaron Patterson | 2013-12-12 | 1 | -6/+10 |
| | |||||
* | extract methods out of the cache update method | Aaron Patterson | 2013-12-12 | 1 | -14/+22 |
| | |||||
* | pull a nil check up one frame | Aaron Patterson | 2013-12-12 | 1 | -6/+10 |
| | |||||
* | remove more nil checks | Aaron Patterson | 2013-12-12 | 1 | -6/+5 |
| | |||||
* | remove nil check | Aaron Patterson | 2013-12-12 | 2 | -7/+11 |
| | | | | | calling replace_keys could possibly do a nil check twice, this commit reduces it to once. | ||||
* | remove the nil check from set_inverse_instance | Aaron Patterson | 2013-12-12 | 4 | -4/+7 |
| | | | | | methods that call set_inverse_instance with a record will not have to pay the cost of a nil check on every call | ||||
* | make sure cached table name is a string. fixes #12582 | Aaron Patterson | 2013-12-12 | 1 | -1/+1 |
| | |||||
* | Move the parameter normalization to the initialize method | Rafael Mendonça França | 2013-12-11 | 1 | -4/+5 |
| | | | | | activerecord-deprecated_finders expects the parameters denormalized in its initialize method | ||||
* | Revert the whole refactoring in the association builder classes. | Rafael Mendonça França | 2013-12-11 | 7 | -46/+62 |
| | | | | This is to get activerecord-deprecated_finders work again | ||||
* | Mark the arguments needed by activerecord-deprecated_finders with a TODO | Rafael Mendonça França | 2013-12-11 | 2 | -0/+4 |
| | |||||
* | Revert "Merge pull request #12518 from vipulnsward/remove_count_options" | Rafael Mendonça França | 2013-12-11 | 2 | -3/+5 |
| | | | | | | | It is needed for activerecord-depecated_finders This reverts commit dcff027a5242b20c0c90eb062dddb22ccf51aed9, reversing changes made to 3a2093984ff49d86db1efeff0c7581e788ecfb9f. | ||||
* | Bring back the valid_options class accessor | Rafael Mendonça França | 2013-12-11 | 6 | -9/+14 |
| | | | | It is need in activerecord-deprecated_finders | ||||
* | fix typo, "state_state" should be "stale_state" [ci skip] | Scott M | 2013-12-07 | 1 | -1/+1 |
| | |||||
* | polymorphic belongs_to association with touch: true updates old record correctly | Severin Schoepke | 2013-12-05 | 1 | -1/+7 |
| | | | | | | | | | Example: Given you have a comments model with a polymorphic commentable association (e.g. books and songs) with the touch option set. Every time you update a comment its commentable should be touched. This was working when you changed attributes on the comment or when you moved the comment from one book to another. However, it was not working when moving a comment from a book to a song. This is now fixed. | ||||
* | Raise `ArgumentError` when `has_one` is used with `counter_cache` | Godfrey Chan | 2013-11-29 | 2 | -2/+2 |
| | | | | | | | | | Previously, the `has_one` macro incorrectly accepts the `counter_cache` option due to a bug, although that options was never supported nor functional on `has_one` and `has_one ... through` relationships. It now correctly raises an `ArgumentError` when passed that option. For reference, this bug was introduced in 52f8e4b9. | ||||
* | tyop | Akira Matsuda | 2013-11-26 | 1 | -1/+1 |
| | |||||
* | Raise `RecordNotDestroyed` when children can't be replaced | Brian Thomas Storti | 2013-11-25 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #12812 Raise `ActiveRecord::RecordNotDestroyed` when a child marked with `dependent: destroy` can't be destroyed. The following code: ```ruby class Post < ActiveRecord::Base has_many :comments, dependent: :destroy end class Comment < ActiveRecord::Base before_destroy do return false end end post = Post.create!(comments: [Comment.create!]) post.comments = [Comment.create!] ```` would result in a `post` with two `comments`. With this commit, the same code would raise a `RecordNotDestroyed` exception, keeping the `post` with the same `comment`. | ||||
* | Merge remote-tracking branch 'docrails/master' | Xavier Noria | 2013-11-24 | 3 | -15/+15 |
|\ | | | | | | | | | | | Conflicts: activesupport/lib/active_support/core_ext/hash/deep_merge.rb activesupport/lib/active_support/core_ext/hash/keys.rb | ||||
| * | Change syntax format for example returned values | Prem Sichanugrist | 2013-11-11 | 3 | -15/+15 |
| | | | | | | | | | | | | | | | | | | According to our guideline, we leave 1 space between `#` and `=>`, so we want `# =>` instead of `#=>`. Thanks to @fxn for the suggestion. [ci skip] | ||||
* | | Merge pull request #12918 from versioncontrol/rails-12866 | Rafael Mendonça França | 2013-11-16 | 1 | -1/+6 |
|\ \ | | | | | | | | | | | | | | | | | | | Checks to see if the record contains the foreign_key to set the inverse automatically Conflicts: activerecord/CHANGELOG.md | ||||
| * | | Checks to see if the record contains the foreign_key to set the inverse ↵ | Edo Balvers | 2013-11-16 | 1 | -1/+6 |
| |/ | | | | | | | automatically | ||||
* | | Prevent the counter cache from being decremented twice | dm1try | 2013-11-11 | 1 | -1/+1 |
| | | | | | | | | | | when destroying a record on a has_many :through association. :destroy method has own counter_cache callbacks. | ||||
* | | Fixes problem with replacing has_one association record with itself | Denis Redozubov | 2013-11-11 | 1 | -2/+4 |
|/ | |||||
* | Merge pull request #12390 from kennyj/rename_to_association_methods | Rafael Mendonça França | 2013-11-05 | 2 | -2/+2 |
|\ | | | | | | | | | | | | | | | | | Renamed generated_feature_methods to generated_association_methods. Conflicts: activerecord/lib/active_record/associations/builder/association.rb activerecord/lib/active_record/associations/builder/singular_association.rb activerecord/test/cases/base_test.rb | ||||
| * | Renamed generated_feature_methods to generated_association_methods. | kennyj | 2013-09-28 | 2 | -2/+2 |
| | | |||||
* | | Fix wrong behavior where associations with dependent: :destroy options | Rafael Mendonça França | 2013-11-01 | 1 | -4/+2 |
| | | | | | | | | | | | | | | | | | | was using nullify strategy This caused a regression in applications trying to upgrade. Also if the user set the dependent option as destroy he expects to get the records removed from the database. | ||||
* | | Skip `include_values` from through associations chains for building target scope | Paul Nikitochkin | 2013-10-27 | 1 | -2/+6 |
| | | | | | | | | Fixes: #12242, #9517, #10240 | ||||
* | | Fix typo: `has_many :pets`, not `pets :has_many`. | Peter Jaros | 2013-10-24 | 1 | -1/+1 |
| | | |||||
* | | move helper class to the top | Aaron Patterson | 2013-10-21 | 1 | -42/+42 |
| | | |||||
* | | build the association graph functionally | Aaron Patterson | 2013-10-21 | 3 | -20/+13 |
| | | | | | | | | This lets us avoid the constant calls to Array#<< | ||||
* | | @base_klass is not used | Aaron Patterson | 2013-10-21 | 1 | -1/+0 |
| | | |||||
* | | join_type isn't used on the node anymore | Aaron Patterson | 2013-10-21 | 2 | -11/+7 |
| | | |||||
* | | make joins generation method look similar | Aaron Patterson | 2013-10-21 | 1 | -6/+9 |
| | | |||||
* | | remove node duping code | Aaron Patterson | 2013-10-21 | 1 | -57/+19 |
| | | |||||
* | | refactor outer join generation | Aaron Patterson | 2013-10-21 | 1 | -11/+6 |
| | | |||||
* | | add outer joins for matching nodes | Aaron Patterson | 2013-10-21 | 1 | -2/+14 |
| | | |||||
* | | construct joins by walking the outer join tree | Aaron Patterson | 2013-10-21 | 1 | -5/+34 |
| | | |||||
* | | pass the outer joins to join_constraints | Aaron Patterson | 2013-10-20 | 1 | -1/+2 |
| | | |||||
* | | disconnect join_constraints from the instance | Aaron Patterson | 2013-10-20 | 2 | -3/+3 |
| | | |||||
* | | pass in scope chain so reflection is not needed | Aaron Patterson | 2013-10-20 | 2 | -3/+3 |
| | | |||||
* | | pass the foreign table and class to the join_constraints method | Aaron Patterson | 2013-10-20 | 2 | -5/+4 |
| | | |||||
* | | pass the join type to the join_constraints method | Aaron Patterson | 2013-10-20 | 2 | -2/+3 |
| | | |||||
* | | use the node as cache so we can avoid accessing the table | Aaron Patterson | 2013-10-15 | 1 | -13/+13 |
| | | |||||
* | | apply tables to the whole tree from the outside | Aaron Patterson | 2013-10-15 | 1 | -14/+8 |
| | | |||||
* | | apply table aliases after the AST has been built | Aaron Patterson | 2013-10-15 | 1 | -1/+13 |
| | | |||||
* | | stop reversing tables until we absolutely must | Aaron Patterson | 2013-10-15 | 2 | -3/+3 |
| | | |||||
* | | pass the chain the join_constraints | Aaron Patterson | 2013-10-15 | 2 | -3/+4 |
| | |