aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/associations
Commit message (Collapse)AuthorAgeFilesLines
...
* loaded? will not raise an AR::RecordNotFound exception, so move the rescue ↵Aaron Patterson2011-01-141-4/+4
| | | | inside the conditional
* reduce funcalls by using falsey objectsAaron Patterson2011-01-141-2/+2
|
* write the delegate method directly to avoid `delegate` callstack overheadAaron Patterson2011-01-141-1/+5
|
* reduce some lasignsAaron Patterson2011-01-141-2/+1
|
* include_in_memory? should check against @target list in case of new records. ↵Aaron Patterson2011-01-121-2/+2
| | | | [#6257 state:resolved]
* use array maths rather than *argsAaron Patterson2011-01-121-2/+4
|
* just use return value of load_targetAaron Patterson2011-01-121-2/+1
|
* just call methods on return value of `load_target`Aaron Patterson2011-01-121-8/+3
|
* default return value is nilAaron Patterson2011-01-121-1/+0
|
* @loaded is defined in initialize, so we should not need thisAaron Patterson2011-01-121-2/+0
|
* just use respond_to? and super rather than aliasing around methodsAaron Patterson2011-01-122-5/+4
|
* adding a test for no method errorAaron Patterson2011-01-111-11/+5
|
* test_with_polymorphic_and_condition works without the conditions methods in ↵Jon Leighton2011-01-111-5/+0
| | | | BelongsToPolymorphicAssociation because the conditions are added straight to the association_scope as of a few days ago
* Support for create_association! for has_one associationsJon Leighton2011-01-111-1/+4
|
* Get rid of set_association_target and association_loaded? as the parts of ↵Jon Leighton2011-01-112-2/+4
| | | | the code that need that can now just use association_proxy(:name).loaded?/target=
* We can use the association_proxy method directly in HasOneThroughAssociation nowJon Leighton2011-01-112-20/+20
|
* find_target can be inheritedJon Leighton2011-01-111-4/+0
|
* Raise ActiveRecord::RecordNotSaved if an AssociationCollection fails to be ↵Jon Leighton2011-01-111-1/+5
| | | | replaced
* When assigning a has_one, if anything fails, the assignment should be rolled ↵Jon Leighton2011-01-111-19/+23
| | | | back entirely
* When assigning a has_one, if the new record fails to save, raise an errorJon Leighton2011-01-111-3/+3
|
* When assigning a has_one, if the existing record fails to be removed from ↵Jon Leighton2011-01-111-5/+11
| | | | the association, raise an error
* has_one should always remove the old record (properly), even if not saving ↵Jon Leighton2011-01-111-1/+1
| | | | the new record, so we don't get the database into a pickle
* Fix polymorphic belongs_to associationproxy raising errors when loading target.Ernie Miller2011-01-111-0/+5
|
* Refactor HasOneAssociation#replaceJon Leighton2011-01-071-26/+22
|
* Don't not remove double negativesJon Leighton2011-01-071-4/+4
|
* Clean up create, create! and build in HasOneAssociationJon Leighton2011-01-071-14/+8
|
* merge_with_conditions is not necessary because the conditions will already ↵Jon Leighton2011-01-071-9/+0
| | | | be in the scope_for_create hash in the scope
* Not really worth having the HasAssociation module for just a single methodJon Leighton2011-01-074-20/+9
|
* Construct an actual ActiveRecord::Relation object for the association scope, ↵Jon Leighton2011-01-078-113/+72
| | | | rather than a hash which is passed to apply_finder_options. This allows more flexibility in how the scope is created, for example because scope.where(a, b) and scope.where(a).where(b) mean different things.
* just use a hash for doing association cachingAaron Patterson2011-01-071-2/+2
|
* no need to send a symbol to send()Aaron Patterson2011-01-051-1/+1
|
* avoid creating so many Arel::Table objectsAaron Patterson2011-01-051-6/+9
|
* use attr_reader and alias methods to access instance variablesAaron Patterson2011-01-051-8/+4
|
* we have a method for this, so let's use itAaron Patterson2011-01-051-2/+2
|
* use arel ast construction rather than generating stringsAaron Patterson2011-01-051-1/+7
|
* use arel to construct AST rather than generate stringsAaron Patterson2011-01-051-2/+3
|
* Explicitly select * from has_and_belongs_to_many association tables, ↵Raimonds Simanovskis2011-01-041-1/+2
| | | | | simplify exists? query Previous version (after commit 3103296a61709e808aa89c3d37cf22bcdbc5a675) was generating wrong SQL for Oracle when calling exists? method on HABTM association.
* Remove undocumented feature from has_one where you could pass false as the ↵Jon Leighton2011-01-031-20/+8
| | | | | | | | | | | | second parameter to build_assoc or create_assoc, and the existing associated object would be untouched (the foreign key would not be nullified, and it would not be deleted). If you want behaviour similar to this you can do the following things: * Use :dependent => :nullify (or don't specify :dependent) if you want to prevent the existing associated object from being deleted * Use has_many if you actually want multiple associated objects * Explicitly set the foreign key if, for some reason, you really need to have multiple objects associated with the same has_one. E.g. previous = obj.assoc obj.create_assoc previous.update_attributes(:obj_id => obj.id)
* When preloading a belongs_to, the target should still be set (to nil) if ↵Jon Leighton2011-01-031-3/+1
| | | | there is no foreign key present. And the loaded flag should be set on the association proxy. This then allows us to remove the foreign_key_present? check from BelongsToAssociation#find_target. Also added a test for the same thing on polymorphic associations.
* Create the association scope directly rather than going through with_scopeJon Leighton2011-01-037-31/+32
|
* Use the association directly in other places tooJon Leighton2011-01-033-20/+13
|
* Let AssociationCollection#find use #scoped to do its finding. Note that I am ↵Jon Leighton2011-01-036-97/+66
| | | | removing test_polymorphic_has_many_going_through_join_model_with_disabled_include, since this specifies different behaviour for an association than for a regular scope. It seems reasonable to expect scopes and association proxies to behave in roughly the same way rather than having subtle differences.
* Rename AssociationProxy#foreign_key_present to foreign_key_present?Jon Leighton2011-01-034-7/+7
|
* Allow assignment on has_one :through where the owner is a new record [#5137 ↵Jon Leighton2011-01-037-51/+39
| | | | | | | | | | state:resolved] This required changing the code to keep the association proxy for a belongs_to around, despite its target being nil. Which in turn required various changes to the way that stale target checking is handled, in order to support various edge cases (loaded target is nil then foreign key added, foreign key is changed and then changed back, etc). A side effect is that the code is nicer and more succinct. Note that I am removing test_no_unexpected_aliasing since that is basically checking that the proxy for a belongs_to *does* change, which is the exact opposite of the intention of this commit. Also adding various tests for various edge cases and related things. Phew, long commit message!
* Have a proper AssociationReflection#foreign_type method rather than using ↵Jon Leighton2011-01-033-6/+6
| | | | options[:foreign_type]
* Rename AssociationReflection#primary_key_name to foreign_key, since the ↵Jon Leighton2010-12-319-26/+26
| | | | options key which it relates to is :foreign_key
* Support for :counter_cache on polymorphic belongs_toJon Leighton2010-12-311-1/+1
|
* Refactor BelongsToAssociation to allow BelongsToPolymorphicAssociation to ↵Jon Leighton2010-12-315-114/+91
| | | | inherit from it
* Specify the STI type condition using SQL IN rather than a whole load of ORs. ↵Jon Leighton2010-12-311-1/+1
| | | | Required a fix to ActiveRecord::Relation#merge for properly merging create_with_value. This also fixes a situation where the type condition was appearing twice in the resultant SQL query.
* And owner_quoted_id can go tooJon Leighton2010-12-313-22/+0
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-08-22 23:35:37 +0000