Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Ensure that inverse associations are set before running callbacks | Sean Griffin | 2016-08-31 | 1 | -1/+0 |
| | | | | | | | | | | | | | | | | | If a parent association was accessed in an `after_find` or `after_initialize` callback, it would always end up loading the association, and then immediately overwriting the association we just loaded. If this occurred in a way that the parent's `current_scope` was set to eager load the child, this would result in an infinite loop and eventually overflow the stack. For records that are created with `.new`, we have a mechanism to perform an action before the callbacks are run. I've introduced the same code path for records created with `instantiate`, and updated all code which sets inverse instances on newly loaded associations to use this block instead. Fixes #26320. | ||||
* | normalizes indentation and whitespace across the project | Xavier Noria | 2016-08-06 | 1 | -7/+7 |
| | |||||
* | Never pass `nil` to `order` | Sean Griffin | 2015-10-29 | 1 | -6/+0 |
| | | | | | | | | This is part of a refactoring to make it easier to allow `order` to use sanitize like just about everything else on relation. The deleted test doesn't give any reasoning as to why passing `nil` to `order` needs to be supported, and it's rather nonsensical. I can almost see allowing an empty string being passed (though I'm tempted to just disallow it...) | ||||
* | pass the preloader down so we only have to construct one | Aaron Patterson | 2013-09-23 | 1 | -2/+2 |
| | |||||
* | Represent association scope options as AR::Relations insternally. | Jon Leighton | 2012-07-13 | 1 | -1/+1 |
| | |||||
* | Rewrote AssociationPreload. | Jon Leighton | 2011-02-28 | 1 | -0/+24 |