Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | join_type isn't used on the node anymore | Aaron Patterson | 2013-10-21 | 1 | -5/+1 | |
| | ||||||
* | disconnect join_constraints from the instance | Aaron Patterson | 2013-10-20 | 1 | -2/+2 | |
| | ||||||
* | pass in scope chain so reflection is not needed | Aaron Patterson | 2013-10-20 | 1 | -2/+2 | |
| | ||||||
* | pass the foreign table and class to the join_constraints method | Aaron Patterson | 2013-10-20 | 1 | -4/+1 | |
| | ||||||
* | pass the join type to the join_constraints method | Aaron Patterson | 2013-10-20 | 1 | -1/+1 | |
| | ||||||
* | stop reversing tables until we absolutely must | Aaron Patterson | 2013-10-15 | 1 | -2/+2 | |
| | ||||||
* | pass the chain the join_constraints | Aaron Patterson | 2013-10-15 | 1 | -2/+2 | |
| | ||||||
* | Merge branch 'master' into joindep | Aaron Patterson | 2013-10-15 | 2 | -2/+2 | |
|\ | | | | | | | | | | | | | | | | | | | | | * master: use the cached arel table Fix typo in the changelog entry Don't remove the select values to add they back again Pluck on NullRelation accepts a list of columns Conflicts: activerecord/lib/active_record/relation/finder_methods.rb | |||||
| * | use the cached arel table | Aaron Patterson | 2013-10-15 | 2 | -2/+2 | |
| | | ||||||
* | | move column_names_with_alias on to the alias cache object | Aaron Patterson | 2013-10-14 | 3 | -29/+4 | |
| | | ||||||
* | | keep a cache on the alias object | Aaron Patterson | 2013-10-14 | 1 | -5/+0 | |
| | | ||||||
* | | move alias building to the table node | Aaron Patterson | 2013-10-14 | 1 | -4/+0 | |
| | | ||||||
* | | remove delegation to `chain` | Aaron Patterson | 2013-10-14 | 1 | -3/+1 | |
| | | ||||||
* | | rm JoinHelper from JoinAssociation | Aaron Patterson | 2013-10-14 | 1 | -3/+1 | |
| | | ||||||
* | | unhook `join_constraints` from the @tables ivar | Aaron Patterson | 2013-10-13 | 1 | -2/+2 | |
| | | ||||||
* | | remove delegate methods that are not used | Aaron Patterson | 2013-10-13 | 1 | -1/+1 | |
| | | ||||||
* | | push the node->AR cache up one level | Aaron Patterson | 2013-10-13 | 1 | -6/+1 | |
| | | ||||||
* | | pull parent and alias tacker from the nodes. | Aaron Patterson | 2013-10-11 | 3 | -19/+5 | |
| | | | | | | | | For now, we'll set the tables on the nodes manually. | |||||
* | | decouple the `join_constraints` method from the parent pointer | Aaron Patterson | 2013-10-11 | 1 | -1/+1 | |
|/ | ||||||
* | no reason to do this column addition and subtraction business | Aaron Patterson | 2013-10-11 | 1 | -1/+1 | |
| | ||||||
* | refactor a little so we can remove some methods | Aaron Patterson | 2013-10-10 | 1 | -3/+0 | |
| | ||||||
* | delete unused code | Aaron Patterson | 2013-10-10 | 1 | -10/+0 | |
| | | | | | Now that we merge trees from the top down, we don't need to search through the whole tree for particular nodes, just walk it and merge. | |||||
* | simplify each method. | Aaron Patterson | 2013-10-10 | 1 | -8/+2 | |
| | | | | Stop writing terrible code Aaron. This is Ruby, not Scheme | |||||
* | stop creating a bunch of relation objects when we can slap all the joins on ↵ | Aaron Patterson | 2013-10-09 | 1 | -5/+0 | |
| | | | | at once | |||||
* | add some convenient methods for avoiding array allocations | Aaron Patterson | 2013-10-09 | 1 | -0/+3 | |
| | ||||||
* | speed up match? | Aaron Patterson | 2013-10-09 | 1 | -0/+1 | |
| | ||||||
* | make node search more efficient | Aaron Patterson | 2013-10-09 | 3 | -0/+23 | |
| | | | | | | Rather than search every node in the tree, comparing that node and all of its parents every time, start at the root from both sides and work our way down the tree | |||||
* | remove == so we can see where walking up parents occurs | Aaron Patterson | 2013-10-09 | 3 | -15/+0 | |
| | ||||||
* | push parent up to the superclass | Aaron Patterson | 2013-10-09 | 3 | -7/+11 | |
| | | | | We always want a linked list back to the root node. | |||||
* | convert JoinBase to a tree and remove the Node class | Aaron Patterson | 2013-10-09 | 1 | -1/+19 | |
| | ||||||
* | don't access the reflections hash | Aaron Patterson | 2013-10-08 | 1 | -1/+1 | |
| | | | | The reflections hash is supposed to be private, so let's use the API. | |||||
* | hide join_parts internals from other classes | Aaron Patterson | 2013-10-08 | 1 | -11/+0 | |
| | ||||||
* | decouple JoinAssociation from JoinDependency | Aaron Patterson | 2013-10-08 | 1 | -9/+4 | |
| | ||||||
* | Set the join type on construction | Aaron Patterson | 2013-10-03 | 1 | -2/+2 | |
| | | | | | We always set the join type immediately after construction, just make it part of the constructor and we can skip that step | |||||
* | simplify the JoinAssociation constructor, check validity *before* | Aaron Patterson | 2013-10-03 | 1 | -6/+0 | |
| | ||||||
* | parent is always passed in, so make it non-optional | Aaron Patterson | 2013-10-03 | 1 | -1/+1 | |
| | ||||||
* | require the files we need so the classes are stand-alone | Aaron Patterson | 2013-10-03 | 2 | -0/+4 | |
| | ||||||
* | remove HABTM special cases from associations classes | Aaron Patterson | 2013-10-02 | 1 | -11/+0 | |
| | ||||||
* | Whitespaces | Rafael Mendonça França | 2013-09-11 | 1 | -1/+2 | |
| | ||||||
* | Reduce allocations when extracting AR models | Sam | 2013-09-11 | 1 | -1/+13 | |
| | ||||||
* | add a specific factory method rather than using new | Aaron Patterson | 2013-07-23 | 1 | -2/+2 | |
| | ||||||
* | parent_table is only used internally | Aaron Patterson | 2013-07-16 | 1 | -4/+4 | |
| | ||||||
* | decouple the manager class from building join constraints | Aaron Patterson | 2013-07-16 | 1 | -6/+6 | |
| | ||||||
* | cache the klass member of the reflection | Aaron Patterson | 2013-07-16 | 1 | -8/+10 | |
| | ||||||
* | cache the scope chain on the stack and eliminate `i` | Aaron Patterson | 2013-07-16 | 1 | -7/+4 | |
| | ||||||
* | just push on to the scope chain items. Oops! (thanks @carlosantoniodasilva) | Aaron Patterson | 2013-07-16 | 1 | -2/+1 | |
| | ||||||
* | use Relation#merge to combine scope chain items | Aaron Patterson | 2013-07-16 | 1 | -6/+6 | |
| | ||||||
* | make sure scope_chain_items has consistent types | Aaron Patterson | 2013-07-16 | 1 | -7/+9 | |
| | ||||||
* | Apply default scope when joining associations. | Jon Leighton | 2013-06-28 | 1 | -0/+2 | |
| | | | | | | | | | | | | | | | | | | | For example: class Post < ActiveRecord::Base default_scope -> { where published: true } end class Comment belongs_to :post end When calling `Comment.join(:post)`, we expect to receive only comments on published posts, since that is the default scope for posts. Before this change, the default scope from `Post` was not applied, so we'd get comments on unpublished posts. | |||||
* | stop doing assingments in an iterator | Aaron Patterson | 2013-05-17 | 1 | -2/+6 | |
| |