Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Remove defunct ivars | Ben Woosley | 2014-09-28 | 1 | -1/+0 |
| | | | | @column_names_with_alias, @dynamic_methods_hash, @time_zone_column_names, and @cached_time_zone | ||||
* | build the association graph functionally | Aaron Patterson | 2013-10-21 | 1 | -2/+2 |
| | | | | This lets us avoid the constant calls to Array#<< | ||||
* | Merge branch 'master' into joindep | Aaron Patterson | 2013-10-15 | 1 | -1/+1 |
|\ | | | | | | | | | | | | | | | | | | | | | * master: use the cached arel table Fix typo in the changelog entry Don't remove the select values to add they back again Pluck on NullRelation accepts a list of columns Conflicts: activerecord/lib/active_record/relation/finder_methods.rb | ||||
| * | use the cached arel table | Aaron Patterson | 2013-10-15 | 1 | -1/+1 |
| | | |||||
* | | move column_names_with_alias on to the alias cache object | Aaron Patterson | 2013-10-14 | 1 | -20/+3 |
| | | |||||
* | | keep a cache on the alias object | Aaron Patterson | 2013-10-14 | 1 | -5/+0 |
| | | |||||
* | | move alias building to the table node | Aaron Patterson | 2013-10-14 | 1 | -4/+0 |
| | | |||||
* | | push the node->AR cache up one level | Aaron Patterson | 2013-10-13 | 1 | -6/+1 |
| | | |||||
* | | pull parent and alias tacker from the nodes. | Aaron Patterson | 2013-10-11 | 1 | -6/+1 |
|/ | | | | For now, we'll set the tables on the nodes manually. | ||||
* | no reason to do this column addition and subtraction business | Aaron Patterson | 2013-10-11 | 1 | -1/+1 |
| | |||||
* | refactor a little so we can remove some methods | Aaron Patterson | 2013-10-10 | 1 | -3/+0 |
| | |||||
* | delete unused code | Aaron Patterson | 2013-10-10 | 1 | -10/+0 |
| | | | | | Now that we merge trees from the top down, we don't need to search through the whole tree for particular nodes, just walk it and merge. | ||||
* | simplify each method. | Aaron Patterson | 2013-10-10 | 1 | -8/+2 |
| | | | | Stop writing terrible code Aaron. This is Ruby, not Scheme | ||||
* | add some convenient methods for avoiding array allocations | Aaron Patterson | 2013-10-09 | 1 | -0/+3 |
| | |||||
* | make node search more efficient | Aaron Patterson | 2013-10-09 | 1 | -0/+14 |
| | | | | | | Rather than search every node in the tree, comparing that node and all of its parents every time, start at the root from both sides and work our way down the tree | ||||
* | remove == so we can see where walking up parents occurs | Aaron Patterson | 2013-10-09 | 1 | -4/+0 |
| | |||||
* | push parent up to the superclass | Aaron Patterson | 2013-10-09 | 1 | -1/+6 |
| | | | | We always want a linked list back to the root node. | ||||
* | convert JoinBase to a tree and remove the Node class | Aaron Patterson | 2013-10-09 | 1 | -1/+19 |
| | |||||
* | don't access the reflections hash | Aaron Patterson | 2013-10-08 | 1 | -1/+1 |
| | | | | The reflections hash is supposed to be private, so let's use the API. | ||||
* | Whitespaces | Rafael Mendonça França | 2013-09-11 | 1 | -1/+2 |
| | |||||
* | Reduce allocations when extracting AR models | Sam | 2013-09-11 | 1 | -1/+13 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-04-11 | 1 | -1/+1 |
|\ | | | | | | | | | Conflicts: guides/source/action_mailer_basics.md | ||||
| * | JoinPart is no longer an abstract class | Neeraj Singh | 2013-04-08 | 1 | -1/+1 |
| | | |||||
* | | changed variable name active_record => base_klass | Neeraj Singh | 2013-04-09 | 1 | -5/+5 |
|/ | | | | | | | | | | | | | | | | | Current code stores the klass name in active_record and this is used throughout. While reviewing the code time and again I had the mental picture of active_record being an instance of a klass. However here the actual klass is being stored in @active_record. Secondly at two different places while referring to @active_record the comment refers to it as base klass. All this points to active_record being not the best variable name. So I thought it is better to replace active_record with base_klass. This change is confined to JoinDependency, JoinBase, JoinPart and JoinAssociation - all joining related work. | ||||
* | No need to send public methods | Akira Matsuda | 2013-02-26 | 1 | -1/+1 |
| | |||||
* | Fix eagerly loading associations without primary keys | Kelley Reynolds | 2012-02-09 | 1 | -1/+1 |
| | |||||
* | TableAlias leg ordering has changed, so change accordingly | Aaron Patterson | 2011-03-30 | 1 | -1/+1 |
| | |||||
* | Move JoinDependency and friends from ↵ | Jon Leighton | 2011-02-28 | 1 | -0/+78 |
ActiveRecord::Associations::ClassMethods to just ActiveRecord::Associations |