Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | remove dead code / make duplicate code more obvious | Aaron Patterson | 2013-10-11 | 1 | -4/+4 | |
| | ||||||
* | pull parent and alias tacker from the nodes. | Aaron Patterson | 2013-10-11 | 1 | -1/+18 | |
| | | | | For now, we'll set the tables on the nodes manually. | |||||
* | decouple the `join_constraints` method from the parent pointer | Aaron Patterson | 2013-10-11 | 1 | -1/+7 | |
| | ||||||
* | refactor a little so we can remove some methods | Aaron Patterson | 2013-10-10 | 1 | -1/+1 | |
| | ||||||
* | the parent node is on the stack, so use it | Aaron Patterson | 2013-10-10 | 1 | -4/+4 | |
| | | | | | we don't need to walk back up the node's parents when we have the parent on the stack | |||||
* | pass the parent node to the construct method | Aaron Patterson | 2013-10-10 | 1 | -7/+6 | |
| | ||||||
* | nodes do not need to be sorted | Aaron Patterson | 2013-10-10 | 1 | -1/+1 | |
| | ||||||
* | delete unused code | Aaron Patterson | 2013-10-10 | 1 | -40/+0 | |
| | | | | | Now that we merge trees from the top down, we don't need to search through the whole tree for particular nodes, just walk it and merge. | |||||
* | merge JoinDependency as outer joins | Aaron Patterson | 2013-10-10 | 1 | -0/+30 | |
| | | | | Merge JoinDependency objects as outer joins | |||||
* | stuff the join dependency object in the "anything goes" hash. | Aaron Patterson | 2013-10-10 | 1 | -2/+2 | |
| | ||||||
* | stop splatting things back and forth | Aaron Patterson | 2013-10-10 | 1 | -1/+1 | |
| | ||||||
* | stop creating a bunch of relation objects when we can slap all the joins on ↵ | Aaron Patterson | 2013-10-09 | 1 | -3/+3 | |
| | | | | at once | |||||
* | remove dead code | Aaron Patterson | 2013-10-09 | 1 | -13/+0 | |
| | ||||||
* | add some convenient methods for avoiding array allocations | Aaron Patterson | 2013-10-09 | 1 | -3/+3 | |
| | ||||||
* | hide join_constraints inside the JoinDependency object | Aaron Patterson | 2013-10-09 | 1 | -6/+6 | |
| | ||||||
* | expose the root node and call it | Aaron Patterson | 2013-10-09 | 1 | -21/+11 | |
| | ||||||
* | just skip the join if it's already there | Aaron Patterson | 2013-10-09 | 1 | -14/+10 | |
| | | | | Remove the annoying `find_or_build` stuff. | |||||
* | speed up finding existing nodes | Aaron Patterson | 2013-10-09 | 1 | -3/+1 | |
| | | | | | The node must be a child of the parent passed in, so only search children of the parent node | |||||
* | make node search more efficient | Aaron Patterson | 2013-10-09 | 1 | -3/+20 | |
| | | | | | | Rather than search every node in the tree, comparing that node and all of its parents every time, start at the root from both sides and work our way down the tree | |||||
* | remove == so we can see where walking up parents occurs | Aaron Patterson | 2013-10-09 | 1 | -10/+15 | |
| | ||||||
* | convert JoinBase to a tree and remove the Node class | Aaron Patterson | 2013-10-09 | 1 | -41/+11 | |
| | ||||||
* | names are guaranteed to be symbols | Aaron Patterson | 2013-10-08 | 1 | -1/+1 | |
| | ||||||
* | eliminate function that is only used in one place | Aaron Patterson | 2013-10-08 | 1 | -7/+2 | |
| | ||||||
* | we will always detect the same node, so just pass the node in | Aaron Patterson | 2013-10-08 | 1 | -7/+2 | |
| | ||||||
* | we do not need to to_s the name all the time | Aaron Patterson | 2013-10-08 | 1 | -5/+3 | |
| | ||||||
* | parent is guaranteed to be the same | Aaron Patterson | 2013-10-08 | 1 | -4/+1 | |
| | | | | | since we are searching a tree, the current level should be consistent, so we don't have to inspect the parent class / table | |||||
* | reduce number of comparisons and array allocations | Aaron Patterson | 2013-10-08 | 1 | -11/+10 | |
| | | | | | Just inspecting the children nodes will reduce the number of comparisons we have to do (since it is limited to the child size) | |||||
* | rename the variable to make more sense with a tree | Aaron Patterson | 2013-10-08 | 1 | -7/+7 | |
| | ||||||
* | walk the tree rather than generating a hash and walking it | Aaron Patterson | 2013-10-08 | 1 | -21/+10 | |
| | ||||||
* | do not convert the tree to a list just for the first node | Aaron Patterson | 2013-10-08 | 1 | -1/+1 | |
| | ||||||
* | generate the association hash from the top down | Aaron Patterson | 2013-10-08 | 1 | -17/+15 | |
| | | | | | This prevents us from walking back up the parent tree once for each leaf. | |||||
* | store join parts in a tree | Aaron Patterson | 2013-10-08 | 1 | -16/+45 | |
| | ||||||
* | join parts in `build` are *always* new, so don't bother checking | Aaron Patterson | 2013-10-08 | 1 | -1/+2 | |
| | ||||||
* | stop looking up the reflection multiple times | Aaron Patterson | 2013-10-08 | 1 | -6/+5 | |
| | ||||||
* | cache join associations and join base on the stack | Aaron Patterson | 2013-10-08 | 1 | -4/+11 | |
| | | | | No reason to decompose the join objects on every iteration | |||||
* | use the API rather than accessing underlying data structures | Aaron Patterson | 2013-10-08 | 1 | -1/+1 | |
| | ||||||
* | associations is always a hash | Aaron Patterson | 2013-10-08 | 1 | -19/+13 | |
| | ||||||
* | keys are always symbols | Aaron Patterson | 2013-10-08 | 1 | -2/+4 | |
| | ||||||
* | we can get a list of reflections from the join parts, so let's remove | Aaron Patterson | 2013-10-08 | 1 | -3/+5 | |
| | | | | the @reflections ivar. | |||||
* | transform the association input so we can avoid type checks later. | Aaron Patterson | 2013-10-08 | 1 | -17/+31 | |
| | | | | | We should consider moving the input munging outside the class instantiation | |||||
* | we know the keys are scalars, so avoid some typechecking | Aaron Patterson | 2013-10-08 | 1 | -8/+12 | |
| | ||||||
* | this method is only ever called with a reflection | Aaron Patterson | 2013-10-08 | 1 | -6/+2 | |
| | | | | Stop typechecking the parameter. We know the type. | |||||
* | don't access the reflections hash | Aaron Patterson | 2013-10-08 | 1 | -2/+6 | |
| | | | | The reflections hash is supposed to be private, so let's use the API. | |||||
* | build association tree thing on demand. | Aaron Patterson | 2013-10-08 | 1 | -6/+11 | |
| | | | | | `instantiate` is only called once, so there is no reason to cache the data structure on the instance and mutate itself. | |||||
* | hide join_parts internals from other classes | Aaron Patterson | 2013-10-08 | 1 | -6/+17 | |
| | ||||||
* | decouple JoinAssociation from JoinDependency | Aaron Patterson | 2013-10-08 | 1 | -1/+1 | |
| | ||||||
* | @associations can never have an array, so remove the dead code | Aaron Patterson | 2013-10-08 | 1 | -4/+0 | |
| | ||||||
* | typecast records returned from the db rather than to_sing everything | Aaron Patterson | 2013-10-08 | 1 | -12/+17 | |
| | ||||||
* | extract the string handling part to a method. | Aaron Patterson | 2013-10-07 | 1 | -15/+15 | |
| | | | | | | We know the structure passed in to the `construct` method will be a hash, so we don't need to test it all the time. The key value will be a symbol or string, so handle it with the special method | |||||
* | remove more dead code | Aaron Patterson | 2013-10-07 | 1 | -2/+0 | |
| | | | | | We control the inputs to `construct`, so the wrong type shouldn't be passed in ever. |