index
:
rails.git
3-2-stable-for-hmno
master
Mirror of official rails repo with custom fixes.
Harald Eilertsen
about
summary
refs
log
tree
commit
diff
stats
log msg
author
committer
range
path:
root
/
activerecord
/
lib
/
active_record
/
associations
/
join_dependency.rb
Commit message (
Expand
)
Author
Age
Files
Lines
...
*
keep track of AR objects we've made as we walk the tree
Aaron Patterson
2013-10-11
1
-35
/
+22
*
push up the loaded target checking
Aaron Patterson
2013-10-11
1
-9
/
+13
*
we always have a model now
Aaron Patterson
2013-10-11
1
-1
/
+1
*
extract conditional to the caller
Aaron Patterson
2013-10-11
1
-11
/
+13
*
we always have a reflection and it is on the node
Aaron Patterson
2013-10-11
1
-2
/
+2
*
fix variable name. we're constructing a model, not an association
Aaron Patterson
2013-10-11
1
-12
/
+12
*
reflections know if they are collections, so ask
Aaron Patterson
2013-10-11
1
-6
/
+5
*
belongs_to can be treated the same way as has_one
Aaron Patterson
2013-10-11
1
-12
/
+5
*
cache the primary key / typcast lookup on the stack
Aaron Patterson
2013-10-11
1
-9
/
+9
*
remove dead code / make duplicate code more obvious
Aaron Patterson
2013-10-11
1
-4
/
+4
*
pull parent and alias tacker from the nodes.
Aaron Patterson
2013-10-11
1
-1
/
+18
*
decouple the `join_constraints` method from the parent pointer
Aaron Patterson
2013-10-11
1
-1
/
+7
*
refactor a little so we can remove some methods
Aaron Patterson
2013-10-10
1
-1
/
+1
*
the parent node is on the stack, so use it
Aaron Patterson
2013-10-10
1
-4
/
+4
*
pass the parent node to the construct method
Aaron Patterson
2013-10-10
1
-7
/
+6
*
nodes do not need to be sorted
Aaron Patterson
2013-10-10
1
-1
/
+1
*
delete unused code
Aaron Patterson
2013-10-10
1
-40
/
+0
*
merge JoinDependency as outer joins
Aaron Patterson
2013-10-10
1
-0
/
+30
*
stuff the join dependency object in the "anything goes" hash.
Aaron Patterson
2013-10-10
1
-2
/
+2
*
stop splatting things back and forth
Aaron Patterson
2013-10-10
1
-1
/
+1
*
stop creating a bunch of relation objects when we can slap all the joins on a...
Aaron Patterson
2013-10-09
1
-3
/
+3
*
remove dead code
Aaron Patterson
2013-10-09
1
-13
/
+0
*
add some convenient methods for avoiding array allocations
Aaron Patterson
2013-10-09
1
-3
/
+3
*
hide join_constraints inside the JoinDependency object
Aaron Patterson
2013-10-09
1
-6
/
+6
*
expose the root node and call it
Aaron Patterson
2013-10-09
1
-21
/
+11
*
just skip the join if it's already there
Aaron Patterson
2013-10-09
1
-14
/
+10
*
speed up finding existing nodes
Aaron Patterson
2013-10-09
1
-3
/
+1
*
make node search more efficient
Aaron Patterson
2013-10-09
1
-3
/
+20
*
remove == so we can see where walking up parents occurs
Aaron Patterson
2013-10-09
1
-10
/
+15
*
convert JoinBase to a tree and remove the Node class
Aaron Patterson
2013-10-09
1
-41
/
+11
*
names are guaranteed to be symbols
Aaron Patterson
2013-10-08
1
-1
/
+1
*
eliminate function that is only used in one place
Aaron Patterson
2013-10-08
1
-7
/
+2
*
we will always detect the same node, so just pass the node in
Aaron Patterson
2013-10-08
1
-7
/
+2
*
we do not need to to_s the name all the time
Aaron Patterson
2013-10-08
1
-5
/
+3
*
parent is guaranteed to be the same
Aaron Patterson
2013-10-08
1
-4
/
+1
*
reduce number of comparisons and array allocations
Aaron Patterson
2013-10-08
1
-11
/
+10
*
rename the variable to make more sense with a tree
Aaron Patterson
2013-10-08
1
-7
/
+7
*
walk the tree rather than generating a hash and walking it
Aaron Patterson
2013-10-08
1
-21
/
+10
*
do not convert the tree to a list just for the first node
Aaron Patterson
2013-10-08
1
-1
/
+1
*
generate the association hash from the top down
Aaron Patterson
2013-10-08
1
-17
/
+15
*
store join parts in a tree
Aaron Patterson
2013-10-08
1
-16
/
+45
*
join parts in `build` are *always* new, so don't bother checking
Aaron Patterson
2013-10-08
1
-1
/
+2
*
stop looking up the reflection multiple times
Aaron Patterson
2013-10-08
1
-6
/
+5
*
cache join associations and join base on the stack
Aaron Patterson
2013-10-08
1
-4
/
+11
*
use the API rather than accessing underlying data structures
Aaron Patterson
2013-10-08
1
-1
/
+1
*
associations is always a hash
Aaron Patterson
2013-10-08
1
-19
/
+13
*
keys are always symbols
Aaron Patterson
2013-10-08
1
-2
/
+4
*
we can get a list of reflections from the join parts, so let's remove
Aaron Patterson
2013-10-08
1
-3
/
+5
*
transform the association input so we can avoid type checks later.
Aaron Patterson
2013-10-08
1
-17
/
+31
*
we know the keys are scalars, so avoid some typechecking
Aaron Patterson
2013-10-08
1
-8
/
+12
[prev]
[next]