Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Refactoring: replace the mix of variables like @finder_sql, @counter_sql, ↵ | Jon Leighton | 2010-10-30 | 1 | -19/+18 |
| | | | | etc with just a single scope hash (created on initialization of the proxy). This is now used consistently across all associations. Therefore, all you have to do to ensure finding/counting etc is done correctly is implement the scope correctly. | ||||
* | Perf: refactor method. | Emilio Tagua | 2010-09-22 | 1 | -11/+8 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | do not pass nil values to arel | Aaron Patterson | 2010-09-21 | 1 | -1/+1 |
| | |||||
* | mark SQL literals as SQL literals | Aaron Patterson | 2010-08-25 | 1 | -1/+1 |
| | |||||
* | marking sql literals as sql literals | Aaron Patterson | 2010-08-23 | 1 | -1/+1 |
| | |||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 1 | -3/+3 |
| | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | Removing most of the symbol to proc usage in Active Record | Prem Sichanugrist | 2010-08-13 | 1 | -1/+1 |
| | | | | This will hopefully make Active Record run a bit more faster. | ||||
* | do not use arel constants directly | Aaron Patterson | 2010-08-13 | 1 | -1/+1 |
| | |||||
* | symbol to proc is slow, we should avoid it | Aaron Patterson | 2010-08-13 | 1 | -1/+1 |
| | |||||
* | ensuring that description does not exceed 100 columns | Neeraj Singh | 2010-08-02 | 1 | -3/+4 |
| | |||||
* | Ensure all join table attributes will be in the same timestamp. | José Valim | 2010-07-21 | 1 | -11/+21 |
| | |||||
* | Timestamp columns of HABTM join table should record timestamps | Neeraj Singh | 2010-07-21 | 1 | -1/+5 |
| | | | | [#5161 state:resolved] | ||||
* | id is a public method | Santiago Pastorino | 2010-07-21 | 1 | -2/+2 |
| | |||||
* | Ensure that primary_keys of HABTM records is not double quoted | Neeraj Singh | 2010-07-20 | 1 | -2/+2 |
| | | | | [#5152 state:reslved] | ||||
* | Adds title to activerecord/lib/active_record/associations/* | Rizwan Reza | 2010-06-16 | 1 | -0/+1 |
| | |||||
* | save(false) is gone, use save(:validate => false) instead. | José Valim | 2010-01-17 | 1 | -1/+1 |
| | |||||
* | Use Arel::Table instead of ActiveRecord::Relation from HABTM and ↵ | Pratik Naik | 2010-01-01 | 1 | -3/+3 |
| | | | | has_many#delete_records | ||||
* | Add Relation#delete [Pratik Naik, Emilio Tagua] | Pratik Naik | 2010-01-01 | 1 | -1/+1 |
| | |||||
* | Rename Model.conditions and relation.conditions to .where | Pratik Naik | 2009-12-26 | 1 | -1/+1 |
| | |||||
* | Revert "Revert "Assert primary key does not exist in habtm when the ↵ | Jeremy Kemper | 2009-11-23 | 1 | -13/+1 |
| | | | | | | | | | | | | | association is defined, instead of doing that everytime a record is inserted."" This reverts commit 2b82708b0efb3a3458e8177beab58f0c585788ae. [#3128 state:resolved] Conflicts: activerecord/lib/active_record/associations.rb activerecord/lib/active_record/associations/has_and_belongs_to_many_association.rb | ||||
* | Revert "Split arel_table into method to get a relation and another to ↵ | Jeremy Kemper | 2009-11-13 | 1 | -2/+2 |
| | | | | | | memoize the default relation." This reverts commit bd51790895fc75a3b4e19e8dd7aa6dc389d77068. | ||||
* | Split arel_table into method to get a relation and another to memoize the ↵ | Jeremy Kemper | 2009-11-13 | 1 | -2/+2 |
| | | | | default relation. | ||||
* | Arel::In -> Arel::Predicates::In | Jeremy Kemper | 2009-11-02 | 1 | -1/+1 |
| | |||||
* | Merge commit 'rails/master' | Emilio Tagua | 2009-09-14 | 1 | -2/+2 |
|\ | |||||
| * | Fix habtm associations when using multiple databases | sdsykes | 2009-09-12 | 1 | -2/+2 |
| | | | | | | | | | | | | [#3128] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | | Merge commit 'rails/master' | Emilio Tagua | 2009-09-08 | 1 | -0/+16 |
|\| | | | | | | | | | Conflicts: activerecord/lib/active_record/associations.rb | ||||
| * | Revert "Assert primary key does not exist in habtm when the association is ↵ | Jeremy Kemper | 2009-09-02 | 1 | -0/+16 |
| | | | | | | | | | | | | | | | | | | | | defined, instead of doing that everytime a record is inserted." Test failures on PostgreSQL. [#3128 state:open] This reverts commit da636809daca9c338200811d3590e446f57c8e81. | ||||
* | | Merge commit 'rails/master' | Emilio Tagua | 2009-09-01 | 1 | -16/+0 |
|\| | | | | | | | | | Conflicts: activerecord/lib/active_record/associations.rb | ||||
| * | Assert primary key does not exist in habtm when the association is defined, ↵ | José Valim | 2009-09-01 | 1 | -16/+0 |
| | | | | | | | | | | | | | | | | instead of doing that everytime a record is inserted. [#3128 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | | habtm insertion with ARel integration. | Emilio Tagua | 2009-08-18 | 1 | -8/+5 |
| | | |||||
* | | habtm delete method integrated with ARel. | Emilio Tagua | 2009-08-18 | 1 | -4/+5 |
|/ | |||||
* | raises an exception on habtm join table inserts if join table contains a ↵ | Jaime Bellmyer | 2009-08-09 | 1 | -2/+14 |
| | | | | | | | | primary key. Caches this check to save time on subsequent inserts. [#2086 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | raises exception (ActiveRecord::ConfigurationError with message) on habtm ↵ | Jaime Bellmyer | 2009-08-09 | 1 | -0/+4 |
| | | | | | | association creation if join table contains a primary key Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Revert "Revert "Generate proper :counter_sql from :finder_sql when there is ↵ | Pratik Naik | 2009-07-01 | 1 | -9/+1 |
| | | | | | | | | | a newline character immediately following 'SELECT' [#2118 state:resolved]"" This reverts commit 80f1f863cd0f9cba89079511282de5710a2e1832. The feature doesn't work on Postgres, so don't test it on Postgres. Also, Postgres compatibility is irrelevant to the ticket/patch in question. | ||||
* | Revert "Generate proper :counter_sql from :finder_sql when there is a ↵ | Yehuda Katz + Carl Lerche | 2009-06-22 | 1 | -1/+9 |
| | | | | | | | | newline character immediately following 'SELECT' [#2118 state:resolved]" This reverts commit 4851ca9e13a4317342df02ae25b1929340523f7a. The tests do not pass for postgresql. | ||||
* | Generate proper :counter_sql from :finder_sql when there is a newline ↵ | Patrick Joyce | 2009-06-21 | 1 | -9/+1 |
| | | | | | | character immediately following 'SELECT' [#2118 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Fixed that autosave should validate associations even if master is invalid ↵ | David Heinemeier Hansson | 2009-02-27 | 1 | -2/+2 |
| | | | | [#1930 status:committed] | ||||
* | Cache columns for has_and_belongs_to_many associations | lukeludwig | 2009-01-17 | 1 | -3/+9 |
| | | | | | This avoids repeatedly calling SHOW COLUMNS when the association is queried [#1738 state:committed] | ||||
* | Refactored AssociationCollection#count for uniformity and Ruby 1.8.7 support. | Ernie Miller | 2008-08-28 | 1 | -0/+10 |
| | | | | | | [#831 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Updated has_and_belongs_to_many association to fix :finder_sql ↵ | Nathan Witmer | 2008-08-16 | 1 | -3/+1 |
| | | | | | | interpolation. [#848 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Extract owner_quoted_id so it can be overridden. [#292 state:committed] | Andre Arko | 2008-06-25 | 1 | -3/+3 |
| | |||||
* | fix eager loading with dynamic finders | Brandon Keepers | 2008-06-09 | 1 | -0/+1 |
| | |||||
* | Fixes a subtle bug when using symbols for key definitions in habtm associations | David Dollar | 2008-04-23 | 1 | -3/+3 |
| | |||||
* | Remove duplicate code from associations. [Pratik] | Pratik Naik | 2008-04-06 | 1 | -49/+4 |
| | | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9231 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Refactor HasManyThroughAssociation to inherit from HasManyAssociation. ↵ | Pratik Naik | 2008-04-06 | 1 | -4/+0 |
| | | | | | | Association callbacks and <association>_ids= now work with hm:t. Closes #11516 [rubyruy] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9230 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Ensure HABTM#create and HABTM#build do not load entire association. [Pratik] | Pratik Naik | 2008-04-05 | 1 | -2/+0 |
| | | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9229 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Make HABTM#create behave the same as << with after_add callbacks. Closes ↵ | Michael Koziarski | 2008-04-04 | 1 | -4/+3 |
| | | | | | | #11374 [freels] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9224 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Ensure that modifying has_and_belongs_to_many actions clear the query cache. ↵ | Rick Olson | 2008-01-18 | 1 | -5/+5 |
| | | | | | | Closes #10840 [john.andrews] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8653 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | More thoroughly quote table names. Exposes some issues with sqlite2 adapter. ↵ | Jeremy Kemper | 2008-01-05 | 1 | -4/+4 |
| | | | | | | Closes #10698. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8571 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Ruby 1.9 compat: fix warnings, shadowed block vars, and unitialized instance ↵ | Jeremy Kemper | 2007-12-22 | 1 | -8/+8 |
| | | | | | | vars git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8481 5ecf4fe2-1ee6-0310-87b1-e25e094e27de |